[gwt-contrib] Re: Add support for touch events for supported mobile webkit platforms. (issue867801)
http://gwt-code-reviews.appspot.com/867801/diff/1/17
File user/src/com/google/gwt/event/dom/client/TouchLocationEvent.java
(right):
http://gwt-code-reviews.appspot.com/867801/diff/1/17#newcode33
user/src/com/google/gwt/event/dom/client/TouchLocationEvent.java:33:
public int getClientX() {
So what should all these get*() methods return in the case of
multitouch? That is what I am concerned about with this API once
multitouch is supported.
http://gwt-code-reviews.appspot.com/867801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Public: Create seperate top level interfaces for (issue1058801)
LGTM http://gwt-code-reviews.appspot.com/1058801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Fix issue with SSSS not getting stylesheets (issue1059801)
Reviewers: jgw, Description: Fix issue with not getting stylesheets Please review this at http://gwt-code-reviews.appspot.com/1059801/show Affected files: M dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionScriptLinker.java M dev/core/src/com/google/gwt/core/linker/CrossSiteIframeLinker.java M dev/core/src/com/google/gwt/core/linker/IFrameLinker.java M dev/core/src/com/google/gwt/core/linker/SingleScriptLinker.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Experimental version of GeoLocation API (issue1060801)
Reviewers: pdr, Description: Experimental version of GeoLocation API Please review this at http://gwt-code-reviews.appspot.com/1060801/show Affected files: A user/src/com/google/gwt/experimental/geolocation/GeoLocation.java A user/src/com/google/gwt/experimental/geolocation/impl/CoordinatesImpl.java A user/src/com/google/gwt/experimental/geolocation/impl/GeoLocationImpl.java A user/src/com/google/gwt/experimental/geolocation/impl/PositionImpl.java A user/src/com/google/gwt/experimental/geolocation/package-info.java M user/src/com/google/gwt/user/client/Window.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix issue with SSSS not getting stylesheets (issue1059801)
LGTM http://gwt-code-reviews.appspot.com/1059801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9160 committed - Upgrade EasyMock to 3.0....
Revision: 9160 Author: j...@google.com Date: Thu Oct 28 11:03:45 2010 Log: Upgrade EasyMock to 3.0. Patch by: yaxin Review by: jat http://code.google.com/p/google-web-toolkit/source/detail?r=9160 Added: /tools/lib/easymock/LICENSE.txt /tools/lib/easymock/README.google /tools/lib/easymock/easymock-3.0-sources.jar /tools/lib/easymock/easymock-3.0.jar /tools/lib/easymock/easymockclassextension-3.0-sources.jar /tools/lib/easymock/easymockclassextension-3.0.jar /tools/lib/objenesis /tools/lib/objenesis/LICENSE /tools/lib/objenesis/README.google /tools/lib/objenesis/objenesis-1.2-sources.jar /tools/lib/objenesis/objenesis-1.2.jar Modified: /tools/lib/easymock/easymock-License.html /tools/lib/easymock/easymockclassextension-License.html === --- /dev/null +++ /tools/lib/easymock/LICENSE.txt Thu Oct 28 11:03:45 2010 @@ -0,0 +1,202 @@ + + Apache License + Version 2.0, January 2004 +http://www.apache.org/licenses/ + + TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION + + 1. Definitions. + + License shall mean the terms and conditions for use, reproduction, + and distribution as defined by Sections 1 through 9 of this document. + + Licensor shall mean the copyright owner or entity authorized by + the copyright owner that is granting the License. + + Legal Entity shall mean the union of the acting entity and all + other entities that control, are controlled by, or are under common + control with that entity. For the purposes of this definition, + control means (i) the power, direct or indirect, to cause the + direction or management of such entity, whether by contract or + otherwise, or (ii) ownership of fifty percent (50%) or more of the + outstanding shares, or (iii) beneficial ownership of such entity. + + You (or Your) shall mean an individual or Legal Entity + exercising permissions granted by this License. + + Source form shall mean the preferred form for making modifications, + including but not limited to software source code, documentation + source, and configuration files. + + Object form shall mean any form resulting from mechanical + transformation or translation of a Source form, including but + not limited to compiled object code, generated documentation, + and conversions to other media types. + + Work shall mean the work of authorship, whether in Source or + Object form, made available under the License, as indicated by a + copyright notice that is included in or attached to the work + (an example is provided in the Appendix below). + + Derivative Works shall mean any work, whether in Source or Object + form, that is based on (or derived from) the Work and for which the + editorial revisions, annotations, elaborations, or other modifications + represent, as a whole, an original work of authorship. For the purposes + of this License, Derivative Works shall not include works that remain + separable from, or merely link (or bind by name) to the interfaces of, + the Work and Derivative Works thereof. + + Contribution shall mean any work of authorship, including + the original version of the Work and any modifications or additions + to that Work or Derivative Works thereof, that is intentionally + submitted to Licensor for inclusion in the Work by the copyright owner + or by an individual or Legal Entity authorized to submit on behalf of + the copyright owner. For the purposes of this definition, submitted + means any form of electronic, verbal, or written communication sent + to the Licensor or its representatives, including but not limited to + communication on electronic mailing lists, source code control systems, + and issue tracking systems that are managed by, or on behalf of, the + Licensor for the purpose of discussing and improving the Work, but + excluding communication that is conspicuously marked or otherwise + designated in writing by the copyright owner as Not a Contribution. + + Contributor shall mean Licensor and any individual or Legal Entity + on behalf of whom a Contribution has been received by Licensor and + subsequently incorporated within the Work. + + 2. Grant of Copyright License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + copyright license to reproduce, prepare Derivative Works of, + publicly display, publicly perform, sublicense, and distribute the + Work and such Derivative Works in Source or Object form. + + 3. Grant of Patent License. Subject to the terms and conditions of + this License, each Contributor hereby grants
[gwt-contrib] Re: Experimental version of GeoLocation API (issue1060801)
http://gwt-code-reviews.appspot.com/1060801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Experimental version of GeoLocation API (issue1060801)
Looks good, including heading, which is tricky (GPS-equipped devices return NaN for stationary, as opposed to null for unavailable). (This is a convenient test site, as it returns the raw values: http://benwerd.com/lab/geo.php) Would it be possible to change GeoLocation to Geolocation to conform with W3C usage? http://www.w3.org/TR/geolocation-API/ http://gwt-code-reviews.appspot.com/1060801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Experimental version of GeoLocation API (issue1060801)
http://gwt-code-reviews.appspot.com/1060801/diff/1/4
File
user/src/com/google/gwt/experimental/geolocation/impl/GeoLocationImpl.java
(right):
http://gwt-code-reviews.appspot.com/1060801/diff/1/4#newcode39
user/src/com/google/gwt/experimental/geolocation/impl/GeoLocationImpl.java:39:
boolean hasHeading, boolean hasSpeed, double timestamp) {
(see note below regarding exception handling)
http://gwt-code-reviews.appspot.com/1060801/diff/1/4#newcode43
user/src/com/google/gwt/experimental/geolocation/impl/GeoLocationImpl.java:43:
callback.onPositionChanged(new PositionImpl(coords, new Date(
I'm skeptical that we are doing anyone a favor by transforming the
double value into a Date object.
http://gwt-code-reviews.appspot.com/1060801/diff/1/4#newcode83
user/src/com/google/gwt/experimental/geolocation/impl/GeoLocationImpl.java:83:
var success = function(position) {
when calling back from a javascript event, you need to be careful to
catch exceptions and forward them to dev mode. Otherwise, your java
exceptions will disappear into the ether.
Here's a utility class we use in gwt-google-apis:
http://code.google.com/p/gwt-google-apis/source/browse/trunk/ajaxloader/ajaxloader/src/com/google/gwt/ajaxloader/client/ExceptionHelper.java
http://gwt-code-reviews.appspot.com/1060801/diff/3001/4001
File user/src/com/google/gwt/experimental/geolocation/GeoLocation.java
(right):
http://gwt-code-reviews.appspot.com/1060801/diff/3001/4001#newcode211
user/src/com/google/gwt/experimental/geolocation/GeoLocation.java:211:
public long getMaximumAge() {
sure you want to use long here? There are penalties in GWT for
emulating long in javascript.
http://gwt-code-reviews.appspot.com/1060801/diff/3001/4001#newcode221
user/src/com/google/gwt/experimental/geolocation/GeoLocation.java:221:
public long getTimeout() {
sure you want to use long here? penalties in GWT for emulating long in
javascript.
http://gwt-code-reviews.appspot.com/1060801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Experimental version of GeoLocation API (issue1060801)
http://gwt-code-reviews.appspot.com/1060801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Experimental version of GeoLocation API (issue1060801)
http://gwt-code-reviews.appspot.com/1060801/diff/1/4
File
user/src/com/google/gwt/experimental/geolocation/impl/GeoLocationImpl.java
(right):
http://gwt-code-reviews.appspot.com/1060801/diff/1/4#newcode83
user/src/com/google/gwt/experimental/geolocation/impl/GeoLocationImpl.java:83:
var success = function(position) {
On 2010/10/28 18:21:15, zundel wrote:
when calling back from a javascript event, you need to be careful to
catch
exceptions and forward them to dev mode. Otherwise, your java
exceptions will
disappear into the ether.
Here's a utility class we use in gwt-google-apis:
http://code.google.com/p/gwt-google-apis/source/browse/trunk/ajaxloader/ajaxloader/src/com/google/gwt/ajaxloader/client/ExceptionHelper.java
I think you just want var success = $entry(function...); and likewise
for any place where JS may call into something that may call Java code.
In addition to exception handling, this is essential for all the
Scheduler methods to work properly.
http://gwt-code-reviews.appspot.com/1060801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Experimental version of GeoLocation API (issue1060801)
Good point, and in fact the values documented in the W3C geolocation API
as 'long' translate to Java 'int':
http://www.w3.org/TR/geolocation-API/
http://dev.w3.org/2006/webapi/WebIDL/#idl-long
On 2010/10/28 18:21:14, zundel wrote:
http://gwt-code-reviews.appspot.com/1060801/diff/3001/4001#newcode211
user/src/com/google/gwt/experimental/geolocation/GeoLocation.java:211:
public
long getMaximumAge() {
sure you want to use long here? There are penalties in GWT for
emulating long
in javascript.
http://gwt-code-reviews.appspot.com/1060801/diff/3001/4001#newcode221
user/src/com/google/gwt/experimental/geolocation/GeoLocation.java:221:
public
long getTimeout() {
sure you want to use long here? penalties in GWT for emulating long
in
javascript.
http://gwt-code-reviews.appspot.com/1060801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9161 committed - Fix issue with SSSS not getting stylesheets...
Revision: 9161
Author: unn...@google.com
Date: Thu Oct 28 08:33:32 2010
Log: Fix issue with not getting stylesheets
Review at http://gwt-code-reviews.appspot.com/1059801
http://code.google.com/p/google-web-toolkit/source/detail?r=9161
Modified:
/trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionScriptLinker.java
/trunk/dev/core/src/com/google/gwt/core/linker/CrossSiteIframeLinker.java
/trunk/dev/core/src/com/google/gwt/core/linker/IFrameLinker.java
/trunk/dev/core/src/com/google/gwt/core/linker/SingleScriptLinker.java
===
---
/trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionScriptLinker.java
Tue Oct 12 16:00:43 2010
+++
/trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionScriptLinker.java
Thu Oct 28 08:33:32 2010
@@ -115,7 +115,7 @@
* called from the legacy link method.
*/
for (CompilationResult compilation :
toReturn.find(CompilationResult.class)) {
-toReturn.addAll(doEmitCompilation(logger, context, compilation));
+toReturn.addAll(doEmitCompilation(logger, context, compilation,
artifacts));
}
return toReturn;
} else {
@@ -137,11 +137,11 @@
}
protected CollectionArtifact? doEmitCompilation(TreeLogger logger,
- LinkerContext context, CompilationResult result)
+ LinkerContext context, CompilationResult result, ArtifactSet
artifacts)
throws UnableToCompleteException {
String[] js = result.getJavaScript();
byte[][] bytes = new byte[js.length][];
-bytes[0] = generatePrimaryFragment(logger, context, result, js);
+bytes[0] = generatePrimaryFragment(logger, context, result, js,
artifacts);
for (int i = 1; i js.length; i++) {
bytes[i] = Util.getBytes(generateDeferredFragment(logger, context, i,
js[i]));
@@ -227,22 +227,23 @@
* {...@link #getModuleSuffix(TreeLogger, LinkerContext)}.
*/
protected byte[] generatePrimaryFragment(TreeLogger logger,
- LinkerContext context, CompilationResult result, String[] js)
- throws UnableToCompleteException {
+ LinkerContext context, CompilationResult result, String[] js,
+ ArtifactSet artifacts) throws UnableToCompleteException {
TextOutput to = new DefaultTextOutput(context.isOutputCompact());
to.print(generatePrimaryFragmentString(
-logger, context, result.getStrongName(), js[0], js.length));
+logger, context, result.getStrongName(), js[0], js.length,
artifacts));
return Util.getBytes(to.toString());
}
protected String generatePrimaryFragmentString(TreeLogger logger,
- LinkerContext context, String strongName, String js, int length)
+ LinkerContext context, String strongName, String js, int length,
+ ArtifactSet artifacts)
throws UnableToCompleteException {
StringBuffer b = new StringBuffer();
b.append(getModulePrefix(logger, context, strongName, length));
b.append(js);
b.append(getModuleSuffix(logger, context));
-return wrapPrimaryFragment(logger, context, b.toString());
+return wrapPrimaryFragment(logger, context, b.toString(), artifacts);
}
protected String generateSelectionScript(TreeLogger logger,
@@ -358,7 +359,7 @@
}
protected String wrapPrimaryFragment(TreeLogger logger,
- LinkerContext context, String script) {
+ LinkerContext context, String script, ArtifactSet artifacts) {
return script;
}
===
---
/trunk/dev/core/src/com/google/gwt/core/linker/CrossSiteIframeLinker.java
Wed Oct 27 13:37:45 2010
+++
/trunk/dev/core/src/com/google/gwt/core/linker/CrossSiteIframeLinker.java
Thu Oct 28 08:33:32 2010
@@ -211,7 +211,7 @@
com/google/gwt/core/ext/linker/impl/ + filename, logger);
String script = generatePrimaryFragmentString(
-logger, context, , buffer.toString(), 1);
+logger, context, , buffer.toString(), 1, artifacts);
EmittedArtifact devArtifact =
emitString(logger, script, filename, lastModified);
@@ -261,11 +261,11 @@
@Override
protected String wrapPrimaryFragment(TreeLogger logger,
- LinkerContext context, String script) {
+ LinkerContext context, String script, ArtifactSet artifacts) {
StringBuffer out = new StringBuffer();
if (shouldIncludeBootstrapInPrimaryFragment(context)) {
try {
-out.append(generateSelectionScript(logger, context, null));
+out.append(generateSelectionScript(logger, context, artifacts));
} catch (UnableToCompleteException e) {
logger.log(TreeLogger.ERROR, Problem setting up selection
script, e);
e.printStackTrace();
===
--- /trunk/dev/core/src/com/google/gwt/core/linker/IFrameLinker.java Wed
Aug 18 11:12:36 2010
+++ /trunk/dev/core/src/com/google/gwt/core/linker/IFrameLinker.java Thu
Oct 28 08:33:32 2010
@@ -18,12 +18,13 @@
import
[gwt-contrib] Re: Experimental version of GeoLocation API (issue1060801)
http://gwt-code-reviews.appspot.com/1060801/diff/10001/11003 File user/src/com/google/gwt/experimental/geolocation/impl/GeolocationImpl.java (right): http://gwt-code-reviews.appspot.com/1060801/diff/10001/11003#newcode34 user/src/com/google/gwt/experimental/geolocation/impl/GeolocationImpl.java:34: return isSupported() ? new GeolocationImpl() : null; what purpose do multiple instances serve here? there is only one wnd.navigator.geolocation, why do we need multiple objects to wrap one object? Unless I'm missing something, it looks like these could all be static dispatched. http://gwt-code-reviews.appspot.com/1060801/diff/10001/11003#newcode98 user/src/com/google/gwt/experimental/geolocation/impl/GeolocationImpl.java:98: @com.google.gwt.experimental.geolocation.impl.GeolocationImpl::success(Lcom/google/gwt/experimental/geolocation/Geolocation$Handler;DDDD)( my JNI-JSNI-fu fails me here: ';DDDD' http://gwt-code-reviews.appspot.com/1060801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Experimental version of GeoLocation API (issue1060801)
That translates to an arglist of: A Java object of this type: Lcom/google/gwt/experimental/geolocation/Geolocation$Handler; Followed by seven doubles: DDD Followed by four booleans: Followed by a double: D On 2010/10/28 18:55:51, conroy wrote: http://gwt-code-reviews.appspot.com/1060801/diff/10001/11003#newcode98 user/src/com/google/gwt/experimental/geolocation/impl/GeolocationImpl.java:98: @com.google.gwt.experimental.geolocation.impl.GeolocationImpl::success(Lcom/google/gwt/experimental/geolocation/Geolocation$Handler;DDDD)( my JNI-JSNI-fu fails me here: ';DDDD' http://gwt-code-reviews.appspot.com/1060801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Experimental version of GeoLocation API (issue1060801)
Ah yes, I'm used to seeing far fewer arguments and still find the syntax unpleasant You know a syntax is ugly when a method signature looks like a toddler snuck up and smashed some keys when you weren't looking :P Sorry for the brain fart there. On Thu, Oct 28, 2010 at 3:16 PM, jdou...@basis.com wrote: That translates to an arglist of: A Java object of this type: Lcom/google/gwt/experimental/geolocation/Geolocation$Handler; Followed by seven doubles: DDD Followed by four booleans: Followed by a double: D On 2010/10/28 18:55:51, conroy wrote: http://gwt-code-reviews.appspot.com/1060801/diff/10001/11003#newcode98 user/src/com/google/gwt/experimental/geolocation/impl/GeolocationImpl.java:98: @com.google.gwt.experimental.geolocation.impl.GeolocationImpl::success(Lcom/google/gwt/experimental/geolocation/Geolocation$Handler;DDDD)( my JNI-JSNI-fu fails me here: ';DDDD' http://gwt-code-reviews.appspot.com/1060801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] RFC requestfactory should support covariant return types on entity type hierarchy
Let me see if I can explain this correctly...
Basically, when a RequestFactory interface is validated it fails if
any of the property methods of the mapped entity class are
overloaded. So basically, if I understand this correctly, for every
method defined on the EntityProxy interface, if more than one method
of the same name is found via reflection on the EntityProxy's
@ProxyFor class, then validation fails. This validation check does not
take into account the parameters specified by the overloaded methods,
and so, for methods that only change the return type (covariance),
this check still fails.
So, an entity type hierarchy like so is *not* supported...
interface IEntity {
Object getId();
}
@MappedSuperclass
abstract class BaseEntity implements IEntity {
Integer version;
Integer getVersion() { return version; }
}
@Entity
class RealEntity extends BaseEntity {
@Id
Long id;
Long getId() { return id; }
}
... Because RealEntity.class has 2 getId methods and is thus
considered overloaded even though the methods only differ by return
type.
If this is totally intended or required, can someone explain it to me?
Because, to me, it seems viable to support this.
If it is viable, I guess the only way to do this right would be to
introspect the list of same-name methods and make sure all the
parameter lists match. And only then allow it to be validated. That
sound about right? If so, I'll see what I can do to put something
together.
Thanks,
-matt
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Remove the onFailure call in case of unauthenticated user. This gets rid of the (issue1061801)
Reviewers: unnurg, robertvawter,
Description:
Remove the onFailure call in case of unauthenticated user. This gets rid
of the
multiple popups for a roo-generated GWT app that uses AppEngine.
Patch by: amitmanjhi
Review by: unnurg,robertvawter
Please review this at http://gwt-code-reviews.appspot.com/1061801/show
Affected files:
M
user/src/com/google/gwt/requestfactory/client/DefaultRequestTransport.java
Index:
user/src/com/google/gwt/requestfactory/client/DefaultRequestTransport.java
===
---
user/src/com/google/gwt/requestfactory/client/DefaultRequestTransport.java
(revision 9162)
+++
user/src/com/google/gwt/requestfactory/client/DefaultRequestTransport.java
(working copy)
@@ -157,7 +157,6 @@
} else if (Response.SC_UNAUTHORIZED == response.getStatusCode())
{
String message = Need to log in;
wireLogger.finest(message);
-receiver.onTransportFailure(message);
} else if (response.getStatusCode() 0) {
/*
* During the redirection for logging in, we get a response
with no
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Remove the onFailure call in case of unauthenticated user. This gets rid of the (issue1061801)
On 2010/10/28 22:00:18, amitmanjhi wrote: Bob should confirm this, but LGTM. I believe that this got added when Bob added the recievers, and he saw that we were logging a finest message and assumed that this was a failure case. This is not a failure case, it is expected. There is an event listener which listens for UNAUTHORIZED responses, and when it sees it, it redirects. However, there shouldn't be any errors fired when this happens - it is an expected codepath. http://gwt-code-reviews.appspot.com/1061801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Remove the onFailure call in case of unauthenticated user. This gets rid of the (issue1061801)
+ Ray since he was the one that wanted the redirect handled by a listener
rather than just doing it directly when we receive the response.
Note that the current behavior in GAE is that a popup saying Need to log
in flashes repeatedly before the user is redirected to the login page. It's
pretty disruptive. As Bob says, if we get rid of the popup, enable
authentication, but do not install the event listener, then it fails
silently.
Bob - why is the event listener not installed by default in non roo apps? I
think it was when I originally added this code (although it has been a
while)
- Unnur
On Thu, Oct 28, 2010 at 3:16 PM, Bob Vawter robertvaw...@google.com wrote:
@@ -157,7 +157,6 @@
} else if (Response.SC_UNAUTHORIZED ==
response.getStatusCode()) {
String message = Need to log in;
wireLogger.finest(message);
-receiver.onTransportFailure(message);
} else if (response.getStatusCode() 0) {
-1
This will fail silently if the AuthenticationFailureHandler is not
installed, which is not done by default in non-Roo apps.
--
Bob Vawter
Google Web Toolkit Team
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Remove the onFailure call in case of unauthenticated user. This gets rid of the (issue1061801)
On Thu, Oct 28, 2010 at 6:26 PM, Unnur Gretarsdottir unn...@google.com wrote: Bob - why is the event listener not installed by default in non roo apps? I think it was when I originally added this code (although it has been a while) There is no good default behavior in this case; authentication almost seems to define the phrase site-specific. The implementation of AuthenticationFailureHandler makes assumptions about the serving environment, namely that the login and userId headers will be defined. If the login header is undefined, Location.replace() is called with a null value. -- Bob Vawter Google Web Toolkit Team -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Remove the onFailure call in case of unauthenticated user. This gets rid of the (issue1061801)
Perhaps for non-roo apps, there could be an alternative AuthenticationFailureHandler which simply displays a pop-up user not logged in. On Thu, Oct 28, 2010 at 3:49 PM, BobV b...@google.com wrote: On Thu, Oct 28, 2010 at 6:26 PM, Unnur Gretarsdottir unn...@google.com wrote: Bob - why is the event listener not installed by default in non roo apps? I think it was when I originally added this code (although it has been a while) There is no good default behavior in this case; authentication almost seems to define the phrase site-specific. The implementation of AuthenticationFailureHandler makes assumptions about the serving environment, namely that the login and userId headers will be defined. If the login header is undefined, Location.replace() is called with a null value. -- Bob Vawter Google Web Toolkit Team -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Overhaul the RequestFactory server code. (issue1062801)
Reviewers: rjrjr, rchandia, Description: Overhaul the RequestFactory server code. Move AutoBeans to a top-level package and add AutoBeanCodex. Make RequestFactory usable from non-GWT code. Patch by: bobv Revwie by: rjrjr, rchandia Please review this at http://gwt-code-reviews.appspot.com/1062801/show Affected files: A samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/console/Console.java A samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/console/HttpClientTransport.java A user/src/com/google/gwt/autobean/AutoBean.gwt.xml A user/src/com/google/gwt/autobean/client/impl/AbstractAutoBeanFactory.java A user/src/com/google/gwt/autobean/client/impl/JsoSplittable.java A user/src/com/google/gwt/autobean/rebind/AutoBeanFactoryGenerator.java A user/src/com/google/gwt/autobean/rebind/model/AutoBeanFactoryMethod.java A user/src/com/google/gwt/autobean/rebind/model/AutoBeanFactoryModel.java A user/src/com/google/gwt/autobean/rebind/model/AutoBeanMethod.java A user/src/com/google/gwt/autobean/rebind/model/AutoBeanType.java A user/src/com/google/gwt/autobean/server/AutoBeanFactoryMagic.java A user/src/com/google/gwt/autobean/server/BeanMethod.java A user/src/com/google/gwt/autobean/server/Configuration.java A user/src/com/google/gwt/autobean/server/FactoryHandler.java A user/src/com/google/gwt/autobean/server/GetterPropertyContext.java A user/src/com/google/gwt/autobean/server/MapPropertyContext.java A user/src/com/google/gwt/autobean/server/ProxyAutoBean.java A user/src/com/google/gwt/autobean/server/ShimHandler.java A user/src/com/google/gwt/autobean/server/SimpleBeanHandler.java A user/src/com/google/gwt/autobean/server/impl/JsonSplittable.java A user/src/com/google/gwt/autobean/server/impl/TypeUtils.java A user/src/com/google/gwt/autobean/shared/AutoBean.java A user/src/com/google/gwt/autobean/shared/AutoBeanCodex.java A user/src/com/google/gwt/autobean/shared/AutoBeanFactory.java A user/src/com/google/gwt/autobean/shared/AutoBeanUtils.java A user/src/com/google/gwt/autobean/shared/AutoBeanVisitor.java A user/src/com/google/gwt/autobean/shared/EncodedAutoBean.java A user/src/com/google/gwt/autobean/shared/SplittableAutoBeanImpl.java A user/src/com/google/gwt/autobean/shared/ValueCodex.java A user/src/com/google/gwt/autobean/shared/impl/AbstractAutoBean.java A user/src/com/google/gwt/autobean/shared/impl/Splittable.java A user/src/com/google/gwt/autobean/shared/impl/StringEncodedAutoBean.java A user/src/com/google/gwt/autobean/shared/impl/StringQuoter.java user/src/com/google/gwt/core/client/impl/WeakMapping.java M user/src/com/google/gwt/editor/Editor.gwt.xml D user/src/com/google/gwt/editor/client/AutoBean.java D user/src/com/google/gwt/editor/client/AutoBeanFactory.java D user/src/com/google/gwt/editor/client/AutoBeanUtils.java D user/src/com/google/gwt/editor/client/AutoBeanVisitor.java D user/src/com/google/gwt/editor/client/impl/AbstractAutoBean.java D user/src/com/google/gwt/editor/client/impl/AbstractAutoBeanFactory.java D user/src/com/google/gwt/editor/rebind/AutoBeanFactoryGenerator.java D user/src/com/google/gwt/editor/rebind/model/AutoBeanFactoryMethod.java D user/src/com/google/gwt/editor/rebind/model/AutoBeanFactoryModel.java D user/src/com/google/gwt/editor/rebind/model/AutoBeanMethod.java D user/src/com/google/gwt/editor/rebind/model/AutoBeanType.java M user/src/com/google/gwt/editor/rebind/model/ModelUtils.java M user/src/com/google/gwt/requestfactory/RequestFactory.gwt.xml A user/src/com/google/gwt/requestfactory/client/impl/AbstractClientRequestFactory.java D user/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java D user/src/com/google/gwt/requestfactory/client/impl/AbstractRequestContext.java D user/src/com/google/gwt/requestfactory/client/impl/AbstractRequestFactory.java user/src/com/google/gwt/requestfactory/client/impl/EntityCodex.java D user/src/com/google/gwt/requestfactory/client/impl/EntityProxyCategory.java D user/src/com/google/gwt/requestfactory/client/impl/FindRequest.java D user/src/com/google/gwt/requestfactory/client/impl/SimpleEntityProxyId.java D user/src/com/google/gwt/requestfactory/client/impl/messages/JsonResults.java D user/src/com/google/gwt/requestfactory/client/impl/messages/JsonServerException.java D user/src/com/google/gwt/requestfactory/client/impl/messages/RelatedObjects.java D user/src/com/google/gwt/requestfactory/client/impl/messages/RequestContentData.java D user/src/com/google/gwt/requestfactory/client/impl/messages/RequestData.java D user/src/com/google/gwt/requestfactory/client/impl/messages/ReturnRecord.java D user/src/com/google/gwt/requestfactory/client/impl/messages/SideEffects.java M user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java M user/src/com/google/gwt/requestfactory/server/DeadEntityException.java
[gwt-contrib] Add property provider generators. (issue1063801)
Reviewers: unnurg, Description: Add property provider generators. Patch by: jat Review by: unnurg Please review this at http://gwt-code-reviews.appspot.com/1063801/show Affected files: A dev/core/src/com/google/gwt/core/ext/linker/PropertyProviderGenerator.java M dev/core/src/com/google/gwt/core/ext/linker/SelectionProperty.java M dev/core/src/com/google/gwt/core/ext/linker/impl/PermutationsUtil.java M dev/core/src/com/google/gwt/core/ext/linker/impl/PropertiesUtil.java M dev/core/src/com/google/gwt/core/ext/linker/impl/StandardSelectionProperty.java M dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java M dev/core/src/com/google/gwt/dev/cfg/ModuleDefSchema.java M dev/core/test/com/google/gwt/core/ext/linker/impl/StandardSelectionPropertyTest.java M distro-source/core/src/gwt-module.dtd M tools/api-checker/config/gwt20_21userApi.conf M user/src/com/google/gwt/i18n/I18N.gwt.xml M user/src/com/google/gwt/i18n/client/LocaleInfo.java M user/src/com/google/gwt/i18n/client/impl/LocaleInfoImpl.java A user/src/com/google/gwt/i18n/linker/LocalePropertyProviderGenerator.java M user/src/com/google/gwt/i18n/rebind/LocaleInfoGenerator.java M user/test/com/google/gwt/i18n/I18NTest_ar.gwt.xml M user/test/com/google/gwt/i18n/client/LocaleInfoTest.java M user/test/com/google/gwt/i18n/client/LocaleInfo_ar_Test.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Cleanup for EnumsTest and EnumsWithNameObfuscationTest suites, make sure they always run with co... (issue1018801)
LGTM http://gwt-code-reviews.appspot.com/1018801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Enum Ordinalization Optimization (issue1015801)
LGTM http://gwt-code-reviews.appspot.com/1015801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
