[gwt-contrib] [google-web-toolkit] r9352 committed - Cherry pick r9350 (bad imports break memcache), r9351 (Delete sample/e...

[codesite-noreply]

Revision: 9352
Author: rj...@google.com
Date: Thu Dec  2 18:32:38 2010
Log: Cherry pick r9350 (bad imports break memcache), r9351 (Delete  
sample/expenses console)


http://code.google.com/p/google-web-toolkit/source/detail?r=9352

Deleted:
  
/releases/2.1/samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/console

Modified:
  
/releases/2.1/samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/Report.java
  
/releases/2.1/samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/ReportBack.java


===
---  
/releases/2.1/samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/Report.java	 
Wed Oct 13 06:40:20 2010
+++  
/releases/2.1/samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/Report.java	 
Thu Dec  2 18:32:38 2010

@@ -17,11 +17,6 @@

 import com.google.appengine.api.datastore.Cursor;

-import net.sf.jsr107cache.Cache;
-import net.sf.jsr107cache.CacheException;
-import net.sf.jsr107cache.CacheFactory;
-import net.sf.jsr107cache.CacheManager;
-
 import org.datanucleus.store.appengine.query.JPACursorHelper;

 import java.util.Collections;
@@ -29,6 +24,10 @@
 import java.util.List;
 import java.util.logging.Logger;

+import javax.cache.Cache;
+import javax.cache.CacheException;
+import javax.cache.CacheFactory;
+import javax.cache.CacheManager;
 import javax.persistence.Column;
 import javax.persistence.Entity;
 import javax.persistence.EntityManager;
===
---  
/releases/2.1/samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/ReportBack.java	 
Thu Sep 16 10:06:06 2010
+++  
/releases/2.1/samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/ReportBack.java	 
Thu Dec  2 18:32:38 2010

@@ -17,11 +17,6 @@

 import com.google.appengine.api.datastore.Cursor;

-import net.sf.jsr107cache.Cache;
-import net.sf.jsr107cache.CacheException;
-import net.sf.jsr107cache.CacheFactory;
-import net.sf.jsr107cache.CacheManager;
-
 import org.datanucleus.store.appengine.query.JPACursorHelper;

 import java.util.Collections;
@@ -29,6 +24,10 @@
 import java.util.List;
 import java.util.logging.Logger;

+import javax.cache.Cache;
+import javax.cache.CacheException;
+import javax.cache.CacheFactory;
+import javax.cache.CacheManager;
 import javax.persistence.Column;
 import javax.persistence.Entity;
 import javax.persistence.EntityManager;

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Breaking change proposed: future proofing Activity in 2.1.1

[Amir Kashani]

We've adopted the new MVP framework pretty heavily in a couple of new
projects and at this point, I don't think we've ever not used
AbstractActivity. So, as long as the existing methods in Activity don't
become inaccessible to non-GWT code (i.e. not package protected or final), I
don't see a problem.

My only concern is that while making it an abstract class makes it easier to
evolve, it also make it easier to default behavior that the end-user may not
want. If a mechanism isn't provided to override this behavior, then someone
may end up having to roll their own MVP framework for an otherwise minor
issue. With a something as powerful and complex as this framework, that'd be
a real shame. So, *please please please,* be cautious with this power:
reasonable default behavior and the ability to override.

Thanks!

- Amir

On Thu, Dec 2, 2010 at 7:55 PM, Ray Ryan  wrote:

> We're making a few breaking changes in 2.1.1 to the new features introduced
> in 2.1. (We're not supposed to do that kind of thing, but are hoping to get
> away with it in this quick follow up release before there is much
> adoption.)
>
> I'd like to add a change to Activity to that list, in order to allow it to
> evolve in later releases when breakage of any kind won't be an option: I'd
> like to make Activity an abstract class instead of an interface, basically
> rename AbstractActivity.
>
> Any objections?
>
> rjrjr
>
>  --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r9351 committed - Delete sample/expenses console. Cool demo but it requires gwt-dev, not...

[codesite-noreply]

Revision: 9351
Author: rj...@google.com
Date: Thu Dec  2 18:19:32 2010
Log: Delete sample/expenses console. Cool demo but it requires gwt-dev, not
viable as a sample. Fixes
http://code.google.com/p/google-web-toolkit/issues/detail?id=5681

http://code.google.com/p/google-web-toolkit/source/detail?r=9351

Deleted:
 /trunk/samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/console

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Public: Check constraints against the field or property that has the actual annotation. (issue1185801)

[nchalko]

Reviewers: rchandia,

Description:
Public: Check constraints against the field or property that has the
actual annotation.


Please review this at http://gwt-code-reviews.appspot.com/1185801/show

Affected files:
  M  
samples/validationtck/test/com/google/gwt/sample/validationtck/constraints/application/TckTestValidator.java
  M  
samples/validationtck/test/com/google/gwt/sample/validationtck/constraints/application/ValidationRequirementTest.java

  M user/src/com/google/gwt/validation/rebind/AbstractCreator.java
  M user/src/com/google/gwt/validation/rebind/BeanHelper.java
  M  
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java



--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Plans to support layouts that are independent of actual browser dimensions

[mP]

I have been listening to some past Android podcasts and they have
triggered some interesting q in my mind which i believe would benefit
people using GWT.

Each browser etc would have one or more profiles associated with it.
Without copying whats exactly in Android ill list something simple
like:
  - big screens
  - medium
  - mobile

Font sizes in css and so on would pick the right one based on the
current profile.
Maybe different profiles could have custom css files.
etc.

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Breaking change proposed: future proofing Activity in 2.1.1

[Ray Ryan]

We're making a few breaking changes in 2.1.1 to the new features introduced
in 2.1. (We're not supposed to do that kind of thing, but are hoping to get
away with it in this quick follow up release before there is much
adoption.)

I'd like to add a change to Activity to that list, in order to allow it to
evolve in later releases when breakage of any kind won't be an option: I'd
like to make Activity an abstract class instead of an interface, basically
rename AbstractActivity.

Any objections?

rjrjr

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: In CompilingClassLoader, refuse to load a class if its compilation unit has errors. (issue1167801)

[scottb]

LGTM

http://gwt-code-reviews.appspot.com/1167801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: The symbolMaps directory provided to StackTraceDeobfuscator should accepts directory name with (issue1180801)

[fredsa]

Committed in r9349

http://gwt-code-reviews.appspot.com/1180801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Update MissingPlugin.html to reflect new Chrome platform support (issue1184801)

[conroy]

Reviewers: robertvawter, jat,

Description:
Update MissingPlugin.html to reflect new Chrome platform support


Please review this at http://gwt-code-reviews.appspot.com/1184801/show

Affected files:
  M plugins/MissingPlugin/war/MissingPlugin.html


Index: plugins/MissingPlugin/war/MissingPlugin.html
===
--- plugins/MissingPlugin/war/MissingPlugin.html(revision 9312)
+++ plugins/MissingPlugin/war/MissingPlugin.html(working copy)
@@ -62,25 +62,12 @@
 "supported" : false
   },

-  "chrome-lin" :
+  "chrome" :
   {
-"caption" : "Sorry, there is currently no GWT Developer Plugin  
for Chrome on Linux",

-"url" : troubleshootingUrl,
-"supported" : false
-  },
-
-  "chrome-mac" :
-  {
-"caption" : "Sorry, there is currently no GWT Developer Plugin  
for Chrome on OS X",

-"url" : troubleshootingUrl,
-"supported" : false
-  },
-
-  "chrome-win" :
-  {
-"caption" : "The GWT Developer Plugin requires Chrome 4 or  
later,so click here to learn about switching to the Chrome DevChannel  
to get early access",

-"url" : "http://dev.chromium.org/getting-involved/dev-channel";,
-"supported" : false
+"caption" : "Download the GWT Developer PluginFor Chrome",
+"url" : 
"https://dl-ssl.google.com/gwt/plugins/chrome/gwt-dev-plugin.crx";,
+"platforms" : "Win x86, Linux x86/x86_64, Mac x86",
+"supported" : true
   },

   "safari-win" :
@@ -106,14 +93,6 @@
 "supported" : true
   },

-  "chrome4-win" :
-  {
-"caption" : "Download the GWT Developer PluginFor Chrome",
-"url" : 
"https://dl-ssl.google.com/gwt/plugins/chrome/gwt-dev-plugin.crx";,
-"platforms" : "Win x86",
-"supported" : true
-  },
-
   "safari-mac" :
   {
 "caption" : "Download the GWT Developer PluginFor Safari",
@@ -133,20 +112,7 @@
 } else if (ua.indexOf("android") != -1) {
   id = 'webkit-android';
 } else if (ua.indexOf("chrome") != -1) {
-  if (ua.indexOf("windows") != -1) {
-var ver = /chrome\/(\d+)(\.\d+)*/.exec(ua);
-if (ver && ver.length > 1 && ver[1] >= 4) {
-  id = 'chrome4-win';
-} else {
-  id = 'chrome-win';
-}
-  } else if (ua.indexOf("linux") != -1) {
-id = 'chrome-lin';
-  } else if (ua.indexOf("macintosh") != -1) {
-id = 'chrome-mac';
-  } else {
-// unknown Chrome platform
-  }
+id = 'chrome';
 } else if (ua.indexOf("macintosh") != -1) {
   id = 'safari-mac';
 } else if (ua.indexOf("windows") != -1) {


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: In CompilingClassLoader, refuse to load a class if its compilation unit has errors. (issue1167801)

[conroy]

http://gwt-code-reviews.appspot.com/1167801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixes two issues (issue1181802)

[Ray Ryan]

LGTM

@conroy, yup, that change to use NumberFormat was intentional. The rint(),
not so much.

On Thu, Dec 2, 2010 at 2:50 PM,  wrote:

> LGTM
>
> looks like this crept in in the massive r8946. In addition to being
> moved, the parse method was changed from
>
>
> public Double parse(CharSequence object) throws ParseException {
> -try {
> -  return Double.valueOf(object.toString());
>
> -} catch (NumberFormatException e) {
> -  throw new ParseException(e.getMessage(), 0);
> -}
> -  }
>
> to
>
> <
>  public Double parse(CharSequence object) throws ParseException {
> +if ("".equals(object.toString())) {
> +  return null;
> +}
> +
> try {
> -  return Double.valueOf(object.toString());
>
> +  return
> Math.rint(NumberFormat.getDecimalFormat().parse(object.toString()));
> } catch (NumberFormatException e) {
>   throw new ParseException(e.getMessage(), 0);
> }
>
> On 2010/12/02 22:45:38, rchandia wrote:
>
>> Gah! I meant:
>> http://gwt-code-reviews.appspot.com/1170801
>>
>
>  El 2 de diciembre de 2010 17:40, Chris Conroy
>>
>  escribió:
>
>  > that's a link to this review :P
>> >
>> >
>> > On Thu, Dec 2, 2010 at 5:39 PM,  wrote:
>> >
>> >> This is actually a repost of tboryer's patch originally submitted
>>
> at:
>
>> >>
>> >>
>> >> http://gwt-code-reviews.appspot.com/1181802
>> >>
>> >> On 2010/12/02 22:33:23, rchandia wrote:
>> >>
>> >>
>> >>
>> >>
>> >> http://gwt-code-reviews.appspot.com/1181802/show
>> >>
>> >
>> >
>>
>
>
>
>
> http://gwt-code-reviews.appspot.com/1181802/show
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r9350 committed - Fixes GWT issue 5705, bad imports break memcache...

[codesite-noreply]

Revision: 9350
Author: rj...@google.com
Date: Thu Dec  2 11:40:44 2010
Log: Fixes GWT issue 5705, bad imports break memcache

Review at http://gwt-code-reviews.appspot.com/1182801

Review by: drfibona...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9350

Modified:
  
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/Report.java
  
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/ReportBack.java


===
---  
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/Report.java	 
Tue Oct  5 11:03:13 2010
+++  
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/Report.java	 
Thu Dec  2 11:40:44 2010

@@ -17,11 +17,6 @@

 import com.google.appengine.api.datastore.Cursor;

-import net.sf.jsr107cache.Cache;
-import net.sf.jsr107cache.CacheException;
-import net.sf.jsr107cache.CacheFactory;
-import net.sf.jsr107cache.CacheManager;
-
 import org.datanucleus.store.appengine.query.JPACursorHelper;

 import java.util.Collections;
@@ -29,6 +24,10 @@
 import java.util.List;
 import java.util.logging.Logger;

+import javax.cache.Cache;
+import javax.cache.CacheException;
+import javax.cache.CacheFactory;
+import javax.cache.CacheManager;
 import javax.persistence.Column;
 import javax.persistence.Entity;
 import javax.persistence.EntityManager;
===
---  
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/ReportBack.java	 
Thu Sep 16 10:06:06 2010
+++  
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/ReportBack.java	 
Thu Dec  2 11:40:44 2010

@@ -17,11 +17,6 @@

 import com.google.appengine.api.datastore.Cursor;

-import net.sf.jsr107cache.Cache;
-import net.sf.jsr107cache.CacheException;
-import net.sf.jsr107cache.CacheFactory;
-import net.sf.jsr107cache.CacheManager;
-
 import org.datanucleus.store.appengine.query.JPACursorHelper;

 import java.util.Collections;
@@ -29,6 +24,10 @@
 import java.util.List;
 import java.util.logging.Logger;

+import javax.cache.Cache;
+import javax.cache.CacheException;
+import javax.cache.CacheFactory;
+import javax.cache.CacheManager;
 import javax.persistence.Column;
 import javax.persistence.Entity;
 import javax.persistence.EntityManager;

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixes two issues (issue1181802)

[conroy]

LGTM

looks like this crept in in the massive r8946. In addition to being
moved, the parse method was changed from


public Double parse(CharSequence object) throws ParseException {
-try {
-  return Double.valueOf(object.toString());
-} catch (NumberFormatException e) {
-  throw new ParseException(e.getMessage(), 0);
-}
-  }

to

<
 public Double parse(CharSequence object) throws ParseException {
+if ("".equals(object.toString())) {
+  return null;
+}
+
 try {
-  return Double.valueOf(object.toString());
+  return
Math.rint(NumberFormat.getDecimalFormat().parse(object.toString()));
 } catch (NumberFormatException e) {
   throw new ParseException(e.getMessage(), 0);
 }

On 2010/12/02 22:45:38, rchandia wrote:

Gah! I meant:
http://gwt-code-reviews.appspot.com/1170801



El 2 de diciembre de 2010 17:40, Chris Conroy

 escribió:


> that's a link to this review :P
>
>
> On Thu, Dec 2, 2010 at 5:39 PM,  wrote:
>
>> This is actually a repost of tboryer's patch originally submitted

at:

>>
>>
>> http://gwt-code-reviews.appspot.com/1181802
>>
>> On 2010/12/02 22:33:23, rchandia wrote:
>>
>>
>>
>>
>> http://gwt-code-reviews.appspot.com/1181802/show
>>
>
>





http://gwt-code-reviews.appspot.com/1181802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixes two issues (issue1181802)

[Rodrigo Chandia]

Gah! I meant:
http://gwt-code-reviews.appspot.com/1170801

El 2 de diciembre de 2010 17:40, Chris Conroy  escribió:

> that's a link to this review :P
>
>
> On Thu, Dec 2, 2010 at 5:39 PM,  wrote:
>
>> This is actually a repost of tboryer's patch originally submitted at:
>>
>>
>> http://gwt-code-reviews.appspot.com/1181802
>>
>> On 2010/12/02 22:33:23, rchandia wrote:
>>
>>
>>
>>
>> http://gwt-code-reviews.appspot.com/1181802/show
>>
>
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixes GWT issue 5705, bad imports break memcache (issue1182801)

[drfibonacci]

LGTM

http://gwt-code-reviews.appspot.com/1182801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: First pass at Issue 1405 (Dialog Box header fix)

[Jeff Larsen]

Thanks for taking the time to look at it.

Bumping this because it seems like things have gotten really busy with
commits in the past few days. I know this isn't complete fix. I want
to add a default implementation for the header that accepts widgets
and modify the uibinder support for dialogbox to include the new
caption stuff but I wanted to make sure I was going down the right
path before I jumped too far down that path.


On Nov 30, 11:29 am, Ray Ryan  wrote:
> Thanks for the patch, Jeff. I'll try to look at it today.
>
>
>
>
>
>
>
> On Mon, Nov 29, 2010 at 8:04 AM, Jeff Larsen  wrote:
> > Please review this at
>
> >http://gwt-code-reviews.appspot.com/1149803/show
>
> > --
> >http://groups.google.com/group/Google-Web-Toolkit-Contributors

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixes two issues (issue1181802)

[Chris Conroy]

that's a link to this review :P

On Thu, Dec 2, 2010 at 5:39 PM,  wrote:

> This is actually a repost of tboryer's patch originally submitted at:
>
>
> http://gwt-code-reviews.appspot.com/1181802
>
> On 2010/12/02 22:33:23, rchandia wrote:
>
>
>
>
> http://gwt-code-reviews.appspot.com/1181802/show
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixes two issues (issue1181802)

[rchandia]

This is actually a repost of tboryer's patch originally submitted at:

http://gwt-code-reviews.appspot.com/1181802

On 2010/12/02 22:33:23, rchandia wrote:




http://gwt-code-reviews.appspot.com/1181802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Issue 5663: DoubleParser rounds values to integers (issue1170801)

[rchandia]

Re posting as http://gwt-code-reviews.appspot.com/1181802

Ovet there I changed the test to use 123.5 to avoid roundoff issues.

On 2010/12/01 16:55:56, jat wrote:

On Wed, Dec 1, 2010 at 11:52 AM, Ray Ryan 

wrote:


> I'll get it in today, thanks very much for the patch.
>
> I suspect this is the cause of
> http://code.google.com/p/google-web-toolkit/issues/detail?id=5460
>



Note if you are going to take care of the patch, you need to make sure

the

double comparison avoids roundoff on all browsers (you would be

surprised

how much it differs, as I found out doing the BigDecimal/NumberFormat

work).

  I would recommend .5 as the fraction, since there can't be any

round-off.


--
John A. Tamplin
Software Engineer (GWT), Google





http://gwt-code-reviews.appspot.com/1170801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fixes two issues (issue1181802)

[rchandia]

Reviewers: conroy, rjrjr, jat, tbroyer,

Description:
Fixes two issues
Issue 5460: Scaffold app expenses does not store decimal values
Issue 5663: DoubleParser rounds values to integers
Thanks to t.bro...@gmail.com


Please review this at http://gwt-code-reviews.appspot.com/1181802/show

Affected files:
  M user/src/com/google/gwt/text/client/DoubleParser.java
  M user/test/com/google/gwt/text/client/DoubleParserTest.java


Index: user/src/com/google/gwt/text/client/DoubleParser.java
===
--- user/src/com/google/gwt/text/client/DoubleParser.java   (revision 9348)
+++ user/src/com/google/gwt/text/client/DoubleParser.java   (working copy)
@@ -46,7 +46,7 @@
 }

 try {
-  return  
Math.rint(NumberFormat.getDecimalFormat().parse(object.toString()));

+  return NumberFormat.getDecimalFormat().parse(object.toString());
 } catch (NumberFormatException e) {
   throw new ParseException(e.getMessage(), 0);
 }
Index: user/test/com/google/gwt/text/client/DoubleParserTest.java
===
--- user/test/com/google/gwt/text/client/DoubleParserTest.java	(revision  
9348)
+++ user/test/com/google/gwt/text/client/DoubleParserTest.java	(working  
copy)

@@ -30,7 +30,7 @@
   }

   public void testOuroborus() throws ParseException {
-assertEquals("123",  
DoubleRenderer.instance().render(DoubleParser.instance().parse("123")));
+assertEquals("123.5",  
DoubleRenderer.instance().render(DoubleParser.instance().parse("123.5")));

   }

   public void testNull() throws ParseException {


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r9349 committed - The symbolMaps directory provided to StackTraceDeobfuscator should acc...

[codesite-noreply]

Revision: 9349
Author: fre...@google.com
Date: Thu Dec  2 11:11:38 2010
Log: The symbolMaps directory provided to StackTraceDeobfuscator should  
accepts directory name with

and without a trailing directory separator character

Fixes Issues: 5703

Review at http://gwt-code-reviews.appspot.com/1180801

Review by: unn...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9349

Modified:
 /trunk/user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java

===
---  
/trunk/user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java	 
Thu Dec  2 06:33:44 2010
+++  
/trunk/user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java	 
Thu Dec  2 11:11:38 2010

@@ -17,6 +17,7 @@
 package com.google.gwt.logging.server;

 import java.io.BufferedReader;
+import java.io.File;
 import java.io.FileReader;
 import java.io.IOException;
 import java.util.HashMap;
@@ -33,7 +34,8 @@
  * server side code has access to it, and then set the symbolMapsDirectory  
in

  * this class through the constructor, or the setter method.
  * For example, this variable could be set to "WEB-INF/classes/symbolMaps/"
- * if you copied the symbolMaps directory to there.
+ * if you copied the symbolMaps directory to there or compiled your  
application

+ * using -extra war/WEB-INF/classes/.
  *
  * TODO(unnurg): Combine this code with similar code in JUnitHostImpl
  */
@@ -46,13 +48,21 @@
   private static Pattern JsniRefPattern =
 Pattern.compile("@?([^:]+)::([^(]+)(\\((.*)\\))?");

-  private String symbolMapsDirectory;
+  private File symbolMapsDirectory;

   private Map symbolMaps =
 new HashMap();
-
+
+  /**
+   * Constructor, which takes a symbolMaps directory as its
+   * argument. Symbol maps can be generated using the -extra  
GWT

+   * compiler argument.
+   *
+   * @param symbolMapsDirectory the symbolMaps directory  
with, or

+   *  without trailing directory separator character
+   */
   public StackTraceDeobfuscator(String symbolMapsDirectory) {
-this.symbolMapsDirectory = symbolMapsDirectory;
+setSymbolMapsDirectory(symbolMapsDirectory);
   }

   public LogRecord deobfuscateLogRecord(LogRecord lr, String strongName) {
@@ -95,15 +105,9 @@
 return ste;
   }

-  public void setSymbolMapsDirectory(String dir) {
-// Switching the directory should clear the symbolMaps variable (which
-// is read in lazily), but causing the symbolMaps variable to be  
re-read
-// is somewhat expensive, so we only want to do this if the directory  
is

-// actually different.
-if (!dir.equals(symbolMapsDirectory)) {
-  symbolMapsDirectory = dir;
-  symbolMaps = new HashMap();
-}
+  public void setSymbolMapsDirectory(String symbolMapsDirectory) {
+// permutations are unique, no need to clear the symbolMaps hash map
+this.symbolMapsDirectory = new File(symbolMapsDirectory);
   }

   private StackTraceElement[] deobfuscateStackTrace(
@@ -136,9 +140,10 @@
 }
 toReturn = new SymbolMap();
 String line;
-String filename = symbolMapsDirectory + strongName + ".symbolMap";

 try {
+  String filename = symbolMapsDirectory.getCanonicalPath()
+  + File.separatorChar + strongName + ".symbolMap";
   BufferedReader bin = new BufferedReader(new FileReader(filename));
   try {
 while ((line = bin.readLine()) != null) {

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding methods to insert columns, get the column count, and get columns by index in a CellTable.... (issue1181801)

[sbrubaker]

LGTM


http://gwt-code-reviews.appspot.com/1181801/diff/1/2
File user/src/com/google/gwt/user/cellview/client/CellTable.java
(right):

http://gwt-code-reviews.appspot.com/1181801/diff/1/2#newcode599
user/src/com/google/gwt/user/cellview/client/CellTable.java:599: public
void addColumn(Column col) {
Nit: Can we differentiate in the comments between functions named
addColumn (which add the column to the end) and functions named
insertColumn, which allow the user to indicate where to insert the
column?  It's not obvious from the existing comments.

http://gwt-code-reviews.appspot.com/1181801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fixes GWT issue 5705, bad imports break memcache (issue1182801)

[rjrjr]

Reviewers: drfibonacci,

Description:
Fixes GWT issue 5705, bad imports break memcache


Please review this at http://gwt-code-reviews.appspot.com/1182801/show

Affected files:
  M  
samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/Report.java
  M  
samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/ReportBack.java



Index:  
samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/Report.java

===
---  
samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/Report.java	 
(revision 9348)
+++  
samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/Report.java	 
(working copy)

@@ -17,11 +17,6 @@

 import com.google.appengine.api.datastore.Cursor;

-import net.sf.jsr107cache.Cache;
-import net.sf.jsr107cache.CacheException;
-import net.sf.jsr107cache.CacheFactory;
-import net.sf.jsr107cache.CacheManager;
-
 import org.datanucleus.store.appengine.query.JPACursorHelper;

 import java.util.Collections;
@@ -29,6 +24,10 @@
 import java.util.List;
 import java.util.logging.Logger;

+import javax.cache.Cache;
+import javax.cache.CacheException;
+import javax.cache.CacheFactory;
+import javax.cache.CacheManager;
 import javax.persistence.Column;
 import javax.persistence.Entity;
 import javax.persistence.EntityManager;
Index:  
samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/ReportBack.java

===
---  
samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/ReportBack.java	 
(revision 9348)
+++  
samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/ReportBack.java	 
(working copy)

@@ -17,11 +17,6 @@

 import com.google.appengine.api.datastore.Cursor;

-import net.sf.jsr107cache.Cache;
-import net.sf.jsr107cache.CacheException;
-import net.sf.jsr107cache.CacheFactory;
-import net.sf.jsr107cache.CacheManager;
-
 import org.datanucleus.store.appengine.query.JPACursorHelper;

 import java.util.Collections;
@@ -29,6 +24,10 @@
 import java.util.List;
 import java.util.logging.Logger;

+import javax.cache.Cache;
+import javax.cache.CacheException;
+import javax.cache.CacheFactory;
+import javax.cache.CacheManager;
 import javax.persistence.Column;
 import javax.persistence.Entity;
 import javax.persistence.EntityManager;


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Adding methods to insert columns, get the column count, and get columns by index in a CellTable.... (issue1181801)

[jlabanca]

Reviewers: sbrubaker,

Description:
Adding methods to insert columns, get the column count, and get columns
by index in a CellTable. Thesemethods are very useful for changing the
visible Columns.  Currently, users must remove all columns, then re-add
them just to insert a single column.


Please review this at http://gwt-code-reviews.appspot.com/1181801/show

Affected files:
  M user/src/com/google/gwt/user/cellview/client/CellTable.java
  M user/test/com/google/gwt/user/cellview/client/CellTableTest.java


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r9348 committed - Update comment...

[codesite-noreply]

Revision: 9348
Author: unn...@google.com
Date: Thu Dec  2 09:47:34 2010
Log: Update comment

Review by: j...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9348

Modified:
 /trunk/user/src/com/google/gwt/logging/server/RemoteLoggingServiceUtil.java

===
---  
/trunk/user/src/com/google/gwt/logging/server/RemoteLoggingServiceUtil.java	 
Thu Oct  7 08:07:05 2010
+++  
/trunk/user/src/com/google/gwt/logging/server/RemoteLoggingServiceUtil.java	 
Thu Dec  2 09:47:34 2010

@@ -25,7 +25,7 @@
 public class RemoteLoggingServiceUtil {

   /**
-   * Exceptions that occur during remote logging.
+   * Exceptions that may occur during remote logging.
*/
   public static class RemoteLoggingException extends Exception {
 public RemoteLoggingException(String message) {

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: The symbolMaps directory provided to StackTraceDeobfuscator should accepts directory name with (issue1180801)

[unnurg]

LGTM
On 2010/12/02 20:00:55, fredsa wrote:




http://gwt-code-reviews.appspot.com/1180801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] The symbolMaps directory provided to StackTraceDeobfuscator should accepts directory name with (issue1180801)

[fredsa]

Reviewers: unnurg,

Description:
The symbolMaps directory provided to StackTraceDeobfuscator should
accepts directory name with
and without a trailing directory separator character

Fixes Issues: 5703


Please review this at http://gwt-code-reviews.appspot.com/1180801/show

Affected files:
  M user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java


Index: user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java
===
--- user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java	 
(revision 9344)
+++ user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java	 
(working copy)

@@ -17,6 +17,7 @@
 package com.google.gwt.logging.server;

 import java.io.BufferedReader;
+import java.io.File;
 import java.io.FileReader;
 import java.io.IOException;
 import java.util.HashMap;
@@ -33,7 +34,8 @@
  * server side code has access to it, and then set the symbolMapsDirectory  
in

  * this class through the constructor, or the setter method.
  * For example, this variable could be set to "WEB-INF/classes/symbolMaps/"
- * if you copied the symbolMaps directory to there.
+ * if you copied the symbolMaps directory to there or compiled your  
application

+ * using -extra war/WEB-INF/classes/.
  *
  * TODO(unnurg): Combine this code with similar code in JUnitHostImpl
  */
@@ -46,13 +48,21 @@
   private static Pattern JsniRefPattern =
 Pattern.compile("@?([^:]+)::([^(]+)(\\((.*)\\))?");

-  private String symbolMapsDirectory;
+  private File symbolMapsDirectory;

   private Map symbolMaps =
 new HashMap();
-
+
+  /**
+   * Constructor, which takes a symbolMaps directory as its
+   * argument. Symbol maps can be generated using the -extra  
GWT

+   * compiler argument.
+   *
+   * @param symbolMapsDirectory the symbolMaps directory  
with, or

+   *  without trailing directory separator character
+   */
   public StackTraceDeobfuscator(String symbolMapsDirectory) {
-this.symbolMapsDirectory = symbolMapsDirectory;
+setSymbolMapsDirectory(symbolMapsDirectory);
   }

   public LogRecord deobfuscateLogRecord(LogRecord lr, String strongName) {
@@ -95,15 +105,9 @@
 return ste;
   }

-  public void setSymbolMapsDirectory(String dir) {
-// Switching the directory should clear the symbolMaps variable (which
-// is read in lazily), but causing the symbolMaps variable to be  
re-read
-// is somewhat expensive, so we only want to do this if the directory  
is

-// actually different.
-if (!dir.equals(symbolMapsDirectory)) {
-  symbolMapsDirectory = dir;
-  symbolMaps = new HashMap();
-}
+  public void setSymbolMapsDirectory(String symbolMapsDirectory) {
+// permutations are unique, no need to clear the symbolMaps hash map
+this.symbolMapsDirectory = new File(symbolMapsDirectory);
   }

   private StackTraceElement[] deobfuscateStackTrace(
@@ -136,9 +140,10 @@
 }
 toReturn = new SymbolMap();
 String line;
-String filename = symbolMapsDirectory + strongName + ".symbolMap";

 try {
+  String filename = symbolMapsDirectory.getCanonicalPath()
+  + File.separatorChar + strongName + ".symbolMap";
   BufferedReader bin = new BufferedReader(new FileReader(filename));
   try {
 while ((line = bin.readLine()) != null) {


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r9347 committed - Bidi support for ListBox...

[codesite-noreply]

Revision: 9347
Author: tomer...@google.com
Date: Thu Dec  2 08:13:42 2010
Log: Bidi support for ListBox

Review at http://gwt-code-reviews.appspot.com/1137801

Review by: aha...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9347

Modified:
 /trunk/tools/api-checker/config/gwt21_22userApi.conf
 /trunk/user/src/com/google/gwt/user/client/ui/ListBox.java
 /trunk/user/test/com/google/gwt/user/client/ui/ListBoxTest.java

===
--- /trunk/tools/api-checker/config/gwt21_22userApi.conf	Thu Dec  2  
03:34:25 2010
+++ /trunk/tools/api-checker/config/gwt21_22userApi.conf	Thu Dec  2  
08:13:42 2010

@@ -273,3 +273,7 @@
  
com.google.gwt.user.cellview.client.Header::onBrowserEvent(Lcom/google/gwt/dom/client/Element;Lcom/google/gwt/dom/client/NativeEvent;)  
MISSING
  
com.google.gwt.user.cellview.client.Header::render(Lcom/google/gwt/safehtml/shared/SafeHtmlBuilder;)  
MISSING


+# These are supposedly ambiguous with other overloads on null values.
+com.google.gwt.user.client.ui.ListBox::addItem(Ljava/lang/String;Ljava/lang/String;)  
OVERLOADED_METHOD_CALL
+com.google.gwt.user.client.ui.ListBox::insertItem(Ljava/lang/String;Ljava/lang/String;I)  
OVERLOADED_METHOD_CALL

+
===
--- /trunk/user/src/com/google/gwt/user/client/ui/ListBox.java	Thu Feb 25  
12:09:02 2010
+++ /trunk/user/src/com/google/gwt/user/client/ui/ListBox.java	Thu Dec  2  
08:13:42 2010

@@ -23,6 +23,13 @@
 import com.google.gwt.event.dom.client.ChangeHandler;
 import com.google.gwt.event.dom.client.HasChangeHandlers;
 import com.google.gwt.event.shared.HandlerRegistration;
+import com.google.gwt.i18n.client.HasDirection.Direction;
+import com.google.gwt.i18n.shared.BidiFormatter;
+import com.google.gwt.i18n.shared.DirectionEstimator;
+import com.google.gwt.i18n.shared.HasDirectionEstimator;
+import com.google.gwt.i18n.shared.WordCountDirectionEstimator;
+
+import java.util.ArrayList;

 /**
  * A widget that presents a list of choices to the user, either as a list  
box or

@@ -41,7 +48,14 @@
  * Example
  * {...@example com.google.gwt.examples.ListBoxExample}
  * 
- *
+ *
+ * 
+ * Built-in Bidi Text Support
+ * This widget is capable of automatically adjusting its direction  
according to
+ * its content. This feature is controlled by {...@link  
#setDirectionEstimator},

+ * and is off by default.
+ * 
+ *
  * Use in UiBinder Templates
  * 
  * The items of a ListBox element are laid out in  elements.
@@ -67,7 +81,10 @@
  */
 @SuppressWarnings("deprecation")
 public class ListBox extends FocusWidget implements SourcesChangeEvents,
-HasChangeHandlers, HasName {
+HasChangeHandlers, HasName, HasDirectionEstimator {
+
+  public static final DirectionEstimator DEFAULT_DIRECTION_ESTIMATOR =
+WordCountDirectionEstimator.get();

   private static final int INSERT_AT_END = -1;

@@ -93,6 +110,9 @@

 return listBox;
   }
+
+  private DirectionEstimator estimator;
+  private ArrayList itemTexts = new ArrayList();

   /**
* Creates an empty list box in single selection mode.
@@ -147,6 +167,21 @@
   public void addItem(String item) {
 insertItem(item, INSERT_AT_END);
   }
+
+  /**
+   * Adds an item to the list box, specifying its direction. This method  
has the

+   * same effect as
+   *
+   * 
+   * addItem(item, dir, item)
+   * 
+   *
+   * @param item the text of the item to be added
+   * @param dir the item's direction
+   */
+  public void addItem(String item, Direction dir) {
+insertItem(item, dir, INSERT_AT_END);
+  }

   /**
* Adds an item to the list box, specifying an initial value for the  
item.

@@ -158,6 +193,19 @@
   public void addItem(String item, String value) {
 insertItem(item, value, INSERT_AT_END);
   }
+
+  /**
+   * Adds an item to the list box, specifying its direction and an initial  
value

+   * for the item.
+   *
+   * @param item the text of the item to be added
+   * @param dir the item's direction
+   * @param value the item's value, to be submitted if it is part of a
+   *  {...@link FormPanel}; cannot be null
+   */
+  public void addItem(String item, Direction dir, String value) {
+insertItem(item, dir, value, INSERT_AT_END);
+  }

   /**
* Removes all items from the list box.
@@ -165,6 +213,10 @@
   public void clear() {
 getSelectElement().clear();
   }
+
+  public DirectionEstimator getDirectionEstimator() {
+return estimator;
+  }

   /**
* Gets the number of items present in the list box.
@@ -184,7 +236,7 @@
*/
   public String getItemText(int index) {
 checkIndex(index);
-return getSelectElement().getOptions().getItem(index).getText();
+return itemTexts.get(index);
   }

   public String getName() {
@@ -237,11 +289,30 @@
   public void insertItem(String item, int index) {
 insertItem(item, item, index);
   }
+
+  /**
+   * Inserts an item into the list box, specifying its direction. Has the  
same

+   * effect as
+   *
+   * 
+   * 

[gwt-contrib] [google-web-toolkit] r9346 committed - Improve the docs on @UiField...

[codesite-noreply]

Revision: 9346
Author: rj...@google.com
Date: Thu Dec  2 07:47:53 2010
Log: Improve the docs on @UiField

Review by: konigsb...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9346

Modified:
 /trunk/user/src/com/google/gwt/uibinder/client/UiField.java

===
--- /trunk/user/src/com/google/gwt/uibinder/client/UiField.java	Tue Jul 20  
08:04:29 2010
+++ /trunk/user/src/com/google/gwt/uibinder/client/UiField.java	Thu Dec  2  
07:47:53 2010

@@ -30,5 +30,10 @@
 @Retention(RetentionPolicy.RUNTIME)
 @Target(ElementType.FIELD)
 public @interface UiField {
+  /**
+   * If true, the field must be filled before {...@link  
UiBinder#createAndBindUi} is called.
+   * If false, {...@link UiBinder#createAndBindUi} will fill the field,  
usually

+   * by calling {...@link com.google.gwt.core.client.GWT#create}.
+   */
   boolean provided() default false;
 }

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r9345 committed - IE devmode plugin: 64 bits support end-to-end, build fixes & cleanup, ...

[codesite-noreply]

Revision: 9345
Author: fabio...@google.com
Date: Thu Dec  2 07:41:14 2010
Log: IE devmode plugin: 64 bits support end-to-end, build fixes & cleanup,  
other polishing items.


Review at http://gwt-code-reviews.appspot.com/1116801

http://code.google.com/p/google-web-toolkit/source/detail?r=9345

Added:
 /trunk/plugins/ie/README.txt
 /trunk/plugins/ie/build.cmd
 /trunk/plugins/ie/installer/build.cmd
 /trunk/plugins/ie/installer/generate-wxsfile.cmd
 /trunk/plugins/ie/installer/gwt.ico
 /trunk/plugins/ie/installer/oophm.wxs
 /trunk/plugins/ie/installer/wix
 /trunk/plugins/ie/installer/wix/README.txt
 /trunk/plugins/ie/installer/wix/WixIIsExtension.dll
 /trunk/plugins/ie/installer/wix/WixUtilExtension.dll
 /trunk/plugins/ie/installer/wix/WixVSExtension.dll
 /trunk/plugins/ie/installer/wix/candle.exe
 /trunk/plugins/ie/installer/wix/candle.exe.config
 /trunk/plugins/ie/installer/wix/darice.cub
 /trunk/plugins/ie/installer/wix/heat.exe
 /trunk/plugins/ie/installer/wix/heat.exe.config
 /trunk/plugins/ie/installer/wix/libiconv2.dll
 /trunk/plugins/ie/installer/wix/libintl3.dll
 /trunk/plugins/ie/installer/wix/light.exe
 /trunk/plugins/ie/installer/wix/light.exe.config
 /trunk/plugins/ie/installer/wix/mspatchc.dll
 /trunk/plugins/ie/installer/wix/regex2.dll
 /trunk/plugins/ie/installer/wix/sed.exe
 /trunk/plugins/ie/installer/wix/wconsole.dll
 /trunk/plugins/ie/installer/wix/winterop.dll
 /trunk/plugins/ie/installer/wix/wix.dll
 /trunk/plugins/ie/prebuilt/Win32
 /trunk/plugins/ie/prebuilt/Win32/oophm.dll
 /trunk/plugins/ie/prebuilt/gwt-dev-plugin-x64.msi
 /trunk/plugins/ie/prebuilt/gwt-dev-plugin-x86.msi
 /trunk/plugins/ie/prebuilt/x64
 /trunk/plugins/ie/prebuilt/x64/oophm.dll
Deleted:
 /trunk/plugins/ie/build.xml
 /trunk/plugins/ie/installer/build.xml
 /trunk/plugins/ie/prebuilt/oophm.dll
 /trunk/plugins/ie/prebuilt/oophm64.dll
Modified:
 /trunk/plugins/ie/installer/README.txt
 /trunk/plugins/ie/installer/installer.wxs.xml
 /trunk/plugins/ie/oophm/oophm/dllmain.cpp
 /trunk/plugins/ie/oophm/oophm/oophm.vcproj
 /trunk/plugins/ie/oophm/oophm/plugin.htm
 /trunk/plugins/ie/oophm/oophm.sln

===
--- /dev/null
+++ /trunk/plugins/ie/README.txtThu Dec  2 07:41:14 2010
@@ -0,0 +1,17 @@
+GWT devmode plugin for IE
+~
+
+To build the plugin, you will need a windows system with Visual Studio  
2008 or newer (WSDK 7.0+)

+
+To build:
+1) make sure devenv.exe is in the path
+2) make sure the binaries under  
$(projectroot)\third_party\java_src\gwt\svn\trunk\plugins\ie\prebuilt are  
writable.
+3) open a cmd.exe window, go to  
$(projectroot)\third_party\java_src\gwt\svn\trunk\plugins\ie

+4) run build.cmd
+
+To create msi installer:
+1) go to folder  
$(projectroot)\third_party\java_src\gwt\svn\trunk\plugins\ie\installer
+2) make sure the msi installers under  
$(projectroot)\third_party\java_src\gwt\svn\trunk\plugins\ie\prebuilt are  
writable.

+3) run build.cmd
+
+
===
--- /dev/null
+++ /trunk/plugins/ie/build.cmd Thu Dec  2 07:41:14 2010
@@ -0,0 +1,18 @@
+...@echo off
+setlocal
+echo.
+::check if correct folder
+::check if devenv is in the path
+echo.
+echo building 32 bits
+echo 
+::pushd oophm\oophm
+devenv /rebuild "Release|Win32" %~dp0\oophm\oophm\oophm.vcproj /out  
build_win32.log

+echo.
+echo building 64 bits
+echo 
+devenv /rebuild "Release|x64" %~dp0\oophm\oophm\oophm.vcproj /out  
build_win64.log

+echo.
+echo Done.
+echo.
+endlocal
===
--- /dev/null
+++ /trunk/plugins/ie/installer/build.cmd   Thu Dec  2 07:41:14 2010
@@ -0,0 +1,79 @@
+...@echo off
+setlocal
+if .%1==. goto :usage
+echo.
+echo.
+
+echo Checking if output files are writeable...
+SET WRITEABLE_FILE_ERROR=0
+CALL :CheckWritable "%~dp0..\prebuilt\gwt-dev-plugin-x86.msi"
+CALL :CheckWritable "%~dp0..\prebuilt\gwt-dev-plugin-x64.msi"
+CALL :CheckWritable "%~dp0oophm.wxs"
+IF "%WRITEABLE_FILE_ERROR%"=="1" GOTO :DONE
+
+SET BINARY_DIR=%~dp0..\prebuilt\Win32
+SET BINARY_FILE=oophm.dll
+
+IF NOT EXIST %BINARY_DIR%\%BINARY_FILE% (
+echo.
+   echo ERROR - Could not find oophm binary under %BINARY_DIR%
+	echo Verify that the build succeeded before trying to create the  
installer.

+   echo.
+   goto :eof
+)
+
+echo.
+echo 'heating' binary %BINARY_FILE% under %BINARY_DIR% ...
+echo ~
+%~dp0wix\heat.exe file %BINARY_DIR%\%BINARY_FILE% -v -nologo -gg -g1 -dr  
INSTALLDIR -generate components -directoryid ff -cg oophmDll  
-out %~dp0oophm.wxs -var var.binDir
+%~dp0wix\sed.exe  
--in-place=xml "s/Source=\"\$(var\.binDir)\\Win32\\oophm.dll\"/Source=\"\$(var\.binDir)\\oophm.dll\"/g" %~dp0oophm.wxs
+%~dp0wix\sed.exe --in-place=xml "s/Directory  
Id=\"dir315E0C50682DFB472927FE1254A22F6A\" Name=\"Win32\"/Directory  
Id=\"dir315E0C50682DFB472927FE1254A22F6A\"  
Name=\"$(var.platform)\"/g" %~dp0oophm.wxs
+%~dp0w

[gwt-contrib] fixup UiField(provided) javadoc (issue1179801)

[conroy]

Reviewers: rjrjr,

Description:
fixup UiField(provided) javadoc


Please review this at http://gwt-code-reviews.appspot.com/1179801/show

Affected files:
  M user/src/com/google/gwt/uibinder/client/UiField.java


Index: user/src/com/google/gwt/uibinder/client/UiField.java
===
--- user/src/com/google/gwt/uibinder/client/UiField.java(revision 9312)
+++ user/src/com/google/gwt/uibinder/client/UiField.java(working copy)
@@ -23,12 +23,16 @@

 /**
  * Marks fields in a UiBinder client that must be filled by the binder's
- * {...@link UiBinder#createAndBindUi} method. If provided is true the field
- * creation is delegated to the client (owner).
+ * {...@link UiBinder#createAndBindUi} method.
  */
 @Documented
 @Retention(RetentionPolicy.RUNTIME)
 @Target(ElementType.FIELD)
 public @interface UiField {
+  /**
+   * If provided is true then field creation is delegated to the client:  
the

+   * client is responsible for filling that field before
+   * {...@link UiBinder#createAndBindUi}.
+   */
   boolean provided() default false;
 }


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Modify EmulateJsStack.gwt.xml and CoreWithUserAgent.gwt.xml to test whether the new 'compiler.st... (issue1174801)

[fredsa]

Committed in r9344

http://gwt-code-reviews.appspot.com/1174801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r9344 committed - Modify EmulateJsStack.gwt.xml and CoreWithUserAgent.gwt.xml to test wh...

[codesite-noreply]

Revision: 9344
Author: fre...@google.com
Date: Thu Dec  2 06:52:10 2010
Log: Modify EmulateJsStack.gwt.xml and CoreWithUserAgent.gwt.xml to test  
whether the new 'compiler.stackMode'
configuration property is set to 'emulated', rather than testing the legacy  
boolean configuration property
'compiler.emulatedStack'. This will allow developers to specify either  
syntax reliably and allow us to potentially

phase out the legacy syntax at some point:


or



Fixes issues: 5692

Review at http://gwt-code-reviews.appspot.com/1174801

Review by: robertvaw...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9344

Modified:
 /trunk/user/src/com/google/gwt/core/CoreWithUserAgent.gwt.xml
 /trunk/user/src/com/google/gwt/core/EmulateJsStack.gwt.xml

===
--- /trunk/user/src/com/google/gwt/core/CoreWithUserAgent.gwt.xml	Thu Nov  
11 05:24:51 2010
+++ /trunk/user/src/com/google/gwt/core/CoreWithUserAgent.gwt.xml	Thu Dec   
2 06:52:10 2010

@@ -18,23 +18,21 @@

   class="com.google.gwt.core.client.impl.StackTraceCreator.CollectorChrome">
 class="com.google.gwt.core.client.impl.StackTraceCreator.Collector" />

-
-
-  
-  
-
+
+
+
   

   class="com.google.gwt.core.client.impl.StackTraceCreator.CollectorMoz">
 class="com.google.gwt.core.client.impl.StackTraceCreator.Collector" />

-
+
 
   

   class="com.google.gwt.core.client.impl.StackTraceCreator.CollectorOpera">
 class="com.google.gwt.core.client.impl.StackTraceCreator.Collector" />

-
+
 
   
 
===
--- /trunk/user/src/com/google/gwt/core/EmulateJsStack.gwt.xml	Tue Feb 16  
07:17:47 2010
+++ /trunk/user/src/com/google/gwt/core/EmulateJsStack.gwt.xml	Thu Dec  2  
06:52:10 2010

@@ -17,6 +17,7 @@
 
   

+  
   

   
   
@@ -29,16 +30,16 @@
   name="compiler.emulatedStack.recordFileNames"

 is-multi-valued="false" />

-  - 
class="com.google.gwt.core.client.impl.StackTraceCreator.CollectorEmulated">
-class="com.google.gwt.core.client.impl.StackTraceCreator.Collector" />

-
-  
-
   
   values="strip,native,emulated" />

   
   
 
   
+
+  + 
class="com.google.gwt.core.client.impl.StackTraceCreator.CollectorEmulated">
+class="com.google.gwt.core.client.impl.StackTraceCreator.Collector" />

+
+  
 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r9343 committed - Public: Add a custom report format....

[codesite-noreply]

Revision: 9343
Author: ncha...@google.com
Date: Thu Dec  2 06:41:07 2010
Log: Public: Add a custom report format.

[JSR 303 TCK Result] 4 Pass 6 Fail 32 Error from a total of 259 tests for a  
success rate of 1.54%.


Review at http://gwt-code-reviews.appspot.com/1169801

Review by: rchan...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9343

Added:
 /trunk/samples/validationtck/style
 /trunk/samples/validationtck/style/html
 /trunk/samples/validationtck/style/html/junit-noframes.xsl
 /trunk/samples/validationtck/style/text
 /trunk/samples/validationtck/style/text/junit-noframes.xsl
Modified:
 /trunk/samples/validationtck/build.xml

===
--- /dev/null
+++ /trunk/samples/validationtck/style/html/junit-noframes.xsl	Thu Dec  2  
06:41:07 2010

@@ -0,0 +1,492 @@
+
+http://www.w3.org/1999/XSL/Transform";  
version="1.0"

+xmlns:lxslt="http://xml.apache.org/xslt";
+xmlns:stringutils="xalan://org.apache.tools.ant.util.StringUtils">
+
+
+
+
+JSR-303 TCK report
+
+
+
+
+
+
+
+  body {
+font:normal 68% verdana,arial,helvetica;
+color:#00;
+  }
+  table tr td, table tr th {
+  font-size: 68%;
+  }
+  table.details tr th{
+font-weight: bold;
+text-align:left;
+background:#a6caf0;
+  }
+  table.details tr td{
+background:#e0;
+  }
+
+  p {
+line-height:1.5em;
+margin-top:0.5em; margin-bottom:1.0em;
+  }
+  h1 {
+margin: 0px 0px 5px; font: 165% verdana,arial,helvetica
+  }
+  h2 {