[gwt-contrib] Have separate devmode.js files for each permutation if we are outputting (issue1208802)
Reviewers: conroy, Description: Have separate devmode.js files for each permutation if we are outputting bootstrap in the primary fragment so we can put the properties info in them and avoid putting it in the primary fragment. Also, fail explicitly when we encounter a script tag in the gwt.xml rather than failing silently (xsiframe linker does not support this feature) Please review this at http://gwt-code-reviews.appspot.com/1208802/show Affected files: M dev/core/src/com/google/gwt/core/ext/linker/impl/PropertiesUtil.java M dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionScriptLinker.java M dev/core/src/com/google/gwt/core/ext/linker/impl/propertiesNull.js M dev/core/src/com/google/gwt/core/linker/CrossSiteIframeLinker.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Reduces class and JSNI loading for RPC in devmode. (issue1215801)
Reviewers: zundel, scottb, Description: Reduces class and JSNI loading for RPC in devmode. - Makes GwtScriptOnly work with JSNI methods. - Modifies the RPC generator to tag native methods with GwtScriptOnly. - Modifies the RPC generator to defer class loads of FieldSerializers until needed. Please review this at http://gwt-code-reviews.appspot.com/1215801/show Affected files: M dev/core/src/com/google/gwt/dev/javac/JsniCollector.java M dev/core/src/com/google/gwt/dev/javac/JsniMethod.java M dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java M dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java M dev/core/src/com/google/gwt/dev/shell/ModuleSpaceOOPHM.java M dev/core/src/com/google/gwt/dev/util/log/speedtracer/CompilerEventType.java M dev/core/src/com/google/gwt/dev/util/log/speedtracer/DevModeEventType.java M dev/core/super/com/google/gwt/core/client/GwtScriptOnly.java M tools/api-checker/config/gwt21_22userApi.conf M user/src/com/google/gwt/user/client/rpc/core/java/util/Arrays.java M user/src/com/google/gwt/user/client/rpc/core/java/util/Collections.java A user/src/com/google/gwt/user/client/rpc/impl/ReflectionHelper.java M user/src/com/google/gwt/user/client/rpc/impl/SerializerBase.java M user/src/com/google/gwt/user/rebind/rpc/CustomFieldSerializerValidator.java M user/src/com/google/gwt/user/rebind/rpc/FieldSerializerCreator.java M user/src/com/google/gwt/user/rebind/rpc/ProxyCreator.java M user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java A user/super/com/google/gwt/user/translatable/com/google/gwt/user/client/rpc/impl/ReflectionHelper.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9413 committed - CellWidget should only fire a ValueChangeEvent when the new value is n...
Revision: 9413
Author: jlaba...@google.com
Date: Mon Dec 13 11:55:24 2010
Log: CellWidget should only fire a ValueChangeEvent when the new value is
not equal to the previous one. The redraw logic should do the same. If you
really want to redraw the widget unconditionally, call setValue(a, b,
false) and then redraw()).
Code Review at http://gwt-code-reviews.appspot.com/1155801/show
Author: tbroyer
Review by: sbruba...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9413
Modified:
/trunk/user/src/com/google/gwt/user/cellview/client/CellWidget.java
/trunk/user/test/com/google/gwt/user/cellview/client/CellWidgetTest.java
===
--- /trunk/user/src/com/google/gwt/user/cellview/client/CellWidget.java Wed
Dec 1 05:40:20 2010
+++ /trunk/user/src/com/google/gwt/user/cellview/client/CellWidget.java Mon
Dec 13 11:55:24 2010
@@ -183,7 +183,8 @@
/**
* {...@inheritdoc}
*
- * This method will redraw the widget using the new value.
+ * This method will redraw the widget if the new value does not equal the
+ * existing value.
*
*/
public void setValue(C value) {
@@ -193,7 +194,8 @@
/**
* {...@inheritdoc}
*
- * This method will redraw the widget using the new value.
+ * This method will redraw the widget if the new value does not equal the
+ * existing value.
*
*/
public void setValue(C value, boolean fireEvents) {
@@ -204,18 +206,23 @@
* Sets this object's value and optionally redraw the widget. Fires
* {...@link com.google.gwt.event.logical.shared.ValueChangeEvent} when
* fireEvents is true and the new value does not equal the existing
value.
+ * Redraws the widget when redraw is true and the new value does not
equal the
+ * existing value.
*
* @param value the object's new value
* @param fireEvents fire events if true and value is new
- * @param redraw true to redraw the widget, false not to
+ * @param redraw redraw the widget if true and value is new
*/
public void setValue(C value, boolean fireEvents, boolean redraw) {
-this.value = value;
-if (redraw) {
- redraw();
-}
-if (fireEvents) {
- ValueChangeEvent.fire(this, value);
+C oldValue = getValue();
+if (value != oldValue && (oldValue == null |
| !oldValue.equals(value))) {
+ this.value = value;
+ if (redraw) {
+redraw();
+ }
+ if (fireEvents) {
+ValueChangeEvent.fire(this, value);
+ }
}
}
===
---
/trunk/user/test/com/google/gwt/user/cellview/client/CellWidgetTest.java
Wed Dec 1 05:40:20 2010
+++
/trunk/user/test/com/google/gwt/user/cellview/client/CellWidgetTest.java
Mon Dec 13 11:55:24 2010
@@ -181,6 +181,10 @@
assertEquals("test0", cw.getElement().getInnerText());
handler.assertOnValueChangeNotCalled();
+// Set value to the existing value, shouldn't fire events.
+cw.setValue("test0", true);
+handler.assertOnValueChangeNotCalled();
+
// Set value and fire events.
cw.setValue("test1", true);
assertEquals("test1", cw.getValue());
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9412 committed - Fixes rebased guava library without using JarJar...
Revision: 9412
Author: rchan...@google.com
Date: Mon Dec 13 11:39:22 2010
Log: Fixes rebased guava library without using JarJar
Fixes Issue
http://code.google.com/p/google-web-toolkit/issues/detail?id=5708
Review at http://gwt-code-reviews.appspot.com/1213801
Review by: r...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9412
Modified:
/trunk/dev/build.xml
===
--- /trunk/dev/build.xmlSat Oct 23 05:32:15 2010
+++ /trunk/dev/build.xmlMon Dec 13 11:39:22 2010
@@ -58,7 +58,7 @@
-
+
name="protobuf/protobuf-2.2.0/protobuf-java-rebased-2.2.0.jar" />
@@ -109,7 +109,7 @@
-
+
@@ -121,7 +121,7 @@
src="${gwt.tools.lib}/apache/tapestry-util-text-4.0.2.jar" />
- src="${gwt.tools.lib}/guava/guava-r06/guava-r06-rebased.jar" />
+ src="${gwt.tools.lib}/guava/guava-r06/guava-r06-rebased-2.jar" />
src="${gwt.tools.lib}/protobuf/protobuf-2.2.0/protobuf-java-rebased-2.2.0.jar"
/>
@@ -172,7 +172,7 @@
src="${gwt.tools.lib}/sun/swingworker/swing-worker-1.1.jar" />
- src="${gwt.tools.lib}/guava/guava-r06/guava-r06-rebased.jar" />
+ src="${gwt.tools.lib}/guava/guava-r06/guava-r06-rebased-2.jar" />
@@ -214,7 +214,7 @@
location="${gwt.tools.lib}/tomcat/commons-collections-3.1.jar" />
- location="${gwt.tools.lib}/guava/guava-r06/guava-r06-rebased.jar" />
+ location="${gwt.tools.lib}/guava/guava-r06/guava-r06-rebased-2.jar" />
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9411 committed - Change the first day of the week from Monday to Sunday for Brazil...
Revision: 9411
Author: j...@google.com
Date: Mon Dec 13 09:02:12 2010
Log: Change the first day of the week from Monday to Sunday for Brazil
(and all of Portuguese except for Portugal, since Brazil's behavior
should be the default for Portuguese in an unknown country).
Issue: 5243
Patch by: jat
Review by: pdr
http://code.google.com/p/google-web-toolkit/source/detail?r=9411
Modified:
/trunk/user/src/com/google/gwt/i18n/client/constants/DateTimeConstantsImpl_pt.properties
/trunk/user/src/com/google/gwt/i18n/client/impl/cldr/DateTimeFormatInfoImpl_pt.java
/trunk/user/src/com/google/gwt/i18n/client/impl/cldr/DateTimeFormatInfoImpl_pt_PT.java
===
---
/trunk/user/src/com/google/gwt/i18n/client/constants/DateTimeConstantsImpl_pt.properties
Fri Feb 26 11:54:15 2010
+++
/trunk/user/src/com/google/gwt/i18n/client/constants/DateTimeConstantsImpl_pt.properties
Mon Dec 13 09:02:12 2010
@@ -26,5 +26,5 @@
ampms = AM, PM
dateFormats = \\, d 'de' 'de' y, d 'de' 'de' y, dd/MM/,
dd/MM/yy
timeFormats = HH'h'mm'min'ss's' , HH'h'mm'min'ss's' z, HH:mm:ss, HH:mm
-firstDayOfTheWeek = 2
+firstDayOfTheWeek = 1
weekendRange = 7, 1
===
---
/trunk/user/src/com/google/gwt/i18n/client/impl/cldr/DateTimeFormatInfoImpl_pt.java
Mon Sep 27 06:25:06 2010
+++
/trunk/user/src/com/google/gwt/i18n/client/impl/cldr/DateTimeFormatInfoImpl_pt.java
Mon Dec 13 09:02:12 2010
@@ -57,6 +57,11 @@
"d.C."
};
}
+
+ @Override
+ public int firstDayOfTheWeek() {
+return 0;
+ }
@Override
public String formatMinuteSecond() {
===
---
/trunk/user/src/com/google/gwt/i18n/client/impl/cldr/DateTimeFormatInfoImpl_pt_PT.java
Wed Sep 29 08:04:55 2010
+++
/trunk/user/src/com/google/gwt/i18n/client/impl/cldr/DateTimeFormatInfoImpl_pt_PT.java
Mon Dec 13 09:02:12 2010
@@ -34,6 +34,11 @@
public String dateFormatMedium() {
return "d 'de' MMM 'de' ";
}
+
+ @Override
+ public int firstDayOfTheWeek() {
+return 1;
+ }
@Override
public String formatHour12Minute() {
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9410 committed - Merge fix for issue 5243 to 2.1 release branch.
Revision: 9410
Author: j...@google.com
Date: Mon Dec 13 09:23:00 2010
Log: Merge fix for issue 5243 to 2.1 release branch.
http://code.google.com/p/google-web-toolkit/source/detail?r=9410
Modified:
/releases/2.1/user/src/com/google/gwt/i18n/client/constants/DateTimeConstantsImpl_pt.properties
/releases/2.1/user/src/com/google/gwt/i18n/client/impl/cldr/DateTimeFormatInfoImpl_pt.java
/releases/2.1/user/src/com/google/gwt/i18n/client/impl/cldr/DateTimeFormatInfoImpl_pt_PT.java
===
---
/releases/2.1/user/src/com/google/gwt/i18n/client/constants/DateTimeConstantsImpl_pt.properties
Fri Feb 26 11:54:15 2010
+++
/releases/2.1/user/src/com/google/gwt/i18n/client/constants/DateTimeConstantsImpl_pt.properties
Mon Dec 13 09:23:00 2010
@@ -26,5 +26,5 @@
ampms = AM, PM
dateFormats = \\, d 'de' 'de' y, d 'de' 'de' y, dd/MM/,
dd/MM/yy
timeFormats = HH'h'mm'min'ss's' , HH'h'mm'min'ss's' z, HH:mm:ss, HH:mm
-firstDayOfTheWeek = 2
+firstDayOfTheWeek = 1
weekendRange = 7, 1
===
---
/releases/2.1/user/src/com/google/gwt/i18n/client/impl/cldr/DateTimeFormatInfoImpl_pt.java
Mon Sep 27 06:25:06 2010
+++
/releases/2.1/user/src/com/google/gwt/i18n/client/impl/cldr/DateTimeFormatInfoImpl_pt.java
Mon Dec 13 09:23:00 2010
@@ -57,6 +57,11 @@
"d.C."
};
}
+
+ @Override
+ public int firstDayOfTheWeek() {
+return 0;
+ }
@Override
public String formatMinuteSecond() {
===
---
/releases/2.1/user/src/com/google/gwt/i18n/client/impl/cldr/DateTimeFormatInfoImpl_pt_PT.java
Wed Sep 29 08:04:55 2010
+++
/releases/2.1/user/src/com/google/gwt/i18n/client/impl/cldr/DateTimeFormatInfoImpl_pt_PT.java
Mon Dec 13 09:23:00 2010
@@ -34,6 +34,11 @@
public String dateFormatMedium() {
return "d 'de' MMM 'de' ";
}
+
+ @Override
+ public int firstDayOfTheWeek() {
+return 1;
+ }
@Override
public String formatHour12Minute() {
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Make ExternalTextResource use Jsonp (issue1214801)
Mostly LGTM
http://gwt-code-reviews.appspot.com/1214801/diff/1/2
File user/src/com/google/gwt/jsonp/client/JsonpRequest.java (right):
http://gwt-code-reviews.appspot.com/1214801/diff/1/2#newcode33
user/src/com/google/gwt/jsonp/client/JsonpRequest.java:33:
Added whitespace.
http://gwt-code-reviews.appspot.com/1214801/diff/1/2#newcode78
user/src/com/google/gwt/jsonp/client/JsonpRequest.java:78:
Whitespace.
http://gwt-code-reviews.appspot.com/1214801/diff/1/2#newcode129
user/src/com/google/gwt/jsonp/client/JsonpRequest.java:129: * Create a
new JSONP request.
Shouldn't this distinguish from the above constructor, explaining why
this would be used?
http://gwt-code-reviews.appspot.com/1214801/diff/1/2#newcode142
user/src/com/google/gwt/jsonp/client/JsonpRequest.java:142: String
callbackParam, String failureCallbackParam, String id) {
Need javadoc for id.
http://gwt-code-reviews.appspot.com/1214801/diff/1/3
File user/src/com/google/gwt/jsonp/client/JsonpRequestBuilder.java
(right):
http://gwt-code-reviews.appspot.com/1214801/diff/1/3#newcode203
user/src/com/google/gwt/jsonp/client/JsonpRequestBuilder.java:203:
failureCallbackParam, predeterminedId);
Would it be cleaner to just pass predeterminedId to the constructor, and
have existing behavior if it is null? That would also remove
duplication in the constructors.
http://gwt-code-reviews.appspot.com/1214801/diff/1/6
File
user/src/com/google/gwt/resources/rg/ExternalTextResourceGenerator.java
(right):
http://gwt-code-reviews.appspot.com/1214801/diff/1/6#newcode67
user/src/com/google/gwt/resources/rg/ExternalTextResourceGenerator.java:67:
Whitespace.
http://gwt-code-reviews.appspot.com/1214801/diff/1/6#newcode91
user/src/com/google/gwt/resources/rg/ExternalTextResourceGenerator.java:91:
Whitespace.
http://gwt-code-reviews.appspot.com/1214801/diff/1/6#newcode154
user/src/com/google/gwt/resources/rg/ExternalTextResourceGenerator.java:154:
Whitespace.
Something must be set wrong in your IDE to generate all these where they
didn't exist previously.
http://gwt-code-reviews.appspot.com/1214801/diff/1/8
File
user/test/com/google/gwt/resources/ExternalTextResourceJsonp.gwt.xml
(right):
http://gwt-code-reviews.appspot.com/1214801/diff/1/8#newcode16
user/test/com/google/gwt/resources/ExternalTextResourceJsonp.gwt.xml:16:
80 columns
http://gwt-code-reviews.appspot.com/1214801/diff/1/11
File
user/test/com/google/gwt/resources/client/ExternalTextResourceTest.java
(right):
http://gwt-code-reviews.appspot.com/1214801/diff/1/11#newcode26
user/test/com/google/gwt/resources/client/ExternalTextResourceTest.java:26:
static interface Resources extends ClientBundleWithLookup {
Why package protected?
http://gwt-code-reviews.appspot.com/1214801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9408 committed - Cherry picking r9403 into release branch.
Revision: 9408
Author: gwt.mirror...@gmail.com
Date: Mon Dec 13 13:39:16 2010
Log: Cherry picking r9403 into release branch.
http://code.google.com/p/google-web-toolkit/source/detail?r=9408
Modified:
/releases/2.1/samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/ShowMorePagerPanel.java
/releases/2.1/user/src/com/google/gwt/user/cellview/client/HasDataPresenter.java
/releases/2.1/user/test/com/google/gwt/user/cellview/client/AbstractCellTreeTestBase.java
/releases/2.1/user/test/com/google/gwt/user/cellview/client/CellBrowserTest.java
/releases/2.1/user/test/com/google/gwt/user/cellview/client/HasDataPresenterTest.java
===
---
/releases/2.1/samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/ShowMorePagerPanel.java
Tue Aug 17 10:14:36 2010
+++
/releases/2.1/samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/ShowMorePagerPanel.java
Mon Dec 13 13:39:16 2010
@@ -54,6 +54,9 @@
public ShowMorePagerPanel() {
initWidget(scrollable);
+// Do not let the scrollable take tab focus.
+scrollable.getElement().setTabIndex(-1);
+
// Handle scroll events.
scrollable.addScrollHandler(new ScrollHandler() {
public void onScroll(ScrollEvent event) {
===
---
/releases/2.1/user/src/com/google/gwt/user/cellview/client/HasDataPresenter.java
Wed Nov 24 05:29:07 2010
+++
/releases/2.1/user/src/com/google/gwt/user/cellview/client/HasDataPresenter.java
Mon Dec 13 13:39:16 2010
@@ -181,6 +181,8 @@
boolean rowCountIsExact = false;
final List rowData = new ArrayList();
final Set selectedRows = new HashSet();
+T selectedValue = null;
+boolean viewTouched;
public DefaultState(int pageSize) {
this.pageSize = pageSize;
@@ -217,6 +219,10 @@
public List getRowDataValues() {
return Collections.unmodifiableList(rowData);
}
+
+public T getSelectedValue() {
+ return selectedValue;
+}
public boolean isRowCountExact() {
return rowCountIsExact;
@@ -233,6 +239,10 @@
public boolean isRowSelected(int index) {
return selectedRows.contains(index);
}
+
+public boolean isViewTouched() {
+ return viewTouched;
+}
}
/**
@@ -271,6 +281,8 @@
this.pageStart = state.getPageStart();
this.rowCount = state.getRowCount();
this.rowCountIsExact = state.isRowCountExact();
+ this.selectedValue = state.getSelectedValue();
+ this.viewTouched = state.isViewTouched();
// Copy the row data.
int rowDataSize = state.getRowDataSize();
@@ -342,6 +354,11 @@
*/
List getRowDataValues();
+/**
+ * Get the value that is selected in the {...@link SelectionModel}.
+ */
+T getSelectedValue();
+
/**
* Get a boolean indicating whether the row count is exact or an
estimate.
*/
@@ -354,6 +371,13 @@
* @return true if selected, false if not
*/
boolean isRowSelected(int index);
+
+/**
+ * Check if the user interacted with the view at some point. Selection
is
+ * not bound to the keyboard selected row until the view is touched.
Once
+ * touched, selection is bound from then on.
+ */
+boolean isViewTouched();
}
/**
@@ -727,10 +751,13 @@
if (KeyboardSelectionPolicy.DISABLED == keyboardSelectionPolicy) {
return;
}
+
+// The user touched the view.
+ensurePendingState().viewTouched = true;
/*
* Early exit if the keyboard selected row has not changed and the
keyboard
- * selected value is already set.
+ * selected value is already set.
*/
if (!forceUpdate && getKeyboardSelectedRow() == index
&& getKeyboardSelectedRowValue() != null) {
@@ -1162,24 +1189,38 @@
/*
* Update the SelectionModel based on the keyboard selected value.
This must
- * happen before we read the selection state.
+ * happen before we read the selection state. We only bind to selection
+ * after the user has interacted with the widget at least once. This
+ * prevents values from being selected by default.
*/
if (KeyboardSelectionPolicy.BOUND_TO_SELECTION ==
keyboardSelectionPolicy
-&& selectionModel != null) {
- T oldValue = oldState.getRowDataSize() > 0
- ? oldState.getRowDataValue(oldState.getKeyboardSelectedRow()) :
null;
+&& selectionModel != null && pending.viewTouched) {
+ T oldValue = oldState.getSelectedValue();
Object oldKey = getRowValueKey(oldValue);
T newValue = rowDataCount > 0
? pending.getRowDataValue(pending.getKeyboardSelectedRow()) :
null;
Object newKey = getRowValueKey(newValue);
- if ((oldKey == null) ? newKey != null : !oldKey.equals(newKey)) {
+ /*
+ * Do not deselect the old value unless we have a new value to
select, or
+ * we will have a null se
[gwt-contrib] Re: Issue 5671: CellWidget breaks HasValue contract: fires ValueChangeEvent even if value doesn't change (issue1155801)
LGTM Thanks for the patch. Sorry for the long delay. http://gwt-code-reviews.appspot.com/1155801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Make ExternalTextResource use Jsonp (issue1214801)
Reviewers: robertvawter, Description: Make ExternalTextResource use Jsonp Review by: robertvaw...@google.com Please review this at http://gwt-code-reviews.appspot.com/1214801/show Affected files: M user/src/com/google/gwt/jsonp/client/JsonpRequest.java M user/src/com/google/gwt/jsonp/client/JsonpRequestBuilder.java M user/src/com/google/gwt/resources/Resources.gwt.xml M user/src/com/google/gwt/resources/client/impl/ExternalTextResourcePrototype.java M user/src/com/google/gwt/resources/rg/ExternalTextResourceGenerator.java M user/test/com/google/gwt/jsonp/client/JsonpRequestTest.java A user/test/com/google/gwt/resources/ExternalTextResourceJsonp.gwt.xml M user/test/com/google/gwt/resources/ResourcesSuite.java A user/test/com/google/gwt/resources/client/ExternalTextResourceJsonpTest.java A user/test/com/google/gwt/resources/client/ExternalTextResourceTest.java M user/test/com/google/gwt/resources/client/TextResourceTest.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fixes rebased guava library without using JarJar (issue1213801)
LGTM http://gwt-code-reviews.appspot.com/1213801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Comment on TroubleshootingOOPHM in google-web-toolkit
Comment by rogovskiy: Chrome plugin is not working. Unable to connect to 9997 works in FF and Safari (sorta works) For more information: http://code.google.com/p/google-web-toolkit/wiki/TroubleshootingOOPHM -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Fixes rebased guava library without using JarJar (issue1213801)
Reviewers: rice,
Description:
Fixes rebased guava library without using JarJar
Fixes Issue
http://code.google.com/p/google-web-toolkit/issues/detail?id=5708
Review by: r...@google.com
Please review this at http://gwt-code-reviews.appspot.com/1213801/show
Affected files:
M dev/build.xml
Index: dev/build.xml
===
--- dev/build.xml (revision 9407)
+++ dev/build.xml (working copy)
@@ -58,7 +58,7 @@
-
+
name="protobuf/protobuf-2.2.0/protobuf-java-rebased-2.2.0.jar" />
@@ -109,7 +109,7 @@
-
+
@@ -121,7 +121,7 @@
src="${gwt.tools.lib}/apache/tapestry-util-text-4.0.2.jar" />
- src="${gwt.tools.lib}/guava/guava-r06/guava-r06-rebased.jar" />
+ src="${gwt.tools.lib}/guava/guava-r06/guava-r06-rebased-2.jar" />
src="${gwt.tools.lib}/protobuf/protobuf-2.2.0/protobuf-java-rebased-2.2.0.jar"
/>
@@ -172,7 +172,7 @@
src="${gwt.tools.lib}/sun/swingworker/swing-worker-1.1.jar" />
- src="${gwt.tools.lib}/guava/guava-r06/guava-r06-rebased.jar" />
+ src="${gwt.tools.lib}/guava/guava-r06/guava-r06-rebased-2.jar" />
@@ -214,7 +214,7 @@
location="${gwt.tools.lib}/tomcat/commons-collections-3.1.jar" />
- location="${gwt.tools.lib}/guava/guava-r06/guava-r06-rebased.jar" />
+ location="${gwt.tools.lib}/guava/guava-r06/guava-r06-rebased-2.jar" />
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Restore previously rolled-back doc build changes (issue970801)
On 2010/10/08 15:04:53, rice wrote: this is still on my dashboard. did this ever go in? should this review be closed? http://gwt-code-reviews.appspot.com/970801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Copying the DOMImplIE6 setOpacity implementation into DOMImplIE8 because IE8 does not support th... (issue1211801)
http://gwt-code-reviews.appspot.com/1211801/diff/3001/4001 File user/src/com/google/gwt/dom/client/DOMImplIE8.java (right): http://gwt-code-reviews.appspot.com/1211801/diff/3001/4001#newcode39 user/src/com/google/gwt/dom/client/DOMImplIE8.java:39: var ua = navigator.userAgent.toLowerCase(); Since its a static method, somebody could call it from outside the IE8 deferred binding via a native block, at least thats what we do with DOMImplIE6#isIE6. Its only called once and it won't affect code size very much, so I think its better to include it than to risk a JS error. At some point, we should find out how to use soft permutations to give us more fine grain information about the user agents. http://gwt-code-reviews.appspot.com/1211801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Copying the DOMImplIE6 setOpacity implementation into DOMImplIE8 because IE8 does not support th... (issue1211801)
http://gwt-code-reviews.appspot.com/1211801/diff/3001/4001 File user/src/com/google/gwt/dom/client/DOMImplIE8.java (right): http://gwt-code-reviews.appspot.com/1211801/diff/3001/4001#newcode39 user/src/com/google/gwt/dom/client/DOMImplIE8.java:39: var ua = navigator.userAgent.toLowerCase(); Is this really needed? Aren't we already assured to be in MSIE? (and therefore only need to check $doc.documentMode) http://gwt-code-reviews.appspot.com/1211801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Copying the DOMImplIE6 setOpacity implementation into DOMImplIE8 because IE8 does not support th... (issue1211801)
http://gwt-code-reviews.appspot.com/1211801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Comment on RequestFactory_2_1_1 in google-web-toolkit
Comment by rj...@google.com: @dominik.mayer, thanks for the report: http://code.google.com/p/google-web-toolkit/issues/detail?id=5755 For more information: http://code.google.com/p/google-web-toolkit/wiki/RequestFactory_2_1_1 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Removing call to RootLayoutPanel#get() in SplitLayoutPanel so that it does not force the creatio... (issue1210801)
committed as r9406 http://gwt-code-reviews.appspot.com/1210801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
