Re: [gwt-contrib] Future of CellTable
Thanks for the info! I guess I'll wait until 2.3 and will start to port the TreeTable + filter stuff. Is there a way to contribute patches since the incubator is deprecated? -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Issue 6040: Editor framework does not support is / has methods (issue1359804)
http://gwt-code-reviews.appspot.com/1359804/diff/1/3 File user/src/com/google/gwt/editor/rebind/model/EditorModel.java (right): http://gwt-code-reviews.appspot.com/1359804/diff/1/3#newcode504 user/src/com/google/gwt/editor/rebind/model/EditorModel.java:504: String getterName = camelCase(get, parts[i]); Use JBeanMethod from the autobean rebind package instead. Build up something like a memoized MapClass, MapString, JMethod for any method matched by JBeanMethod.GET (which understands is/has), using the inferName() method to extract the property name. There's also an associated BeanMethod in autobean.server.impl that has the same setup, if you ever need to do something similar with reflection-based code. http://gwt-code-reviews.appspot.com/1359804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Changes the distributed eclipse .launch files to use DevMode instead of HostedMode. (issue1352808)
Most developers are probably using the Google Plugin for Eclipse, which will create a DevMode launch config. This just transitions the distributed launch configs for folks wanting to run GWT from sources without the plugin. http://gwt-code-reviews.appspot.com/1352808/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Issue 6040: Editor framework does not support is / has methods (issue1359804)
http://gwt-code-reviews.appspot.com/1359804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Changes the distributed eclipse .launch files to use DevMode instead of HostedMode. (issue1352808)
Kudos, Eric. I was hoping if I procrastinated long enough on this, someone else would eventually do it. :D http://gwt-code-reviews.appspot.com/1352808/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] user.agent proposal. (issue1354806)
Reviewers: bobv, rjrjr,
Description:
user.agent proposal.
Please review this at http://gwt-code-reviews.appspot.com/1354806/show
Affected files:
M user/src/com/google/gwt/user/UserAgent.gwt.xml
Index: user/src/com/google/gwt/user/UserAgent.gwt.xml
===
--- user/src/com/google/gwt/user/UserAgent.gwt.xml (revision 9744)
+++ user/src/com/google/gwt/user/UserAgent.gwt.xml (working copy)
@@ -19,10 +19,77 @@
module
!-- Browser-sensitive code should use the 'user.agent' property --
- define-property name=user.agent
values=ie6,ie8,gecko1_8,safari,opera/
-
+
+ !--
+ DEPRECATED - prefer new user.agent.{ua}OrLater, where {ua} is a user
+ agent specification name.
+ example: user.agent.IE8OrLater
+ --
+ define-property name=user.agent
values=ie6,ie8,gecko1_8,safari,opera/
+
+ !-- todo: will go away once we agree on this plan - add remaining ua
(safari,ff, opera) --
property-provider name=user.agent
generator=com.google.gwt.user.rebind.UserAgentPropertyGenerator/
+ define-property name=user.agent.IE6OrLater values=true,false/
+ property-provider name=user.agent.IE6OrLater![CDATA[
+function makeVersion(result) {
+ return (parseInt(result[1]) * 1000) + parseInt(result[2]);
+}
+var ua = navigator.userAgent.toLowerCase();
+if (ua.indexOf(msie) != -1) {
+ var result = /msie ([0-9]+)\.([0-9]+)/.exec(ua);
+ if (result result.length == 3) {
+var v = makeVersion(result);
+if (v 7000) {
+ return true;
+}
+ }
+}
+return false;
+ ]]
+ /property-provider
+ set-property name=user.agent value=ie6
+when-property-is name=user.agent.IE6OrLater value=true/
+ /set-property
+
+ define-property name=user.agent.IE7OrLater values=true,false/
+ property-provider name=user.agent.IE7OrLater![CDATA[
+function makeVersion(result) {
+ return (parseInt(result[1]) * 1000) + parseInt(result[2]);
+}
+var ua = navigator.userAgent.toLowerCase();
+if (ua.indexOf(msie) != -1) {
+ var result = /msie ([0-9]+)\.([0-9]+)/.exec(ua);
+ if (result result.length == 3) {
+var v = makeVersion(result);
+if (v 8000) {
+ return true;
+}
+ }
+}
+return false;
+ ]]
+ /property-provider
+ set-property name=user.agent value=ie6
+when-property-is name=user.agent.IE7OrLater value=true/
+ /set-property
+
+ define-property name=user.agent.IE8OrLater values=true,false/
+ property-provider name=user.agent.IE8OrLater![CDATA[
+return ((navigator.userAgent.toLowerCase().indexOf('msie') != -1)
(document.documentMode == 8)).toString();
+ ]]
+ /property-provider
+ set-property name=user.agent value=ie8
+ when-property-is name=user.agent.IE8OrLater value=true/
+ /set-property
+
+ define-property name=user.agent.IE9OrLater values=true,false/
+ property-provider name=user.agent.IE9OrLater![CDATA[
+ return ((navigator.userAgent.toLowerCase().indexOf('msie') != -1)
(document.documentMode == 9)).toString();
+ ]]
+ /property-provider
+
+
!-- Set to false to avoid runtime warnings for mismatched runtime and
--
!-- compile time user.agent values --
define-configuration-property name=user.agent.runtimeWarning
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Updating API checker for GWT 2.3. In CellBasedWidgetImplStandard, I fixed the package declaratio... (issue1356805)
Reviewers: rjrjr, Description: Updating API checker for GWT 2.3. In CellBasedWidgetImplStandard, I fixed the package declaration per an Api Checker warning. Please review this at http://gwt-code-reviews.appspot.com/1356805/show Affected files: M build.xml A tools/api-checker/config/gwt22_23userApi.conf M tools/api-checker/reference/README M user/src/com/google/gwt/user/cellview/client/CellBasedWidgetImplStandard.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Updating API checker for GWT 2.3. In CellBasedWidgetImplStandard, I fixed the package declaratio... (issue1356805)
LGTM http://gwt-code-reviews.appspot.com/1356805/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Future of CellTable
Do you mean patches for CellTable? It's part of GWT, so the usual way: http://code.google.com/webtoolkit/makinggwtbetter.html On Fri, Feb 18, 2011 at 3:30 AM, dflorey daniel.flo...@gmail.com wrote: Thanks for the info! I guess I'll wait until 2.3 and will start to port the TreeTable + filter stuff. Is there a way to contribute patches since the incubator is deprecated? -- http://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9751 committed - Changes the distributed eclipse .launch files to use DevMode instead o...
Revision: 9751
Author: zun...@google.com
Date: Fri Feb 18 08:16:52 2011
Log: Changes the distributed eclipse .launch files to use DevMode instead
of HostedMode.
Review at http://gwt-code-reviews.appspot.com/1352808
http://code.google.com/p/google-web-toolkit/source/detail?r=9751
Modified:
/trunk/eclipse/samples/DynaTable/DynaTable.launch
/trunk/eclipse/samples/DynaTableRf/DynaTableRf.launch
/trunk/eclipse/samples/Hello/Hello.launch
/trunk/eclipse/samples/JSON/JSON.launch
/trunk/eclipse/samples/LogExample/LogExample.launch
/trunk/eclipse/samples/Mail/Mail.launch
/trunk/eclipse/samples/Showcase/Showcase.launch
/trunk/eclipse/samples/SimpleRPC/SimpleRPC.launch
/trunk/eclipse/samples/SimpleXML/SimpleXML.launch
/trunk/eclipse/samples/Validation/Validation.launch
===
--- /trunk/eclipse/samples/DynaTable/DynaTable.launch Fri Jul 23 15:42:40
2010
+++ /trunk/eclipse/samples/DynaTable/DynaTable.launch Fri Feb 18 08:16:52
2011
@@ -10,7 +10,7 @@
listEntry value=lt;?xml version=quot;1.0quot;
encoding=quot;UTF-8quot;?gt;#10;lt;runtimeClasspathEntry
id=quot;org.eclipse.jdt.launching.classpathentry.defaultClasspathquot;gt;#10;lt;memento
exportedEntriesOnly=quot;falsequot;
project=quot;DynaTablequot;/gt;#10;lt;/runtimeClasspathEntrygt;#10;/
/listAttribute
booleanAttribute key=org.eclipse.jdt.launching.DEFAULT_CLASSPATH
value=false/
-stringAttribute key=org.eclipse.jdt.launching.MAIN_TYPE
value=com.google.gwt.dev.HostedMode/
+stringAttribute key=org.eclipse.jdt.launching.MAIN_TYPE
value=com.google.gwt.dev.DevMode/
stringAttribute key=org.eclipse.jdt.launching.PROGRAM_ARGUMENTS
value=-startupUrl
DynaTable.html#13;#10;com.google.gwt.sample.dynatable.DynaTable/
stringAttribute key=org.eclipse.jdt.launching.PROJECT_ATTR
value=DynaTable/
/launchConfiguration
===
--- /trunk/eclipse/samples/DynaTableRf/DynaTableRf.launch Fri Jul 23
15:42:40 2010
+++ /trunk/eclipse/samples/DynaTableRf/DynaTableRf.launch Fri Feb 18
08:16:52 2011
@@ -10,7 +10,7 @@
listEntry value=lt;?xml version=quot;1.0quot;
encoding=quot;UTF-8quot;?gt;#10;lt;runtimeClasspathEntry
id=quot;org.eclipse.jdt.launching.classpathentry.defaultClasspathquot;gt;#10;lt;memento
exportedEntriesOnly=quot;falsequot;
project=quot;DynaTableRfquot;/gt;#10;lt;/runtimeClasspathEntrygt;#10;/
/listAttribute
booleanAttribute key=org.eclipse.jdt.launching.DEFAULT_CLASSPATH
value=false/
-stringAttribute key=org.eclipse.jdt.launching.MAIN_TYPE
value=com.google.gwt.dev.HostedMode/
+stringAttribute key=org.eclipse.jdt.launching.MAIN_TYPE
value=com.google.gwt.dev.DevMode/
stringAttribute key=org.eclipse.jdt.launching.PROGRAM_ARGUMENTS
value=-startupUrl
DynaTableRf.html#13;#10;com.google.gwt.sample.dynatablerf.DynaTableRf/
stringAttribute key=org.eclipse.jdt.launching.PROJECT_ATTR
value=DynaTableRf/
/launchConfiguration
===
--- /trunk/eclipse/samples/Hello/Hello.launch Tue Oct 13 16:57:19 2009
+++ /trunk/eclipse/samples/Hello/Hello.launch Fri Feb 18 08:16:52 2011
@@ -10,7 +10,7 @@
listEntry value=lt;?xml version=quot;1.0quot;
encoding=quot;UTF-8quot;?gt;#10;lt;runtimeClasspathEntry
id=quot;org.eclipse.jdt.launching.classpathentry.defaultClasspathquot;gt;#10;lt;memento
exportedEntriesOnly=quot;falsequot;
project=quot;Helloquot;/gt;#10;lt;/runtimeClasspathEntrygt;#10;/
/listAttribute
booleanAttribute key=org.eclipse.jdt.launching.DEFAULT_CLASSPATH
value=false/
-stringAttribute key=org.eclipse.jdt.launching.MAIN_TYPE
value=com.google.gwt.dev.HostedMode/
+stringAttribute key=org.eclipse.jdt.launching.MAIN_TYPE
value=com.google.gwt.dev.DevMode/
stringAttribute key=org.eclipse.jdt.launching.PROGRAM_ARGUMENTS
value=-startupUrl Hello.html#13;#10;com.google.gwt.sample.hello.Hello/
stringAttribute key=org.eclipse.jdt.launching.PROJECT_ATTR
value=Hello/
stringAttribute key=org.eclipse.jdt.launching.VM_ARGUMENTS
value=-ea#13;#10;-Xmx256M#13;#10;-Dgwt.devjar=${gwt_devjar}/
===
--- /trunk/eclipse/samples/JSON/JSON.launch Mon Jun 7 12:20:31 2010
+++ /trunk/eclipse/samples/JSON/JSON.launch Fri Feb 18 08:16:52 2011
@@ -10,7 +10,7 @@
listEntry value=lt;?xml version=quot;1.0quot;
encoding=quot;UTF-8quot;?gt;#10;lt;runtimeClasspathEntry
id=quot;org.eclipse.jdt.launching.classpathentry.defaultClasspathquot;gt;#10;lt;memento
exportedEntriesOnly=quot;falsequot;
project=quot;JSONquot;/gt;#10;lt;/runtimeClasspathEntrygt;#10;/
/listAttribute
booleanAttribute key=org.eclipse.jdt.launching.DEFAULT_CLASSPATH
value=false/
-stringAttribute key=org.eclipse.jdt.launching.MAIN_TYPE
value=com.google.gwt.dev.HostedMode/
+stringAttribute key=org.eclipse.jdt.launching.MAIN_TYPE
value=com.google.gwt.dev.DevMode/
stringAttribute key=org.eclipse.jdt.launching.PROGRAM_ARGUMENTS
value=-startupUrl JSON.html#13;#10;com.google.gwt.sample.json.JSON/
[gwt-contrib] Re: user.agent proposal. (issue1354806)
http://gwt-code-reviews.appspot.com/1354806/diff/1/2 File user/src/com/google/gwt/user/UserAgent.gwt.xml (right): http://gwt-code-reviews.appspot.com/1354806/diff/1/2#newcode38 user/src/com/google/gwt/user/UserAgent.gwt.xml:38: var ua = navigator.userAgent.toLowerCase(); Per offline discussion, this code probably still needs to live in a java file somewhere, so that Fred's code which checks to make sure the correct permutation was launched can stay in sync. UserAgentPropertyGenerator needs to be refactored, not retired. http://gwt-code-reviews.appspot.com/1354806/diff/1/2#newcode50 user/src/com/google/gwt/user/UserAgent.gwt.xml:50: /property-provider Worth adding a comment here and in similar places: !-- Set deprecated legacy user.agent value -- http://gwt-code-reviews.appspot.com/1354806/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9752 committed - Updating API checker for GWT 2.3. In CellBasedWidgetImplStandard, I fi...
Revision: 9752 Author: jlaba...@google.com Date: Fri Feb 18 11:21:07 2011 Log: Updating API checker for GWT 2.3. In CellBasedWidgetImplStandard, I fixed the package declaration per an Api Checker warning. Review at http://gwt-code-reviews.appspot.com/1356805 Review by: rj...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=9752 Added: /trunk/tools/api-checker/config/gwt22_23userApi.conf Modified: /trunk/build.xml /trunk/tools/api-checker/reference/README /trunk/tools/api-checker/reference/gwt-dev-modified.jar /trunk/tools/api-checker/reference/gwt-user-modified.jar /trunk/user/src/com/google/gwt/user/cellview/client/CellBasedWidgetImplStandard.java === --- /dev/null +++ /trunk/tools/api-checker/config/gwt22_23userApi.conf Fri Feb 18 11:21:07 2011 @@ -0,0 +1,122 @@ +#existing API + +# dirRoot_old is missing because refJars are being supplied +name_old gwt22userApi +#sourceFiles is specified as colon-separated list of files +sourceFiles_old com/google/gwt\ +:javax/validation\ + +#excludedFiles is specified as colon-separated ant patterns +excludedFiles_old com/google/gwt/benchmarks/BenchmarkReport.java\ +:com/google/gwt/benchmarks/BenchmarkShell.java\ +:com/google/gwt/benchmarks/client/Benchmark.java\ +:**/linker/**\ +:**/rebind/**\ +:**/server/**\ +:**/tools/**\ +:com/google/gwt/regexp/shared/**\ +:com/google/gwt/autobean/shared/impl/StringQuoter.java\ +:com/google/gwt/autobean/shared/ValueCodexHelper.java\ +:com/google/gwt/core/client/impl/WeakMapping.java\ +:com/google/gwt/core/ext/**\ +:com/google/gwt/dev/*.java\ +:com/google/gwt/dev/asm/**\ +:com/google/gwt/dev/cfg/**\ +:com/google/gwt/dev/generator/**\ +:com/google/gwt/dev/javac/**\ +:com/google/gwt/dev/jdt/**\ +:com/google/gwt/dev/jjs/*.java\ +:com/google/gwt/dev/jjs/ast/**\ +:com/google/gwt/dev/jjs/impl/**\ +:com/google/gwt/dev/js/**\ +:com/google/gwt/dev/json/**\ +:com/google/gwt/dev/resource/**\ +:com/google/gwt/dev/shell/**\ +:com/google/gwt/dev/ui/**\ +:com/google/gwt/dev/util/**\ +:com/google/gwt/junit/*.java\ +:com/google/gwt/junit/client/GWTTestCase.java\ +:com/google/gwt/junit/client/impl/GWTRunner.java\ +:com/google/gwt/junit/remote/**\ +:com/google/gwt/resources/client/impl/**\ +:com/google/gwt/resources/css/**\ +:com/google/gwt/resources/ext/**\ +:com/google/gwt/resources/rg/**\ +:com/google/gwt/requestfactory/client/impl/FindRequest.java\ +:com/google/gwt/requestfactory/shared/impl/MessageFactoryHolder.java\ +:com/google/gwt/requestfactory/shared/UserInformationProxy.java\ +:com/google/gwt/requestfactory/shared/UserInformationRequest.java\ +:com/google/gwt/requestfactory/ui/client/LoginWidget.java\ +:com/google/gwt/rpc/client/impl/ClientWriterFactory.java\ +:com/google/gwt/rpc/client/impl/EscapeUtil.java\ +:com/google/gwt/rpc/client/impl/RpcCallbackAdapter.java\ +:com/google/gwt/soyc/**\ +:com/google/gwt/safehtml/shared/SafeHtmlHostedModeUtils.java\ +:com/google/gwt/user/client/rpc/core/**\ +:com/google/gwt/user/client/rpc/impl/**\ +:com/google/gwt/uibinder/attributeparsers/**\ +:com/google/gwt/uibinder/elementparsers/**\ +:com/google/gwt/uibinder/testing/**\ +:com/google/gwt/util/**\ +:com/google/gwt/validation/**\ + +## +#new Api + +dirRoot_new ./ +name_new gwt23userApi +#sourceFiles is specified as colon-separated list of files +sourceFiles_new dev/core/super\ +:user/src\ +:user/super\ + +#excludedFiles is specified as colon-separated ant patterns +# The last 3 entries exclude the validation stuff. +# Bug: http://code.google.com/p/google-web-toolkit/issues/detail?id=5566 +excludedFiles_new user/src/com/google/gwt/benchmarks/BenchmarkReport.java\ +:user/src/com/google/gwt/benchmarks/BenchmarkShell.java\ +:user/src/com/google/gwt/benchmarks/client/Benchmark.java\ +:**/linker/**\ +:**/rebind/**\ +:**/server/**\ +:**/tools/**\ +:user/src/com/google/gwt/regexp/shared/**\ +:user/src/com/google/gwt/autobean/shared/ValueCodexHelper.java\ +:user/src/com/google/gwt/autobean/shared/impl/StringQuoter.java\ +:user/src/com/google/gwt/core/client/impl/WeakMapping.java\ +:user/src/com/google/gwt/junit/*.java\ +:user/src/com/google/gwt/junit/client/GWTTestCase.java\ +:user/src/com/google/gwt/junit/client/impl/GWTRunner.java\ +:user/src/com/google/gwt/junit/remote/**\ +:user/src/com/google/gwt/resources/css/**\ +:user/src/com/google/gwt/resources/ext/**\ +:user/src/com/google/gwt/resources/rg/**\ +:user/src/com/google/gwt/requestfactory/shared/impl/MessageFactoryHolder.java\ +:user/src/com/google/gwt/rpc/client/impl/ClientWriterFactory.java\ +:user/src/com/google/gwt/rpc/client/impl/EscapeUtil.java\ +:user/src/com/google/gwt/rpc/client/impl/RpcCallbackAdapter.java\ +:user/src/com/google/gwt/safehtml/shared/SafeHtmlHostedModeUtils.java\ +:user/src/com/google/gwt/user/client/rpc/core/**\ +:user/src/com/google/gwt/user/client/rpc/impl/**\ +:user/src/com/google/gwt/uibinder/attributeparsers/**\
[gwt-contrib] Re: Do not put ?serial=0 at the end of the URL for the first fetch attempt on a runAsync fragement... (issue1358804)
On 2011/02/18 23:24:10, jaredking wrote: I'd vote for leaving the CrossSite linker alone for now. It's been around a long time, and will be deprecated soon, so changing the behavior probably isn't worth it, unless there's a specific reason you need it changed along with the CrossSiteIframeLinker. http://gwt-code-reviews.appspot.com/1358804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Do not put ?serial=0 at the end of the URL for the first fetch attempt on a runAsync fragement... (issue1358804)
On 2011/02/18 23:46:55, jaredking wrote: LGTM http://gwt-code-reviews.appspot.com/1358804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Change the DevModeOptions page to use the xs linker due to recent Chrome extension permissions c... (issue1356803)
relevant chrome bug http://code.google.com/p/chromium/issues/detail?id=72407 On 2011/02/15 21:55:29, knorton wrote: Awesome. good to know. I need to figure out how it manages to work. On Tue, Feb 15, 2011 at 4:52 PM, Chris Conroy mailto:con...@google.com wrote: Actually, it does work. On Tue, Feb 15, 2011 at 4:49 PM, Kelly Norton mailto:knor...@google.com wrote: I could be wrong, but I don't think the xsiframe linker is going to work here. On Tue, Feb 15, 2011 at 4:46 PM, Kelly Norton mailto:knor...@google.com wrote: xsiframe is fine if it works. But you'll have to check it because these are not the normal xs restrictions. On Tue, Feb 15, 2011 at 4:28 PM, Unnur Gretarsdottir mailto:unn...@google.com wrote: All google3 projects are being switched to xsiframe in a few weeks (currently blocked by lack of a Blaze push). Deprecation/deletions of other linkers for regular GWT will soon follow, but to be honest, will be a GWT 3.0 thing at the very earliest. It's not a burning issue, but I do recommend that you do not switch to the xs linker at this point. It doesn't install in an iframe, and switching from being iframe installed vs. not has proven painful for some teams. Right now - if you're using the std linker (default), your compliant with being installed in an iframe, so if you start using xs, pick up some code dependencies that assume non-iframe, and then need to switch back to iframe based (xsiframe), you may see some issues. Or maybe not It's also possible that xs does not support DevMode - I can't remember off the top of my head. If you care about that, then xsiframe definitely does support it. - Unnur On Tue, Feb 15, 2011 at 1:09 PM, John Tamplin mailto:j...@google.com wrote: On Tue, Feb 15, 2011 at 4:03 PM, Chris Conroy mailto:con...@google.com wrote: Sorry, didn't see your comment in time for the commit. I just used the same fix Kelly applied in SpeedTracer. I don't think it really matters strongly either way. As I understand it, the xs linker will soon be deprecated since the xsiframe linker provides a superset of its functionality. -- John A. Tamplin Software Engineer (GWT), Google -- If you received this communication by mistake, you are entitled to one free ice cream cone on me. Simply print out this email including all relevant SMTP headers and present them at my desk to claim your creamy treat. We'll have a laugh at my emailing incompetence, and play a game of ping pong. (offer may not be valid in all States). -- If you received this communication by mistake, you are entitled to one free ice cream cone on me. Simply print out this email including all relevant SMTP headers and present them at my desk to claim your creamy treat. We'll have a laugh at my emailing incompetence, and play a game of ping pong. (offer may not be valid in all States). -- If you received this communication by mistake, you are entitled to one free ice cream cone on me. Simply print out this email including all relevant SMTP headers and present them at my desk to claim your creamy treat. We'll have a laugh at my emailing incompetence, and play a game of ping pong. (offer may not be valid in all States). http://gwt-code-reviews.appspot.com/1356803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9753 committed - Do not put ?serial=0 at the end of the URL for the first fetch attem...
Revision: 9753
Author: jaredk...@google.com
Date: Fri Feb 18 14:32:34 2011
Log: Do not put ?serial=0 at the end of the URL for the first fetch
attempt on a runAsync fragement. Preserve it for later attempts.
- Improves caching.
- Makes it easier to write HTML5 manifests, do prefetching, etc, where
stable URLs are needed.
Review at http://gwt-code-reviews.appspot.com/1358804
Review by: unn...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9753
Modified:
/trunk/user/src/com/google/gwt/core/client/impl/CrossSiteIframeLoadingStrategy.java
===
---
/trunk/user/src/com/google/gwt/core/client/impl/CrossSiteIframeLoadingStrategy.java
Mon Oct 11 09:55:46 2010
+++
/trunk/user/src/com/google/gwt/core/client/impl/CrossSiteIframeLoadingStrategy.java
Fri Feb 18 14:32:34 2011
@@ -157,8 +157,12 @@
* to cache a download failure.
*/
private String getUrl(int fragment) {
+// Not appending serial=N to the first attempt improves proxy caching
+// and makes it easier to write HTML5 AppCache manifests.
+int serial = getSerial(fragment);
+String parameters = ((serial == 0) ? : (?serial= + serial));
return GWT.getModuleBaseURL() + getDeferredJavaScriptDirectory()
-+ GWT.getPermutationStrongName() + / + fragment
+ .cache.js?serial=
-+ getSerial(fragment);
++ GWT.getPermutationStrongName() + / + fragment + .cache.js
++ parameters;
}
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
