[gwt-contrib] [google-web-toolkit] r10571 committed - Fixes SafeUri tests to work with my good friend IE.

[codesite-noreply]

Revision: 10571
Author:   rj...@google.com
Date: Wed Aug 24 18:17:39 2011
Log:  Fixes SafeUri tests to work with my good friend IE.

http://code.google.com/p/google-web-toolkit/source/detail?r=10571

Modified:
  
/trunk/user/test/com/google/gwt/uibinder/test/client/LazyWidgetBuilderSafeUriIntegrationTest.java
  
/trunk/user/test/com/google/gwt/uibinder/test/client/SafeUriIntegrationTest.java


===
---  
/trunk/user/test/com/google/gwt/uibinder/test/client/LazyWidgetBuilderSafeUriIntegrationTest.java	 
Thu Aug 18 06:20:28 2011
+++  
/trunk/user/test/com/google/gwt/uibinder/test/client/LazyWidgetBuilderSafeUriIntegrationTest.java	 
Wed Aug 24 18:17:39 2011

@@ -90,9 +90,7 @@
 try {
   RootPanel.get().add(ui);
   assertEquals(values.anUnsafeUri(), ui.jsAnchorFromSafeUri.getHref());
-  AnchorElement anchor = Document.get().createAnchorElement();
-  anchor.setHref("#");
-  assertEquals(anchor.getHref(), ui.jsAnchorFromString.getHref());
+  AnchorElement anchor = expectedEscapedAnchor();
   assertEquals(anchor.getHref(), ui.jsAnchorFromString.getHref());
   assertEquals("http://www.google.com/images/logo_sm.gif";,  
ui.inlineHttpAnchor.getHref());
   assertEquals("javascript:void(0)",  
ui.inlineJavascriptAnchor.getHref());

@@ -118,9 +116,7 @@
 try {
   assertEquals(values.anUnsafeUri(),  
r.getJsAnchorFromSafeUri(e).getHref());


-  AnchorElement anchor = Document.get().createAnchorElement();
-  anchor.setHref("#");
-  assertEquals(anchor.getHref(), r.getJsAnchorFromString(e).getHref());
+  AnchorElement anchor = expectedEscapedAnchor();
   assertEquals(anchor.getHref(), r.getJsAnchorFromString(e).getHref());

   assertEquals("http://www.google.com/images/logo_sm.gif";,  
r.getInlineHttpAnchor(e).getHref());

===
---  
/trunk/user/test/com/google/gwt/uibinder/test/client/SafeUriIntegrationTest.java	 
Thu Aug 18 06:20:28 2011
+++  
/trunk/user/test/com/google/gwt/uibinder/test/client/SafeUriIntegrationTest.java	 
Wed Aug 24 18:17:39 2011

@@ -17,9 +17,9 @@

 import com.google.gwt.core.client.GWT;
 import com.google.gwt.dom.client.AnchorElement;
-import com.google.gwt.dom.client.Document;
 import com.google.gwt.junit.client.GWTTestCase;
 import com.google.gwt.uibinder.client.UiBinder;
+import com.google.gwt.uibinder.client.UiBinderUtil;
 import com.google.gwt.uibinder.client.UiField;
 import com.google.gwt.user.client.ui.Widget;

@@ -69,9 +69,7 @@
 BinderUi ui = new BinderUi();

 assertEquals(values.anUnsafeUri(), ui.jsAnchorFromSafeUri.getHref());
-AnchorElement anchor = Document.get().createAnchorElement();
-anchor.setHref("#");
-assertEquals(anchor.getHref(), ui.jsAnchorFromString.getHref());
+AnchorElement anchor = expectedEscapedAnchor();
 assertEquals(anchor.getHref(), ui.jsAnchorFromString.getHref());
 assertEquals("http://www.google.com/images/logo_sm.gif";,  
ui.inlineHttpAnchor.getHref());
 assertEquals("javascript:void(0)",  
ui.inlineJavascriptAnchor.getHref());

@@ -81,4 +79,9 @@
 assertEquals("http://www.google.com/images/logo_sm.gif";,  
ui.inlineHttpAnchorObj.uri.asString());
 assertEquals("javascript:void(0)",  
ui.inlineJavascriptAnchorObj.uri.asString());

   }
-}
+
+  protected AnchorElement expectedEscapedAnchor() {
+AnchorElement anchor = UiBinderUtil.fromHtml("href='#'>snot").cast();

+return anchor;
+  }
+}

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Address RunStyle TODO (issue1529805)

[Jeff Larsen]

The general practice I've seen the GWT guys do for that is to do an initial 
patch where they autoformat, then 2nd patch with the actual changes. 

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Address RunStyle TODO (issue1529805)

[skybrian]

Looks good. I need to look into how to actually commit this.


http://gwt-code-reviews.appspot.com/1529805/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Address RunStyle TODO (issue1529805)

[stephen . haberman]

http://gwt-code-reviews.appspot.com/1529805/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Address RunStyle TODO (issue1529805)

[skybrian]

http://gwt-code-reviews.appspot.com/1529805/diff/3002/user/src/com/google/gwt/junit/RunStyleHtmlUnit.java
File user/src/com/google/gwt/junit/RunStyleHtmlUnit.java (right):

http://gwt-code-reviews.appspot.com/1529805/diff/3002/user/src/com/google/gwt/junit/RunStyleHtmlUnit.java#newcode184
user/src/com/google/gwt/junit/RunStyleHtmlUnit.java:184: private static
final Set PLATFORMS = Sets.newHashSet(Platform.HtmlUnitBug,
ImmutableSet.of() is slightly safer here.

http://gwt-code-reviews.appspot.com/1529805/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Address RunStyle TODO (issue1529805)

[skybrian]

On 2011/08/25 01:56:26, stephenh wrote:

Thanks for the review. Agreed on all the nits and updated.



Sorry about the line length--I haven't gotten checkstyle installed in

Eclipse,

nor have auto-format turned on because it seems like a lot of files

(like the

ones in this review) haven't been reformatted yet.



I have a thousand-some warnings right now--if I spend some time on

configuring

Eclipse, is it possible to get to 0-warnings?


I don't use Eclipse so I couldn't really tell you.


http://gwt-code-reviews.appspot.com/1529805/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Address RunStyle TODO (issue1529805)

[stephen . haberman]

Thanks for the review. Agreed on all the nits and updated.

Sorry about the line length--I haven't gotten checkstyle installed in
Eclipse, nor have auto-format turned on because it seems like a lot of
files (like the ones in this review) haven't been reformatted yet.

I have a thousand-some warnings right now--if I spend some time on
configuring Eclipse, is it possible to get to 0-warnings?

http://gwt-code-reviews.appspot.com/1529805/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Address RunStyle TODO (issue1529805)

[stephen . haberman]

http://gwt-code-reviews.appspot.com/1529805/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Address RunStyle TODO (issue1529805)

[skybrian]

Makes sense. A few nitpicks.



http://gwt-code-reviews.appspot.com/1529805/diff/1/user/src/com/google/gwt/junit/JUnitShell.java
File user/src/com/google/gwt/junit/JUnitShell.java (right):

http://gwt-code-reviews.appspot.com/1529805/diff/1/user/src/com/google/gwt/junit/JUnitShell.java#newcode1223
user/src/com/google/gwt/junit/JUnitShell.java:1223: if
(runStyle.getPlatforms() != null) {
If you make getPlatforms() return a non-null List then you
could use Collections.disjoint() here:

if (!Collections.disjoint(bannedPlatforms, runStyle.getPlatforms()) {
  return true;
}

http://gwt-code-reviews.appspot.com/1529805/diff/1/user/src/com/google/gwt/junit/RunStyle.java
File user/src/com/google/gwt/junit/RunStyle.java (right):

http://gwt-code-reviews.appspot.com/1529805/diff/1/user/src/com/google/gwt/junit/RunStyle.java#newcode75
user/src/com/google/gwt/junit/RunStyle.java:75: return null;
It's better to return an array with zero elements, to avoid the special
case.

http://gwt-code-reviews.appspot.com/1529805/diff/1/user/src/com/google/gwt/junit/RunStyleHtmlUnit.java
File user/src/com/google/gwt/junit/RunStyleHtmlUnit.java (right):

http://gwt-code-reviews.appspot.com/1529805/diff/1/user/src/com/google/gwt/junit/RunStyleHtmlUnit.java#newcode183
user/src/com/google/gwt/junit/RunStyleHtmlUnit.java:183: private static
final Platform[] PLATFORMS = { Platform.HtmlUnitBug,
Platform.HtmlUnitLayout, Platform.HtmlUnitUnknown };
Line too long; please wrap.

http://gwt-code-reviews.appspot.com/1529805/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Address RunStyle TODO (issue1529805)

[Stephen Haberman]

> I do not think *amitmanjhi *works at Google anymore:

Heh, guess not, thanks for pointing that out.

Any volunteers for the review then?

- Stephen

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Address RunStyle TODO (issue1529805)

[karthik reddy]

I do not think *amitmanjhi *works at Google anymore:
http://www.linkedin.com/profile/view?id=10952047

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add Integer.TYPE, etc. (issue1528806)

[stephen . haberman]

Patch originally by Grzegorz Kossakowski:

https://gist.github.com/1168576


http://gwt-code-reviews.appspot.com/1528806/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Add Integer.TYPE, etc. (issue1528806)

[stephen . haberman]

Reviewers: scottb,



Please review this at http://gwt-code-reviews.appspot.com/1528806/

Affected files:
  M user/super/com/google/gwt/emul/java/lang/Boolean.java
  M user/super/com/google/gwt/emul/java/lang/Byte.java
  M user/super/com/google/gwt/emul/java/lang/Double.java
  M user/super/com/google/gwt/emul/java/lang/Float.java
  M user/super/com/google/gwt/emul/java/lang/Integer.java
  M user/super/com/google/gwt/emul/java/lang/Long.java
  M user/super/com/google/gwt/emul/java/lang/Short.java
  M user/super/com/google/gwt/emul/java/lang/Void.java


Index: user/super/com/google/gwt/emul/java/lang/Boolean.java
diff --git a/user/super/com/google/gwt/emul/java/lang/Boolean.java  
b/user/super/com/google/gwt/emul/java/lang/Boolean.java
index  
6273bd2f65353b7bfc68130b01724fb3c1fba1d6..c092fb8a0843d3726ac34ffc8f6c7ea66d8ea621  
100644

--- a/user/super/com/google/gwt/emul/java/lang/Boolean.java
+++ b/user/super/com/google/gwt/emul/java/lang/Boolean.java
@@ -31,6 +31,8 @@ public final class Boolean implements  
Comparable, Serializable {


   // CHECKSTYLE_ON

+  public static final Class TYPE = boolean.class;
+
   public static boolean parseBoolean(String s) {
 return "true".equalsIgnoreCase(s);
   }
Index: user/super/com/google/gwt/emul/java/lang/Byte.java
diff --git a/user/super/com/google/gwt/emul/java/lang/Byte.java  
b/user/super/com/google/gwt/emul/java/lang/Byte.java
index  
4d6b7573ae4df2bc3feb2347f71885826688db60..664589efc43193341cc35b9f72ae0de1d42122ca  
100644

--- a/user/super/com/google/gwt/emul/java/lang/Byte.java
+++ b/user/super/com/google/gwt/emul/java/lang/Byte.java
@@ -23,6 +23,7 @@ public final class Byte extends Number implements  
Comparable {

   public static final byte MIN_VALUE = (byte) 0x80;
   public static final byte MAX_VALUE = (byte) 0x7F;
   public static final int SIZE = 8;
+  public static final Class TYPE = byte.class;

   /**
* Use nested class to avoid clinit on outer.
Index: user/super/com/google/gwt/emul/java/lang/Double.java
diff --git a/user/super/com/google/gwt/emul/java/lang/Double.java  
b/user/super/com/google/gwt/emul/java/lang/Double.java
index  
95b06055af2e5449b47c59907674e0a6e7e16746..6949a41c022ab9af6058b7c4cc02e0fe4704349d  
100644

--- a/user/super/com/google/gwt/emul/java/lang/Double.java
+++ b/user/super/com/google/gwt/emul/java/lang/Double.java
@@ -31,6 +31,7 @@ public final class Double extends Number implements  
Comparable {

   public static final double NEGATIVE_INFINITY = -1d / 0d;
   public static final double POSITIVE_INFINITY = 1d / 0d;
   public static final int SIZE = 64;
+  public static final Class TYPE = double.class;

   public static int compare(double x, double y) {
 if (isNaN(x)) {
Index: user/super/com/google/gwt/emul/java/lang/Float.java
diff --git a/user/super/com/google/gwt/emul/java/lang/Float.java  
b/user/super/com/google/gwt/emul/java/lang/Float.java
index  
b3c95764ea7b74afea4102d8a70383f21fa038a3..a631729fadc2aca5aa5ee1d488575af3595e8443  
100644

--- a/user/super/com/google/gwt/emul/java/lang/Float.java
+++ b/user/super/com/google/gwt/emul/java/lang/Float.java
@@ -28,6 +28,7 @@ public final class Float extends Number implements  
Comparable {

   public static final float NEGATIVE_INFINITY = -1f / 0f;
   public static final float POSITIVE_INFINITY = 1f / 0f;
   public static final int SIZE = 32;
+  public static final Class TYPE = float.class;

   public static int compare(float x, float y) {
 if (x < y) {
Index: user/super/com/google/gwt/emul/java/lang/Integer.java
diff --git a/user/super/com/google/gwt/emul/java/lang/Integer.java  
b/user/super/com/google/gwt/emul/java/lang/Integer.java
index  
6a44ab67963b0037a27d487d76766ea519592387..04e2b005ff1412fb2c18bbd443844e0e92943089  
100644

--- a/user/super/com/google/gwt/emul/java/lang/Integer.java
+++ b/user/super/com/google/gwt/emul/java/lang/Integer.java
@@ -23,6 +23,7 @@ public final class Integer extends Number implements  
Comparable {

   public static final int MAX_VALUE = 0x7fff;
   public static final int MIN_VALUE = 0x8000;
   public static final int SIZE = 32;
+  public static final Class TYPE = int.class;

   /**
* Use nested class to avoid clinit on outer.
Index: user/super/com/google/gwt/emul/java/lang/Long.java
diff --git a/user/super/com/google/gwt/emul/java/lang/Long.java  
b/user/super/com/google/gwt/emul/java/lang/Long.java
index  
0971d94975ef6ba8555d04534230c97f6612de11..c0b08d7eeefbba80dcd46af6aabc74d9f9efb68e  
100644

--- a/user/super/com/google/gwt/emul/java/lang/Long.java
+++ b/user/super/com/google/gwt/emul/java/lang/Long.java
@@ -50,6 +50,7 @@ public final class Long extends Number implements  
Comparable {

   public static final long MAX_VALUE = 0x7fffL;
   public static final long MIN_VALUE = 0x8000L;
   public static final int SIZE = 64;
+  public static final Class TYPE = long.class;

   public static int bitCount(long i) {
 int high = (int) (i >> 32);
Index: user/super/com/google/gwt/em

[gwt-contrib] Re: Remove unused dev/common.ant.xml. (issue1523807)

[stephen . haberman]

After wondering why my changes to the "build" target in this file
weren't showing up, it looks like this is a legacy file that isn't
imported anymore. All of the targets are defined in dev/build.xml
instead.

http://gwt-code-reviews.appspot.com/1523807/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Remove unused dev/common.ant.xml. (issue1523807)

[stephen . haberman]

Reviewers: jat,



Please review this at http://gwt-code-reviews.appspot.com/1523807/

Affected files:
  D dev/common.ant.xml


Index: dev/common.ant.xml
diff --git a/dev/common.ant.xml b/dev/common.ant.xml
deleted file mode 100755
index  
262d3ba8eb166510cd585b05f298dc66ee9b1a9e..

--- a/dev/common.ant.xml
+++ /dev/null
@@ -1,60 +0,0 @@
-
-  
-  
-
-  
-  location="${project.build}/../core" />

-
-  
-
-
-  
-
-
-  
-
-  
-
-  

-
-
-  
-
-
-  
-   

-
-
-
-
-
-  
-  
-
-  
-  
-
-  
-  
-
- 

-  
-  />

-  
-  
-  
-
-  
-value="com.google.gwt.dev.GWTMain" />

-  
-
-  
-
-  
-
-  

-
-
-  
-
-


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Minor dev/build.xml cleanup (issue1524804)

[John Tamplin]

On Wed, Aug 24, 2011 at 3:30 PM,  wrote:

>
> http://gwt-code-reviews.**appspot.com/1524804/diff/1/**dev/build.xml
> File dev/build.xml (left):
>
> http://gwt-code-reviews.**appspot.com/1524804/diff/1/**
> dev/build.xml#oldcode113
> dev/build.xml:113: 
> name="guava/guava-r06/guava-**r06-rebased-2.jar" />
> guava was already listed above and I don't see any references to
> swingworker in the codebase, so I assume it's legacy and can be removed?


Yes, swingworker used to be used in SwingUI, but is no longer.

-- 
John A. Tamplin
Software Engineer (GWT), Google

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] maven source jars

[Stephen Haberman]

> Hm, perhaps a few. I saw instructions on patching emma; nothing else
> is leaping out at me.

Okay, there are patch files for json and streamhtmlparser. The latter is
rebased. Leaving anything that is rebased or patched in the jar seems
fine to me, since it's only a few.

(I'm replying to myself, but I sent my previous message from the
wrong email address, so it is probably moderated/dropped. Here's
the text in case my previous message never shows up:)

Taking gwt-dev-nodeps further, it looks like most of the deps come from
bundling tomcat and htmlunit. Neither of which I use. I think it would
be fairly easily, at least from a packaging perspective, to make
gwt-dev-nodeps, gwt-tomcat, and gwt-htmlunit jars, none of which have
their dependencies in them, but instead pulled in however projects
otherwise manage transitive dependencies (poms/what have you).

If I got a gwt-dev-nodeps/gwt-tomcat/gwt-htmlunit build working, would
anyone be interested in that?

- Stephen

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Address RunStyle TODO (issue1529805)

[stephen . haberman]

Reviewers: amitmanjhi,



Please review this at http://gwt-code-reviews.appspot.com/1529805/

Affected files:
  M user/src/com/google/gwt/junit/JUnitShell.java
  M user/src/com/google/gwt/junit/RunStyle.java
  M user/src/com/google/gwt/junit/RunStyleHtmlUnit.java


Index: user/src/com/google/gwt/junit/JUnitShell.java
diff --git a/user/src/com/google/gwt/junit/JUnitShell.java  
b/user/src/com/google/gwt/junit/JUnitShell.java
index  
eb9b112fccf5dab10c9d16c863ef26ef9d74781c..e79c60818647b477295601a746a4419293f9191b  
100644

--- a/user/src/com/google/gwt/junit/JUnitShell.java
+++ b/user/src/com/google/gwt/junit/JUnitShell.java
@@ -1220,12 +1220,12 @@ public class JUnitShell extends DevMode {
   }

   private boolean mustNotExecuteTest(Set bannedPlatforms) {
-// TODO (amitmanjhi): Remove this hard-coding. A RunStyle somehow  
needs to

-// specify how it interacts with the platforms.
-if (runStyle instanceof RunStyleHtmlUnit
-&& (bannedPlatforms.contains(Platform.HtmlUnitUnknown)
-|| bannedPlatforms.contains(Platform.HtmlUnitLayout) ||  
bannedPlatforms.contains(Platform.HtmlUnitBug))) {

-  return true;
+if (runStyle.getPlatforms() != null) {
+  for (Platform platform : runStyle.getPlatforms()) {
+if (bannedPlatforms.contains(platform)) {
+  return true;
+}
+  }
 }

 if (developmentMode) {
Index: user/src/com/google/gwt/junit/RunStyle.java
diff --git a/user/src/com/google/gwt/junit/RunStyle.java  
b/user/src/com/google/gwt/junit/RunStyle.java
index  
a7aaa8db0bab8fc93f25e4f359789acf5ba189e4..0c4b49d70993e979acab00f7410921268b2862dd  
100644

--- a/user/src/com/google/gwt/junit/RunStyle.java
+++ b/user/src/com/google/gwt/junit/RunStyle.java
@@ -69,6 +69,13 @@ public abstract class RunStyle {
   }

   /**
+   * Returns the platforms specific to this run style.
+   */
+  public Platform[] getPlatforms() {
+return null;
+  }
+
+  /**
* Returns the number of times this test should be tried to run. A test
* succeeds if it succeeds even once.
*
Index: user/src/com/google/gwt/junit/RunStyleHtmlUnit.java
diff --git a/user/src/com/google/gwt/junit/RunStyleHtmlUnit.java  
b/user/src/com/google/gwt/junit/RunStyleHtmlUnit.java
index  
efc99491d6ccfe4d4ed25efd14f5aeb85858e721..e5b1d4ea851f0f2c5e3e1682a9d18389fdf17310  
100644

--- a/user/src/com/google/gwt/junit/RunStyleHtmlUnit.java
+++ b/user/src/com/google/gwt/junit/RunStyleHtmlUnit.java
@@ -180,6 +180,8 @@ public class RunStyleHtmlUnit extends RunStyle {
*/
   private static final int DEFAULT_TRIES = 1;

+  private static final Platform[] PLATFORMS = { Platform.HtmlUnitBug,  
Platform.HtmlUnitLayout, Platform.HtmlUnitUnknown };

+
   /**
* Returns the list of browsers Htmlunit emulates as a comma separated  
string.

*/
@@ -241,6 +243,11 @@ public class RunStyleHtmlUnit extends RunStyle {
   }

   @Override
+  public Platform[] getPlatforms() {
+return PLATFORMS;
+  }
+
+  @Override
   public void launchModule(String moduleName) {
 for (BrowserVersion browser : browsers) {
   String url = shell.getModuleUrl(moduleName);


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Minor dev/build.xml cleanup (issue1524804)

[stephen . haberman]

http://gwt-code-reviews.appspot.com/1524804/diff/1/dev/build.xml
File dev/build.xml (left):

http://gwt-code-reviews.appspot.com/1524804/diff/1/dev/build.xml#oldcode113
dev/build.xml:113: 
guava was already listed above and I don't see any references to
swingworker in the codebase, so I assume it's legacy and can be removed?

http://gwt-code-reviews.appspot.com/1524804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Minor dev/build.xml cleanup (issue1524804)

[stephen . haberman]

Reviewers: jat,



Please review this at http://gwt-code-reviews.appspot.com/1524804/

Affected files:
  M dev/build.xml


Index: dev/build.xml
diff --git a/dev/build.xml b/dev/build.xml
index  
48381ab5a74a2f3363e13d542e2703f0f754d4ff..7b527d8d65bfea90694cea9de48d818682194af0  
100755

--- a/dev/build.xml
+++ b/dev/build.xml
@@ -109,8 +109,6 @@
   
   
   
-  
-  
 
 
   
@@ -173,8 +171,6 @@
   src="${gwt.tools.lib}/xerces/xerces-2_9_1/xml-apis.jar" />

   
   
-  src="${gwt.tools.lib}/sun/swingworker/swing-worker-1.1.jar" />
-  src="${gwt.tools.lib}/guava/guava-r06/guava-r06-rebased-2.jar" />

 
   
 


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Save the factory and options in the ValidatorContext (issue1523806)

[nchalko]

Reviewers: rchandia,

Description:
Save the factory and options in the ValidatorContext
Add test for GwtValidatorContext.

Please review this at http://gwt-code-reviews.appspot.com/1523806/

Affected files:
  M user/src/com/google/gwt/validation/Validation.gwt.xml
  M  
user/src/com/google/gwt/validation/client/AbstractGwtValidatorFactory.java

  M user/src/com/google/gwt/validation/client/GwtValidatorContext.java
  M user/src/com/google/gwt/validation/client/impl/AbstractGwtValidator.java
  M user/test/com/google/gwt/validation/ValidationClientGwtSuite.java
  A user/test/com/google/gwt/validation/client/GwtValidatorContextTest.java


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] maven source jars

[Stephen Haberman]

> The issue is that, AFAICT, some dependencies have been patched, so
> you cannot simply use Maven dependencies

Hm, perhaps a few. I saw instructions on patching emma; nothing else
is leaping out at me.

Taking gwt-dev-nodeps further, it looks like most of the deps come from bundling
tomcat and htmlunit. Neither of which I use. I think it would be fairly easily,
at least from a packaging perspective, to make gwt-dev-nodeps, gwt-tomcat, and
gwt-htmlunit jars, none of which have their dependencies in them, but instead
pulled in however projects otherwise manage transitive dependencies
(poms/what have you).

If I got a gwt-dev-nodeps/gwt-tomcat/gwt-htmlunit build working, would
anyone be interested in that?

- Stephen


-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10570 committed - Prevents double-escaping of characters by keeping Window.createUrlBuil...

[codesite-noreply]

Revision: 10570
Author:   gwt.mirror...@gmail.com
Date: Wed Aug 24 11:18:25 2011
Log:  Prevents double-escaping of characters by keeping  
Window.createUrlBuilder() consistent with UrlBuilder.buildString().


Review at http://gwt-code-reviews.appspot.com/1528805

Review by: jlaba...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10570

Modified:
 /trunk/user/src/com/google/gwt/user/client/Window.java

===
--- /trunk/user/src/com/google/gwt/user/client/Window.java	Tue Oct  5  
11:03:13 2010
+++ /trunk/user/src/com/google/gwt/user/client/Window.java	Wed Aug 24  
11:18:25 2011

@@ -145,7 +145,8 @@
   }
   String hash = getHash();
   if (hash != null && hash.length() > 0) {
-builder.setHash(hash);
+// Decode the hash now, because UrlBuilder.buildString() later  
encodes it.

+builder.setHash(URL.decodeQueryString(hash));
   }
   String port = getPort();
   if (port != null && port.length() > 0) {

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10569 committed - Revert r10565 due to build break....

[codesite-noreply]

Revision: 10569
Author:   b...@google.com
Date: Wed Aug 24 05:52:16 2011
Log:  Revert r10565 due to build break.
Review by: rjrjr (TBR)

http://code.google.com/p/google-web-toolkit/source/detail?r=10569

Modified:
 /trunk/dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java
 /trunk/dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java
 /trunk/dev/core/test/com/google/gwt/dev/cfg/ModuleDefTest.java

===
--- /trunk/dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java	Wed Aug  
24 04:12:01 2011
+++ /trunk/dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java	Wed Aug  
24 05:52:16 2011

@@ -31,10 +31,10 @@
 import java.util.LinkedList;
 import java.util.List;
 import java.util.Map;
-import java.util.Map.Entry;
 import java.util.Set;
 import java.util.SortedSet;
 import java.util.TreeSet;
+import java.util.Map.Entry;
 import java.util.regex.Pattern;

 /**
@@ -48,15 +48,13 @@
   private static final String EMPTY = "";

   private List> collapsedValues = Lists.create();
-  private final Map> conditionalValues =
-  new LinkedHashMap>();
+  private final Map> conditionalValues = new  
LinkedHashMap>();

   private final SortedSet definedValues = new TreeSet();
   private PropertyProvider provider;
   private Class providerGenerator;
   private String fallback;
-  private HashMap>>  
fallbackValueMap;

-  private HashMap> fallbackValues =
-  new HashMap>();
+  private HashMap>>  
fallbackValueMap;
+  private HashMap> fallbackValues = new  
HashMap>();

   private final ConditionAll rootCondition = new ConditionAll();

   {
@@ -79,7 +77,8 @@
 // Expanded in normalizeCollapsedValues()
 continue;
   } else if (!definedValues.contains(value)) {
-throw new IllegalArgumentException("Attempting to collapse unknown  
value " + value);

+throw new IllegalArgumentException(
+"Attempting to collapse unknown value " + value);
   }
 }

@@ -100,8 +99,7 @@
   }

   /**
-   * Adds fall back value to given property name.
-   *
+   * Adds fall back value to given property name.
* @param value the property value.
* @param fallbackValue the fall back value for given property value.
*/
@@ -166,15 +164,13 @@
   }

   /**
-   * Returns the map of values to fall back values. the list of fall back  
values

-   * is in decreasing order of preference.
-   *
+   * Returns the map of values to fall back values. the list of fall
+   * back values is in decreasing order of preference.
* @return map of property value to fall back values.
*/
-  public Map>>  
getFallbackValuesMap() {
+  public Map>>  
getFallbackValuesMap() {

 if (fallbackValueMap == null) {
-  HashMap>> valuesMap =
-  new HashMap>>();
+  HashMap>> valuesMap = new  
HashMap>>();

   // compute closure of fall back values preserving order
   for (Entry> e :  
fallbackValues.entrySet()) {

 String from = e.getKey();
@@ -183,7 +179,8 @@
 LinkedList childList = fallbackValues.get(from);
 LinkedHashSet children = new LinkedHashSet();
 children.addAll(childList);
-while (children != null && children.size() > 0) {
+while (children != null && children.size() > 0)
+{
   alternates.add(children);
   LinkedHashSet newChildren = new LinkedHashSet();
   for (String child : children) {
@@ -202,7 +199,7 @@
 }
 return fallbackValueMap;
   }
-
+
   public PropertyProvider getProvider() {
 return provider;
   }
@@ -265,7 +262,7 @@
* the currently-defined values.
*
* @throws IllegalArgumentException if any of the provided values were  
not

-   *   provided to {@link #addDefinedValue(Condition,String)}.
+   * provided to {@link #addDefinedValue(Condition,String)}.
*/
   public void setAllowedValues(Condition condition, String... values) {
 SortedSet temp = new TreeSet(Arrays.asList(values));
@@ -311,29 +308,6 @@
* Create a minimal number of equivalence sets, expanding any glob  
patterns.

*/
   void normalizeCollapsedValues() {
-/*
- * Properties that depend upon a collapsed property value must be  
recombined

- * into an equivalence set.
- */
-if (!getRequiredProperties().isEmpty()) {
-  // This defines additional equivalence sets
-  Map>  
requiredPropertyNamesToDependentValues =

-  new HashMap>();
-  for (Map.Entry> entry :  
getConditionalValues().entrySet()) {
-for (String requiredPropertyName :  
entry.getKey().getRequiredProperties()) {
-  SortedSet set =  
requiredPropertyNamesToDependentValues.get(requiredPropertyName);

-  if (set == null) {
-set = new TreeSet();
- 
requiredPropertyNamesToDependentValues.put(requiredPropertyName, set);

-  }
-  set.addAll(entry.getValue());
-}
-  }
-  for (SortedSet valuesToCollapse :  
requiredPropertyNamesToDependentValues.values(

[gwt-contrib] [google-web-toolkit] r10568 committed - Cherry picking r10567 into releases/2.4

[codesite-noreply]

Revision: 10568
Author:   rchan...@google.com
Date: Wed Aug 24 06:05:52 2011
Log:  Cherry picking r10567 into releases/2.4

http://code.google.com/p/google-web-toolkit/source/detail?r=10568

Modified:
 /releases/2.4/samples/mobilewebapp/src/main/webapp/WEB-INF/web.xml
  
/releases/2.4/user/src/com/google/gwt/user/tools/templates/sample/_warFolder_/WEB-INF/web.xmlsrc


===
--- /releases/2.4/samples/mobilewebapp/src/main/webapp/WEB-INF/web.xml	Wed  
Jun  1 07:45:02 2011
+++ /releases/2.4/samples/mobilewebapp/src/main/webapp/WEB-INF/web.xml	Wed  
Aug 24 06:05:52 2011

@@ -1,9 +1,9 @@
 
-http://java.sun.com/dtd/web-app_2_3.dtd";>
-
-
+http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
+  http://java.sun.com/xml/ns/javaee/web-app_2_5.xsd";
+ version="2.5"
+ xmlns="http://java.sun.com/xml/ns/javaee";>

   
  
com.google.gwt.sample.gaerequest.server.GaeAuthFilter

   
   
===
---  
/releases/2.4/user/src/com/google/gwt/user/tools/templates/sample/_warFolder_/WEB-INF/web.xmlsrc	 
Mon Mar  7 08:21:08 2011
+++  
/releases/2.4/user/src/com/google/gwt/user/tools/templates/sample/_warFolder_/WEB-INF/web.xmlsrc	 
Wed Aug 24 06:05:52 2011

@@ -1,10 +1,10 @@
 
-http://java.sun.com/dtd/web-app_2_3.dtd";>
-
-
-
+http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
+  http://java.sun.com/xml/ns/javaee/web-app_2_5.xsd";
+ version="2.5"
+ xmlns="http://java.sun.com/xml/ns/javaee";>
+
   
   
 greetServlet

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Updated header of web.xml files to use XSD version 2.5 (issue1529804)

[rchandia]

submitted as r10567

http://gwt-code-reviews.appspot.com/1529804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10567 committed - Updated header of web.xml files to use XSD version 2.5...

[codesite-noreply]

Revision: 10567
Author:   rchan...@google.com
Date: Wed Aug 24 05:30:48 2011
Log:  Updated header of web.xml files to use XSD version 2.5

Review at http://gwt-code-reviews.appspot.com/1529804

Review by: rda...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10567

Modified:
 /trunk/samples/mobilewebapp/src/main/webapp/WEB-INF/web.xml
  
/trunk/user/src/com/google/gwt/user/tools/templates/sample/_warFolder_/WEB-INF/web.xmlsrc


===
--- /trunk/samples/mobilewebapp/src/main/webapp/WEB-INF/web.xml	Wed Jun  1  
07:45:02 2011
+++ /trunk/samples/mobilewebapp/src/main/webapp/WEB-INF/web.xml	Wed Aug 24  
05:30:48 2011

@@ -1,9 +1,9 @@
 
-http://java.sun.com/dtd/web-app_2_3.dtd";>
-
-
+http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
+  http://java.sun.com/xml/ns/javaee/web-app_2_5.xsd";
+ version="2.5"
+ xmlns="http://java.sun.com/xml/ns/javaee";>

   
  
com.google.gwt.sample.gaerequest.server.GaeAuthFilter

   
   
===
---  
/trunk/user/src/com/google/gwt/user/tools/templates/sample/_warFolder_/WEB-INF/web.xmlsrc	 
Mon Mar  7 08:21:08 2011
+++  
/trunk/user/src/com/google/gwt/user/tools/templates/sample/_warFolder_/WEB-INF/web.xmlsrc	 
Wed Aug 24 05:30:48 2011

@@ -1,10 +1,10 @@
 
-http://java.sun.com/dtd/web-app_2_3.dtd";>
-
-
-
+http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
+  http://java.sun.com/xml/ns/javaee/web-app_2_5.xsd";
+ version="2.5"
+ xmlns="http://java.sun.com/xml/ns/javaee";>
+
   
   
 greetServlet

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10566 committed - Adding an example of creating a Cell that handles events. Also updated...

[codesite-noreply]

Revision: 10566
Author:   jlaba...@google.com
Date: Wed Aug 24 04:41:48 2011
Log:  Adding an example of creating a Cell that handles events. Also  
updated the existing Cell example to use SafeHtmlTemplates, which is a  
better alternative to manually appending HTML strings.  Add a comment in  
the Cell interface explaining that we may modify the Cell API in the  
future, and users should always extend AbstractCell.


Review by: rj...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10566

Added:
 /trunk/user/javadoc/com/google/gwt/examples/cell/CellWithEventsExample.java
Modified:
 /trunk/user/javadoc/com/google/gwt/examples/cell/CellExample.java
 /trunk/user/src/com/google/gwt/cell/client/AbstractCell.java
 /trunk/user/src/com/google/gwt/cell/client/Cell.java

===
--- /dev/null
+++  
/trunk/user/javadoc/com/google/gwt/examples/cell/CellWithEventsExample.java	 
Wed Aug 24 04:41:48 2011

@@ -0,0 +1,166 @@
+/*
+ * Copyright 2011 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may  
not
+ * use this file except in compliance with the License. You may obtain a  
copy of

+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,  
WITHOUT

+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations  
under

+ * the License.
+ */
+package com.google.gwt.examples.cell;
+
+import com.google.gwt.cell.client.AbstractCell;
+import com.google.gwt.cell.client.Cell;
+import com.google.gwt.cell.client.ValueUpdater;
+import com.google.gwt.core.client.EntryPoint;
+import com.google.gwt.core.client.GWT;
+import com.google.gwt.dom.client.Element;
+import com.google.gwt.dom.client.EventTarget;
+import com.google.gwt.dom.client.NativeEvent;
+import com.google.gwt.safecss.shared.SafeStyles;
+import com.google.gwt.safecss.shared.SafeStylesUtils;
+import com.google.gwt.safehtml.client.SafeHtmlTemplates;
+import com.google.gwt.safehtml.shared.SafeHtml;
+import com.google.gwt.safehtml.shared.SafeHtmlBuilder;
+import com.google.gwt.safehtml.shared.SafeHtmlUtils;
+import com.google.gwt.user.cellview.client.CellList;
+import com.google.gwt.user.client.Window;
+import com.google.gwt.user.client.ui.RootPanel;
+
+import java.util.Arrays;
+import java.util.List;
+
+/**
+ * Example of creating a custom {@link Cell} that responds to events.
+ */
+public class CellWithEventsExample implements EntryPoint {
+
+  /**
+   * A custom {@link Cell} used to render a string that contains the name  
of a

+   * color.
+   */
+  static class ColorCell extends AbstractCell {
+
+/**
+ * The HTML templates used to render the cell.
+ */
+interface Templates extends SafeHtmlTemplates {
+  /**
+   * The template for this Cell, which includes styles and a value.
+   *
+   * @param styles the styles to include in the style attribute of the  
div
+   * @param value the safe value. Since the value type is {@link  
SafeHtml},
+   *  it will not be escaped before including it in the  
template.
+   *  Alternatively, you could make the value type String, in  
which

+   *  case the value would be escaped.
+   * @return a {@link SafeHtml} instance
+   */
+  @SafeHtmlTemplates.Template("{1}")
+  SafeHtml cell(SafeStyles styles, SafeHtml value);
+}
+
+/**
+ * Create a singleton instance of the templates used to render the  
cell.

+ */
+private static Templates templates = GWT.create(Templates.class);
+
+public ColorCell() {
+  /*
+   * Sink the click and keydown events. We handle click events in this
+   * class. AbstractCell will handle the keydown event and call
+   * onEnterKeyDown() if the user presses the enter key while the cell  
is

+   * selected.
+   */
+  super("click", "keydown");
+}
+
+/**
+ * Called when an event occurs in a rendered instance of this Cell. The
+ * parent element refers to the element that contains the rendered  
cell, NOT

+ * to the outermost element that the Cell rendered.
+ */
+@Override
+public void onBrowserEvent(Context context, Element parent, String  
value, NativeEvent event,

+ValueUpdater valueUpdater) {
+  // Let AbstractCell handle the keydown event.
+  super.onBrowserEvent(context, parent, value, event, valueUpdater);
+
+  // Handle the click event.
+  if ("click".equals(event.getType())) {
+// Ignore clicks that occur outside of the outermost element.
+EventTarget eventTarget = event.getEventTarget();
+if  
(parent.getFirstChildElement().isOrHasChild(Element.as(eventTarget))) {

+  doAction(value, valueUpdater);
+}
+  }
+}
+
+

[gwt-contrib] [google-web-toolkit] r10565 committed - Collapse deferred-binding property values that depend on collapsed pro...

[codesite-noreply]

Revision: 10565
Author:   b...@google.com
Date: Wed Aug 24 04:12:01 2011
Log:  Collapse deferred-binding property values that depend on  
collapsed property values.

Patch by: bobv
Review by: rjrjr

Review at http://gwt-code-reviews.appspot.com/1525804

http://code.google.com/p/google-web-toolkit/source/detail?r=10565

Modified:
 /trunk/dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java
 /trunk/dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java
 /trunk/dev/core/test/com/google/gwt/dev/cfg/ModuleDefTest.java

===
--- /trunk/dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java	Tue  
Mar  8 09:11:26 2011
+++ /trunk/dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java	Wed Aug  
24 04:12:01 2011

@@ -31,10 +31,10 @@
 import java.util.LinkedList;
 import java.util.List;
 import java.util.Map;
+import java.util.Map.Entry;
 import java.util.Set;
 import java.util.SortedSet;
 import java.util.TreeSet;
-import java.util.Map.Entry;
 import java.util.regex.Pattern;

 /**
@@ -48,13 +48,15 @@
   private static final String EMPTY = "";

   private List> collapsedValues = Lists.create();
-  private final Map> conditionalValues = new  
LinkedHashMap>();

+  private final Map> conditionalValues =
+  new LinkedHashMap>();
   private final SortedSet definedValues = new TreeSet();
   private PropertyProvider provider;
   private Class providerGenerator;
   private String fallback;
-  private HashMap>>  
fallbackValueMap;
-  private HashMap> fallbackValues = new  
HashMap>();
+  private HashMap>>  
fallbackValueMap;

+  private HashMap> fallbackValues =
+  new HashMap>();
   private final ConditionAll rootCondition = new ConditionAll();

   {
@@ -77,8 +79,7 @@
 // Expanded in normalizeCollapsedValues()
 continue;
   } else if (!definedValues.contains(value)) {
-throw new IllegalArgumentException(
-"Attempting to collapse unknown value " + value);
+throw new IllegalArgumentException("Attempting to collapse unknown  
value " + value);

   }
 }

@@ -99,7 +100,8 @@
   }

   /**
-   * Adds fall back value to given property name.
+   * Adds fall back value to given property name.
+   *
* @param value the property value.
* @param fallbackValue the fall back value for given property value.
*/
@@ -164,13 +166,15 @@
   }

   /**
-   * Returns the map of values to fall back values. the list of fall
-   * back values is in decreasing order of preference.
+   * Returns the map of values to fall back values. the list of fall back  
values

+   * is in decreasing order of preference.
+   *
* @return map of property value to fall back values.
*/
-  public Map>>  
getFallbackValuesMap() {
+  public Map>>  
getFallbackValuesMap() {

 if (fallbackValueMap == null) {
-  HashMap>> valuesMap = new  
HashMap>>();

+  HashMap>> valuesMap =
+  new HashMap>>();
   // compute closure of fall back values preserving order
   for (Entry> e :  
fallbackValues.entrySet()) {

 String from = e.getKey();
@@ -179,8 +183,7 @@
 LinkedList childList = fallbackValues.get(from);
 LinkedHashSet children = new LinkedHashSet();
 children.addAll(childList);
-while (children != null && children.size() > 0)
-{
+while (children != null && children.size() > 0) {
   alternates.add(children);
   LinkedHashSet newChildren = new LinkedHashSet();
   for (String child : children) {
@@ -199,7 +202,7 @@
 }
 return fallbackValueMap;
   }
-
+
   public PropertyProvider getProvider() {
 return provider;
   }
@@ -262,7 +265,7 @@
* the currently-defined values.
*
* @throws IllegalArgumentException if any of the provided values were  
not

-   * provided to {@link #addDefinedValue(Condition,String)}.
+   *   provided to {@link #addDefinedValue(Condition,String)}.
*/
   public void setAllowedValues(Condition condition, String... values) {
 SortedSet temp = new TreeSet(Arrays.asList(values));
@@ -308,6 +311,29 @@
* Create a minimal number of equivalence sets, expanding any glob  
patterns.

*/
   void normalizeCollapsedValues() {
+/*
+ * Properties that depend upon a collapsed property value must be  
recombined

+ * into an equivalence set.
+ */
+if (!getRequiredProperties().isEmpty()) {
+  // This defines additional equivalence sets
+  Map>  
requiredPropertyNamesToDependentValues =

+  new HashMap>();
+  for (Map.Entry> entry :  
getConditionalValues().entrySet()) {
+for (String requiredPropertyName :  
entry.getKey().getRequiredProperties()) {
+  SortedSet set =  
requiredPropertyNamesToDependentValues.get(requiredPropertyName);

+  if (set == null) {
+set = new TreeSet();
+ 
requiredPropertyNamesToDependentValues.put(requiredPropertyName, set);

+  }
+  set.addAll(entry.getVal

[gwt-contrib] [google-web-toolkit] r10564 committed - Cherry picking r10561 into releases/2.4

[codesite-noreply]

Revision: 10564
Author:   rchan...@google.com
Date: Wed Aug 24 04:23:24 2011
Log:  Cherry picking r10561 into releases/2.4

http://code.google.com/p/google-web-toolkit/source/detail?r=10564

Modified:
 /releases/2.4/samples/mobilewebapp/pom.xml

===
--- /releases/2.4/samples/mobilewebapp/pom.xml  Tue Aug 16 10:34:01 2011
+++ /releases/2.4/samples/mobilewebapp/pom.xml  Wed Aug 24 04:23:24 2011
@@ -65,9 +65,7 @@
  of the GWT compiler.

  This dependency has a scope of "provided" so that it only gets  
used as a
- compiler dependecy. The Maven GWT Plugin does not seem to honor  
this scoping,
- though. For that reason we explicitly remove gwt-dev-*.jar from  
the produced

- artifacts later on.
+ compiler dependecy.
 -->
 
   com.google.gwt
@@ -190,8 +188,8 @@
   
 org.codehaus.mojo
 gwt-maven-plugin
-   2.2.0
-   
+2.3.0-1
+
   
 com.google.gwt
 gwt-user
@@ -207,7 +205,7 @@
 gwt-servlet
 ${gwtVersion}
   
-   
+
 

 
   
@@ -226,7 +224,7 @@
   target/www
   

   true
- com.google.gwt.sample.mobilewebapp.MobileWebApp
+  com.google.gwt.sample.mobilewebapp.MobileWebApp

   ${gae.version}
   ${gae.home}
@@ -258,7 +256,7 @@
   

   
 maven-surefire-plugin
-   2.5
+2.5
 
   
  
${project.build.sourceDirectory}

@@ -276,7 +274,7 @@
   
 
   
-
+
   
   
 maven-resources-plugin
@@ -300,9 +298,9 @@
   

   
-   maven-eclipse-plugin
-   2.8
-   
+maven-eclipse-plugin
+2.8
+
   true
   false
   2.0
@@ -315,45 +313,51 @@
  
com.google.gwt.eclipse.core.gwtNature
  
com.google.appengine.eclipse.core.gaeNature

   
-   
+
   
-
-  
-
-maven-clean-plugin
-2.3
-
-  
-default-clean
-clean
-
-  clean
-
-  
-  
-remove-gwt-dev-jar
-process-classes
-
-  clean
-
-
-  true
-  
-
-   
${project.build.directory}/${project.build.finalName}/WEB-INF/lib

-  
-gwt-dev*jar
-gwt-user*jar
-  
-
-  
-
-  
-
-  
 
+
+
+  
+

+
+  org.eclipse.m2e
+  lifecycle-mapping
+  1.0.0
+  
+
+  
+
+  
+org.datanucleus
+maven-datanucleus-plugin
+[1.1.4,)
+
+  enhance
+
+  
+  
+
+  
+
+
+  
+net.kindleit
+maven-gae-plugin
+[0.7.3,)
+
+  unpack
+
+  
+  
+
+  
+
+  
+
+  
+
+  
+
   
 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Updated header of web.xml files to use XSD version 2.5 (issue1529804)

[rdayal]

LGTM.

http://gwt-code-reviews.appspot.com/1529804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Updated header of web.xml files to use XSD version 2.5 (issue1529804)

[rchandia]

Reviewers: rdayal,

Description:
Updated header of web.xml files to use XSD version 2.5

Review by: rda...@google.com

Please review this at http://gwt-code-reviews.appspot.com/1529804/

Affected files:
  M samples/mobilewebapp/src/main/webapp/WEB-INF/web.xml
  M  
user/src/com/google/gwt/user/tools/templates/sample/_warFolder_/WEB-INF/web.xmlsrc



Index: samples/mobilewebapp/src/main/webapp/WEB-INF/web.xml
===
--- samples/mobilewebapp/src/main/webapp/WEB-INF/web.xml(revision 10561)
+++ samples/mobilewebapp/src/main/webapp/WEB-INF/web.xml(working copy)
@@ -1,9 +1,9 @@
 
-http://java.sun.com/dtd/web-app_2_3.dtd";>
-
-
+http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
+  http://java.sun.com/xml/ns/javaee/web-app_2_5.xsd";
+ version="2.5"
+ xmlns="http://java.sun.com/xml/ns/javaee";>

   
  
com.google.gwt.sample.gaerequest.server.GaeAuthFilter

   
   
Index:  
user/src/com/google/gwt/user/tools/templates/sample/_warFolder_/WEB-INF/web.xmlsrc

===
---  
user/src/com/google/gwt/user/tools/templates/sample/_warFolder_/WEB-INF/web.xmlsrc	 
(revision 10561)
+++  
user/src/com/google/gwt/user/tools/templates/sample/_warFolder_/WEB-INF/web.xmlsrc	 
(working copy)

@@ -1,10 +1,10 @@
 
-http://java.sun.com/dtd/web-app_2_3.dtd";>
+http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
+  http://java.sun.com/xml/ns/javaee/web-app_2_5.xsd";
+ version="2.5"
+ xmlns="http://java.sun.com/xml/ns/javaee";>

-
-
   
   
 greetServlet


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Prevents double-escaping of characters by keeping Window.createUrlBuilder() consistent with UrlB... (issue1528805)

[jlabanca]

LGTM

http://gwt-code-reviews.appspot.com/1528805/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Firefox 6 DevMode Plugin (issue1523805)

[conroy]

in plugin-sdks:

please add the appropriate toplevel README as well as the README for the
Darwin modifications.

speaking of which, I don't see the Darwin modifications. js-config and
mozilla-config need to be made universal using FLAG32BIT.

you're missing libxpcomglue_s.a for Darwin, and all of both Linux lib/
directories--looks like you hit the same codesite bug as me there.

You didn't set the version properly: it should be 1.0.


http://gwt-code-reviews.appspot.com/1523805/diff/1/plugins/xpcom/version
File plugins/xpcom/version (right):

http://gwt-code-reviews.appspot.com/1523805/diff/1/plugins/xpcom/version#newcode1
plugins/xpcom/version:1: 0.0.3745.20110823
this file hasn't been touched in a long time. not sure why your setup is
different, but this is an obsolete file. please just delete it.

http://gwt-code-reviews.appspot.com/1523805/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors