[gwt-contrib] Re: Converts the validation sample to build with maven. (issue1537805)

2011-09-08 Thread Nick Chalko 
>  org.hibernate.validator.**constraints.impl.**ScriptAssertValidator
>>
>
>
> So ScriptAssertValidator should not be getting compiled.  Let me try to
> find where it is excluded.
>

user/src/org/hibernate/validator/HibernateValidator.gwt.xml  excludes that
file with.

  





  

Not sure why this is not used.

-- 
Nick Chalko | Software Engineer | ncha...@google.com |   :-)

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Converts the validation sample to build with maven. (issue1537805)

2011-09-08 Thread Nick Chalko 
On Thu, Sep 8, 2011 at 5:00 PM,  wrote:

> Getting closer, still not ready for review.
>
> I learned how to pull in both the binary and the source for hibernate
> validator. Now getting the app's "An error occurred" dialog when
> sending, nothing in the console.
>
> At launch still seeing the ClassNotFound exception below.
>
> Will debug in the morning, but if anyone has clue to share in the
> meantime I'll be obliged.
>
>
> 00:00:30.295  [SPAM] Resolving
>
> org.hibernate.validator.**constraints.ScriptAssert
>  00:00:30.296  [SPAM] Found type
>
> 'org.hibernate.validator.**constraints.ScriptAssert'
>00:00:30.296  [ERROR] Annotation error: cannot resolve
>
> org.hibernate.validator.**constraints.impl.**ScriptAssertValidator
>


So ScriptAssertValidator should not be getting compiled.  Let me try to find
where it is excluded.

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Converts the validation sample to build with maven. (issue1537805)

2011-09-08 Thread rjrjr 

Getting closer, still not ready for review.

I learned how to pull in both the binary and the source for hibernate
validator. Now getting the app's "An error occurred" dialog when
sending, nothing in the console.

At launch still seeing the ClassNotFound exception below.

Will debug in the morning, but if anyone has clue to share in the
meantime I'll be obliged.


00:00:30.295  [SPAM] Resolving
org.hibernate.validator.constraints.ScriptAssert
  00:00:30.296  [SPAM] Found type
'org.hibernate.validator.constraints.ScriptAssert'
00:00:30.296  [ERROR] Annotation error: cannot resolve
org.hibernate.validator.constraints.impl.ScriptAssertValidator
java.lang.ClassNotFoundException:
org.hibernate.validator.constraints.impl.ScriptAssertValidator
at java.net.URLClassLoader$1.run(URLClassLoader.java:202)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301)
at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:247)
at
com.google.gwt.dev.javac.TypeOracleMediator.resolveAnnotationValue(TypeOracleMediator.java:750)
at
com.google.gwt.dev.javac.TypeOracleMediator.resolveAnnotationValue(TypeOracleMediator.java:689)
at
com.google.gwt.dev.javac.TypeOracleMediator.createAnnotation(TypeOracleMediator.java:498)
at
com.google.gwt.dev.javac.TypeOracleMediator.resolveAnnotation(TypeOracleMediator.java:648)
at
com.google.gwt.dev.javac.TypeOracleMediator.resolveAnnotations(TypeOracleMediator.java:663)
at
com.google.gwt.dev.javac.TypeOracleMediator.resolveClass(TypeOracleMediator.java:809)
at
com.google.gwt.dev.javac.TypeOracleMediator.addNewTypes(TypeOracleMediator.java:439)
at
com.google.gwt.dev.javac.TypeOracleMediatorFromSource.addNewUnits(TypeOracleMediatorFromSource.java:52)
at
com.google.gwt.dev.javac.CompilationState.assimilateUnits(CompilationState.java:164)
at
com.google.gwt.dev.javac.CompilationState.(CompilationState.java:82)
at
com.google.gwt.dev.javac.CompilationStateBuilder.doBuildFrom(CompilationStateBuilder.java:450)
at
com.google.gwt.dev.javac.CompilationStateBuilder.buildFrom(CompilationStateBuilder.java:370)
at
com.google.gwt.dev.cfg.ModuleDef.getCompilationState(ModuleDef.java:360)
at
com.google.gwt.dev.DevModeBase$UiBrowserWidgetHostImpl.createModuleSpaceHost(DevModeBase.java:110)
at
com.google.gwt.dev.shell.OophmSessionHandler.loadModule(OophmSessionHandler.java:197)
at
com.google.gwt.dev.shell.BrowserChannelServer.processConnection(BrowserChannelServer.java:525)
at
com.google.gwt.dev.shell.BrowserChannelServer.run(BrowserChannelServer.java:363)
at java.lang.Thread.run(Thread.java:680)00:00:30.297  [ERROR]
Annotation error: expected class java.lang.Class, got null


http://gwt-code-reviews.appspot.com/1537805/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Converts the validation sample to build with maven. (issue1537805)

2011-09-08 Thread rjrjr 

http://gwt-code-reviews.appspot.com/1537805/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Converts the validation sample to build with maven. (issue1537805)

2011-09-08 Thread rjrjr 

http://gwt-code-reviews.appspot.com/1537805/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Converts the validation sample to build with maven. (issue1537805)

2011-09-08 Thread rjrjr 

I'm stuck.

At runtime in dev mode (when I send a name to be validated from the
client), I'm getting "No source code is available" errors for the
hibernate validators. e.g.

00:00:57.069  [ERROR] Errors in
'/Users/rjrjr/src/gwt-g5/google3/third_party/java_src/gwt/svn/trunk/samples/validation/target/.generated/com/google/gwt/sample/validation/shared/_PersonValidatorImpl.java'
  00:00:57.069  [ERROR] Line 36: No source code is available for type
org.hibernate.validator.constraints.impl.SizeValidatorForString; did you
forget to inherit a required module?
  00:00:57.069  [ERROR] Line 36: No source code is available for type
org.hibernate.validator.constraints.impl.SizeValidatorForCollection; did
you forget to inherit a required module?
  00:00:57.069  [ERROR] Line 36: No source code is available for type
org.hibernate.validator.constraints.impl.SizeValidatorForMap; did you
forget to inherit a required module?
  00:00:57.070  [ERROR] Line 57: No source code is available for type
org.hibernate.validator.constraints.impl.NotNullValidator; did you
forget to inherit a required module?
  00:00:57.070  [ERROR] Line 87: No source code is available for type
org.hibernate.validator.constraints.impl.MaxValidatorForNumber; did you
forget to inherit a required module?
  00:00:57.070  [ERROR] Line 87: No source code is available for type
org.hibernate.validator.constraints.impl.MaxValidatorForString; did you
forget to inherit a required module?

And maybe this is a clue, or just noise -- on launch I see this
complaint:

00:00:08.075  [SPAM] Resolving
org.hibernate.validator.constraints.ScriptAssert
  00:00:08.075  [SPAM] Found type
'org.hibernate.validator.constraints.ScriptAssert'
00:00:08.075  [ERROR] Annotation error: cannot resolve
org.hibernate.validator.constraints.impl.ScriptAssertValidator
java.lang.ClassNotFoundException:
org.hibernate.validator.constraints.impl.ScriptAssertValidator
at java.net.URLClassLoader$1.run(URLClassLoader.java:202)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301)
at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:247)
at
com.google.gwt.dev.javac.TypeOracleMediator.resolveAnnotationValue(TypeOracleMediator.java:750)
at
com.google.gwt.dev.javac.TypeOracleMediator.resolveAnnotationValue(TypeOracleMediator.java:689)
at
com.google.gwt.dev.javac.TypeOracleMediator.createAnnotation(TypeOracleMediator.java:498)
at
com.google.gwt.dev.javac.TypeOracleMediator.resolveAnnotation(TypeOracleMediator.java:648)
at
com.google.gwt.dev.javac.TypeOracleMediator.resolveAnnotations(TypeOracleMediator.java:663)
at
com.google.gwt.dev.javac.TypeOracleMediator.resolveClass(TypeOracleMediator.java:809)
at
com.google.gwt.dev.javac.TypeOracleMediator.addNewTypes(TypeOracleMediator.java:439)
at
com.google.gwt.dev.javac.TypeOracleMediatorFromSource.addNewUnits(TypeOracleMediatorFromSource.java:52)
at
com.google.gwt.dev.javac.CompilationState.assimilateUnits(CompilationState.java:164)
at
com.google.gwt.dev.javac.CompilationState.(CompilationState.java:82)
at
com.google.gwt.dev.javac.CompilationStateBuilder.doBuildFrom(CompilationStateBuilder.java:450)
at
com.google.gwt.dev.javac.CompilationStateBuilder.buildFrom(CompilationStateBuilder.java:370)
at
com.google.gwt.dev.cfg.ModuleDef.getCompilationState(ModuleDef.java:360)
at
com.google.gwt.dev.DevModeBase$UiBrowserWidgetHostImpl.createModuleSpaceHost(DevModeBase.java:110)
at
com.google.gwt.dev.shell.OophmSessionHandler.loadModule(OophmSessionHandler.java:197)
at
com.google.gwt.dev.shell.BrowserChannelServer.processConnection(BrowserChannelServer.java:525)
at
com.google.gwt.dev.shell.BrowserChannelServer.run(BrowserChannelServer.java:363)
at java.lang.Thread.run(Thread.java:680)00:00:08.075  [ERROR]
Annotation error: expected class java.lang.Class, got null


http://gwt-code-reviews.appspot.com/1537805/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Converts the validation sample to build with maven. (issue1537805)

2011-09-08 Thread rjrjr 

Reviewers: drfibonacci, rchandia,

Description:
Converts the validation sample to build with maven.


Please review this at http://gwt-code-reviews.appspot.com/1537805/

Affected files:
  D eclipse/samples/Validation/.checkstyle
  D eclipse/samples/Validation/.classpath
  D eclipse/samples/Validation/.project
  D eclipse/samples/Validation/Validation-gwtc.launch
  D eclipse/samples/Validation/Validation.launch
  M samples/build.xml
  A samples/validation/README-MAVEN.txt
  M samples/validation/build.xml
  A samples/validation/pom.xml
  D samples/validation/src/com/google/gwt/sample/validation/COPYING
  D  
samples/validation/src/com/google/gwt/sample/validation/Validation.gwt.xml
  D  
samples/validation/src/com/google/gwt/sample/validation/client/CustomValidationMessagesResolver.java
  D  
samples/validation/src/com/google/gwt/sample/validation/client/GreetingService.java
  D  
samples/validation/src/com/google/gwt/sample/validation/client/GreetingServiceAsync.java
  D  
samples/validation/src/com/google/gwt/sample/validation/client/SampleValidatorFactory.java
  D  
samples/validation/src/com/google/gwt/sample/validation/client/Validation.java
  D  
samples/validation/src/com/google/gwt/sample/validation/client/ValidationMessages.java
  D  
samples/validation/src/com/google/gwt/sample/validation/client/ValidationMessages.properties
  D  
samples/validation/src/com/google/gwt/sample/validation/client/ValidationView.java
  D  
samples/validation/src/com/google/gwt/sample/validation/client/ValidationView.ui.xml
  D  
samples/validation/src/com/google/gwt/sample/validation/server/GreetingServiceImpl.java
  D  
samples/validation/src/com/google/gwt/sample/validation/shared/Address.java
  D  
samples/validation/src/com/google/gwt/sample/validation/shared/ClientGroup.java

  D samples/validation/src/com/google/gwt/sample/validation/shared/NoOp.java
  D  
samples/validation/src/com/google/gwt/sample/validation/shared/NoOpValidator.java
  D  
samples/validation/src/com/google/gwt/sample/validation/shared/Person.java
  D  
samples/validation/src/com/google/gwt/sample/validation/shared/ServerConstraint.java
  D  
samples/validation/src/com/google/gwt/sample/validation/shared/ServerGroup.java
  D  
samples/validation/src/com/google/gwt/sample/validation/shared/ServerValidator.java

  D samples/validation/src/com/google/gwt/sample/validation/shared/Zip.java
  D  
samples/validation/src/com/google/gwt/sample/validation/super/com/google/gwt/sample/validation/shared/ServerValidator.java
  A  
samples/validation/src/main/java/com/google/gwt/sample/validation/COPYING
  A  
samples/validation/src/main/java/com/google/gwt/sample/validation/Validation.gwt.xml
  A  
samples/validation/src/main/java/com/google/gwt/sample/validation/client/CustomValidationMessagesResolver.java
  A  
samples/validation/src/main/java/com/google/gwt/sample/validation/client/GreetingService.java
  A  
samples/validation/src/main/java/com/google/gwt/sample/validation/client/GreetingServiceAsync.java
  A  
samples/validation/src/main/java/com/google/gwt/sample/validation/client/SampleValidatorFactory.java
  A  
samples/validation/src/main/java/com/google/gwt/sample/validation/client/Validation.java
  A  
samples/validation/src/main/java/com/google/gwt/sample/validation/client/ValidationMessages.java
  A  
samples/validation/src/main/java/com/google/gwt/sample/validation/client/ValidationMessages.properties
  A  
samples/validation/src/main/java/com/google/gwt/sample/validation/client/ValidationView.java
  A  
samples/validation/src/main/java/com/google/gwt/sample/validation/client/ValidationView.ui.xml
  A  
samples/validation/src/main/java/com/google/gwt/sample/validation/server/GreetingServiceImpl.java
  A  
samples/validation/src/main/java/com/google/gwt/sample/validation/shared/Address.java
  A  
samples/validation/src/main/java/com/google/gwt/sample/validation/shared/ClientGroup.java
  A  
samples/validation/src/main/java/com/google/gwt/sample/validation/shared/NoOp.java
  A  
samples/validation/src/main/java/com/google/gwt/sample/validation/shared/NoOpValidator.java
  A  
samples/validation/src/main/java/com/google/gwt/sample/validation/shared/Person.java
  A  
samples/validation/src/main/java/com/google/gwt/sample/validation/shared/ServerConstraint.java
  A  
samples/validation/src/main/java/com/google/gwt/sample/validation/shared/ServerGroup.java
  A  
samples/validation/src/main/java/com/google/gwt/sample/validation/shared/ServerValidator.java
  A  
samples/validation/src/main/java/com/google/gwt/sample/validation/shared/Zip.java
  A  
samples/validation/src/main/resources/com/google/gwt/sample/validation/SuperSource.gwt.xml
  A  
samples/validation/src/main/resources/com/google/gwt/sample/validation/super/com/google/gwt/sample/validation/shared/ServerValidator.java

  A samples/validation/src/main/webapp/Validation.css
  A samples/validation/src/main/webapp/Validation.html
  D samples/validation/war/Validation.css
  D samples/validation/war

[gwt-contrib] [google-web-toolkit] r10637 committed - Integrates r10634 to releases/2.4, fix breakage from DynaTableRf maven...

2011-09-08 Thread codesite-noreply 

Revision: 10637
Author:   rj...@google.com
Date: Thu Sep  8 12:26:49 2011
Log:  Integrates r10634 to releases/2.4, fix breakage from DynaTableRf  
maven conversion


http://code.google.com/p/google-web-toolkit/source/detail?r=10637

Added:
 /releases/2.4/samples/dynatablerf/build.xml
Modified:
 /releases/2.4/samples/build.xml

===
--- /dev/null
+++ /releases/2.4/samples/dynatablerf/build.xml Thu Sep  8 12:26:49 2011
@@ -0,0 +1,11 @@
+
+  
+  
+  
+  
+  
+  
+  
+  
+  
+
===
--- /releases/2.4/samples/build.xml Wed Jun  1 08:59:33 2011
+++ /releases/2.4/samples/build.xml Thu Sep  8 12:26:49 2011
@@ -11,7 +11,7 @@
   

   
-
+
   

   

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Deprecate DeferredCommand and IncrementalCommand. (issue982802)

2011-09-08 Thread Ray Ryan 
This isn't a release notes issue. The deprecation happened quite a while
ago. DevGuideCodingBasicsDelayed.html is very, very out of date.

On Thu, Sep 8, 2011 at 3:31 PM, Doug Anderson  wrote:

> Eric:
>
> I can note this and any other deprecation you want in the release notes for
> next release, say 2.5  (or, if anything was deprecated for 2.4 and we missed
> it, I can also update the 2.4 notes!).
>
> The actual Javadoc is maintained by you folks, so any changes you want in
> that needs to be made at your end, I'm pretty sure.
>
> Doug
>
>
>
> On Thu, Sep 8, 2011 at 3:01 PM, Eric Ayers  wrote:
>
>>
>> http://google-web-toolkit.googlecode.com/svn/javadoc/latest/com/google/gwt/user/client/DeferredCommand.html
>>
>> has a pointer to the blessed alternative (Scheduler).
>>
>> @Doug, can you flag this page as needing an update?
>>
>> On Thu, Sep 8, 2011 at 4:43 PM,  wrote:
>>
>>> Since this is deprecated what is the alternative to these classes?
>>>
>>> The documentation continues to provide these as examples.
>>> http://code.google.com/**webtoolkit/doc/latest/**
>>> DevGuideCodingBasicsDelayed.**html
>>>
>>> On 2010/10/13 17:13:43, rjrjr wrote:
>>>
 On Wed, Oct 13, 2010 at 5:28 AM,  wrote:

>>>
>>>  >
 > http://gwt-code-reviews.**appspot.com/982802/diff/1/5
 > File user/src/com/google/gwt/user/**client/DeferredCommand.java

>>> (right):
>>>
 >
 > http://gwt-code-reviews.**appspot.com/982802/diff/1/5#**newcode27
 > user/src/com/google/gwt/user/**client/DeferredCommand.java:**27: *
 >  API prevents effective mocking.
 > On 2010/10/13 03:50:36, rjrjr wrote:
 >
 >> I thought it was deprecated because it was redundant...TMI?
 >>
 >
 > IMHO, I don't think you can give too much information on the impetus
 > behind this change.  Its going to be painful to see all those
 > deprecation warnings come out the first time for most users.

>>>
>>>
>>>  We might want to provide more justification then. We're not just

>>> deprecating
>>>
 the thing for mockability, it's redundant code, right?

>>>
>>>  >
 >
 > http://gwt-code-reviews.**appspot.com/982802/show
 >

>>>
>>>
>>>
>>> http://gwt-code-reviews.**appspot.com/982802/
>>>
>>
>>
>>
>> --
>> Eric Ayers | Software Engineer | zun...@google.com | +1 404 487 9229
>>
>>
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] less name mangling

2011-09-08 Thread Stephen Haberman 

> That is exactly what I was getting at in the earlier discussion --
> conversion to a source name (which this essentially is, just
> separated at the dots for you) is lossy.

Right, that is primarily what my patch is attempting to fix. This
was one the spot (...well, deferred binding aside) I hadn't seen
a way to avoid it yet.

However, since the source name is already correctly split by "."
(instead of just hueristically splitting on all dots) we can use
the compiler as the, as you said, lookup oracle, so, after thinking
about it, it's possible to do this deterministically:

https://github.com/stephenh/scalagwt-gwt/commit/b1975fb1009fdae6fde847752fef1a37a5441b1e

I'll do some more sanity checking and then upload a new patchset if
this works out.

- Stephen

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Deprecate DeferredCommand and IncrementalCommand. (issue982802)

2011-09-08 Thread Eric Ayers 
http://google-web-toolkit.googlecode.com/svn/javadoc/latest/com/google/gwt/user/client/DeferredCommand.html

has a pointer to the blessed alternative (Scheduler).

@Doug, can you flag this page as needing an update?

On Thu, Sep 8, 2011 at 4:43 PM,  wrote:

> Since this is deprecated what is the alternative to these classes?
>
> The documentation continues to provide these as examples.
> http://code.google.com/**webtoolkit/doc/latest/**
> DevGuideCodingBasicsDelayed.**html
>
> On 2010/10/13 17:13:43, rjrjr wrote:
>
>> On Wed, Oct 13, 2010 at 5:28 AM,  wrote:
>>
>
>  >
>> > http://gwt-code-reviews.**appspot.com/982802/diff/1/5
>> > File user/src/com/google/gwt/user/**client/DeferredCommand.java
>>
> (right):
>
>> >
>> > http://gwt-code-reviews.**appspot.com/982802/diff/1/5#**newcode27
>> > user/src/com/google/gwt/user/**client/DeferredCommand.java:**27: *
>> >  API prevents effective mocking.
>> > On 2010/10/13 03:50:36, rjrjr wrote:
>> >
>> >> I thought it was deprecated because it was redundant...TMI?
>> >>
>> >
>> > IMHO, I don't think you can give too much information on the impetus
>> > behind this change.  Its going to be painful to see all those
>> > deprecation warnings come out the first time for most users.
>>
>
>
>  We might want to provide more justification then. We're not just
>>
> deprecating
>
>> the thing for mockability, it's redundant code, right?
>>
>
>  >
>> >
>> > http://gwt-code-reviews.**appspot.com/982802/show
>> >
>>
>
>
>
> http://gwt-code-reviews.**appspot.com/982802/
>



-- 
Eric Ayers | Software Engineer | zun...@google.com | +1 404 487 9229

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10636 committed - Fix http://code.google.com/p/google-web-toolkit/issues/detail?id=6161...

2011-09-08 Thread codesite-noreply 

Revision: 10636
Author:   rj...@google.com
Date: Thu Sep  8 10:49:11 2011
Log:  Fix  
http://code.google.com/p/google-web-toolkit/issues/detail?id=6161

by dying on suspicious looking namespaces. Also keep
StackLayoutPanelParser from generating bad code for such things.

Review at http://gwt-code-reviews.appspot.com/1520807

Review by: mros...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10636

Modified:
 /trunk/user/src/com/google/gwt/uibinder/elementparsers/HtmlInterpreter.java
  
/trunk/user/src/com/google/gwt/uibinder/elementparsers/StackPanelParser.java

 /trunk/user/src/com/google/gwt/uibinder/rebind/XMLElement.java
  
/trunk/user/test/com/google/gwt/uibinder/elementparsers/StackPanelParserTest.java
  
/trunk/user/test/com/google/gwt/uibinder/rebind/UiBinderParserUiWithTest.java


===
---  
/trunk/user/src/com/google/gwt/uibinder/elementparsers/HtmlInterpreter.java	 
Thu Aug 18 06:20:28 2011
+++  
/trunk/user/src/com/google/gwt/uibinder/elementparsers/HtmlInterpreter.java	 
Thu Sep  8 10:49:11 2011

@@ -130,6 +130,12 @@
 if (writer.isImportedElement(elem)) {
   writer.die(elem, "Not allowed in an HTML context");
 }
+
+if (elem.getNamespaceUri() != null && !writer.isBinderElement(elem)) {
+  // It's not a widget, and it's not a ui: element.
+  writer.die(elem, "Prefix \"%s:\" has unrecognized xmlns \"%s\" (bad  
import?)",

+elem.getPrefix(), elem.getNamespaceUri());
+}

 return pipe.interpretElement(elem);
   }
===
---  
/trunk/user/src/com/google/gwt/uibinder/elementparsers/StackPanelParser.java	 
Thu May  5 09:42:56 2011
+++  
/trunk/user/src/com/google/gwt/uibinder/elementparsers/StackPanelParser.java	 
Thu Sep  8 10:49:11 2011

@@ -31,7 +31,10 @@
   UiBinderWriter writer) throws UnableToCompleteException {
 // Parse children.
 for (XMLElement child : elem.consumeChildElements()) {
-
+  if (!writer.isWidgetElement(child)) {
+writer.die(child, "Widget required");
+  }
+
   // Stack panel label comes from the StackPanel-text attribute of the  
child

   String stackItemLabel = null;
   String variableAttributeName = elem.getPrefix() + ":" +  
ATTRIBUTE_TEXT;

===
--- /trunk/user/src/com/google/gwt/uibinder/rebind/XMLElement.java	Thu Aug  
18 06:20:28 2011
+++ /trunk/user/src/com/google/gwt/uibinder/rebind/XMLElement.java	Thu Sep   
8 10:49:11 2011

@@ -773,11 +773,6 @@
   public String getNamespaceUri() {
 return elem.getNamespaceURI();
   }
-
-  public String getNamespaceUriForAttribute(String fieldName) {
-Attr attr = elem.getAttributeNode(fieldName);
-return attr.getNamespaceURI();
-  }

   /**
* Returns the parent element, or null if parent is null or a node type  
other

===
---  
/trunk/user/test/com/google/gwt/uibinder/elementparsers/StackPanelParserTest.java	 
Tue Aug 31 08:46:42 2010
+++  
/trunk/user/test/com/google/gwt/uibinder/elementparsers/StackPanelParserTest.java	 
Thu Sep  8 10:49:11 2011

@@ -15,8 +15,12 @@
  */
 package com.google.gwt.uibinder.elementparsers;

+import com.google.gwt.core.ext.UnableToCompleteException;
+
 import junit.framework.TestCase;

+import org.xml.sax.SAXParseException;
+
 import java.util.Iterator;

 /**
@@ -34,7 +38,7 @@
 tester = new ElementParserTester(PARSED_TYPE, new StackPanelParser());
   }

-  public void testHappy_noStackText() throws Exception {
+  public void testHappy_noStackText() throws SAXParseException,  
UnableToCompleteException {

 StringBuffer b = new StringBuffer();
 b.append("");
 b.append("  ");
@@ -45,7 +49,7 @@
 assertStatements("fieldName.add();");
   }

-  public void testHappy_hasStackText() throws Exception {
+  public void testHappy_hasStackText() throws SAXParseException,  
UnableToCompleteException {

 StringBuffer b = new StringBuffer();
 b.append("");
 b.append("  ");
@@ -55,6 +59,19 @@

 assertStatements("fieldName.add(, \"Foo\");");
   }
+
+  public void testBadChild() throws SAXParseException {
+StringBuffer b = new StringBuffer();
+b.append("");
+b.append("  ");
+b.append("");
+try {
+  tester.parse(b.toString());
+  fail("Expected UnableToCompleteException");
+} catch (UnableToCompleteException e) {
+  /* pass */
+}
+  }

   private void assertStatements(String... expected) {
 Iterator i = tester.writer.statements.iterator();
===
---  
/trunk/user/test/com/google/gwt/uibinder/rebind/UiBinderParserUiWithTest.java	 
Wed Sep  7 09:32:44 2011
+++  
/trunk/user/test/com/google/gwt/uibinder/rebind/UiBinderParserUiWithTest.java	 
Thu Sep  8 10:49:11 2011

@@ -141,7 +141,6 @@

   private UiBinderWriter writer;

-  @SuppressWarnings("deprecation")
   @Override
   public void setUp() throws Exception {
 super.setUp();

--
http://groups.googl

[gwt-contrib] Re: Scripts and configuration to upload GWT bits to Maven repos (issue1520810)

2011-09-08 Thread rchandia 

http://gwt-code-reviews.appspot.com/1520810/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixes ant build of DynatableRf sample (issue1537804)

2011-09-08 Thread rchandia 

Submitted as r10634

http://gwt-code-reviews.appspot.com/1537804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10634 committed - Fixes ant build of DynatableRf sample...

2011-09-08 Thread codesite-noreply 

Revision: 10634
Author:   rchan...@google.com
Date: Thu Sep  8 10:23:31 2011
Log:  Fixes ant build of DynatableRf sample

Review at http://gwt-code-reviews.appspot.com/1537804

http://code.google.com/p/google-web-toolkit/source/detail?r=10634

Added:
 /trunk/samples/dynatablerf/build.xml
Modified:
 /trunk/samples/build.xml

===
--- /dev/null
+++ /trunk/samples/dynatablerf/build.xmlThu Sep  8 10:23:31 2011
@@ -0,0 +1,11 @@
+
+  
+  
+  
+  
+  
+  
+  
+  
+  
+
===
--- /trunk/samples/build.xmlWed Jun  1 08:59:33 2011
+++ /trunk/samples/build.xmlThu Sep  8 10:23:31 2011
@@ -11,7 +11,7 @@
   

   
-
+
   

   

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Scripts and configuration to upload GWT bits to Maven repos (issue1520810)

2011-09-08 Thread rchandia 

http://gwt-code-reviews.appspot.com/1520810/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Scripts and configuration to upload GWT bits to Maven repos (issue1520810)

2011-09-08 Thread drfibonacci 

POM changes done, rchandia still working on script exit conditions


http://gwt-code-reviews.appspot.com/1520810/diff/1/maven/poms/gwt/gwt-soyc-vis/pom-template.xml
File maven/poms/gwt/gwt-soyc-vis/pom-template.xml (right):

http://gwt-code-reviews.appspot.com/1520810/diff/1/maven/poms/gwt/gwt-soyc-vis/pom-template.xml#newcode12
maven/poms/gwt/gwt-soyc-vis/pom-template.xml:12:
gwt-soyc-vis
On 2011/09/01 08:34:53, tbroyer wrote:

I thought gwt-soyc-vis had disappeared?


Done.

http://gwt-code-reviews.appspot.com/1520810/diff/12001/maven/poms/gwt/gwt-user/pom-template.xml
File maven/poms/gwt/gwt-user/pom-template.xml (right):

http://gwt-code-reviews.appspot.com/1520810/diff/12001/maven/poms/gwt/gwt-user/pom-template.xml#newcode20
maven/poms/gwt/gwt-user/pom-template.xml:20: 
On 2011/09/07 16:24:50, rjrjr wrote:

out-dent


Done.

http://gwt-code-reviews.appspot.com/1520810/diff/12001/maven/poms/requestfactory/pom-template.xml
File maven/poms/requestfactory/pom-template.xml (right):

http://gwt-code-reviews.appspot.com/1520810/diff/12001/maven/poms/requestfactory/pom-template.xml#newcode25
maven/poms/requestfactory/pom-template.xml:25:
javax.validation
On 2011/09/07 16:34:52, tbroyer wrote:

Should probably be only in requestfactory-server, as it's not used at

all by

requestfactory-client or requestfactory-apt


javax.validation is imported in shared/Receiver and
shared/FanoutReceiver, which are included in the client jar. But it's
not used in apt, so moving down to client and server only.

http://gwt-code-reviews.appspot.com/1520810/diff/12001/maven/poms/requestfactory/pom-template.xml#newcode30
maven/poms/requestfactory/pom-template.xml:30:
org.json
On 2011/09/07 16:34:52, tbroyer wrote:

Should probably be only in a dependencyManagement section, and called

out in

requestfactory-client and requestfactory-server, as requestfactory-apt

doesn't

need it.


Done.

http://gwt-code-reviews.appspot.com/1520810/diff/9005/maven/README.txt
File maven/README.txt (right):

http://gwt-code-reviews.appspot.com/1520810/diff/9005/maven/README.txt#newcode5
maven/README.txt:5: > ant clean dist
On 2011/09/07 16:34:52, tbroyer wrote:

dist-dev should be enough and speed the process a whole lot by not

compiling and

packaging the tools and samples.



(I haven't checked which part builds the javadoc though)


Done.

http://gwt-code-reviews.appspot.com/1520810/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixes ant build of DynatableRf sample (issue1537804)

2011-09-08 Thread rjrjr 

On 2011/09/08 18:43:20, rchandia wrote:

LGTM

http://gwt-code-reviews.appspot.com/1537804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fixes ant build of DynatableRf sample (issue1537804)

2011-09-08 Thread rchandia 

Reviewers: unnurg, rjrjr,

Description:
Fixes ant build of DynatableRf sample


Please review this at http://gwt-code-reviews.appspot.com/1537804/

Affected files:
  M samples/build.xml
  A samples/dynatablerf/build.xml


Index: samples/build.xml
===
--- samples/build.xml   (revision 10633)
+++ samples/build.xml   (working copy)
@@ -11,7 +11,7 @@
   

   
-
+
   

   
Index: samples/dynatablerf/build.xml
===
--- samples/dynatablerf/build.xml   (revision 0)
+++ samples/dynatablerf/build.xml   (revision 0)
@@ -0,0 +1,11 @@
+
+  
+  
+  
+  
+  
+  
+  
+  
+  
+


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] less name mangling

2011-09-08 Thread John Tamplin 
On Thu, Sep 8, 2011 at 1:36 PM, Stephen Haberman  wrote:

> For some reason when I put it in, I thought it would be easy to come
> back later and fix. But that is not turning out to be the case.
>
> I really expected qualifiedRef to be a "regular" compound name, e.g.
> [foo, Bar$Zaz], but instead it is [foo, Bar, Zaz].
>

That is exactly what I was getting at in the earlier discussion --
conversion to a source name (which this essentially is, just separated at
the dots for you) is lossy.  You cannot convert it back to a binary or
internal name without some lookup oracle to tell you whether foo.Bar is a
package or a class.

-- 
John A. Tamplin
Software Engineer (GWT), Google

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] less name mangling

2011-09-08 Thread Stephen Haberman 

> http://gwt-code-reviews.appspot.com/1542804/

Well. I'm stuck on this TODO:

https://github.com/stephenh/scalagwt-gwt/blob/lessnamemangling/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java#L106

For some reason when I put it in, I thought it would be easy to come
back later and fix. But that is not turning out to be the case.

I really expected qualifiedRef to be a "regular" compound name, e.g.
[foo, Bar$Zaz], but instead it is [foo, Bar, Zaz].

In general, I'm finding Eclipse's char[][] compound names to be
confusing; I initially thought they could always be converted into
binary names with a simple join, like I've confirmed for this case:

https://github.com/stephenh/scalagwt-gwt/blob/lessnamemangling/dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java#L633

...but not the qualified references. And I don't see a nice way to do
lookups by source name in the LookupEnvironment, which I imagine is
why JdtCompiler.resolveType exists (which uses name mangling).

So...if anyone has any ideas, I'd greatly appreciate it. Otherwise
I'll stare at it for a few days and see what happens.

- Stephen

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] maven source jars

2011-09-08 Thread Jeff Larsen 
Are you interested in an  ant build target that pushes gwt builds into your
local repo? If so, I've got that setup on my machine locally, and with some
minor tweeks to it, I could use what you guys have for your push script.

I've found it useful for myself.

On Thu, Sep 8, 2011 at 12:13 PM, David Chandler wrote:

> Maven push scripts are up for review, still making small tweaks:
>
> http://gwt-code-reviews.appspot.com/1520810/
>
>
> On Wed, Aug 31, 2011 at 3:37 PM, Stephen Haberman <
> stephen.haber...@gmail.com> wrote:
>
>>
>> > so renaming it without regenerating or stripping the JarIndex
>> > (META-INF/INDEX.LIST) generates spurious exceptions in DevMode
>>
>> So that's what been causing that for me--I never would have thought
>> renaming the jar file would be a problem. Thanks for pointing that
>> out!
>>
>> - Stephen
>>
>>
>> --
>> http://groups.google.com/group/Google-Web-Toolkit-Contributors
>>
>
>
>
> --
> David Chandler
> Developer Programs Engineer, GWT+GAE
> w: http://code.google.com/
> b: http://turbomanage.wordpress.com/
> b: http://googlewebtoolkit.blogspot.com/
> t: @googledevtools
>
>  --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] maven source jars

2011-09-08 Thread David Chandler 
Maven push scripts are up for review, still making small tweaks:

http://gwt-code-reviews.appspot.com/1520810/

On Wed, Aug 31, 2011 at 3:37 PM, Stephen Haberman <
stephen.haber...@gmail.com> wrote:

>
> > so renaming it without regenerating or stripping the JarIndex
> > (META-INF/INDEX.LIST) generates spurious exceptions in DevMode
>
> So that's what been causing that for me--I never would have thought
> renaming the jar file would be a problem. Thanks for pointing that
> out!
>
> - Stephen
>
>
> --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
>



-- 
David Chandler
Developer Programs Engineer, GWT+GAE
w: http://code.google.com/
b: http://turbomanage.wordpress.com/
b: http://googlewebtoolkit.blogspot.com/
t: @googledevtools

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Re: Convert DynaTableRF to use maven. Clean up the docs in the other two (issue1537803)

2011-09-08 Thread Hilco Wijbenga 
On 8 September 2011 09:41, Ray Ryan  wrote:
> On Thu Sep 08 08:52:42 GMT-700 2011,  wrote:
>>
>> LGTM
>>
>> No changes needed. Nice Mavenizing!
>
> Thanks. I can copy and paste with the best of them.
>>
>>
>> http://gwt-code-reviews.appspot.com/1537803/diff/3001/samples/dynatablerf/pom.xml
>> File samples/dynatablerf/pom.xml (right):
>>
>>
>> http://gwt-code-reviews.appspot.com/1537803/diff/3001/samples/dynatablerf/pom.xml#newcode26
>> samples/dynatablerf/pom.xml:26: gwt-servlet
>> You could replace this with requestfactory-server as mobilewebapp now
>> does, but this is fine (and actually useful in case of those using RF
>> with RPC).
>
> Adding a comment to that effect
>>
>>
>> http://gwt-code-reviews.appspot.com/1537803/diff/3001/samples/mobilewebapp/pom.xml
>> File samples/mobilewebapp/pom.xml (right):
>>
>>
>> http://gwt-code-reviews.appspot.com/1537803/diff/3001/samples/mobilewebapp/pom.xml#newcode160
>> samples/mobilewebapp/pom.xml:160:  http://groups.google.com/group/Google-Web-Toolkit-Contributors

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Convert DynaTableRF to use maven. Clean up the docs in the other two (issue1537803)

2011-09-08 Thread Ray Ryan 
On Thu Sep 08 08:52:42 GMT-700 2011,  wrote:

> LGTM
>
> No changes needed. Nice Mavenizing!
>
Thanks. I can copy and paste with the best of them.

>
>
> http://gwt-code-reviews.appspot.com/1537803/diff/3001/samples/dynatablerf/pom.xml
> File samples/dynatablerf/pom.xml (right):
>
>
> http://gwt-code-reviews.appspot.com/1537803/diff/3001/samples/dynatablerf/pom.xml#newcode26
> samples/dynatablerf/pom.xml:26:
> gwt-servlet
> You could replace this with requestfactory-server as mobilewebapp now
> does, but this is fine (and actually useful in case of those using RF
> with RPC).
>
Adding a comment to that effect

>
> http://gwt-code-reviews.appspot.com/1537803/diff/3001/samples/mobilewebapp/pom.xml
> File samples/mobilewebapp/pom.xml (right):
>
>
> http://gwt-code-reviews.appspot.com/1537803/diff/3001/samples/mobilewebapp/pom.xml#newcode160
> samples/mobilewebapp/pom.xml:160:
>

[gwt-contrib] Re: Convert DynaTableRF to use maven. Clean up the docs in the other two (issue1537803)

2011-09-08 Thread drfibonacci 

LGTM

No changes needed. Nice Mavenizing!


http://gwt-code-reviews.appspot.com/1537803/diff/3001/samples/dynatablerf/pom.xml
File samples/dynatablerf/pom.xml (right):

http://gwt-code-reviews.appspot.com/1537803/diff/3001/samples/dynatablerf/pom.xml#newcode26
samples/dynatablerf/pom.xml:26: gwt-servlet
You could replace this with requestfactory-server as mobilewebapp now
does, but this is fine (and actually useful in case of those using RF
with RPC).

http://gwt-code-reviews.appspot.com/1537803/diff/3001/samples/mobilewebapp/pom.xml
File samples/mobilewebapp/pom.xml (right):

http://gwt-code-reviews.appspot.com/1537803/diff/3001/samples/mobilewebapp/pom.xml#newcode160
samples/mobilewebapp/pom.xml:160:

[gwt-contrib] [google-web-toolkit] r10632 committed - Add ability to control time zone in DateCell....

2011-09-08 Thread codesite-noreply 

Revision: 10632
Author:   gwt.mirror...@gmail.com
Date: Thu Sep  8 05:48:56 2011
Log:  Add ability to control time zone in DateCell.

Review at http://gwt-code-reviews.appspot.com/1539803

Review by: jlaba...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10632

Modified:
 /trunk/tools/api-checker/config/gwt23_24userApi.conf
 /trunk/user/src/com/google/gwt/cell/client/DateCell.java
 /trunk/user/test/com/google/gwt/cell/client/DateCellTest.java

===
--- /trunk/tools/api-checker/config/gwt23_24userApi.conf	Wed Sep  7  
09:32:44 2011
+++ /trunk/tools/api-checker/config/gwt23_24userApi.conf	Thu Sep  8  
02:20:30 2011

@@ -176,3 +176,6 @@
 com.google.gwt.user.cellview.client.AbstractHasData::onUpdateSelection()  
MISSING
  
com.google.gwt.user.cellview.client.CellList::doSelection(Lcom/google/gwt/user/client/Event;Ljava/lang/Object;I)  
MISSING
  
com.google.gwt.user.cellview.client.CellTable::doSelection(Lcom/google/gwt/user/client/Event;Ljava/lang/Object;II)  
MISSING

+
+# Adding timezone constructor argument to DateCell
+com.google.gwt.cell.client.DateCell::DateCell(Lcom/google/gwt/i18n/client/DateTimeFormat;Lcom/google/gwt/text/shared/SafeHtmlRenderer;)  
OVERLOADED_METHOD_CALL

===
--- /trunk/user/src/com/google/gwt/cell/client/DateCell.java	Wed Dec  1  
05:40:20 2010
+++ /trunk/user/src/com/google/gwt/cell/client/DateCell.java	Thu Sep  8  
02:20:30 2011

@@ -17,6 +17,7 @@

 import com.google.gwt.i18n.client.DateTimeFormat;
 import com.google.gwt.i18n.client.DateTimeFormat.PredefinedFormat;
+import com.google.gwt.i18n.client.TimeZone;
 import com.google.gwt.safehtml.shared.SafeHtmlBuilder;
 import com.google.gwt.text.shared.SafeHtmlRenderer;
 import com.google.gwt.text.shared.SimpleSafeHtmlRenderer;
@@ -32,13 +33,15 @@

   private final SafeHtmlRenderer renderer;

+  private final TimeZone timeZone;
+
   /**
* Construct a new {@link DateCell} using the format
* {@link PredefinedFormat#DATE_FULL} and a {@link  
SimpleSafeHtmlRenderer}.

*/
   public DateCell() {
 this(DateTimeFormat.getFormat(PredefinedFormat.DATE_FULL),
-SimpleSafeHtmlRenderer.getInstance());
+SimpleSafeHtmlRenderer.getInstance(), null);
   }

   /**
@@ -49,7 +52,7 @@
*  formatted date as HTML
*/
   public DateCell(SafeHtmlRenderer renderer) {
-this(DateTimeFormat.getFormat(PredefinedFormat.DATE_FULL), renderer);
+this(DateTimeFormat.getFormat(PredefinedFormat.DATE_FULL), renderer,  
null);

   }

   /**
@@ -59,7 +62,7 @@
* @param format the {@link DateTimeFormat} used to render the date
*/
   public DateCell(DateTimeFormat format) {
-this(format, SimpleSafeHtmlRenderer.getInstance());
+this(format, SimpleSafeHtmlRenderer.getInstance(), null);
   }

   /**
@@ -71,6 +74,36 @@
*  formatted date
*/
   public DateCell(DateTimeFormat format, SafeHtmlRenderer  
renderer) {

+this(format, renderer, null);
+  }
+
+  /**
+   * Construct a new {@link DateCell} using the specified format and time  
zone.

+   *
+   * @param format the {@link DateTimeFormat} used to render the date
+   * @param timezone the {@link TimeZone} used to render the date, or null  
to
+   *  use the default behavior for the local time zone and the  
rendered

+   *  date. See {@link DateTimeFormat#format(Date)} and
+   *  {@link Date#getTimeZoneOffset}
+   */
+  public DateCell(DateTimeFormat format, TimeZone timeZone) {
+this(format, SimpleSafeHtmlRenderer.getInstance(), timeZone);
+  }
+
+  /**
+   * Construct a new {@link DateCell} using the specified format, the given
+   * {@link SafeHtmlRenderer}, and the specified time zone.
+   *
+   * @param format the {@link DateTimeFormat} used to render the date
+   * @param renderer a non-null {@link SafeHtmlRenderer} used to render the
+   *  formatted date
+   * @param timezone the {@link TimeZone} used to render the date, or null  
to
+   *  use the default behavior for the local time zone and the  
rendered

+   *  date. See {@link DateTimeFormat#format(Date)} and
+   *  {@link Date#getTimeZoneOffset}
+   */
+  public DateCell(DateTimeFormat format, SafeHtmlRenderer renderer,
+  TimeZone timeZone) {
 if (format == null) {
   throw new IllegalArgumentException("format == null");
 }
@@ -79,12 +112,13 @@
 }
 this.format = format;
 this.renderer = renderer;
+this.timeZone = timeZone;
   }

   @Override
   public void render(Context context, Date value, SafeHtmlBuilder sb) {
 if (value != null) {
-  sb.append(renderer.render(format.format(value)));
+  sb.append(renderer.render(format.format(value, timeZone)));
 }
   }
 }
===
--- /trunk/user/test/com/google/gwt/cell/client/DateCellTest.java	Tue Jul  
27 08:47:38 2010
+++ /trunk/user/test/com/google/gwt/cell/client/DateCellTest.java	Thu Sep   
8