[gwt-contrib] Re: Keep track of TCK coverage. (issue1575803)

[rjrjr]

LGTM


http://gwt-code-reviews.appspot.com/1575803/diff/5001/user/style/html/junit-noframes.xsl
File user/style/html/junit-noframes.xsl (right):

http://gwt-code-reviews.appspot.com/1575803/diff/5001/user/style/html/junit-noframes.xsl#newcode287
user/style/html/junit-noframes.xsl:287: 
indentation is a bit wonky

http://gwt-code-reviews.appspot.com/1575803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: More TCK tests (issue1567804)

[Ray Ryan]

LGTM
On Oct 17, 2011 4:26 PM,  wrote:

>
> http://gwt-code-reviews.**appspot.com/1567804/diff/1/**
> user/test/org/hibernate/**jsr303/tck/tests/bootstrap/**customprovider/**
> TckTestValidatorFactory.java
> File
> user/test/org/hibernate/**jsr303/tck/tests/bootstrap/**customprovider/**
> TckTestValidatorFactory.java
> (right):
>
> http://gwt-code-reviews.**appspot.com/1567804/diff/1/**
> user/test/org/hibernate/**jsr303/tck/tests/bootstrap/**customprovider/**
> TckTestValidatorFactory.java#**newcode16
> user/test/org/hibernate/**jsr303/tck/tests/bootstrap/**customprovider/**
> TckTestValidatorFactory.java:**16:
> package org.hibernate.jsr303.tck.**tests.bootstrap.**customprovider;
> On 2011/10/17 20:55:03, rjrjr wrote:
>
>> Is it really appropriate for this to be in the org.hibernate space
>>
> rather than
>
>> com.google.gwt?
>>
>
> This is the same directory as the test.   For some of the tests it was
> important to be in the same package.
>
> http://gwt-code-reviews.**appspot.com/1567804/
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Keep track of TCK coverage. (issue1575803)

[nchalko]

http://gwt-code-reviews.appspot.com/1575803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: More TCK tests (issue1567804)

[nchalko]

http://gwt-code-reviews.appspot.com/1567804/diff/1/user/test/org/hibernate/jsr303/tck/tests/bootstrap/customprovider/TckTestValidatorFactory.java
File
user/test/org/hibernate/jsr303/tck/tests/bootstrap/customprovider/TckTestValidatorFactory.java
(right):

http://gwt-code-reviews.appspot.com/1567804/diff/1/user/test/org/hibernate/jsr303/tck/tests/bootstrap/customprovider/TckTestValidatorFactory.java#newcode16
user/test/org/hibernate/jsr303/tck/tests/bootstrap/customprovider/TckTestValidatorFactory.java:16:
package org.hibernate.jsr303.tck.tests.bootstrap.customprovider;
On 2011/10/17 20:55:03, rjrjr wrote:

Is it really appropriate for this to be in the org.hibernate space

rather than

com.google.gwt?


This is the same directory as the test.   For some of the tests it was
important to be in the same package.

http://gwt-code-reviews.appspot.com/1567804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Keep track of TCK coverage. (issue1575803)

[nchalko]

On 2011/10/17 20:56:59, rjrjr wrote:

On 2011/10/17 18:35:43, Nick Chalko wrote:



Redundant with http://gwt-code-reviews.appspot.com/1567804/?


Not completely.  the "Keep track of TCK coverage." is new.

http://gwt-code-reviews.appspot.com/1575803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Change default of UiBinder.useLazyWidgetBuilders to true, in (issue1574803)

[rchandia]

LGTM

http://gwt-code-reviews.appspot.com/1574803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Change default of UiBinder.useLazyWidgetBuilders to true, in (issue1574803)

[rjrjr]

No broken test, ready for review.

http://gwt-code-reviews.appspot.com/1574803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Keep track of TCK coverage. (issue1575803)

[rjrjr]

On 2011/10/17 18:35:43, Nick Chalko wrote:

Redundant with http://gwt-code-reviews.appspot.com/1567804/?

http://gwt-code-reviews.appspot.com/1575803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: More TCK tests (issue1567804)

[rjrjr]

LGTM


http://gwt-code-reviews.appspot.com/1567804/diff/1/user/test/org/hibernate/jsr303/tck/tests/bootstrap/customprovider/TckTest.gwt.xml
File
user/test/org/hibernate/jsr303/tck/tests/bootstrap/customprovider/TckTest.gwt.xml
(right):

http://gwt-code-reviews.appspot.com/1567804/diff/1/user/test/org/hibernate/jsr303/tck/tests/bootstrap/customprovider/TckTest.gwt.xml#newcode4
user/test/org/hibernate/jsr303/tck/tests/bootstrap/customprovider/TckTest.gwt.xml:4:
Copyright 2010 Google Inc.
2011. Others?

http://gwt-code-reviews.appspot.com/1567804/diff/1/user/test/org/hibernate/jsr303/tck/tests/bootstrap/customprovider/TckTestValidatorFactory.java
File
user/test/org/hibernate/jsr303/tck/tests/bootstrap/customprovider/TckTestValidatorFactory.java
(right):

http://gwt-code-reviews.appspot.com/1567804/diff/1/user/test/org/hibernate/jsr303/tck/tests/bootstrap/customprovider/TckTestValidatorFactory.java#newcode16
user/test/org/hibernate/jsr303/tck/tests/bootstrap/customprovider/TckTestValidatorFactory.java:16:
package org.hibernate.jsr303.tck.tests.bootstrap.customprovider;
Is it really appropriate for this to be in the org.hibernate space
rather than com.google.gwt?

http://gwt-code-reviews.appspot.com/1567804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: More TCK tests (issue1567804)

[Ray Ryan]

Missed this, looking now.

On Mon, Oct 17, 2011 at 10:26 AM,  wrote:

> On 2011/10/13 18:53:54, Nick Chalko wrote:
>
> ping
>
> http://gwt-code-reviews.**appspot.com/1567804/
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Keep track of TCK coverage. (issue1575803)

[nchalko]

Reviewers: rjrjr,

Description:
Keep track of TCK coverage.
Run the non TCK test to ensure there is always at least one test.

[JSR 303 TCK Result] WARNING only 191 of 258 (74.03%) TCK Tests Covered.
[JSR 303 TCK Result] 151 of 257 (58.75%) Pass with 32 Failures and 7
Errors.


Please review this at http://gwt-code-reviews.appspot.com/1575803/

Affected files:
  M user/build.xml
  M user/style/html/junit-noframes.xsl
  M user/style/text/junit-noframes.xsl


Index: user/build.xml
===
--- user/build.xml  (revision 10705)
+++ user/build.xml  (working copy)
@@ -853,7 +853,7 @@
   excludes="${gwt.tck.testcase.dev.excludes}" />
   -  test.jvmargs="-ea  
-Dcom.google.gwt.sample.validationtck.util.Failing.include=true   
-Dcom.google.gwt.sample.validationtck.util.NonTckTest.exclude=true"
+  test.jvmargs="-ea  
-Dcom.google.gwt.sample.validationtck.util.Failing.include=true"

   test.out="${junit.out}/tck-dev-htmlunit"
   test.cases="tck.dev.htmlunit.tests"
   haltonfailure="false"
Index: user/style/html/junit-noframes.xsl
===
--- user/style/html/junit-noframes.xsl  (revision 10705)
+++ user/style/html/junit-noframes.xsl  (working copy)
@@ -261,12 +261,13 @@
   grep -r \@Test org/hibernate/jsr303/tck/tests/| grep -v "enabled  
= false"  | wc -l

 -->
 
-select="sum(testsuite/@tests)"/>
+select="sum(testsuite/@tests) - $markedNonTckTest"/>

 
 select="sum(testsuite/@failures)"/>

 
 
 
+

 
 of 
 (
@@ -279,10 +280,18 @@
 

 
-  WARINING expected Failures +  
Errors to match the
+  WARNING expected Failures +  
Errors to match the

   
   test marked @Failing
 
+
+ WARNING only
+   of
+   (name="display-percent">
+ 

+  ) TCK Tests Covered.
+
+
 width="95%">

 
 Tests
Index: user/style/text/junit-noframes.xsl
===
--- user/style/text/junit-noframes.xsl  (revision 10705)
+++ user/style/text/junit-noframes.xsl  (working copy)
@@ -44,18 +44,29 @@
   grep -r \@Test org/hibernate/jsr303/tck/tests/| grep -v "enabled =  
false"  | wc -l

 -->
 

-
+

 
 
 
 
 
+

 
-  WARINING expected Failures + Errors to match the  


+  WARNING expected Failures + Errors to match the 
   
test marked @Failing
 
 
+
+  WARNING only 
+of 
+(
+  
+ 

+  
+  ) TCK Tests Covered.
+
+
   of 
   (
 
@@ -63,7 +74,9 @@
 
 ) Pass with 
   Failures and  


-  Errors.
+  Errors.
+
+
 

 


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: More TCK tests (issue1567804)

[nchalko]

On 2011/10/13 18:53:54, Nick Chalko wrote:

ping

http://gwt-code-reviews.appspot.com/1567804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Change default of UiBinder.useLazyWidgetBuilders to true, in (issue1574803)

[rjrjr]

Oops, I think my fix actually broke a test, still digging. I'll ping
when this is really ready.

http://gwt-code-reviews.appspot.com/1574803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Change default of UiBinder.useLazyWidgetBuilders to true, in (issue1574803)

[rjrjr]

Reviewers: rchandia,

Description:
Change default of UiBinder.useLazyWidgetBuilders to true, in
preparation for deleting the old code.

Also fixes unreported bad code gen for things like 
when
safehtml is off. Fix is a bit squirrelly, but the intent is to delete
the code
in question almost immediately if nothing blows up with new default.

Review by: rchan...@google.com

Please review this at http://gwt-code-reviews.appspot.com/1574803/

Affected files:
  M user/src/com/google/gwt/uibinder/UiBinder.gwt.xml
  M user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java
  M user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java


Index: user/src/com/google/gwt/uibinder/UiBinder.gwt.xml
===
--- user/src/com/google/gwt/uibinder/UiBinder.gwt.xml   (revision 10704)
+++ user/src/com/google/gwt/uibinder/UiBinder.gwt.xml   (working copy)
@@ -27,11 +27,11 @@
   is-multi-valued="false"/>
   value="true"/>


-  
+  
   is-multi-valued="false"/>
-  value="false"/>
+  value="true"/>


   
 class="com.google.gwt.uibinder.client.UiRenderer"/>

Index: user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java
===
--- user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java	 
(revision 10704)
+++ user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java	(working  
copy)

@@ -52,6 +52,7 @@
   private static final String LAZY_WIDGET_BUILDERS_PROPERTY  
= "UiBinder.useLazyWidgetBuilders";


   private static boolean gaveSafeHtmlWarning;
+  private static boolean gaveLazyBuildersWarning;

   /**
* Given a UiBinder interface, return the path to its ui.xml file,  
suitable

@@ -212,7 +213,14 @@
   }

   private Boolean useLazyWidgetBuilders(MortalLogger logger,  
PropertyOracle propertyOracle) {
-return extractConfigProperty(logger, propertyOracle,  
LAZY_WIDGET_BUILDERS_PROPERTY, false);
+Boolean rtn = extractConfigProperty(logger, propertyOracle,  
LAZY_WIDGET_BUILDERS_PROPERTY, false);

+if (!gaveLazyBuildersWarning && !rtn) {
+  logger.warn("Configuration property %s is false. Deprecated code  
generation is in play. " +

+   "This property will soon become a no-op.",
+   LAZY_WIDGET_BUILDERS_PROPERTY);
+  gaveLazyBuildersWarning = true;
+}
+return rtn;
   }

   private Boolean useSafeHtmlTemplates(MortalLogger logger, PropertyOracle  
propertyOracle) {

@@ -221,7 +229,8 @@

 if (!gaveSafeHtmlWarning && !rtn) {
   logger.warn("Configuration property %s is false! UiBinder SafeHtml  
integration is off, "
-  + "leaving your users more vulnerable to cross-site scripting  
attacks.",
+  + "leaving your users more vulnerable to cross-site scripting  
attacks. This property " +
+  "will soon become a no-op, and SafeHtml integration will always  
be on.",

   XSS_SAFE_CONFIG_PROPERTY);
   gaveSafeHtmlWarning = true;
 }
Index: user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
===
--- user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java	(revision  
10704)
+++ user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java	(working  
copy)

@@ -1030,7 +1030,7 @@
*/
   public String tokenForSafeUriExpression(XMLElement source, String  
expression) {

 if (!useSafeHtmlTemplates) {
-  return tokenForStringExpression(source, expression + ".asString()");
+  return tokenForStringExpression(source, expression);
 }

 htmlTemplates.noteUri(expression);


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors