[gwt-contrib] Fix issue 5658: PlaceHistoryGeneratorContext now examines PlaceTokenizers' hierarchy. (issue1674804)

[t . broyer]

Reviewers: rdayal,

Description:
Fix issue 5658: PlaceHistoryGeneratorContext now examines
PlaceTokenizers' hierarchy.


Please review this at https://gwt-code-reviews.appspot.com/1674804/

Affected files:
  M user/src/com/google/gwt/place/rebind/PlaceHistoryGeneratorContext.java
  M  
user/test/com/google/gwt/place/rebind/PlaceHistoryGeneratorContextTest.java

  M user/test/com/google/gwt/place/testplaces/Tokenizer4.java


Index:  
user/src/com/google/gwt/place/rebind/PlaceHistoryGeneratorContext.java
diff --git  
a/user/src/com/google/gwt/place/rebind/PlaceHistoryGeneratorContext.java  
b/user/src/com/google/gwt/place/rebind/PlaceHistoryGeneratorContext.java
index  
4cdd5fa83b299d94bc087ff24209e40ff8412f59..97def441c0c762fc4c91102efdba4f96c3bcec6a  
100644

--- a/user/src/com/google/gwt/place/rebind/PlaceHistoryGeneratorContext.java
+++ b/user/src/com/google/gwt/place/rebind/PlaceHistoryGeneratorContext.java
@@ -240,7 +240,7 @@ class PlaceHistoryGeneratorContext {
   implementedInterfaces.add(isInterface);
 }

- 
implementedInterfaces.addAll(Arrays.asList(tokenizerType.getImplementedInterfaces()));
+ 
implementedInterfaces.addAll(tokenizerType.getFlattenedSupertypeHierarchy());


 JClassType rtn = placeTypeForInterfaces(implementedInterfaces);
 if (rtn == null) {
@@ -343,4 +343,4 @@ class PlaceHistoryGeneratorContext {
 }
 return rtn;
   }
-}
\ No newline at end of file
+}
Index:  
user/test/com/google/gwt/place/rebind/PlaceHistoryGeneratorContextTest.java
diff --git  
a/user/test/com/google/gwt/place/rebind/PlaceHistoryGeneratorContextTest.java  
b/user/test/com/google/gwt/place/rebind/PlaceHistoryGeneratorContextTest.java
index  
623fa5d08beb83519273ed26628ccc458637c1de..37a8c72a63925c13deb147929452547f198e72d1  
100644
---  
a/user/test/com/google/gwt/place/rebind/PlaceHistoryGeneratorContextTest.java
+++  
b/user/test/com/google/gwt/place/rebind/PlaceHistoryGeneratorContextTest.java

@@ -35,6 +35,7 @@ import com.google.gwt.place.shared.Prefix;
 import com.google.gwt.place.shared.WithTokenizers;
 import com.google.gwt.place.testplacemappers.NoFactory;
 import com.google.gwt.place.testplacemappers.WithFactory;
+import com.google.gwt.place.testplaces.AbstractTokenizer;
 import com.google.gwt.place.testplaces.Place1;
 import com.google.gwt.place.testplaces.Place2;
 import com.google.gwt.place.testplaces.Place3;
@@ -85,6 +86,7 @@ public class PlaceHistoryGeneratorContextTest extends  
TestCase {

 rtn.add(new RealJavaResource(Place3.class));
 rtn.add(new RealJavaResource(Place4.class));
 rtn.add(new RealJavaResource(Place6.class));
+rtn.add(new RealJavaResource(AbstractTokenizer.class));
 rtn.add(new RealJavaResource(Tokenizer2.class));
 rtn.add(new RealJavaResource(Tokenizer3.class));
 rtn.add(new RealJavaResource(Tokenizer4.class));
Index: user/test/com/google/gwt/place/testplaces/Tokenizer4.java
diff --git a/user/test/com/google/gwt/place/testplaces/Tokenizer4.java  
b/user/test/com/google/gwt/place/testplaces/Tokenizer4.java
index  
7f416350c11210378860ff6b38d4fb823bf405b5..eba0d0b47efb116db09d6dea364197c8433a5968  
100644

--- a/user/test/com/google/gwt/place/testplaces/Tokenizer4.java
+++ b/user/test/com/google/gwt/place/testplaces/Tokenizer4.java
@@ -15,17 +15,11 @@
  */
 package com.google.gwt.place.testplaces;

-import com.google.gwt.place.shared.PlaceTokenizer;
-
 /**
  * Used by tests of {@link  
com.google.gwt.place.rebind.PlaceHistoryMapperGenerator}.

  */
-public class Tokenizer4 implements PlaceTokenizerPlace4 {
+public class Tokenizer4 extends AbstractTokenizerPlace4 {
   public Place4 getPlace(String token) {
 return new Place4(token);
   }
-
-  public String getToken(Place4 place) {
-return place.content;
-  }
 }


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] @com.google.gwt.user.client.impl.DOMImpl::eventGetTypeInt(Ljava/lang/String;)': JS value of type null, expected int

[yves]

Hello,

I am running myapp in dev mode in chrome and I got the following
error.
Versions are : gwt 2.4.0v201203300216-rel-37  / eclipse 3.7  / chrome
19.0.1084.1 dev-m

After a search in this group, I didn't found something related to this
issue, thus I post it.
Yves


20:54:31.000 [ERROR] [myapp] Uncaught exception escaped

com.google.gwt.dev.shell.HostedModeException: Something other than an
int was returned from JSNI method
'@com.google.gwt.user.client.impl.DOMImpl::eventGetTypeInt(Ljava/lang/
String;)': JS value of type null, expected int
at
com.google.gwt.dev.shell.JsValueGlue.getIntRange(JsValueGlue.java:266)
at com.google.gwt.dev.shell.JsValueGlue.get(JsValueGlue.java:144)
at
com.google.gwt.dev.shell.ModuleSpace.invokeNativeInt(ModuleSpace.java:
247)
at
com.google.gwt.dev.shell.JavaScriptHost.invokeNativeInt(JavaScriptHost.java:
75)
at
com.google.gwt.user.client.impl.DOMImpl.eventGetTypeInt(DOMImpl.java)
at
com.google.gwt.user.client.impl.DOMImpl.eventGetTypeInt(DOMImpl.java:
62)
at com.google.gwt.user.client.DOM.eventGetType(DOM.java:602)
at com.google.gwt.user.client.ui.Widget.onBrowserEvent(Widget.java:
164)
at com.google.gwt.user.client.DOM.dispatchEventImpl(DOM.java:1351)
at com.google.gwt.user.client.DOM.dispatchEvent(DOM.java:1307)
at sun.reflect.GeneratedMethodAccessor34.invoke(Unknown Source)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:
25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
com.google.gwt.dev.shell.MethodAdaptor.invoke(MethodAdaptor.java:103)
at
com.google.gwt.dev.shell.MethodDispatch.invoke(MethodDispatch.java:71)
at
com.google.gwt.dev.shell.OophmSessionHandler.invoke(OophmSessionHandler.java:
172)
at
com.google.gwt.dev.shell.BrowserChannelServer.reactToMessagesWhileWaitingForReturn(BrowserChannelServer.java:
337)
at
com.google.gwt.dev.shell.BrowserChannelServer.invokeJavascript(BrowserChannelServer.java:
218)
at
com.google.gwt.dev.shell.ModuleSpaceOOPHM.doInvoke(ModuleSpaceOOPHM.java:
136)
at
com.google.gwt.dev.shell.ModuleSpace.invokeNative(ModuleSpace.java:
561)
at
com.google.gwt.dev.shell.ModuleSpace.invokeNativeObject(ModuleSpace.java:
269)
at
com.google.gwt.dev.shell.JavaScriptHost.invokeNativeObject(JavaScriptHost.java:
91)
at com.google.gwt.core.client.impl.Impl.apply(Impl.java)
at com.google.gwt.core.client.impl.Impl.entry0(Impl.java:213)
at sun.reflect.GeneratedMethodAccessor31.invoke(Unknown Source)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:
25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
com.google.gwt.dev.shell.MethodAdaptor.invoke(MethodAdaptor.java:103)
at
com.google.gwt.dev.shell.MethodDispatch.invoke(MethodDispatch.java:71)
at
com.google.gwt.dev.shell.OophmSessionHandler.invoke(OophmSessionHandler.java:
172)
at
com.google.gwt.dev.shell.BrowserChannelServer.reactToMessages(BrowserChannelServer.java:
292)
at
com.google.gwt.dev.shell.BrowserChannelServer.processConnection(BrowserChannelServer.java:
546)
at
com.google.gwt.dev.shell.BrowserChannelServer.run(BrowserChannelServer.java:
363)
at java.lang.Thread.run(Thread.java:619)

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors