[gwt-contrib] Re: Add Integer.TYPE, etc. (issue1528806)

[stephen . haberman]

http://gwt-code-reviews.appspot.com/1528806/diff/8001/user/super/com/google/gwt/emul/java/lang/Double.java
File user/super/com/google/gwt/emul/java/lang/Double.java (right):

http://gwt-code-reviews.appspot.com/1528806/diff/8001/user/super/com/google/gwt/emul/java/lang/Double.java#newcode36
user/super/com/google/gwt/emul/java/lang/Double.java:36: // 2^512,
2^-512
Er...these changes aren't in the raw patchset/diff file that I uploaded.

I must have confused reitveld by rebasing my latest patchset against
trunk.

http://gwt-code-reviews.appspot.com/1528806/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: AbsolutePanel logs IllegalStateException in dev mode (issue1703803)

[Daniel Kurka]

Hi everyone,

I still need a reviewer for this one.

-Daniel

2012/5/5 

> Reviewers: rdayal,
>
> Description:
> fix for
> http://code.google.com/p/**google-web-toolkit/issues/**detail?id=5251
>
> Please review this at 
> http://gwt-code-reviews.**appspot.com/1703803/
>
> Affected files:
>  user/src/com/google/gwt/user/**client/ui/AbsolutePanel.java
>
>
> Index: user/src/com/google/gwt/user/**client/ui/AbsolutePanel.java
> ==**==**===
> --- user/src/com/google/gwt/user/**client/ui/AbsolutePanel.java
> (Revision 10964)
> +++ user/src/com/google/gwt/user/**client/ui/AbsolutePanel.java
> (Arbeitskopie)
> @@ -251,6 +251,12 @@
> if (GWT.isProdMode()) {
>   return;
> }
> +
> +//make sure we can actually perform a check
> +if(!isAttached())
> +{
> +  return;
> +}
>
> // Non-visible or detached elements have no offsetParent
> if (child.getElement().**getOffsetParent() == null) {
>
>
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add Integer.TYPE, etc. (issue1528806)

[stephen . haberman]

What would you say the priority is for 2.5?


Given it's simplicity (*cough* breaking the build aside *cough*), I'd
like to see it go in.


Is this breaking/preventing something in the Scala-GWT project?


Not critically, but somewhat: some scala-library code uses Integer.TYPE
& friends, so to compile scala-library in GWT without this change, the
source needs to be massaged a bit.

If this change goes in, it means one less time to getting scala-library
compiled.


Class TYPE = char.class;
This causes a compilation error (double def of TYPE).


Oh my. Sorry about that--I originally did not have that, but vaguely
remember when submitting the 2nd patchset, sanity checking that I had
all of the .TYPEs covered, and failed on Character.

I've verified the patchset 3 actually compiles in web mode (sheesh).

Thanks, Rajeev.

http://gwt-code-reviews.appspot.com/1528806/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add Integer.TYPE, etc. (issue1528806)

[stephen . haberman]

http://gwt-code-reviews.appspot.com/1528806/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix this->window confusion in DevMode (issue1620805)

[Stephen Haberman]

> I'd rather spend that time working on SuperDevMode and moving people
> over to that, where this whole issue of differing implementations
> between web mode and dev mode goes away.

+1 to that.

> I just don't think this issue is one where we should start to break
> backwards compatibility.

That is fine with me. This was issue that wasn't really directly affecting me,
just seemed fun to work on.

> Stephen, what do you think? Would you be amenable to adding the code
> for the flag?

Sure, I'll see what I can do.

- Stephen

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix leak in LayoutImplIE6 (issue1601804)

[stephen . haberman]

Looks like this one has been hanging out here for a long time - how

strongly do

you guys feel about this getting into 2.5?


Personally, this bug is not affecting me as we don't worry about IE6
anymore. I was only working on it because it seemed interesting.

That being said, if it can get in, I think it's good because it does fix
a leak. And I think there are some remaining leaks, but I'm not sure, so
it would be great to have this in 2.5 so that on those remaining tickets
we could have users test with 2.5 to see if their issue still remains.

Or at least winnow down the potential culprits.

http://gwt-code-reviews.appspot.com/1601804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Added style getters to UiRenderers (issue1700803)

[rchandia]

On 2012/05/03 18:50:43, rchandia wrote:

Ping

http://gwt-code-reviews.appspot.com/1700803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors