[gwt-contrib] Re: Using RequestFactory, AutoBean equality compares stableId proxyClass, which will NPE if stableId is not set.
On Thursday, July 12, 2012 2:56:06 AM UTC+2, Eric Friesen wrote: This occurs in the ValueProxyCategory: http://code.google.com/searchframe#T04cSGC7sWI/trunk/user/src/com/google/web/bindery/requestfactory/shared/impl/ValueProxyCategory.javaq=ValueProxyCategory%20package:google-web-toolkit%5C.googlecode%5C.coml=42 It's causing our project to not be able to compare our AutoBean objects returned to us from RequestFactory requests. Would a change to check whether the AutoBeans have stable ids in the first place before trying to compare their proxy classes be acceptable? Or am I missing something in the big picture here and it's a bad idea. As far as I can tell it's an optimization to fail early without having to do a deep equals and this change would be alright. If this sounds reasonable I'll put in a fix for review. The thing is: stableId shouldn't ever be 'null', that'd be a bug. Maybe you create a ValueProxy AutoBean without using RequestContext#create(); that's not supported, that'd be a bug in your code. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Using RequestFactory, AutoBean equality compares stableId proxyClass, which will NPE if stableId is not set.
Interesting. I'm using regular RequestFactory calls to the server to get these objects. In particular my example where this is happening is: Call a server method to get a List of objects of type A. Get two objects from the list (or the same object twice). and call a.equals(b); So I suppose there's a way for RequestFactory to create objects without StableIds that I need to look into. Thanks! -E On Thursday, July 12, 2012 2:19:51 AM UTC-7, Thomas Broyer wrote: On Thursday, July 12, 2012 2:56:06 AM UTC+2, Eric Friesen wrote: This occurs in the ValueProxyCategory: http://code.google.com/searchframe#T04cSGC7sWI/trunk/user/src/com/google/web/bindery/requestfactory/shared/impl/ValueProxyCategory.javaq=ValueProxyCategory%20package:google-web-toolkit%5C.googlecode%5C.coml=42 It's causing our project to not be able to compare our AutoBean objects returned to us from RequestFactory requests. Would a change to check whether the AutoBeans have stable ids in the first place before trying to compare their proxy classes be acceptable? Or am I missing something in the big picture here and it's a bad idea. As far as I can tell it's an optimization to fail early without having to do a deep equals and this change would be alright. If this sounds reasonable I'll put in a fix for review. The thing is: stableId shouldn't ever be 'null', that'd be a bug. Maybe you create a ValueProxy AutoBean without using RequestContext#create(); that's not supported, that'd be a bug in your code. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Add instrumentation for collecting client-side code coverage. (issue1764803)
http://gwt-code-reviews.appspot.com/1764803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Reviewer for simple typo
Hi Everyone, I still need a reviewer for a simple typo: http://code.google.com/p/google-web-toolkit/issues/detail?id=7479 Patch is in Rietveld: http://gwt-code-reviews.appspot.com/1770803/ -Daniel -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Refactoring to set empty groups to include Default earlier. (issue1761805)
lgtm http://gwt-code-reviews.appspot.com/1761805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
