[gwt-contrib] Re: Extracted constant strings to the constructor, that allow translation to be provided from the ou... (issue1739803)
A little late, but I hasn't run across this problem until yesterday... http://gwt-code-reviews.appspot.com/1739803/diff/14001/user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java File user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java (right): http://gwt-code-reviews.appspot.com/1739803/diff/14001/user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java#newcode857 user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java:857: * @param messages tranlation messages Just a spelling mistake, it should be translation. http://gwt-code-reviews.appspot.com/1739803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Regarding Issue 1601804: Fix leak in LayoutImplIE6
Anyone have any pointers to offer? thanks, jay On Sunday, September 16, 2012 3:14:17 PM UTC-7, jay wrote: (I seem to be unable to post this comment to the code review...) In regards to the code review posted at http://gwt-code-reviews.appspot.com/1601804, I would love to see this land in 2.5, as we have some large customers who are still using IE7. And, no surprise, we're having some memory issues... Unfortunately, when I applied this patch to our code base, part of our app failed to render. The problem seems to be in the LayoutImplIE6 class, though I'm not sure exactly what's going wrong. Clearly the DOM is generated differently, and that's expected. If someone can provide a pointer or some more details on how the layers are supposed to be used in the onAttach now vs. previously, I will try to take a look and get a better understanding of what's going wrong. Thanks, jay -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix typo in a comment. (issue1845804)
Hi, one-line typo fixes like this aren't worth bothering with, particularly since the constructor isn't public. If you want to help, I would suggest either doing a more extensive spell-checking pass, or figure out how to say something more useful. In this case, it looks like all CellTreeNodeViews in the same tree have the same messages variable and it's the one passed into CellTree's constructor, so you could say something about that. http://gwt-code-reviews.appspot.com/1845804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
