date:20121018

[gwt-contrib] Re: Update the DevMode Chrome plugin's Makefile to build a zip file to upload to the Chrome web store. (issue1858803)

2012-10-18 Thread mdempsky



http://gwt-code-reviews.appspot.com/1858803/diff/1/plugins/npapi/Makefile
File plugins/npapi/Makefile (right):

http://gwt-code-reviews.appspot.com/1858803/diff/1/plugins/npapi/Makefile#newcode57
plugins/npapi/Makefile:57: EXTENSION_FILES = *.html *.js *.png *.txt \
Oops, I did want to comment that this makes me a little nervous because
people might get confused by when the globs are expanded, but I can't
think of a better solution off hand and there's nothing technically
wrong with this one.

http://gwt-code-reviews.appspot.com/1858803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Update the DevMode Chrome plugin's Makefile to build a zip file to upload to the Chrome web store. (issue1858803)

2012-10-18 Thread mdempsky


LGTM

http://gwt-code-reviews.appspot.com/1858803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Update the DevMode Chrome plugin's Makefile to build a zip file to upload to the Chrome web store. (issue1858803)

2012-10-18 Thread skybrian


Reviewers: mdempsky,

Description:
Update the DevMode Chrome plugin's Makefile to build a zip file to
upload to the Chrome web store.

Instead of building a crx file, we build a zip file containing the files
to upload. Also, the Chrome web store doesn't allow the key or update
URL to be set in the manifest.


Please review this at http://gwt-code-reviews.appspot.com/1858803/

Affected files:
  M plugins/npapi/Makefile
  M plugins/npapi/manifest-template.json
  M plugins/npapi/prebuilt/gwt-dev-plugin/manifest.json


Index: plugins/npapi/Makefile
===
--- plugins/npapi/Makefile  (revision 11340)
+++ plugins/npapi/Makefile  (working copy)
@@ -54,30 +54,30 @@

 OBJ_OUTDIR= build/$(TARGET_PLATFORM)
 EXTENSION_OUTDIR  = prebuilt/gwt-dev-plugin
+EXTENSION_FILES = *.html *.js *.png *.txt \
+  DevModeOptions/*.gif DevModeOptions/*.js DevModeOptions/*.txt \
+  Linux*/*.so WIN*/*.dll Darwin*/*/*/*.plist Darwin*/*/*/*/*.dylib
 PLATFORM_DIR  = $(EXTENSION_OUTDIR)/$(TARGET_PLATFORM)
 PLATFORM_DIR_SUFFIX ?= ""

-INSTALLER_CRX = prebuilt/gwt-dev-plugin.crx
 DLL   = $(OBJ_OUTDIR)/libGwtDevPlugin$(DLL_SUFFIX)
-GWTDEV_CRX_PEM   ?= $(CURDIR)/gwt-dev-plugin.pem
-CHROME_COMMAND= $(CHROME_PATH)  
--pack-extension=$(CURDIR)/$(EXTENSION_OUTDIR) --no-message-box  
--user-data-dir=$(CURDIR)/$(OBJ_OUTDIR)/user-data  
--pack-extension-key=$(GWTDEV_CRX_PEM)

-
-#DLLFLAGS +=
+#DLLFLAGS +=

 VERSION ?= 1.0.$(shell ./getversion)
 ifeq ($(VERSION), 1.0.)
 $(error You must specify the version if you are not in an svn checkout)
 endif

-.PHONY: default all crx lib common clean depend install install-platform \
+.PHONY: default all zip lib common clean depend install install-platform \
versioned-files devmodeoptions

 default:: lib versioned-files devmodeoptions

-all:: common lib install-platform crx
+all:: common lib install-platform zip

 lib:: $(OBJ_OUTDIR) $(EXTENSION_OUTDIR) $(DLL)
-crx:: $(EXTENSION_OUTDIR) $(INSTALLER_CRX)
+zip:: $(EXTENSION_OUTDIR)
+   (cd $(EXTENSION_OUTDIR); zip ../upload.zip $(EXTENSION_FILES))

 linuxplatforms:
$(MAKE) lib ARCH=x86
@@ -108,9 +108,6 @@

 $(OBJ_OUTDIR)::
@mkdir -p $@
-
-$(INSTALLER_CRX): $(GWTDEV_CRX_PEM) $(EXTENSION_OUTDIR) versioned-files
-   $(shell $(CHROME_COMMAND))

 versioned-files::
 	sed -e s/GWT_DEV_PLUGIN_VERSION/$(VERSION)/ manifest-template.json  

prebuilt/gwt-dev-plugin/manifest.json

Index: plugins/npapi/manifest-template.json
===
--- plugins/npapi/manifest-template.json(revision 11340)
+++ plugins/npapi/manifest-template.json(working copy)
@@ -4,7 +4,6 @@
   "manifest_version": 2,

   "description": "A plugin to enable debugging with GWT's Development  
Mode",

-  "update_url": "https://dl-ssl.google.com/gwt/plugins/chrome/updates.xml";,
   "icons": {
 "16": "gwt16.png",
 "32": "gwt32.png",
@@ -13,7 +12,6 @@
 "128": "gwt128.png"
   },

-  "key": 
"MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDi6RrEy9YllRLM8bGBcIEk5ECAG2z+8ngTz7wwzRAQJpOzDp1Alq8fQFjH0+dzxok4RFLrWKHjxGqvXzWyWyTEo2nY3ScHLN/RoANMs8pl9X6TygRyO+3naqZOtLCrYHfV49JKXnYoFVbY5eBVYxHYY3BHAOKJj9onyAM4UPmMzQIDAQAB",
   "background": {
  "page": "background.html"
},
Index: plugins/npapi/prebuilt/gwt-dev-plugin/manifest.json
===
--- plugins/npapi/prebuilt/gwt-dev-plugin/manifest.json (revision 11340)
+++ plugins/npapi/prebuilt/gwt-dev-plugin/manifest.json (working copy)
@@ -4,7 +4,6 @@
   "manifest_version": 2,

   "description": "A plugin to enable debugging with GWT's Development  
Mode",

-  "update_url": "https://dl-ssl.google.com/gwt/plugins/chrome/updates.xml";,
   "icons": {
 "16": "gwt16.png",
 "32": "gwt32.png",
@@ -13,7 +12,6 @@
 "128": "gwt128.png"
   },

-  "key": 
"MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDi6RrEy9YllRLM8bGBcIEk5ECAG2z+8ngTz7wwzRAQJpOzDp1Alq8fQFjH0+dzxok4RFLrWKHjxGqvXzWyWyTEo2nY3ScHLN/RoANMs8pl9X6TygRyO+3naqZOtLCrYHfV49JKXnYoFVbY5eBVYxHYY3BHAOKJj9onyAM4UPmMzQIDAQAB",
   "background": {
  "page": "background.html"
},


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Replace instances of element.setInnerHTML(safeHtml.asString()) (issue1857803)

2012-10-18 Thread skybrian


LGTM


http://gwt-code-reviews.appspot.com/1857803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Replace instances of element.setInnerHTML(safeHtml.asString()) (issue1857803)

2012-10-18 Thread mdempsky


Reviewers: skybrian, tbroyer,

Description:
Replace instances of element.setInnerHTML(safeHtml.asString())
with element.setInnerSafeHtml(safeHtml).


Please review this at http://gwt-code-reviews.appspot.com/1857803/

Affected files:
  M  
samples/showcase/src/com/google/gwt/sample/showcase/client/ContentWidgetView.java

  M user/src/com/google/gwt/cell/client/AbstractCell.java
  M user/src/com/google/gwt/cell/client/ImageLoadingCell.java
  M user/src/com/google/gwt/dom/builder/client/DomBuilderImpl.java
  M user/src/com/google/gwt/dom/builder/shared/HtmlBuilderImpl.java
  M user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java
  M user/src/com/google/gwt/user/cellview/client/AbstractHasData.java
  M user/src/com/google/gwt/user/cellview/client/CellBrowser.java
  M user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java
  M user/src/com/google/gwt/user/cellview/client/CellWidget.java
  M user/src/com/google/gwt/user/client/ui/RenderablePanel.java
  M user/src/com/google/gwt/user/client/ui/impl/ClippedImageImpl.java
  M user/test/com/google/gwt/cell/client/ImageLoadingCellTest.java
  M user/test/com/google/gwt/uibinder/test/client/UiRendererEventsTest.java
  M user/test/com/google/gwt/uibinder/test/client/UiRendererTest.java


Index:  
samples/showcase/src/com/google/gwt/sample/showcase/client/ContentWidgetView.java

===
---  
samples/showcase/src/com/google/gwt/sample/showcase/client/ContentWidgetView.java	 
(revision 11343)
+++  
samples/showcase/src/com/google/gwt/sample/showcase/client/ContentWidgetView.java	 
(working copy)

@@ -56,7 +56,7 @@
   }

   public void setDescription(SafeHtml html) {
-descElem.setInnerHTML(html.asString());
+descElem.setInnerSafeHtml(html);
   }

   public void setExample(Widget widget) {
Index: user/src/com/google/gwt/cell/client/AbstractCell.java
===
--- user/src/com/google/gwt/cell/client/AbstractCell.java   (revision 11343)
+++ user/src/com/google/gwt/cell/client/AbstractCell.java   (working copy)
@@ -135,7 +135,7 @@
   public void setValue(Context context, Element parent, C value) {
 SafeHtmlBuilder sb = new SafeHtmlBuilder();
 render(context, value, sb);
-parent.setInnerHTML(sb.toSafeHtml().asString());
+parent.setInnerSafeHtml(sb.toSafeHtml());
   }

   /**
Index: user/src/com/google/gwt/cell/client/ImageLoadingCell.java
===
--- user/src/com/google/gwt/cell/client/ImageLoadingCell.java	(revision  
11343)

+++ user/src/com/google/gwt/cell/client/ImageLoadingCell.java   (working copy)
@@ -195,8 +195,7 @@
   imgWrapper.getStyle().setProperty("overflow", "auto");
 } else if (BrowserEvents.ERROR.equals(type) &&  
eventOccurredOnImage(event, parent)) {

   // Replace the loading indicator with an error message.
-  parent.getFirstChildElement().setInnerHTML(
-  errorRenderer.render(value).asString());
+   
parent.getFirstChildElement().setInnerSafeHtml(errorRenderer.render(value));

 }
   }

Index: user/src/com/google/gwt/dom/builder/client/DomBuilderImpl.java
===
--- user/src/com/google/gwt/dom/builder/client/DomBuilderImpl.java	 
(revision 11343)
+++ user/src/com/google/gwt/dom/builder/client/DomBuilderImpl.java	(working  
copy)

@@ -568,7 +568,7 @@

   @Override
   protected void doHtmlImpl(SafeHtml html) {
-getCurrentElement().setInnerHTML(html.asString());
+getCurrentElement().setInnerSafeHtml(html);
   }

   @Override
Index: user/src/com/google/gwt/dom/builder/shared/HtmlBuilderImpl.java
===
--- user/src/com/google/gwt/dom/builder/shared/HtmlBuilderImpl.java	 
(revision 11343)
+++ user/src/com/google/gwt/dom/builder/shared/HtmlBuilderImpl.java	 
(working copy)

@@ -654,7 +654,7 @@
   @Override
   protected Element doFinishImpl() {
 Element tmp = Document.get().createDivElement();
-tmp.setInnerHTML(asSafeHtml().asString());
+tmp.setInnerSafeHtml(asSafeHtml());
 return tmp.getFirstChildElement();
   }

Index: user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java
===
--- user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java	 
(revision 11343)
+++ user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java	 
(working copy)

@@ -475,11 +475,11 @@
*/
   sectionTag = sectionTag.toLowerCase();
   if ("tbody".equals(sectionTag)) {
-tmpElem.setInnerHTML(template.tbody(rowHtml).asString());
+tmpElem.setInnerSafeHtml(template.tbody(rowHtml));
   } else if ("thead".equals(sectionTag)) {
-tmpElem.setInnerHTML(template.thead(rowHtml).asString());
+tmpElem.setInnerSafeHtml(template.thead(rowHtml));
   } el

Re: [gwt-contrib] GWT 2.5 Final - Next Week

2012-10-18 Thread Johannes Barop

I'm still having this issue: 
http://code.google.com/p/google-web-toolkit/issues/detail?id=7475

Am 18.10.2012 um 17:56 schrieb unnurg :

> Hi Guys -
>   We are going to be pushing the 2.5 RC2 (plus 1-2 minor cherrypicks) to 
> Final next week - if there are any problems, please let me 
> (unn...@google.com) know before Monday morning.  Note that "problems" 
> includes only regressions - so stuff that worked in 2.4 and is now broken in 
> 2.5.
> 
> Thanks everyone!
> - Unnur
> 
> -- 
> http://groups.google.com/group/Google-Web-Toolkit-Contributors

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] GWT 2.5 Final - Next Week

2012-10-18 Thread Unnur Gretarsdottir

Hi Jens -
  It seems like both of those are still being debugged and are potentially
unrelated to the 2.5 upgrade.  As far as I know, there were few changes to
RequestFactory and TabLayoutPanel in 2.5.  I added both of those threads to
my watchlist however, and if they resolve in the next few days to point to
a 2.5 regression we'll see what we can do.  Thanks for the heads up!

- Unnur

On Thu, Oct 18, 2012 at 12:00 PM, Jens  wrote:

> These came up on the GWT group from guys upgrading to 2.5 RC1/2:
>
> RequestFactory (Update from 2.4 to 2.5):
> https://groups.google.com/forum/#!msg/google-web-toolkit/kYrmJ3gQLRI/ZcjrSIZ_qWYJ
> TabLayoutPanel (Update from 2.3 to 2.5):
> https://groups.google.com/forum/#!msg/google-web-toolkit/E2-DcCWhz6U/57a52tcPIaAJ
>
> -- J.
>
> --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors

-- 
DO NOT FORWARD

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] GWT 2.5 Final - Next Week

2012-10-18 Thread Unnur Gretarsdottir

Hi Johannes -
  I've confirmed that this is not a regression - just a known issue with
the new closure compiler stuff.  I've updated the bug accordingly.
- Unnur


On Thu, Oct 18, 2012 at 11:35 AM, Unnur Gretarsdottir wrote:

> Hmmm - I'm not sure that will qualify as a regression - did it work in 2.4
> (I thought closure compiler was new in 2.5)?  I'll ping our guys that
> worked on Closure Compiler though and see what the status is - thanks for
> the heads up!
> - Unnur
>
>
> On Thu, Oct 18, 2012 at 11:19 AM, Johannes Barop  wrote:
>
>> I'm still having this issue:
>> http://code.google.com/p/google-web-toolkit/issues/detail?id=7475
>>
>> Am 18.10.2012 um 17:56 schrieb unnurg :
>>
>> Hi Guys -
>>   We are going to be pushing the 2.5 RC2 (plus 1-2 minor cherrypicks) to
>> Final next week - if there are any problems, please let me (
>> unn...@google.com) know before Monday morning.  Note that "problems"
>> includes only regressions - so stuff that worked in 2.4 and is now broken
>> in 2.5.
>>
>> Thanks everyone!
>> - Unnur
>>
>> --
>> http://groups.google.com/group/Google-Web-Toolkit-Contributors
>>
>>
>>
>
>
> --
> DO NOT FORWARD
>



-- 
DO NOT FORWARD

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] GWT 2.5 Final - Next Week

2012-10-18 Thread Jens

These came up on the GWT group from guys upgrading to 2.5 RC1/2:

RequestFactory (Update from 2.4 to 2.5): 
https://groups.google.com/forum/#!msg/google-web-toolkit/kYrmJ3gQLRI/ZcjrSIZ_qWYJ
TabLayoutPanel (Update from 2.3 to 2.5): 
https://groups.google.com/forum/#!msg/google-web-toolkit/E2-DcCWhz6U/57a52tcPIaAJ

-- J.

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] GWT 2.5 Final - Next Week

2012-10-18 Thread Unnur Gretarsdottir

Hmmm - I'm not sure that will qualify as a regression - did it work in 2.4
(I thought closure compiler was new in 2.5)?  I'll ping our guys that
worked on Closure Compiler though and see what the status is - thanks for
the heads up!
- Unnur


On Thu, Oct 18, 2012 at 11:19 AM, Johannes Barop  wrote:

> I'm still having this issue:
> http://code.google.com/p/google-web-toolkit/issues/detail?id=7475
>
> Am 18.10.2012 um 17:56 schrieb unnurg :
>
> Hi Guys -
>   We are going to be pushing the 2.5 RC2 (plus 1-2 minor cherrypicks) to
> Final next week - if there are any problems, please let me (
> unn...@google.com) know before Monday morning.  Note that "problems"
> includes only regressions - so stuff that worked in 2.4 and is now broken
> in 2.5.
>
> Thanks everyone!
> - Unnur
>
> --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
>
>
>


-- 
DO NOT FORWARD

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] GWT 2.5 Final - Next Week

2012-10-18 Thread unnurg

Hi Guys -
  We are going to be pushing the 2.5 RC2 (plus 1-2 minor cherrypicks) to 
Final next week - if there are any problems, please let me 
(unn...@google.com) know before Monday morning.  Note that "problems" 
includes only regressions - so stuff that worked in 2.4 and is now broken 
in 2.5.

Thanks everyone!
- Unnur

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Initial Gerrit setup for GWT Open Source Project

2012-10-18 Thread Thomas Broyer

All,

Matthew doesn't mention it above (it's a copy/paste from the mail he sent 
to us members of the Steering Committee a few days ago) but be prepared to 
rebase your changes sometime in the near future, as the "plugins" folder 
(for instance) will be extracted out into its own repository, meaning the 
whole repo history will be rewritten.
As Matthew said: consider this a "beta" release.

And since I'm writing this, I'd like to publicly thank Google, and more 
specifically Matthew, for setting up this platform.

On Wednesday, October 17, 2012 8:56:02 PM UTC+2, Matthew Dempsky wrote:
>
> *Hello GWT Contributors!
>
> I wanted to let you know that we've configured a Git and Gerrit server for 
> the GWT Open Source Project at https://gwt.googlesource.com and 
> https://gwt-review.googlesource.com, respectively.  It’s pre-populated 
> with a mirror of the Google Code Subversion repository using git-svn, and 
> we'll be keeping them in sync going forward.
>
> Consider this a "beta" release still, but it should currently be possible 
> for registered users to checkout the code and to post comments and vote. 
>  Additionally, users that sign the CLA should be able to upload changes of 
> their own.  We've also created an invite-only list 
> gwt-mai...@googlegroups.com  whose members will have 
> additional permissions for approving and submitting changes.  Ray Cromwell 
> is currently administering this list, so I'll leave it to him to take care 
> of adding people as appropriate.
>
> At the moment, the Git repo is effectively just an external mirror like 
> the current Subversion repo.  The intent here is to allow the community to 
> start trying out Gerrit instead of Rietveld for reviews, while we [Google] 
> work out the remaining details to switch from our current push-mirroring 
> model to a pull-mirroring model.  We intend to also now start accepting 
> patches uploaded to Gerrit (though still through manual import into our 
> internal repository).*
> *
> *
> *Please test it out and give us any feedback you have.
>
> Thanks,
> Matthew
>
>
> Gerrit Crash Course
>
> In case you’re not familiar with Gerrit already, here are a few beginner 
> steps to get started with:
>
> Going to 
> https://gwt.googlesource.com/or 
> https://gwt-review.googlesource.com/ you should be able to see the “gwt” 
> project.  You should also be able to anonymously check this out by simply 
> running “git clone https://gwt.googlesource.com/gwt”.
>
> Further, you should be able to go to https://gwt-review.googlesource.com/and 
> sign in using your Google Account.  Once signed in you should be able 
> to comment and code review existing issues like the sample issue I created 
> at https://gwt-review.googlesource.com/#/c/1020/.
>
> Finally, to actually create an issue is slightly more involved, but most 
> of the steps only need to be done once:
>
>
>1. Complete a Contributor Agreement: go to 
>https://gwt-review.googlesource.com, click “Settings” and then 
>“Agreements”, and follow the instructions.  If you previously submitted an 
>individual CLA electronically via Google Code, please do so again via 
>Gerrit (sorry!).  If you previously submitted a corporate CLA and 
>Gerrit does not reflect this already, please email me privately and I’ll 
>check with Google’s Open Source Program Office to get this resolved. 
>2. Setup your HTTP Password: Still under Settings, go to “HTTP 
>Password” and click “Obtain Password” and follow the steps to get your 
> HTTP 
>Password and/or to setup your .netrc file. 
>3. Setup your Gerrit commit-msg hook (optional, but recommended): 
>Gerrit provides a commit hook at 
>https://gwt-review.googlesource.com/tools/hooks/commit-msg to 
>automatically add Change-Id lines to your commits.  Download this and add 
>it to your checkout’s .git/hooks directory (e.g., “curl -o 
>.git/hooks/commit-msg 
>https://gwt-review.googlesource.com/tools/hooks/commit-msg && chmod +x 
>.git/hooks/commit-msg”). 
>4. Make a change and commit it locally using git (e.g., edit a file 
>foo and then run “git commit -m ‘my first change’ foo”). 
>5. Push the commit to Gerrit for review: git push origin 
>HEAD:refs/for/master. 
>
>
> Further details can be found in the Git and Gerrit documentations:
> http://git-scm.com/documentation
> https://gerrit-review.googlesource.com/Documentation/index.html*
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Update the DevMode Chrome plugin's Makefile to build a zip file to upload to the Chrome web store. (issue1858803)

[gwt-contrib] Re: Update the DevMode Chrome plugin's Makefile to build a zip file to upload to the Chrome web store. (issue1858803)

[gwt-contrib] Update the DevMode Chrome plugin's Makefile to build a zip file to upload to the Chrome web store. (issue1858803)

[gwt-contrib] Re: Replace instances of element.setInnerHTML(safeHtml.asString()) (issue1857803)

[gwt-contrib] Replace instances of element.setInnerHTML(safeHtml.asString()) (issue1857803)

Re: [gwt-contrib] GWT 2.5 Final - Next Week

Re: [gwt-contrib] GWT 2.5 Final - Next Week

Re: [gwt-contrib] GWT 2.5 Final - Next Week

Re: [gwt-contrib] GWT 2.5 Final - Next Week

Re: [gwt-contrib] GWT 2.5 Final - Next Week

[gwt-contrib] GWT 2.5 Final - Next Week

[gwt-contrib] Re: Initial Gerrit setup for GWT Open Source Project

12 matches

Site Navigation

Mail list logo

Footer information