Re: [gwt-contrib] GWT 2.5 Final - Next Week
Hi Unnur, This is a regression of code that works in 2.3 and 2.4. But we were able to implement a workaround based on the suggestions in the bug report. Jim. On Thursday, October 25, 2012 5:08:08 PM UTC-7, unnurg wrote: > > Hi Adam - > I'm sorry, but we were only considering immediate regressions (so > stuff that worked in 2.4 and broke in 2.5) for the 2.5 RC2 -> 2.5 > Final cherrypick list (we did add some patches that fixed older > problems, but they were patches that were small and ready to go, not > bug fix requests), and we also closed the door on new requests/issues > on Monday morning (at some point, we just have to draw the line and > get it out). > > - Unnur > > On Tue, Oct 23, 2012 at 1:07 PM, Adam Hawthorne > > > wrote: > > Hi Unnur, > > > > We just discovered that > > http://code.google.com/p/google-web-toolkit/issues/detail?id=7628severely > > breaks our application; is a fix for this a possibility for 2.5.0-final? > > > > For a little bit of background, we have a large number of high-level > command > > objects that may return data. The web application requests using RPC > and > > the server responds with these commands. When the client completes the > > commands, it can send responses back to the server with its next > request. > > These responses share a common parameterized superclass that holds a > value > > of that type. Each subclass specifies a concrete type to the type > > parameter. > > > > What we initially found to be a problem was a class 'IntArrayResponse > > extends Response> '. If the ArrayList had any > elements, > > we receive the RPC error. It might be possible to specify the value in > each > > subclass, but we haven't yet verified that. > > > > Thanks for your response, > > > > Adam > > > > On Thu, Oct 18, 2012 at 11:56 AM, unnurg > > wrote: > >> > >> Hi Guys - > >> We are going to be pushing the 2.5 RC2 (plus 1-2 minor cherrypicks) > to > >> Final next week - if there are any problems, please let me > >> (unn...@google.com ) know before Monday morning. Note > that "problems" > >> includes only regressions - so stuff that worked in 2.4 and is now > broken in > >> 2.5. > >> > >> Thanks everyone! > >> - Unnur > >> > >> -- > >> http://groups.google.com/group/Google-Web-Toolkit-Contributors > > > > > > > > > > -- > > Adam Hawthorne > > Software Architect > > BASIS International Ltd. > > www.basis.com > > +1.505.938.6169 Phone > > +1.505.750.4128 Direct > > > > -- > > http://groups.google.com/group/Google-Web-Toolkit-Contributors > > > > -- > DO NOT FORWARD > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Adding wrap method to Canvas and/or make constructor protected
On Mon, Oct 22, 2012 at 8:52 AM, Maik Riechert wrote:
> I'm using 2.5.0rc2 and find the Canvas class not useable if I use JS
> libraries through JSNI which give me canvas elements (I'm contributing to
> KineticGWT, a wrapper for KineticJS). There's no wrap() method like in the
> other widget classes and I can't even solve it by subclassing Canvas, as
> the constructor is private: private Canvas(CanvasElement element).
>
I haven't tried it personally, but you should be able to use the "violator
pattern" and call the private constructor from a JSNI method:
public static native Canvas createCanvas(CanvasElement element) /*-{
@com.google.gwt.canvas.client.Canvas::new(Lcom/google/gwt/dom/client/CanvasElement;)(element);
}
I don't know what else you will have to deal with for supplying the element
externally, but that should get you past the access control issue.
--
John A. Tamplin
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Chrome plugin: don't use an iterator after the underlying entry has been freed. (issue1861803)
LGTM http://gwt-code-reviews.appspot.com/1861803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Chrome plugin: don't use an iterator after the underlying entry has been freed. (issue1861803)
Awesome, I wondering if this effects the recurring bug we get with object ids.
On Thu, Oct 25, 2012 at 4:05 PM, wrote:
> Reviewers: mdempsky,
>
> Description:
> Chrome plugin: don't use an iterator after the underlying entry has been
> freed.
> Rebuilt Windows DLL and created a release.
> (This patch might help on Linux and Mac as well, but for safety I'm not
> updating them yet.)
>
>
> Please review this at http://gwt-code-reviews.appspot.com/1861803/
>
> Affected files:
> M plugins/npapi/LocalObjectTable.h
> M plugins/npapi/prebuilt/gwt-dev-plugin/manifest.json
>
>
> Index: plugins/npapi/LocalObjectTable.h
> ===
> --- plugins/npapi/LocalObjectTable.h(revision 11357)
> +++ plugins/npapi/LocalObjectTable.h(working copy)
> @@ -124,9 +124,9 @@
>Debug::log(Debug::Debugging) << "removing expando!" << Debug::flush;
>NPN_RemoveProperty(npp, it->second, gwtId);
> }
> -setFree(id);
> +NPObject* obj = it->second;
> +setFree(id); // erases entry, invalidating iterator
> if (!dontFree) {
> - NPObject* obj = it->second;
>NPN_ReleaseObject(obj);
> }
>}
> Index: plugins/npapi/prebuilt/gwt-dev-plugin/manifest.json
> ===
> --- plugins/npapi/prebuilt/gwt-dev-plugin/manifest.json (revision 11357)
> +++ plugins/npapi/prebuilt/gwt-dev-plugin/manifest.json (working copy)
> @@ -1,6 +1,6 @@
> {
>"name": "GWT Developer Plugin",
> - "version": "1.0.11349",
> + "version": "1.0.11357",
>"manifest_version": 2,
>
>"description": "A plugin to enable debugging with GWT's Development
> Mode",
>
>
> --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] GWT 2.5 Final - Next Week
Hi Adam - I'm sorry, but we were only considering immediate regressions (so stuff that worked in 2.4 and broke in 2.5) for the 2.5 RC2 -> 2.5 Final cherrypick list (we did add some patches that fixed older problems, but they were patches that were small and ready to go, not bug fix requests), and we also closed the door on new requests/issues on Monday morning (at some point, we just have to draw the line and get it out). - Unnur On Tue, Oct 23, 2012 at 1:07 PM, Adam Hawthorne wrote: > Hi Unnur, > > We just discovered that > http://code.google.com/p/google-web-toolkit/issues/detail?id=7628 severely > breaks our application; is a fix for this a possibility for 2.5.0-final? > > For a little bit of background, we have a large number of high-level command > objects that may return data. The web application requests using RPC and > the server responds with these commands. When the client completes the > commands, it can send responses back to the server with its next request. > These responses share a common parameterized superclass that holds a value > of that type. Each subclass specifies a concrete type to the type > parameter. > > What we initially found to be a problem was a class 'IntArrayResponse > extends Response> '. If the ArrayList had any elements, > we receive the RPC error. It might be possible to specify the value in each > subclass, but we haven't yet verified that. > > Thanks for your response, > > Adam > > On Thu, Oct 18, 2012 at 11:56 AM, unnurg wrote: >> >> Hi Guys - >> We are going to be pushing the 2.5 RC2 (plus 1-2 minor cherrypicks) to >> Final next week - if there are any problems, please let me >> (unn...@google.com) know before Monday morning. Note that "problems" >> includes only regressions - so stuff that worked in 2.4 and is now broken in >> 2.5. >> >> Thanks everyone! >> - Unnur >> >> -- >> http://groups.google.com/group/Google-Web-Toolkit-Contributors > > > > > -- > Adam Hawthorne > Software Architect > BASIS International Ltd. > www.basis.com > +1.505.938.6169 Phone > +1.505.750.4128 Direct > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors -- DO NOT FORWARD -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Adding wrap method to Canvas and/or make constructor protected
Hi, I'm using 2.5.0rc2 and find the Canvas class not useable if I use JS libraries through JSNI which give me canvas elements (I'm contributing to KineticGWT, a wrapper for KineticJS). There's no wrap() method like in the other widget classes and I can't even solve it by subclassing Canvas, as the constructor is private: private Canvas(CanvasElement element). This issue has been raised a year ago here: https://groups.google.com/d/topic/google-web-toolkit/xNA8wPpp9RY/discussion Could this be fixed for the final 2.5.0? Cheers Maik -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] GWT 2.5 Final - Next Week
Hi Unnur, We just discovered that http://code.google.com/p/google-web-toolkit/issues/detail?id=7628 severely breaks our application; is a fix for this a possibility for 2.5.0-final? For a little bit of background, we have a large number of high-level command objects that may return data. The web application requests using RPC and the server responds with these commands. When the client completes the commands, it can send responses back to the server with its next request. These responses share a common parameterized superclass that holds a value of that type. Each subclass specifies a concrete type to the type parameter. What we initially found to be a problem was a class 'IntArrayResponse extends Response> '. If the ArrayList had any elements, we receive the RPC error. It might be possible to specify the value in each subclass, but we haven't yet verified that. Thanks for your response, Adam On Thu, Oct 18, 2012 at 11:56 AM, unnurg wrote: > Hi Guys - > We are going to be pushing the 2.5 RC2 (plus 1-2 minor cherrypicks) to > Final next week - if there are any problems, please let me ( > unn...@google.com) know before Monday morning. Note that "problems" > includes only regressions - so stuff that worked in 2.4 and is now broken > in 2.5. > > Thanks everyone! > - Unnur > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors -- Adam Hawthorne Software Architect BASIS International Ltd. www.basis.com +1.505.938.6169 Phone +1.505.750.4128 Direct -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Hi Can anyone help me regarding development of resume via gwt.
Hi,Akash this side .I am web developer but new to GWT.But want to make a My fancy resume with the help of GWT.Can any one please help me to get source code of it.I will be very thankful for. Project name-development of resume or CV.With help of GWT -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Chrome plugin: don't use an iterator after the underlying entry has been freed. (issue1861803)
LGTM, nice catch. http://gwt-code-reviews.appspot.com/1861803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Chrome plugin: don't use an iterator after the underlying entry has been freed. (issue1861803)
Reviewers: mdempsky,
Description:
Chrome plugin: don't use an iterator after the underlying entry has been
freed.
Rebuilt Windows DLL and created a release.
(This patch might help on Linux and Mac as well, but for safety I'm not
updating them yet.)
Please review this at http://gwt-code-reviews.appspot.com/1861803/
Affected files:
M plugins/npapi/LocalObjectTable.h
M plugins/npapi/prebuilt/gwt-dev-plugin/manifest.json
Index: plugins/npapi/LocalObjectTable.h
===
--- plugins/npapi/LocalObjectTable.h(revision 11357)
+++ plugins/npapi/LocalObjectTable.h(working copy)
@@ -124,9 +124,9 @@
Debug::log(Debug::Debugging) << "removing expando!" << Debug::flush;
NPN_RemoveProperty(npp, it->second, gwtId);
}
-setFree(id);
+NPObject* obj = it->second;
+setFree(id); // erases entry, invalidating iterator
if (!dontFree) {
- NPObject* obj = it->second;
NPN_ReleaseObject(obj);
}
}
Index: plugins/npapi/prebuilt/gwt-dev-plugin/manifest.json
===
--- plugins/npapi/prebuilt/gwt-dev-plugin/manifest.json (revision 11357)
+++ plugins/npapi/prebuilt/gwt-dev-plugin/manifest.json (working copy)
@@ -1,6 +1,6 @@
{
"name": "GWT Developer Plugin",
- "version": "1.0.11349",
+ "version": "1.0.11357",
"manifest_version": 2,
"description": "A plugin to enable debugging with GWT's Development
Mode",
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Chrome devmode plugin: recompile Windows DLL to be statically linked. (issue1860803)
LGTM http://gwt-code-reviews.appspot.com/1860803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Chrome devmode plugin: recompile Windows DLL to be statically linked. (issue1860803)
Reviewers: mdempsky, Description: Chrome devmode plugin: recompile Windows DLL to be statically linked. Other fixes: - Check in zip file as uploaded to Chrome web store; remove crx file. - Makefile "zip" rule didn't include the manifest. Please review this at http://gwt-code-reviews.appspot.com/1860803/ Affected files: M plugins/npapi/Makefile M plugins/npapi/VisualStudio/npapi-plugin.vcxproj M plugins/npapi/prebuilt/gwt-dev-plugin/manifest.json -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
