[gwt-contrib] Problems pushing a patch to gerrit
Hi everyone, I am a little baffled that I am not able to push patches to gerrit anymore. I just tried to submit a simple patch for http://code.google.com/p/google-web-toolkit/issues/detail?id=7683 , but all I got was: To https://gwt.googlesource.com/gwt ! [remote rejected] master - master (prohibited by Gerrit) error: failed to push some refs to 'https://gwt.googlesource.com/gwt' I can`t seem to get any real information on what actually went wrong here. Is it working fine for everyone else or is it just me? -Daniel -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Problems pushing a patch to gerrit
On Mon, Oct 29, 2012 at 11:37 AM, Daniel Kurka kurka.dan...@gmail.comwrote: I am a little baffled that I am not able to push patches to gerrit anymore. I just tried to submit a simple patch for http://code.google.com/p/google-web-toolkit/issues/detail?id=7683 , but all I got was: To https://gwt.googlesource.com/gwt ! [remote rejected] master - master (prohibited by Gerrit) error: failed to push some refs to 'https://gwt.googlesource.com/gwt' I can`t seem to get any real information on what actually went wrong here. Is it working fine for everyone else or is it just me? Were you really trying to push to master? -- John A. Tamplin -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Problems pushing a patch to gerrit
Make sure you're using git push HEAD:refs/for/master. In particular, you need to push to refs/for/master and not to master directly if you want to create a review issue. For more details, see the Gerrit documentation: http://gerrit-documentation.googlecode.com/svn/Documentation/2.5/intro-quick.html#_creating_the_review http://gerrit-documentation.googlecode.com/svn/Documentation/2.5/user-upload.html#_git_push -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Problems pushing a patch to gerrit
my bad, got it working now... 2012/10/29 Matthew Dempsky mdemp...@google.com Make sure you're using git push HEAD:refs/for/master. In particular, you need to push to refs/for/master and not to master directly if you want to create a review issue. For more details, see the Gerrit documentation: http://gerrit-documentation.googlecode.com/svn/Documentation/2.5/intro-quick.html#_creating_the_review http://gerrit-documentation.googlecode.com/svn/Documentation/2.5/user-upload.html#_git_push -- http://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Move Super Dev Mode to the open source repository. (issue1727804)
Not yet. SuperDevMode is still considered experimental for 2.5. But we'll be working on it soon. On Mon, Oct 29, 2012 at 12:07 PM, NK naginkoth...@gmail.com wrote: With release of GWT 2.5GA has this issue been resolved? I tried to use SuperDev mode ig 2.5 GA, , it takes to recompile my app around 40to 60 sec. On Tuesday, June 5, 2012 4:06:15 AM UTC+5:30, Brian Slesinsky wrote: Reviewers: cromwellian, Description: Move Super Dev Mode to the open source repository. Includes a simple demo target that works with the Hello sample app. I've also made some linker options configurable, as necessary to make this work. Review by: cromw...@google.com Please review this at http://gwt-code-reviews.appspot.com/1727804/ Affected files: A dev/codeserver/BUILD A dev/codeserver/build.xml A dev/codeserver/java/com/google/gwt/dev/codeserver/AppSpace.java A dev/codeserver/java/com/google/gwt/dev/codeserver/CodeServer.java A dev/codeserver/java/com/google/gwt/dev/codeserver/CompileDir.java A dev/codeserver/java/com/google/gwt/dev/codeserver/CompilerOptionsImpl.java A dev/codeserver/java/com/google/gwt/dev/codeserver/ModuleState.java A dev/codeserver/java/com/google/gwt/dev/codeserver/Modules.java A dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java A dev/codeserver/java/com/google/gwt/dev/codeserver/Recompiler.java A dev/codeserver/java/com/google/gwt/dev/codeserver/SourceHandler.java A dev/codeserver/java/com/google/gwt/dev/codeserver/UnmodifiableCompilerOptions.java A dev/codeserver/java/com/google/gwt/dev/codeserver/WebServer.java A dev/codeserver/java/com/google/gwt/dev/codeserver/computeScriptBase.js A dev/codeserver/java/com/google/gwt/dev/codeserver/dev_mode_on.js A dev/codeserver/java/com/google/gwt/dev/codeserver/frontpage.html A dev/codeserver/java/com/google/gwt/dev/codeserver/modulepage.html M dev/core/src/com/google/gwt/core/linker/CrossSiteIframeLinker.java M samples/hello/src/com/google/gwt/sample/hello/Hello.gwt.xml M user/src/com/google/gwt/core/CrossSiteIframeLinker.gwt.xml -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] “GWT no longer supports ChromeFrame. The implementation caused more bugs than it solved.”
OK - I'm just removing the bullet point entirely now - should be live soon On Fri, Oct 26, 2012 at 5:53 PM, Thomas Broyer t.bro...@gmail.com wrote: On Thursday, July 19, 2012 12:16:26 AM UTC+2, rdayal wrote: Hey guys, This is my fault. I mis-interpreted the code change. As the change to fix this issue was basically a revert of the original commit that was supposed to add ChromeFrame support, I incorrectly assumed that reverting the code would prevent special behavior for ChromeFrame (which I figured we needed in order to make it work). Had I read issue #6665 more carefully, I would have realized that this fix was to improve support for ChromeFrame, not remove it entirely. I'll be sure to fix this statement in the release notes. 3 months later, this is unfortunately still there :-( Could anyone fix it please? -- DO NOT FORWARD -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Thanks minichate! (issue1863803)
http://gwt-code-reviews.appspot.com/1863803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] “GWT no longer supports ChromeFrame. The implementation caused more bugs than it solved.”
Ugh, thanks Unnur. Sorry about that, Thomas. On Mon, Oct 29, 2012 at 1:02 PM, Unnur Gretarsdottir unn...@google.comwrote: OK - I'm just removing the bullet point entirely now - should be live soon On Fri, Oct 26, 2012 at 5:53 PM, Thomas Broyer t.bro...@gmail.com wrote: On Thursday, July 19, 2012 12:16:26 AM UTC+2, rdayal wrote: Hey guys, This is my fault. I mis-interpreted the code change. As the change to fix this issue was basically a revert of the original commit that was supposed to add ChromeFrame support, I incorrectly assumed that reverting the code would prevent special behavior for ChromeFrame (which I figured we needed in order to make it work). Had I read issue #6665 more carefully, I would have realized that this fix was to improve support for ChromeFrame, not remove it entirely. I'll be sure to fix this statement in the release notes. 3 months later, this is unfortunately still there :-( Could anyone fix it please? -- DO NOT FORWARD -- http://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Thanks minichate! (issue1863803)
LGTM http://gwt-code-reviews.appspot.com/1863803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Thanks minichate! (issue1863803)
LGTM too http://gwt-code-reviews.appspot.com/1863803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Move Super Dev Mode to the open source repository. (issue1727804)
With release of GWT 2.5GA has this issue been resolved? I tried to use SuperDev mode ig 2.5 GA, , it takes to recompile my app around 40to 60 sec. On Tuesday, June 5, 2012 4:06:15 AM UTC+5:30, Brian Slesinsky wrote: Reviewers: cromwellian, Description: Move Super Dev Mode to the open source repository. Includes a simple demo target that works with the Hello sample app. I've also made some linker options configurable, as necessary to make this work. Review by: cromw...@google.com javascript: Please review this at http://gwt-code-reviews.appspot.com/1727804/ Affected files: A dev/codeserver/BUILD A dev/codeserver/build.xml A dev/codeserver/java/com/google/gwt/dev/codeserver/AppSpace.java A dev/codeserver/java/com/google/gwt/dev/codeserver/CodeServer.java A dev/codeserver/java/com/google/gwt/dev/codeserver/CompileDir.java A dev/codeserver/java/com/google/gwt/dev/codeserver/CompilerOptionsImpl.java A dev/codeserver/java/com/google/gwt/dev/codeserver/ModuleState.java A dev/codeserver/java/com/google/gwt/dev/codeserver/Modules.java A dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java A dev/codeserver/java/com/google/gwt/dev/codeserver/Recompiler.java A dev/codeserver/java/com/google/gwt/dev/codeserver/SourceHandler.java A dev/codeserver/java/com/google/gwt/dev/codeserver/UnmodifiableCompilerOptions.java A dev/codeserver/java/com/google/gwt/dev/codeserver/WebServer.java A dev/codeserver/java/com/google/gwt/dev/codeserver/computeScriptBase.js A dev/codeserver/java/com/google/gwt/dev/codeserver/dev_mode_on.js A dev/codeserver/java/com/google/gwt/dev/codeserver/frontpage.html A dev/codeserver/java/com/google/gwt/dev/codeserver/modulepage.html M dev/core/src/com/google/gwt/core/linker/CrossSiteIframeLinker.java M samples/hello/src/com/google/gwt/sample/hello/Hello.gwt.xml M user/src/com/google/gwt/core/CrossSiteIframeLinker.gwt.xml -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Move Super Dev Mode to the open source repository. (issue1727804)
With release of GWT 2.5GA has this issue been resolved? I tried to use SuperDev mode ig 2.5 GA, , it takes to recompile my app around 40to 60 sec. On Tuesday, June 5, 2012 4:06:15 AM UTC+5:30, Brian Slesinsky wrote: Reviewers: cromwellian, Description: Move Super Dev Mode to the open source repository. Includes a simple demo target that works with the Hello sample app. I've also made some linker options configurable, as necessary to make this work. Review by: cromw...@google.com javascript: Please review this at http://gwt-code-reviews.appspot.com/1727804/ Affected files: A dev/codeserver/BUILD A dev/codeserver/build.xml A dev/codeserver/java/com/google/gwt/dev/codeserver/AppSpace.java A dev/codeserver/java/com/google/gwt/dev/codeserver/CodeServer.java A dev/codeserver/java/com/google/gwt/dev/codeserver/CompileDir.java A dev/codeserver/java/com/google/gwt/dev/codeserver/CompilerOptionsImpl.java A dev/codeserver/java/com/google/gwt/dev/codeserver/ModuleState.java A dev/codeserver/java/com/google/gwt/dev/codeserver/Modules.java A dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java A dev/codeserver/java/com/google/gwt/dev/codeserver/Recompiler.java A dev/codeserver/java/com/google/gwt/dev/codeserver/SourceHandler.java A dev/codeserver/java/com/google/gwt/dev/codeserver/UnmodifiableCompilerOptions.java A dev/codeserver/java/com/google/gwt/dev/codeserver/WebServer.java A dev/codeserver/java/com/google/gwt/dev/codeserver/computeScriptBase.js A dev/codeserver/java/com/google/gwt/dev/codeserver/dev_mode_on.js A dev/codeserver/java/com/google/gwt/dev/codeserver/frontpage.html A dev/codeserver/java/com/google/gwt/dev/codeserver/modulepage.html M dev/core/src/com/google/gwt/core/linker/CrossSiteIframeLinker.java M samples/hello/src/com/google/gwt/sample/hello/Hello.gwt.xml M user/src/com/google/gwt/core/CrossSiteIframeLinker.gwt.xml -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] “GWT no longer supports ChromeFrame. The implementation caused more bugs than it solved.”
On Mon, Oct 29, 2012 at 9:33 PM, Rajeev Dayal rda...@google.com wrote: Ugh, thanks Unnur. Sorry about that, Thomas. No problem Rajeev. Better late than never ;-) -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Thanks minichate! (issue1863803)
http://gwt-code-reviews.appspot.com/1863803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
