[gwt-contrib] Re: Avoid using eval() (issue1882803)

[t . broyer]

Superseded by http://gwt-code-reviews.appspot.com/1883803

miichal, you can close this review.

http://gwt-code-reviews.appspot.com/1882803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Change in gwt[master]: Make sure a method and constructor cannot have the same sign...

[Roberto Lublinerman]

Roberto Lublinerman has abandoned this change.

Change subject: Make sure a method and constructor cannot have the same  
signature.

..


Abandoned

Submitted, thanks!

--
To view, visit https://gwt-review.googlesource.com/1330
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Iebcd7d0060bf7ac39c59e316b7d6dfb4c9727d7e
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Thomas Broyer 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Ray Cromwell 
Gerrit-Reviewer: Roberto Lublinerman 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Change in gwt[master]: Make sure a method and constructor cannot have the same sign...

[Brian Slesinsky]

Brian Slesinsky has posted comments on this change.

Change subject: Make sure a method and constructor cannot have the same  
signature.

..


Patch Set 2: Code-Review+1

--
To view, visit https://gwt-review.googlesource.com/1330
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iebcd7d0060bf7ac39c59e316b7d6dfb4c9727d7e
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Thomas Broyer 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Ray Cromwell 
Gerrit-Reviewer: Roberto Lublinerman 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Change in gwt[master]: Emit a warning if (some) incompatible options are used.

[Roberto Lublinerman]

Roberto Lublinerman has uploaded a new change for review.

  https://gwt-review.googlesource.com/1760


Change subject: Emit a warning if (some) incompatible options are used.
..

Emit a warning if (some) incompatible options are used.

In particular when -XenableClosureCompiler is used story of your compile  
reports

are disabled.

The GWT compiler does not keep track of the optimnization performed by the
Closure compiler, hence it lacks the information to produce a report that  
matches the

output.

Fixes issue 7475

Change-Id: I0e73b0107c23e54b69b9e648bff05d2135ff0b77
---
M dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
1 file changed, 10 insertions(+), 0 deletions(-)



diff --git  
a/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java  
b/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java

index 042e145..9a84a7f 100644
--- a/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
+++ b/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
@@ -485,7 +485,13 @@
   PermutationResult toReturn =
   new PermutationResultImpl(js, permutation,  
makeSymbolMap(symbolTable, jsProgram), ranges);

   CompilationMetricsArtifact compilationMetrics = null;
+
   // TODO: enable this when ClosureCompiler is enabled
+  if (options.isClosureCompilerEnabled() &&  
options.isCompilerMetricsEnabled() {
+logger.log(TreeLogger.WARN, "Incompatible options:  
-XenableClosureCompiler and "

++ "-XcompilerMetric; ignoring -XcompilerMetric.");
+  }
+
   if (!options.isClosureCompilerEnabled() &&  
options.isCompilerMetricsEnabled()) {
 compilationMetrics = new  
CompilationMetricsArtifact(permutation.getId());
  
compilationMetrics.setCompileElapsedMilliseconds(System.currentTimeMillis()

@@ -499,6 +505,10 @@
   }

   // TODO: enable this when ClosureCompiler is enabled
+  if (options.isClosureCompilerEnabled() && options.isSoycEnabled() {
+logger.log(TreeLogger.WARN, "Incompatible options:  
-XenableClosureCompiler and "

++ "-compileReport; ignoring -compileReport.");
+  }
   if (!options.isClosureCompilerEnabled()) {
 toReturn.addArtifacts(makeSoycArtifacts(logger, permutationId,  
jprogram, js, sizeBreakdowns,
 options.isSoycExtra() ? sourceInfoMaps : null, dependencies,  
jjsmap, obfuscateMap,


--
To view, visit https://gwt-review.googlesource.com/1760
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0e73b0107c23e54b69b9e648bff05d2135ff0b77
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Change in gwt[master]: Fixes compiler error for class extending an inner class.

[Roberto Lublinerman]

Roberto Lublinerman has abandoned this change.

Change subject: Fixes compiler error for class extending an inner class.
..


Abandoned

Submitted, thanks!

--
To view, visit https://gwt-review.googlesource.com/1690
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I0d1c5ababe332efad7b58b98b85a150b83d659f2
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Ray Cromwell 
Gerrit-Reviewer: Roberto Lublinerman 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] “GWT no longer supports ChromeFrame. The implementation caused more bugs than it solved.”

[Alex-Dan Luca]

Sorry to say this, but it's still there.

https://developers.google.com/web-toolkit/release-notes#Release_Notes_Current

Can you remove it?

*GWT no longer supports ChromeFrame. The implementation caused more bugs 
than it solved.*


On Monday, October 29, 2012 10:02:44 PM UTC+2, unnurg wrote:
>
> OK - I'm just removing the bullet point entirely now - should be live soon 
>
> On Fri, Oct 26, 2012 at 5:53 PM, Thomas Broyer 
> > 
> wrote: 
> > 
> > 
> > On Thursday, July 19, 2012 12:16:26 AM UTC+2, rdayal wrote: 
> >> 
> >> Hey guys, 
> >> 
> >> This is my fault. I mis-interpreted the code change. As the change to 
> >> "fix" this issue was basically a "revert" of the original commit that 
> was 
> >> supposed to add ChromeFrame support, I incorrectly assumed that 
> reverting 
> >> the code would prevent special behavior for ChromeFrame (which I 
> figured we 
> >> needed in order to make it work). Had I read issue #6665 more 
> carefully, I 
> >> would have realized that this fix was to improve support for 
> ChromeFrame, 
> >> not remove it entirely. 
> >> 
> >> I'll be sure to fix this statement in the release notes. 
> > 
> > 
> > 3 months later, this is unfortunately still there :-( 
> > 
> > Could anyone fix it please? 
> > 
>
>
>
> -- 
> DO NOT FORWARD 
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Change in gwt[master]: Make sure a method and constructor cannot have the same sign...

[Thomas Broyer]

Thomas Broyer has posted comments on this change.

Change subject: Make sure a method and constructor cannot have the same  
signature.

..


Patch Set 2: Code-Review+1

Ah, so it was that simple testing it!? ;-)

--
To view, visit https://gwt-review.googlesource.com/1330
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iebcd7d0060bf7ac39c59e316b7d6dfb4c9727d7e
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Thomas Broyer 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Ray Cromwell 
Gerrit-Reviewer: Roberto Lublinerman 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Avoid using eval() (issue1882803)

[jat]

LGTM with the suggested change.


http://gwt-code-reviews.appspot.com/1882803/diff/1/user/src/com/google/gwt/i18n/client/TimeZoneInfo.java
File user/src/com/google/gwt/i18n/client/TimeZoneInfo.java (right):

http://gwt-code-reviews.appspot.com/1882803/diff/1/user/src/com/google/gwt/i18n/client/TimeZoneInfo.java#newcode45
user/src/com/google/gwt/i18n/client/TimeZoneInfo.java:45: return
JSON.parse(json);
+1 on JsonUtils.safeEval(), and you don't need the separate eval method
any more -- just put it into buildTimeZoneData.

http://gwt-code-reviews.appspot.com/1882803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Support withCredentials attribute for XHR requests (Chrome 3+, Firefox 3.5+, Opera12+, Safari 4+... (issue1879804)

[t . broyer]

FYI, an issue related to this change:
https://code.google.com/p/google-web-toolkit/issues/detail?id=7677

http://gwt-code-reviews.appspot.com/1879804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Avoid using eval() (issue1882803)

[t . broyer]

(adding jtamplin as a reviewer as it's in I18N)


http://gwt-code-reviews.appspot.com/1882803/diff/1/user/src/com/google/gwt/i18n/client/TimeZoneInfo.java
File user/src/com/google/gwt/i18n/client/TimeZoneInfo.java (right):

http://gwt-code-reviews.appspot.com/1882803/diff/1/user/src/com/google/gwt/i18n/client/TimeZoneInfo.java#newcode45
user/src/com/google/gwt/i18n/client/TimeZoneInfo.java:45: return
JSON.parse(json);
JSON.parse() isn't available everywhere (that GWT supports).

Use JsonUtils.safeEval() instead, it'll use JSON.parse if available, and
fallback to eval() after checking it's safeToEval().

http://gwt-code-reviews.appspot.com/1882803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] GWT 2.5.1 release - Call for help

[Patrick Tucker]

I do not have an open issue for that patch.  Would you like me to create 
one?

On Tuesday, January 15, 2013 5:48:17 PM UTC-5, Daniel Kurka wrote:

> Hi Patrick,
>
> thanks for putting in the work, it's really appreciated!
>
> I have added the reviews to the list for GWT 2.5.1, there is no guarantee 
> that everything will land in GWT 2.5.1, but at least someone will take a 
> look.
>
> Do you have an open issue for http://gwt-code-reviews.appspot.com/1736804/
>  ?
>
> Thanks again,
> Daniel
>
>
> Am 13.01.2013 um 19:24 schrieb Patrick Tucker 
> >:
>
> http://gwt-code-reviews.appspot.com/1736804/
>
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Support withCredentials attribute for XHR requests (Chrome 3+, Firefox 3.5+, Opera12+, Safari 4+... (issue1879804)

[t . broyer]

http://gwt-code-reviews.appspot.com/1879804/diff/1/user/src/com/google/gwt/xhr/client/XMLHttpRequest.java
File user/src/com/google/gwt/xhr/client/XMLHttpRequest.java (right):

http://gwt-code-reviews.appspot.com/1879804/diff/1/user/src/com/google/gwt/xhr/client/XMLHttpRequest.java#newcode377
user/src/com/google/gwt/xhr/client/XMLHttpRequest.java:377: if
("withCredentials" in this.xmlHttpRequest) {
Is this check really needed? That XHR class is low-level, you're
supposed to know what you're doing when using it. Calling
setWithCredentials() on a non-cross-origin request is probably a
mistake, and I wouldn't really care that it throws in browsers not
supporting CORS (e.g. IE up to and including IE9), and if the browser
doesn't support CORS and you try to do a cross-origin request, then
open() would throw anyway, so it doesn't seem worth it to avoid an
exception in setWithCredentials.

http://gwt-code-reviews.appspot.com/1879804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] GWT 2.5.1 release - Call for help

[James Horsley]

Thanks Thomas. I'm happy to make any necessary changes to the patch so let
me know when you get more time to look it over again as I know you'd said
it was a big enough change to warrant a long look.


On 15 January 2013 12:24, Thomas Broyer  wrote:

>
>
> On Tuesday, January 15, 2013 12:02:54 PM UTC+1, James Horsley wrote:
>>
>> Anything I can do with 
>> https://codereview.appspot.**com/6132056/to
>>  help get it ready to go out with whatever release is deemed appropriate?
>>
>
> Won't make it to 2.5.1 sorry. For the next release after 2.5.1, my first
> task is to finish modularizing and mavenizing GWT, and only then I'll get
> back to fully work on fixing issues.
>
> --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors