[gwt-contrib] Change in gwt[master]: fixes ISSUE 7752 added constructor for java.util.logging.Lev...
Patrick Tucker has posted comments on this change. Change subject: fixes ISSUE 7752 added constructor for java.util.logging.Level gwt emulation to be compatible with JRE .. Patch Set 4: I'm just curious, why are hashCode() and equals(Object) not implemented? Where hashCode() would return intValue() and equals(Object) would == intValue(). -- To view, visit https://gwt-review.googlesource.com/1650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf7297eef0d7e892054baecfe3e1a023001e0325 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Patrick Tucker tucker...@gmail.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Unnur Gretarsdottir unn...@google.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Change in gwt[master]: Updates ICU4J from 4.4.2 to 50.1.1
It seems that the build.xml file has been merged with this patch but the tools directory still has the previous (4.4.2) version, hence with a fresh checkout of both, the build fails: common.ant.xml:169: The archive icu4j.jar doesn't exist On Tuesday, January 29, 2013 1:23:18 AM UTC+1, Andrew Bachmann wrote: Andrew Bachmann has posted comments on this change. Change subject: Updates ICU4J from 4.4.2 to 50.1.1 .. Patch Set 3: Code-Review+1 -- To view, visit https://gwt-review.googlesource.com/1700 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75c9e0e07c4d29a75573701a676a19d6e83b91d9 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John A. Tamplin j...@jaet.org javascript: Gerrit-Reviewer: Andrew Bachmann andrewb...@google.com javascript: Gerrit-Reviewer: Brian Slesinsky skyb...@google.com javascript: Gerrit-Reviewer: John A. Tamplin j...@jaet.org javascript: Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Proxy IDs have to be the same for a given proxy in the respo...
Brian Slesinsky has posted comments on this change. Change subject: Proxy IDs have to be the same for a given proxy in the response payload. .. Patch Set 2: Code-Review+1 -- To view, visit https://gwt-review.googlesource.com/1770 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c2ccbcfc67323e9e5cae214b0d101ddfc1a2298 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Fix for typo in JsJsonString (issue1802804)
LGTM http://gwt-code-reviews.appspot.com/1802804/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Fix for typo in JsJsonString (issue1802804)
On 2013/01/29 22:52:16, mdempsky wrote: LGTM Can you add a test case? It looks like that line is not covered in any test cases. http://gwt-code-reviews.appspot.com/1802804/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Currently the GWT compiler adds a var declaration for each c...
Ray Cromwell has uploaded a new change for review.
https://gwt-review.googlesource.com/1810
Change subject: Currently the GWT compiler adds a var declaration for each
catch parameter in a try/catch statement, but this is unneeded according to
the spec, and the Closure compiler will issue errors against it.
..
Currently the GWT compiler adds a var declaration for each catch parameter
in
a try/catch statement, but this is unneeded according to the spec, and the
Closure compiler will issue errors against it.
Change-Id: I05dd0429ec22315d57069046b0139ecce045919e
---
M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git
a/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
b/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
index 81ad168..6b86885 100644
--- a/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
+++ b/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
@@ -439,6 +439,7 @@
JsParameter jsParam = jsCatch.getParameter();
names.put(arg.getTarget(), jsParam.getName());
catchMap.put(catchBlock, jsCatch);
+catchParamIdentifiers.add(jsParam.getName());
push(jsCatch.getScope());
accept(catchBlock);
@@ -1146,7 +1147,9 @@
for (int i = 0; i locals.size(); ++i) {
JsName name = names.get(x.getLocals().get(i));
String ident = name.getIdent();
-if (!alreadySeen.contains(ident)) {
+if (!alreadySeen.contains(ident)
+// Catch block params don't need var declarations
+ !catchParamIdentifiers.contains(name)) {
alreadySeen.add(ident);
vars.add(new JsVar(x.getSourceInfo(), name));
}
@@ -2337,6 +2340,8 @@
private final MapJBlock, JsCatch catchMap = new
IdentityHashMapJBlock, JsCatch();
+ private final SetJsName catchParamIdentifiers = new HashSetJsName();
+
private final MapJClassType, JsScope classScopes = new
IdentityHashMapJClassType, JsScope();
/**
--
To view, visit https://gwt-review.googlesource.com/1810
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I05dd0429ec22315d57069046b0139ecce045919e
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Ray Cromwell cromwell...@google.com
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Currently the GWT compiler adds a var declaration for each c...
Matthew Dempsky has posted comments on this change. Change subject: Currently the GWT compiler adds a var declaration for each catch parameter in a try/catch statement, but this is unneeded according to the spec, and the Closure compiler will issue errors against it. .. Patch Set 1: Code-Review+1 Makes sense to me. -- To view, visit https://gwt-review.googlesource.com/1810 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05dd0429ec22315d57069046b0139ecce045919e Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Matthew Dempsky matt...@dempsky.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Currently the GWT compiler adds a var declaration for each c...
Roberto Lublinerman has posted comments on this change.
Change subject: Currently the GWT compiler adds a var declaration for each
catch parameter in a try/catch statement, but this is unneeded according to
the spec, and the Closure compiler will issue errors against it.
..
Patch Set 1: Code-Review+1
I don't have a full knowledge of Js generation but it SGTM.
I assume that code like
{ int x = ...
try {
} catch (Exception x) {
.
}
... = .. x ..
}
works correctly (i.e. there will be var x ).
--
To view, visit https://gwt-review.googlesource.com/1810
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I05dd0429ec22315d57069046b0139ecce045919e
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com
Gerrit-HasComments: No
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Currently the GWT compiler adds a var declaration for each c...
Brian Slesinsky has posted comments on this change. Change subject: Currently the GWT compiler adds a var declaration for each catch parameter in a try/catch statement, but this is unneeded according to the spec, and the Closure compiler will issue errors against it. .. Patch Set 1: Code-Review+1 Makes sense. Surprised no unit tests care. Do we check the generated JavaScript anywhere? -- To view, visit https://gwt-review.googlesource.com/1810 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05dd0429ec22315d57069046b0139ecce045919e Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: incremental dev mode
IMHO this should be the #1 feature to add to the next GWT version (after 2.5.1). On Thursday, December 13, 2012 5:18:15 AM UTC+1, Stephen Haberman wrote: Hey, Since Thomas brought up changes to dev mode, I've been thinking about how to implement an incremental dev mode. After playing with SuperDevMode, it is better (no extensions/etc.), but AFAICT it still starts over from let's build a ResourceOracle, now let's build a TypeOracle, etc. Seems like we should be able to reuse ResourceOracle, TypeOracle, etc., instances across compiles. And really, have the notion of invoking GWT dev mode compiles go away altogether. E.g. hook into Eclipse, and during auto builds have the JS files on disk just magically get updated after each save. I've been spiking an Eclipse plugin, which seems not as hard as I thought it would be, which incrementally generates .jribble files as .java/.class files change, with the idea of not embedding ecj anymore. That's a slightly separate topic though. The only thing that seems impossible with incremental compiles is preserving the semantics that code generators see--currently they are very deterministic/batch, and this would change all of that. But for the better, I think. (It would invert how GWT currently works--it's a batch system that sometimes we force (badly) to be incremental, to being an incremental system which sometimes you could run in batch (on the CLI).) Does this seem terribly egregious? I think if it worked, it would result in dramatic productivity improvements--the goal would be faster than coffeescript (or whatever) compiles, and truly instant refreshes after making changes. - Stephen -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] GWT 2.5.1 release - Call for help
Any news on the 2.5.1 release? On Saturday, January 19, 2013 5:01:33 PM UTC+2, Patrick Tucker wrote: Issue 7905 created. On Thursday, January 17, 2013 3:49:16 PM UTC-5, Daniel Kurka wrote: Please do ! Thanks Patrick! 2013/1/16 Patrick Tucker tuck...@gmail.com I do not have an open issue for that patch. Would you like me to create one? On Tuesday, January 15, 2013 5:48:17 PM UTC-5, Daniel Kurka wrote: Hi Patrick, thanks for putting in the work, it's really appreciated! I have added the reviews to the list for GWT 2.5.1, there is no guarantee that everything will land in GWT 2.5.1, but at least someone will take a look. Do you have an open issue for http://gwt-code-reviews.** appspot.com/1736804/ http://gwt-code-reviews.appspot.com/1736804/ ? Thanks again, Daniel Am 13.01.2013 um 19:24 schrieb Patrick Tucker tuck...@gmail.com: http://gwt-code-reviews.**appspot.com/1736804/http://gwt-code-reviews.appspot.com/1736804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
