[gwt-contrib] Re: Fix for typo in JsJsonString (issue1802804)
On 2013/01/29 22:54:41, goktug wrote: Can you add a test case? It looks like that line is not covered in any test cases. I think it should be covered by JsonUtilTest.java already, but it looks like we don't actually test that in production mode. Also, I think we don't run the elemental test suite internally at the moment. :/ http://gwt-code-reviews.appspot.com/1802804/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] GWT 2.5.1 Code freeze this friday
Cross post from GWT Steering: Hi everyone, we are going to do the code freeze for GWT 2.5.1 this Friday. We already got more than 30 issues fixed and committed in the last weeks (on top of the many fixes that already hit trunk after 2.5.0), but we still got some open issues that need reviewing. So if you feel strongly for any of those issues here is your chance to help. Here is a short list of the issues that still need work: 7481 http://code.google.com/p/google-web-toolkit/issues/detail?id=7481, 4714 http://code.google.com/p/google-web-toolkit/issues/detail?id=4714, 3533 http://code.google.com/p/google-web-toolkit/issues/detail?id=3533, 6161 http://code.google.com/p/google-web-toolkit/issues/detail?id=6161, 7655 http://code.google.com/p/google-web-toolkit/issues/detail?id=7655, 7836 http://code.google.com/p/google-web-toolkit/issues/detail?id=7836, 1054 http://code.google.com/p/google-web-toolkit/issues/detail?id=1054, 7834 http://code.google.com/p/google-web-toolkit/issues/detail?id=7834, 3069 http://code.google.com/p/google-web-toolkit/issues/detail?id=3069, 7752 http://code.google.com/p/google-web-toolkit/issues/detail?id=7752, 7436 http://code.google.com/p/google-web-toolkit/issues/detail?id=7436, 5477 http://code.google.com/p/google-web-toolkit/issues/detail?id=5477, 7716 http://code.google.com/p/google-web-toolkit/issues/detail?id=7716, 6130 http://code.google.com/p/google-web-toolkit/issues/detail?id=6130, 6959 http://code.google.com/p/google-web-toolkit/issues/detail?id=6959, 7905 http://code.google.com/p/google-web-toolkit/issues/detail?id=7905 A complete list can be found here: https://docs.google.com/spreadsheet/ccc?key=0AuK8EZ6jAAQrdDk1ME1lcmtWOWt3MngxOUlTMGJSVEE If you want to work on any of these issues please let me know, so that your work can actually make it into 2.5.1 -Daniel -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces GWT#reportUncaughtException and GWT#setUncaughtEx...
Goktug Gokdogan has uploaded a new change for review.
https://gwt-review.googlesource.com/1820
Change subject: Introduces GWT#reportUncaughtException and
GWT#setUncaughtExceptionHandlerForTest.
..
Introduces GWT#reportUncaughtException and
GWT#setUncaughtExceptionHandlerForTest.
Also this enables unit test frameworks to set an uncaught exception handler
without interfering with the user/production one. A following patch will
make the changes necessary to utilize new
GWT#setUncaughtExceptionHandlerForTest.
Change-Id: I7c25b8de334ef24c4795efdbb76023e0825136bb
---
M user/src/com/google/gwt/core/client/GWT.java
M user/src/com/google/gwt/core/client/impl/AsyncFragmentLoader.java
M user/src/com/google/gwt/core/client/impl/Impl.java
M user/src/com/google/gwt/core/client/impl/SchedulerImpl.java
M user/src/com/google/gwt/storage/client/StorageImpl.java
M user/src/com/google/gwt/user/client/AsyncProxy.java
M user/src/com/google/gwt/user/client/CommandExecutor.java
M user/src/com/google/gwt/user/client/impl/AsyncProxyBase.java
8 files changed, 135 insertions(+), 111 deletions(-)
diff --git a/user/src/com/google/gwt/core/client/GWT.java
b/user/src/com/google/gwt/core/client/GWT.java
index d2e2ca6..de13eac 100644
--- a/user/src/com/google/gwt/core/client/GWT.java
+++ b/user/src/com/google/gwt/core/client/GWT.java
@@ -1,12 +1,12 @@
/*
* Copyright 2008 Google Inc.
- *
+ *
* Licensed under the Apache License, Version 2.0 (the License); you may
not
* use this file except in compliance with the License. You may obtain a
copy of
* the License at
- *
+ *
* http://www.apache.org/licenses/LICENSE-2.0
- *
+ *
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an AS IS BASIS,
WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
@@ -61,18 +61,24 @@
* Defaults to codenull/code in Production Mode and an instance of
* {@link DefaultUncaughtExceptionHandler} in Development Mode.
*/
- private static UncaughtExceptionHandler sUncaughtExceptionHandler = null;
+ private static UncaughtExceptionHandler uncaughtExceptionHandler = null;
+
+ /**
+ * UncaughtExceptionHandler that is used by unit tests to spy on uncaught
+ * exceptions.
+ */
+ private static UncaughtExceptionHandler uncaughtExceptionHandlerForTest;
/**
* Instantiates a class via deferred binding.
- *
+ *
* p
* The argument to {@link #create(Class)}#160;imust/i be a class
literal
* because the Production Mode compiler must be able to statically
determine
* the requested type at compile-time. This can be tricky because using a
* {@link Class} variable may appear to work correctly in Development
Mode.
* /p
- *
+ *
* @param classLiteral a class literal specifying the base class to be
* instantiated
* @return the new instance, which must be cast to the requested class
@@ -90,7 +96,7 @@
* paths of resources which may be relative to the host page. Typically,
you
* should use {@link #getModuleBaseURL()} unless you have a specific
reason to
* load a resource relative to the host page.
- *
+ *
* @return if non-empty, the base URL is guaranteed to end with a slash
*/
public static String getHostPageBaseURL() {
@@ -157,18 +163,31 @@
}
/**
- * Returns the currently active uncaughtExceptionHandler. Top level
methods
- * that dispatch events from the browser into user code must call this
method
- * on entry to get the active handler. If the active handler is null, the
- * entry point must allow exceptions to escape into the browser. If the
- * handler is non-null, exceptions must be caught and routed to the
handler.
- * See the source code for codeDOM.dispatchEvent()/code for an
example
- * of how to handle this correctly.
- *
+ * Returns the currently active uncaughtExceptionHandler.
+ *
* @return the currently active handler, or null if no handler is active.
+ *
+ * @see #reportUncaughtException(Throwable)
*/
public static UncaughtExceptionHandler getUncaughtExceptionHandler() {
-return sUncaughtExceptionHandler;
+return uncaughtExceptionHandler;
+ }
+
+ /**
+ * Reports an exception caught at the top level to a handler set via
+ * {@link #setUncaughtExceptionHandler(UncaughtExceptionHandler)}. This
is
+ * used in places where the browser calls into user code such as event
+ * callbacks, timers, and RPC.
+ * p
+ * This method is a no-op if no handler is set.
+ */
+ public static void reportUncaughtException(Throwable t) {
+if (uncaughtExceptionHandler != null) {
+ uncaughtExceptionHandler.onUncaughtException(t);
+}
+if (uncaughtExceptionHandlerForTest != null) {
+ uncaughtExceptionHandler.onUncaughtException(t);
+}
}
/**
@@ -258,14 +277,28 @@
[gwt-contrib] Change in gwt[master]: Fixes internal compiler error caused by a null logger parsin...
Roberto Lublinerman has uploaded a new change for review.
https://gwt-review.googlesource.com/1830
Change subject: Fixes internal compiler error caused by a null logger
parsing jsni code that was generated by a generator at test time.
..
Fixes internal compiler error caused by a null logger parsing jsni code
that was generated by a generator at test time.
Change-Id: I034918d940c3318bc82ed9cb615c6f64b89fb027
---
M dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
M dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git
a/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
b/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
index 042e145..36102d2 100644
--- a/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
+++ b/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
@@ -618,7 +618,7 @@
try {
// (2) Assemble the Java AST.
UnifyAst unifyAst = new UnifyAst(jprogram, jsProgram, options, rpo);
- unifyAst.addRootTypes(allRootTypes);
+ unifyAst.addRootTypes(logger, allRootTypes);
// TODO: move this into UnifyAst?
findEntryPoints(logger, rpo, declEntryPts, jprogram);
unifyAst.exec(logger);
diff --git a/dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java
b/dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java
index a7aa3a9..ed7e38a 100644
--- a/dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java
+++ b/dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java
@@ -525,7 +525,9 @@
this.classFileMapBySource =
rpo.getCompilationState().getClassFileMapBySource();
}
- public void addRootTypes(CollectionString sourceTypeNames) throws
UnableToCompleteException {
+ public void addRootTypes(TreeLogger logger, CollectionString
sourceTypeNames)
+ throws UnableToCompleteException {
+this.logger = logger;
for (String sourceTypeName : sourceTypeNames) {
searchForTypeBySource(sourceTypeName);
}
--
To view, visit https://gwt-review.googlesource.com/1830
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I034918d940c3318bc82ed9cb615c6f64b89fb027
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman rlu...@google.com
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces GWT#reportUncaughtException and GWT#setUncaughtEx...
Brian Slesinsky has posted comments on this change.
Change subject: Introduces GWT#reportUncaughtException and
GWT#setUncaughtExceptionHandlerForTest.
..
Patch Set 1:
(6 comments)
Commit Message
Line 9: Also this enables unit test frameworks to set an uncaught exception
handler without interfering with the user/production one. A following patch
will make the changes necessary to utilize new
GWT#setUncaughtExceptionHandlerForTest.
line too long
File user/src/com/google/gwt/core/client/GWT.java
Line 180:* callbacks, timers, and RPC.
Can we keep the reference to DOM.dispatchEvent as an example?
Line 184: public static void reportUncaughtException(Throwable t) {
perhaps maybeReportUncaughtException?
Line 188: if (uncaughtExceptionHandlerForTest != null) {
It might be a bit more reliable to report it to the test framework first,
in case there's an exception in the other uncaught exception handler.
Maybe something like this:
interface TestExceptionHandler {
onUncaughtException(Throwable t, UncaughtExceptionHandler nextHandler);
}
if (testHandler != null) {
testHandler.onUncaughtException(t, uncaughtExceptionHandler);
} else if (uncaughtExceptionHandler != null) {
...
}
In the test harness, we could call the original handler (if any) and catch
the exception in the handler (if any) and report it.
Line 299: public static void setUncaughtExceptionHandlerForTest(
Do we really want this to be a public API? We could make it private to
GWTTestCase by making it default access here and putting a public method in
a less used class, perhaps in Impl or a new GwtTestApi class.
File user/src/com/google/gwt/core/client/impl/AsyncFragmentLoader.java
Line 3: *
Could you avoid reformatting trailing whitespace in this CL? It makes the
diffs smaller and you probably don't want your name to show up on those
lines in 'annotate', or at least not yet.
--
To view, visit https://gwt-review.googlesource.com/1820
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c25b8de334ef24c4795efdbb76023e0825136bb
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fixes internal compiler error caused by a null logger parsin...
Brian Slesinsky has posted comments on this change. Change subject: Fixes internal compiler error caused by a null logger parsing jsni code that was generated by a generator at test time. .. Patch Set 1: (1 comment) File dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java Line 528: public void addRootTypes(TreeLogger logger, CollectionString sourceTypeNames) It seems like it would be cleaner to pass the logger to the constructor and make it a final field. (It is only constructed in two places and it will be the same logger.) -- To view, visit https://gwt-review.googlesource.com/1830 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I034918d940c3318bc82ed9cb615c6f64b89fb027 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fixes internal compiler error caused by a null logger parsin...
Roberto Lublinerman has uploaded a new patch set (#2). Change subject: Fixes internal compiler error caused by a null logger parsing jsni code that was generated by a generator at test time. .. Fixes internal compiler error caused by a null logger parsing jsni code that was generated by a generator at test time. Change-Id: I034918d940c3318bc82ed9cb615c6f64b89fb027 Review-Link: https://gwt-review.googlesource.com/#/c/1830/ --- M dev/core/src/com/google/gwt/dev/jjs/AstConstructor.java M dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java M dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java 3 files changed, 9 insertions(+), 11 deletions(-) -- To view, visit https://gwt-review.googlesource.com/1830 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I034918d940c3318bc82ed9cb615c6f64b89fb027 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fixes internal compiler error caused by a null logger parsin...
Roberto Lublinerman has posted comments on this change. Change subject: Fixes internal compiler error caused by a null logger parsing jsni code that was generated by a generator at test time. .. Patch Set 1: (1 comment) File dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java Line 528: public void addRootTypes(TreeLogger logger, CollectionString sourceTypeNames) Done -- To view, visit https://gwt-review.googlesource.com/1830 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I034918d940c3318bc82ed9cb615c6f64b89fb027 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Emit a warning if (some) incompatible options are used.
Roberto Lublinerman has abandoned this change. Change subject: Emit a warning if (some) incompatible options are used. .. Abandoned Submitted, thanks! -- To view, visit https://gwt-review.googlesource.com/1760 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I0e73b0107c23e54b69b9e648bff05d2135ff0b77 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces GWT#reportUncaughtException and GWT#setUncaughtEx...
Goktug Gokdogan has posted comments on this change.
Change subject: Introduces GWT#reportUncaughtException and
GWT#setUncaughtExceptionHandlerForTest.
..
Patch Set 1:
(6 comments)
Commit Message
Line 9: Also this enables unit test frameworks to set an uncaught exception
handler without interfering with the user/production one. A following patch
will make the changes necessary to utilize new
GWT#setUncaughtExceptionHandlerForTest.
Done
File user/src/com/google/gwt/core/client/GWT.java
Line 180:* callbacks, timers, and RPC.
There was not longer uncaught exception handling in DOM.dispatch event so
I'm putting a reference to com.google.gwt.core.client.impl.Impl.
Line 184: public static void reportUncaughtException(Throwable t) {
Done.
Hopefully, I will introduce the one that always report in the next patch,
in that case we can use method name reportUncaughtException..
Line 188: if (uncaughtExceptionHandlerForTest != null) {
Done.
I changed the order. I'm not sure the other one carries the weight of added
complexity.
Also as now on, we will be in the control of exception reporting, we can do
add similar changes later.
Line 299: public static void setUncaughtExceptionHandlerForTest(
This is public in the sense as developers can set it to null to disable
exception reporting to the test frameworks.
File user/src/com/google/gwt/core/client/impl/AsyncFragmentLoader.java
Line 3: *
I can revert them. Are you referring to this specific CL or in general?
Eclipse doesn't give the option to remove trailing spaces just for edited
lines. When that feature it is not enabled, it becomes pretty painful to do
it manually.
Also this is usually fixes trailing spaces just in the comments so that was
the reason I didn't mind much.
--
To view, visit https://gwt-review.googlesource.com/1820
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c25b8de334ef24c4795efdbb76023e0825136bb
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fixes internal compiler error caused by a null logger parsin...
Brian Slesinsky has posted comments on this change. Change subject: Fixes internal compiler error caused by a null logger parsing jsni code that was generated by a generator at test time. .. Patch Set 2: Code-Review+1 -- To view, visit https://gwt-review.googlesource.com/1830 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I034918d940c3318bc82ed9cb615c6f64b89fb027 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces GWT#reportUncaughtException and GWT#setUncaughtEx...
Goktug Gokdogan has uploaded a new patch set (#2). Change subject: Introduces GWT#reportUncaughtException and GWT#setUncaughtExceptionHandlerForTest. .. Introduces GWT#reportUncaughtException and GWT#setUncaughtExceptionHandlerForTest. Also this enables unit test frameworks to set an uncaught exception handler without interfering with the user/production one. A following patch will make the changes necessary to utilize new GWT#setUncaughtExceptionHandlerForTest. Change-Id: I7c25b8de334ef24c4795efdbb76023e0825136bb Review-Link: https://gwt-review.googlesource.com/#/c/1820/ --- M user/src/com/google/gwt/core/client/GWT.java M user/src/com/google/gwt/core/client/impl/AsyncFragmentLoader.java M user/src/com/google/gwt/core/client/impl/Impl.java M user/src/com/google/gwt/core/client/impl/SchedulerImpl.java M user/src/com/google/gwt/storage/client/StorageImpl.java M user/src/com/google/gwt/user/client/AsyncProxy.java M user/src/com/google/gwt/user/client/CommandExecutor.java M user/src/com/google/gwt/user/client/impl/AsyncProxyBase.java 8 files changed, 69 insertions(+), 44 deletions(-) -- To view, visit https://gwt-review.googlesource.com/1820 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7c25b8de334ef24c4795efdbb76023e0825136bb Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces GWT#reportUncaughtException and GWT#setUncaughtEx...
Matthew Dempsky has posted comments on this change.
Change subject: Introduces GWT#reportUncaughtException and
GWT#setUncaughtExceptionHandlerForTest.
..
Patch Set 2:
(3 comments)
File user/src/com/google/gwt/core/client/GWT.java
Line 187: uncaughtExceptionHandler.onUncaughtException(t);
Should this be uncaughtExceptionHandlerForTest.onCaughtException(t)?
Line 189: if (uncaughtExceptionHandler != null) {
Intentionally if and not else if?
Also, can we re-throw the exception if no handler was registered? I
suppose that would change the interface.
Alternatively, we could return a boolean indicating whether it was
reported, then callers could write
if (!GWT.maybeReportUncaughtException(t))
throw t;
if they want the exception to propagate.
Line 301: UncaughtExceptionHandler uncaughtHandler) {
Can we rename the variable to just handler to match
setUncaughtExceptionHandler()?
--
To view, visit https://gwt-review.googlesource.com/1820
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c25b8de334ef24c4795efdbb76023e0825136bb
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces GWT#reportUncaughtException and GWT#setUncaughtEx...
Brian Slesinsky has posted comments on this change. Change subject: Introduces GWT#reportUncaughtException and GWT#setUncaughtExceptionHandlerForTest. .. Patch Set 1: (1 comment) File user/src/com/google/gwt/core/client/GWT.java Line 299: public static void setUncaughtExceptionHandlerForTest( That makes sense, but I don't think this is the right API for that use case. In production code, the uncaughtExceptionHandlerForTest field should not be used at all so it will compile away. So I think this method doesn't belong in a non-testing public API, particularly a very visible one like GWT. In a test, if there's a reason to disable the test's exception handler (which should be rare), it seems like it's more readable if it happens in gwtSetUp() or the test method itself, so someone reading the test knows that there's something special going on. So it seems like there should be a private API for GWTTestCase to use, and we should add a protected method to GWTTestCase itself to disable its default exception handling? -- To view, visit https://gwt-review.googlesource.com/1820 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c25b8de334ef24c4795efdbb76023e0825136bb Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fixes internal compiler error caused by a null logger parsin...
Ray Cromwell has posted comments on this change. Change subject: Fixes internal compiler error caused by a null logger parsing jsni code that was generated by a generator at test time. .. Patch Set 2: Code-Review+1 -- To view, visit https://gwt-review.googlesource.com/1830 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I034918d940c3318bc82ed9cb615c6f64b89fb027 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces GWT#reportUncaughtException and GWT#setUncaughtEx...
Goktug Gokdogan has posted comments on this change.
Change subject: Introduces GWT#reportUncaughtException and
GWT#setUncaughtExceptionHandlerForTest.
..
Patch Set 2:
(3 comments)
File user/src/com/google/gwt/core/client/GWT.java
Line 187: uncaughtExceptionHandler.onUncaughtException(t);
Yes, good catch. There is actually a test would fail with this error but
was not part of this patch :(
Line 189: if (uncaughtExceptionHandler != null) {
Intentionally if as I want to the same code flow for both unit tests and
production.
Originally I tried writing a version of this method that was doing exactly
what you are suggesting but I noticed that in a lot places that approach
was causing a lot of complexity and refactoring to handle it properly as
they are written in a way to swallow the exceptions.
Also code pieces that re-throw the exception is actually following a more
complex logic right now; they are not actually catching the exception in
the first place.
My plan is to turn this method into a reportUncaughtException which will
make the exception to escape to browser in a deferred when there is no
uncaught exception handler but hope will not break the code flow.
Line 301: UncaughtExceptionHandler uncaughtHandler) {
Done
--
To view, visit https://gwt-review.googlesource.com/1820
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c25b8de334ef24c4795efdbb76023e0825136bb
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces GWT#reportUncaughtException and GWT#setUncaughtEx...
Goktug Gokdogan has posted comments on this change. Change subject: Introduces GWT#reportUncaughtException and GWT#setUncaughtExceptionHandlerForTest. .. Patch Set 1: (1 comment) File user/src/com/google/gwt/core/client/GWT.java Line 299: public static void setUncaughtExceptionHandlerForTest( Agreed. Please take another look. -- To view, visit https://gwt-review.googlesource.com/1820 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c25b8de334ef24c4795efdbb76023e0825136bb Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces GWT#reportUncaughtException and GWT#setUncaughtEx...
Goktug Gokdogan has uploaded a new patch set (#3). Change subject: Introduces GWT#reportUncaughtException and GWT#setUncaughtExceptionHandlerForTest. .. Introduces GWT#reportUncaughtException and GWT#setUncaughtExceptionHandlerForTest. Also this enables unit test frameworks to set an uncaught exception handler without interfering with the user/production one. A following patch will make the changes necessary to utilize new GWT#setUncaughtExceptionHandlerForTest. Change-Id: I7c25b8de334ef24c4795efdbb76023e0825136bb Review-Link: https://gwt-review.googlesource.com/#/c/1820/ --- M user/src/com/google/gwt/core/client/GWT.java M user/src/com/google/gwt/core/client/impl/AsyncFragmentLoader.java M user/src/com/google/gwt/core/client/impl/Impl.java M user/src/com/google/gwt/core/client/impl/SchedulerImpl.java M user/src/com/google/gwt/storage/client/StorageImpl.java M user/src/com/google/gwt/user/client/AsyncProxy.java M user/src/com/google/gwt/user/client/CommandExecutor.java M user/src/com/google/gwt/user/client/impl/AsyncProxyBase.java 8 files changed, 74 insertions(+), 44 deletions(-) -- To view, visit https://gwt-review.googlesource.com/1820 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7c25b8de334ef24c4795efdbb76023e0825136bb Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Change in gwt[master]: Updates ICU4J from 4.4.2 to 50.1.1
Sorry about that - I hadn't realized that we don't automatically mirror this directory. It should be there now. On Tue, Jan 29, 2013 at 6:04 AM, Gaspard van Ko gaspar...@gmail.com wrote: It seems that the build.xml file has been merged with this patch but the tools directory still has the previous (4.4.2) version, hence with a fresh checkout of both, the build fails: common.ant.xml:169: The archive icu4j.jar doesn't exist On Tuesday, January 29, 2013 1:23:18 AM UTC+1, Andrew Bachmann wrote: Andrew Bachmann has posted comments on this change. Change subject: Updates ICU4J from 4.4.2 to 50.1.1 ..**..**.. Patch Set 3: Code-Review+1 -- To view, visit https://gwt-review.**googlesource.com/1700https://gwt-review.googlesource.com/1700 To unsubscribe, visit https://gwt-review.**googlesource.com/settingshttps://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75c9e0e07c4d29a75573701a676a1**9d6e83b91d9 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Andrew Bachmann andrewb...@google.com Gerrit-Reviewer: Brian Slesinsky skyb...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
