[gwt-contrib] Change in gwt[master]: Remove unnecessary wrapping of IOException in DiskCacheToken...
Brian Slesinsky has uploaded a new change for review.
https://gwt-review.googlesource.com/2020
Change subject: Remove unnecessary wrapping of IOException in
DiskCacheToken. This just increases stack trace verbosity, since the
callers either throw IOException already or could easily do so.
..
Remove unnecessary wrapping of IOException in DiskCacheToken.
This just increases stack trace verbosity, since the callers
either throw IOException already or could easily do so.
Change-Id: Idf40e5c09dc2b9a91c8ae96d8ba79f6f69890410
---
M dev/core/src/com/google/gwt/core/ext/linker/EmittedArtifact.java
M dev/core/src/com/google/gwt/core/ext/linker/SyntheticArtifact.java
M
dev/core/src/com/google/gwt/core/ext/linker/impl/StandardGeneratedResource.java
M dev/core/src/com/google/gwt/dev/util/DiskCache.java
M dev/core/src/com/google/gwt/dev/util/DiskCacheToken.java
5 files changed, 11 insertions(+), 38 deletions(-)
diff --git
a/dev/core/src/com/google/gwt/core/ext/linker/EmittedArtifact.java
b/dev/core/src/com/google/gwt/core/ext/linker/EmittedArtifact.java
index 067c238..4809866 100644
--- a/dev/core/src/com/google/gwt/core/ext/linker/EmittedArtifact.java
+++ b/dev/core/src/com/google/gwt/core/ext/linker/EmittedArtifact.java
@@ -220,15 +220,10 @@
* Provides access to the contents of the EmittedResource.
*/
public void writeTo(TreeLogger logger, OutputStream out)
- throws UnableToCompleteException {
-try {
- InputStream in = getContents(logger);
- Util.copyNoClose(in, out);
- Utility.close(in);
-} catch (IOException e) {
- logger.log(TreeLogger.ERROR, Unable to read or write stream, e);
- throw new UnableToCompleteException();
-}
+ throws IOException, UnableToCompleteException {
+InputStream in = getContents(logger);
+Util.copyNoClose(in, out);
+Utility.close(in);
}
@Override
diff --git
a/dev/core/src/com/google/gwt/core/ext/linker/SyntheticArtifact.java
b/dev/core/src/com/google/gwt/core/ext/linker/SyntheticArtifact.java
index 8fbb6f8..2fee86f 100644
--- a/dev/core/src/com/google/gwt/core/ext/linker/SyntheticArtifact.java
+++ b/dev/core/src/com/google/gwt/core/ext/linker/SyntheticArtifact.java
@@ -62,7 +62,7 @@
@Override
public void writeTo(TreeLogger logger, OutputStream out)
- throws UnableToCompleteException {
+ throws IOException {
diskCache.transferToStream(token, out);
}
diff --git
a/dev/core/src/com/google/gwt/core/ext/linker/impl/StandardGeneratedResource.java
b/dev/core/src/com/google/gwt/core/ext/linker/impl/StandardGeneratedResource.java
index c0b62d8..a25a3c5 100644
---
a/dev/core/src/com/google/gwt/core/ext/linker/impl/StandardGeneratedResource.java
+++
b/dev/core/src/com/google/gwt/core/ext/linker/impl/StandardGeneratedResource.java
@@ -57,7 +57,7 @@
@Override
public void writeTo(TreeLogger logger, OutputStream out)
- throws UnableToCompleteException {
+ throws IOException {
diskCache.transferToStream(token, out);
}
diff --git a/dev/core/src/com/google/gwt/dev/util/DiskCache.java
b/dev/core/src/com/google/gwt/dev/util/DiskCache.java
index f966f1f..5f34d13 100644
--- a/dev/core/src/com/google/gwt/dev/util/DiskCache.java
+++ b/dev/core/src/com/google/gwt/dev/util/DiskCache.java
@@ -144,7 +144,7 @@
*
* @return a token to retrieve the data later
*/
- public synchronized long transferFromStream(InputStream in) {
+ public synchronized long transferFromStream(InputStream in) throws
IOException {
assert in != null;
byte[] buf = Util.takeThreadLocalBuf();
try {
@@ -167,8 +167,6 @@
// Don't eagerly seek the end, the next operation might be a read.
atEnd = false;
return position;
-} catch (IOException e) {
- throw new RuntimeException(Unable to read from byte cache, e);
} finally {
Util.releaseThreadLocalBuf(buf);
}
@@ -180,7 +178,7 @@
* @param token a previously returned token
* @param out the stream to write into
*/
- public synchronized void transferToStream(long token, OutputStream out) {
+ public synchronized void transferToStream(long token, OutputStream out)
throws IOException {
byte[] buf = Util.takeThreadLocalBuf();
try {
atEnd = false;
@@ -197,8 +195,6 @@
length -= read;
out.write(buf, 0, read);
}
-} catch (IOException e) {
- throw new RuntimeException(Unable to read from byte cache, e);
} finally {
Util.releaseThreadLocalBuf(buf);
}
diff --git a/dev/core/src/com/google/gwt/dev/util/DiskCacheToken.java
b/dev/core/src/com/google/gwt/dev/util/DiskCacheToken.java
index 36952ce..373558f 100644
--- a/dev/core/src/com/google/gwt/dev/util/DiskCacheToken.java
+++ b/dev/core/src/com/google/gwt/dev/util/DiskCacheToken.java
@@ -15,9 +15,9 @@
*/
package com.google.gwt.dev.util;
+import java.io.IOException;
import
[gwt-contrib] Change in gwt[master]: Remove unnecessary wrapping of IOException in DiskCacheToken...
Matthew Dempsky has posted comments on this change. Change subject: Remove unnecessary wrapping of IOException in DiskCacheToken. This just increases stack trace verbosity, since the callers either throw IOException already or could easily do so. .. Patch Set 1: (1 comment) Looks like you could also simplify StandardPublicResource.SerializedPublicResource.writeTo()? Also, I think this alters the semantics of StandardLinkerContext.productOutput()? Currently there's a catch (IOException e) that would ignore UnableToCompleteExceptions, whereas now they'll be caught. Looking around, there seems to be a lot of catch-IOException-log-and-throw-UnableToCompleteException code actually. Do you think all of that should just let the IOException propagate directly? Maybe we can add a constructor to UnableToCompleteException to wrap an existing exception? File dev/core/src/com/google/gwt/dev/util/DiskCacheToken.java Line 72 Removing readString() is intentional? -- To view, visit https://gwt-review.googlesource.com/2020 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf40e5c09dc2b9a91c8ae96d8ba79f6f69890410 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes deprecated methods from JUnitShell.
Goktug Gokdogan has uploaded a new change for review.
https://gwt-review.googlesource.com/2030
Change subject: Removes deprecated methods from JUnitShell.
..
Removes deprecated methods from JUnitShell.
Change-Id: I0e3fc2b0773d3b9814e1800c2ddfaa21213adeab
---
M user/src/com/google/gwt/junit/JUnitShell.java
1 file changed, 1 insertion(+), 39 deletions(-)
diff --git a/user/src/com/google/gwt/junit/JUnitShell.java
b/user/src/com/google/gwt/junit/JUnitShell.java
index 1911031..8cff47a 100644
--- a/user/src/com/google/gwt/junit/JUnitShell.java
+++ b/user/src/com/google/gwt/junit/JUnitShell.java
@@ -29,9 +29,9 @@
import com.google.gwt.dev.cfg.ModuleDef;
import com.google.gwt.dev.cfg.Properties;
import com.google.gwt.dev.cfg.Property;
+import com.google.gwt.dev.javac.CompilationProblemReporter;
import com.google.gwt.dev.javac.CompilationState;
import com.google.gwt.dev.javac.CompilationUnit;
-import com.google.gwt.dev.javac.CompilationProblemReporter;
import com.google.gwt.dev.shell.CheckForUpdates;
import com.google.gwt.dev.shell.jetty.JettyLauncher;
import com.google.gwt.dev.util.arg.ArgHandlerDeployDir;
@@ -653,35 +653,6 @@
}
/**
- * Entry point for {@link com.google.gwt.junit.client.GWTTestCase}. Gets
or
- * creates the singleton {@link JUnitShell} and invokes its
- * {@link #runTestImpl(GWTTestCase, TestResult)}.
- *
- * @deprecated use {@link #runTest(GWTTestCase, TestResult)} instead
- */
- @Deprecated
- public static void runTest(String moduleName, TestCase testCase,
- TestResult testResult) throws UnableToCompleteException {
-runTest(moduleName, testCase, testResult,
-((GWTTestCase) testCase).getStrategy());
- }
-
- /**
- * @deprecated use {@link #runTest(GWTTestCase, TestResult)} instead
- */
- @Deprecated
- public static void runTest(String moduleName, TestCase testCase,
- TestResult testResult, Strategy strategy)
- throws UnableToCompleteException {
-GWTTestCase gwtTestCase = (GWTTestCase) testCase;
-assert moduleName != null : moduleName cannot be null;
-assert strategy != null : strategy cannot be null;
-assert moduleName.equals(gwtTestCase.getModuleName()) : moduleName
does not match GWTTestCase#getModuleName();
-assert strategy.equals(gwtTestCase.getStrategy()) : strategy does not
match GWTTestCase#getStrategy();
-runTest(gwtTestCase, testResult);
- }
-
- /**
* Retrieves the JUnitShell. This should only be invoked during
TestRunner
* execution of JUnit tests.
*/
@@ -1141,15 +1112,6 @@
} else {
compileForWebMode(module, userAgents);
}
- }
-
- /**
- * @deprecated TODO(fabbott) delete me
- */
- @Deprecated
- @SuppressWarnings(unused)
- void setNumClients(int numClients) {
-throw new UnsupportedOperationException(This method should be
deleted.);
}
void setStandardsMode(boolean standardsMode) {
--
To view, visit https://gwt-review.googlesource.com/2030
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0e3fc2b0773d3b9814e1800c2ddfaa21213adeab
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan gok...@google.com
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes deprecated methods from JUnitShell.
Matthew Dempsky has posted comments on this change. Change subject: Removes deprecated methods from JUnitShell. .. Patch Set 1: Code-Review+1 -- To view, visit https://gwt-review.googlesource.com/2030 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e3fc2b0773d3b9814e1800c2ddfaa21213adeab Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Remove unnecessary wrapping of IOException in DiskCacheToken...
Matthew Dempsky has posted comments on this change. Change subject: Remove unnecessary wrapping of IOException in DiskCacheToken. This just increases stack trace verbosity, since the callers either throw IOException already or could easily do so. .. Patch Set 1: Hm, after reading the Javadoc for UnableToCompleteException, just letting the original exceptions propagate seems most appropriate. I think StandardLinkerContext.productOutput() needs to throw an UnableToCompleteException if it catches an IOException (or allow the IOException to propagate). That seems like a bug at the moment that we might just log Fatal error and then let the compilation succeed anyway. :( -- To view, visit https://gwt-review.googlesource.com/2020 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf40e5c09dc2b9a91c8ae96d8ba79f6f69890410 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fix SpeedTracer Log when compilation is spread across differ...
Roberto Lublinerman has uploaded a new change for review.
https://gwt-review.googlesource.com/2031
Change subject: Fix SpeedTracer Log when compilation is spread across
different processes.
..
Fix SpeedTracer Log when compilation is spread across different processes.
The common time referrence recorded in baseTime was not correct.
Change-Id: If91008cd75c187dff667adc2411f60d4dadabbe3
---
M
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java
1 file changed, 13 insertions(+), 25 deletions(-)
diff --git
a/dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java
b/dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java
index 0866fcf..fa5730a 100644
---
a/dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java
+++
b/dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java
@@ -145,7 +145,7 @@
this.children = Lists.create();
this.devModeSession = session;
}
-
+
/**
* @param data key/value pairs to add to JSON object.
*/
@@ -395,19 +395,13 @@
private class ElapsedNormalizedTimeKeeper {
private final long zeroTimeNanos;
-private final long zeroTimeMillis;
public ElapsedNormalizedTimeKeeper() {
zeroTimeNanos = System.nanoTime();
- zeroTimeMillis = (long) convertToMilliseconds(zeroTimeNanos);
}
public long normalizedTimeNanos() {
return System.nanoTime() - zeroTimeNanos;
-}
-
-public long zeroTimeMillis() {
- return zeroTimeMillis;
}
}
@@ -419,8 +413,7 @@
private final OperatingSystemMXBean osMXBean;
private final Method getProcessCpuTimeMethod;
private final long zeroTimeNanos;
-private final long zeroTimeMillis;
-
+
public ProcessNormalizedTimeKeeper() {
try {
osMXBean = ManagementFactory.getOperatingSystemMXBean();
@@ -433,7 +426,6 @@
osMXBean.getClass().getMethod(getProcessCpuTime);
getProcessCpuTimeMethod.setAccessible(true);
zeroTimeNanos = (Long) getProcessCpuTimeMethod.invoke(osMXBean);
-zeroTimeMillis = (long) convertToMilliseconds(zeroTimeNanos);
} catch (Exception ex) {
throw new RuntimeException(ex);
}
@@ -445,10 +437,6 @@
} catch (Exception ex) {
throw new RuntimeException(ex);
}
-}
-
-public long zeroTimeMillis() {
- return zeroTimeMillis;
}
}
@@ -467,7 +455,6 @@
private final ThreadMXBean threadMXBean;
private final ThreadLocalLong resettableTimeBase = new
ThreadLocalLong();
private final long zeroTimeNanos;
-private final long zeroTimeMillis;
public ThreadNormalizedTimeKeeper() {
threadMXBean = ManagementFactory.getThreadMXBean();
@@ -475,7 +462,6 @@
throw new RuntimeException(Current thread cpu time not
supported);
}
zeroTimeNanos = System.nanoTime();
- zeroTimeMillis = (long) convertToMilliseconds(zeroTimeNanos);
}
public long normalizedTimeNanos() {
@@ -490,11 +476,7 @@
resettableTimeBase.set(System.nanoTime()
- zeroTimeNanos - threadMXBean.getCurrentThreadCpuTime());
}
-
-public long zeroTimeMillis() {
- return zeroTimeMillis;
-}
- }
+ }
/**
* Initializes the singleton on demand.
@@ -714,6 +696,15 @@
(logThreadCpuTime) ? new ThreadNormalizedTimeKeeper() : null;
/**
+ * Time in millis since the start of this process. To be used when
merging timelines
+ * created by different processes.
+ *
+ * Do not use nanoTime since it is not related to any fixed moment in
time and
+ * hence can not be used for merging timelines from different processes.
+ */
+ private final long baseTimeMillis = System.currentTimeMillis();
+
+ /**
* Constructor intended for unit testing.
*
* @param writer alternative {@link Writer} to send speed tracer output.
@@ -917,10 +908,7 @@
// Add a field to the top level event in order to track the base time
// so we can re-normalize the data
if (threadPendingEvents.size() == 0) {
- long baseTime = logProcessCpuTime ?
processCpuTimeKeeper.zeroTimeMillis()
- : (logThreadCpuTime ? threadCpuTimeKeeper.zeroTimeMillis()
- : elapsedTimeKeeper.zeroTimeMillis());
- newEvent.addData(baseTime, + baseTime);
+ newEvent.addData(baseTime, + baseTimeMillis);
}
threadPendingEvents.push(newEvent);
return newEvent;
--
To view, visit https://gwt-review.googlesource.com/2031
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If91008cd75c187dff667adc2411f60d4dadabbe3
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman rlu...@google.com
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You
[gwt-contrib] Change in gwt[master]: Fix SpeedTracer Log when compilation is spread across differ...
Matthew Dempsky has posted comments on this change. Change subject: Fix SpeedTracer Log when compilation is spread across different processes. .. Patch Set 1: Code-Review+1 Seems to make sense to me. -- To view, visit https://gwt-review.googlesource.com/2031 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: If91008cd75c187dff667adc2411f60d4dadabbe3 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Exposed ability for implmentations of Animation.java to check if the animation is currently running. (issue1891804)
Why protected? Also, shouldn't the unit tests be updated? http://gwt-code-reviews.appspot.com/1891804/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Exposed ability for implmentations of Animation.java to check if the animation is currently running. (issue1891804)
http://gwt-code-reviews.appspot.com/1891804/diff/1/user/src/com/google/gwt/animation/client/Animation.java
File user/src/com/google/gwt/animation/client/Animation.java (right):
http://gwt-code-reviews.appspot.com/1891804/diff/1/user/src/com/google/gwt/animation/client/Animation.java#newcode203
user/src/com/google/gwt/animation/client/Animation.java:203: * Is the
animation running, even if it hasn't started yet.
Returns true if the animation is running, even if it hasn't started
yet.
http://gwt-code-reviews.appspot.com/1891804/diff/1/user/src/com/google/gwt/animation/client/Animation.java#newcode205
user/src/com/google/gwt/animation/client/Animation.java:205: protected
boolean isRunning() {
Why protected? Since the running() and cancel() methods are public, I'd
imagine there are callers who would be interested in this method being
public.
http://gwt-code-reviews.appspot.com/1891804/
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Exposed ability for implmentations of Animation.java to check if the animation is currently running. (issue1891804)
On 2013/02/28 01:45:15, jtam wrote: Switched to Public. Not sure what you would like me to do in terms of unit tests. This is just exposing an internal which should be already tested. I think just adding appropriate asserts for isRunning()'s return value to AnimationTest would be sufficient. So that in the future if we refactor Animation, that we don't suddenly change the behavior inadvertently. http://gwt-code-reviews.appspot.com/1891804/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fix SpeedTracer Log when compilation is spread across differ...
Brian Slesinsky has posted comments on this change. Change subject: Fix SpeedTracer Log when compilation is spread across different processes. .. Patch Set 1: Code-Review+1 Sure, makes sense. -- To view, visit https://gwt-review.googlesource.com/2031 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: If91008cd75c187dff667adc2411f60d4dadabbe3 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fix SpeedTracer Log when compilation is spread across differ...
Roberto Lublinerman has abandoned this change. Change subject: Fix SpeedTracer Log when compilation is spread across different processes. .. Abandoned Submitted, Thanks! -- To view, visit https://gwt-review.googlesource.com/2031 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: If91008cd75c187dff667adc2411f60d4dadabbe3 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Exposed ability for implmentations of Animation.java to check if the animation is currently running. (issue1891804)
http://gwt-code-reviews.appspot.com/1891804/diff/7001/user/src/com/google/gwt/animation/client/Animation.java File user/src/com/google/gwt/animation/client/Animation.java (right): http://gwt-code-reviews.appspot.com/1891804/diff/7001/user/src/com/google/gwt/animation/client/Animation.java#newcode203 user/src/com/google/gwt/animation/client/Animation.java:203: * Returns true if the animation is running, even if it hasn't started yet. I think javadoc is confusing as it is for a public api as differentiation of started vs running is not made in any place. What about following: Returns true if the animation is running. Note that animation may be 'running' but no callbacks is executed yet. http://gwt-code-reviews.appspot.com/1891804/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
