[gwt-contrib] Change in gwt[master]: Allow strong name to be omitted.
Brian Slesinsky has posted comments on this change.
Change subject: Allow strong name to be omitted.
..
Patch Set 1: Code-Review+1
(1 comment)
File
user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamReader.java
Line 499: if (serializationPolicyProvider != null) {
Maybe we should put this check on the previous line? If there's no
strongName, skip the policy provider altogether.
But this is safer for now.
--
To view, visit https://gwt-review.googlesource.com/2420
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9d4ae13a9fdf188bfacb2caabb0b5b136dc342a
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Matthew Dempsky
Gerrit-Reviewer: Brian Slesinsky
Gerrit-Reviewer: Matthew Dempsky
Gerrit-Reviewer: Matthew Dempsky
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Allow strong name to be omitted.
Matthew Dempsky has posted comments on this change. Change subject: Allow strong name to be omitted. .. Patch Set 1: That's an interesting failure... looks like the "java" command broke on the jenkins VPS(!!). -- To view, visit https://gwt-review.googlesource.com/2420 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9d4ae13a9fdf188bfacb2caabb0b5b136dc342a Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matthew Dempsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Matthew Dempsky Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Allow strong name to be omitted.
Matthew Dempsky has posted comments on this change. Change subject: Allow strong name to be omitted. .. Patch Set 1: Verified-1 Boo, this patch set FAILED the build and/or checkstyle tests. :( Build details: http://gwt-ci.dempsky.org:8080/job/gwt.checkstyle/25/ -- To view, visit https://gwt-review.googlesource.com/2420 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9d4ae13a9fdf188bfacb2caabb0b5b136dc342a Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matthew Dempsky Gerrit-Reviewer: Matthew Dempsky Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Allow strong name to be omitted.
Matthew Dempsky has uploaded a new change for review.
https://gwt-review.googlesource.com/2420
Change subject: Allow strong name to be omitted.
..
Allow strong name to be omitted.
Change-Id: Ie9d4ae13a9fdf188bfacb2caabb0b5b136dc342a
---
M
user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamReader.java
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamReader.java
b/user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamReader.java
index 3ba3dd5..6b703e8 100644
---
a/user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamReader.java
+++
b/user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamReader.java
@@ -497,7 +497,7 @@
String moduleBaseURL = readString();
String strongName = readString();
if (serializationPolicyProvider != null) {
- if (!ALLOWED_STRONG_NAME.matcher(strongName).matches()) {
+ if (strongName != null
&& !ALLOWED_STRONG_NAME.matcher(strongName).matches()) {
throw new SerializationException(
"GWT-RPC request is invalid because the strong name contains
invalid characters");
}
--
To view, visit https://gwt-review.googlesource.com/2420
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie9d4ae13a9fdf188bfacb2caabb0b5b136dc342a
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Matthew Dempsky
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Fixes #8036, properly sorting of places in PlaceHistoryGeneratorContext (issue1895803)
We just need someone with commit rights. Calling in Matthew (at random), who will delegate if needed. http://gwt-code-reviews.appspot.com/1895803/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
