[gwt-contrib] Re: corrects typos (issue1902803)

2013-04-17 Thread rluble

Ray, are these public methods used at all by custom linkers or any other
user code?

http://gwt-code-reviews.appspot.com/1902803/

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Add callbacks to Super Dev Mode to find out when a compile s...

2013-04-17 Thread Brian Slesinsky

Brian Slesinsky has abandoned this change.

Change subject: Add callbacks to Super Dev Mode to find out when a compile  
starts and finishes, and an alternate main() that can be called after  
parsing options.

..


Abandoned

Submitted.

--
To view, visit https://gwt-review.googlesource.com/2540
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I2a27a07d2c8219d496613b1c1c88380c6dc3d032
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Brian Slesinsky 
Gerrit-Reviewer: James Nelson 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Matthew Dempsky 

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Add callbacks to Super Dev Mode to find out when a compile s...

2013-04-17 Thread Matthew Dempsky

Matthew Dempsky has posted comments on this change.

Change subject: Add callbacks to Super Dev Mode to find out when a compile  
starts and finishes, and an alternate main() that can be called after  
parsing options.

..


Patch Set 1:

Hoorays, this change passed the build and style presubmit. :D  More details  
at http://gwt-ci.dempsky.org:8080/job/gwt.presubmit/30


--
To view, visit https://gwt-review.googlesource.com/2540
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2a27a07d2c8219d496613b1c1c88380c6dc3d032
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Brian Slesinsky 
Gerrit-Reviewer: James Nelson 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-HasComments: No

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Re: corrects typos (issue1902803)

2013-04-17 Thread mdempsky

On 2013/04/17 23:12:34, mdempsky wrote:

Face palm.


(And that's at the typos being overlooked for so long, not at the
patch!)

http://gwt-code-reviews.appspot.com/1902803/

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Re: corrects typos (issue1902803)

2013-04-17 Thread mdempsky

Face palm.

Does this break backwards compatibility at all?  E.g., are any of the
permuation methods user accessible?  Do we need to add @Deprecated
forwarding methods for them?

http://gwt-code-reviews.appspot.com/1902803/

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Re: corrects typos (issue1902803)

2013-04-17 Thread rluble

LGTM.

I can not believe that this was not caught by anyone before.

http://gwt-code-reviews.appspot.com/1902803/

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Fixes ISSUE 7079 - Add support for the newer bindery Handler...

2013-04-17 Thread Matthew Dempsky

Matthew Dempsky has posted comments on this change.

Change subject: Fixes ISSUE 7079 - Add support for the newer bindery  
HandlerRegistration

..


Patch Set 1: Verified+1

Hoorays, this change passed presubmit. :D  More details at

--
To view, visit https://gwt-review.googlesource.com/1350
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80f23b094f55e40d2b2223e9f018c98c4e41a850
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Julien Dramaix 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Julien Dramaix 
Gerrit-Reviewer: Manuel Carrasco MoƱino 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-HasComments: No

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.

2013-04-17 Thread Matthew Dempsky

Matthew Dempsky has posted comments on this change.

Change subject: Removes api-checker reference JARs from the source tree.
..


Patch Set 1: Verified-1

Oops, this change failed presubmit. :(  More details at

--
To view, visit https://gwt-review.googlesource.com/2500
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Thomas Broyer 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Ray Cromwell 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Re: documents and tests the fact that the ArgProcessor allows duplicate args and honors the last one (issue1901803)

2013-04-17 Thread rluble

On 2013/04/17 21:10:31, stalcup wrote:

LGTM.

BTW, we are using gwt-review.googlesource.com

http://gwt-code-reviews.appspot.com/1901803/

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Add callbacks to Super Dev Mode to find out when a compile s...

2013-04-17 Thread Matthew Dempsky

Matthew Dempsky has posted comments on this change.

Change subject: Add callbacks to Super Dev Mode to find out when a compile  
starts and finishes, and an alternate main() that can be called after  
parsing options.

..


Patch Set 1: Verified+1

Hoorays, this change passed presubmit. :D  More details at

--
To view, visit https://gwt-review.googlesource.com/2540
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2a27a07d2c8219d496613b1c1c88380c6dc3d032
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Brian Slesinsky 
Gerrit-Reviewer: James Nelson 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-HasComments: No

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




Re: [gwt-contrib] Re: RequestFactory Feature Request: @Immutable EntityProxy, reduced payload size, Map support.

2013-04-17 Thread Thomas Broyer


On Wednesday, April 17, 2013 12:17:25 PM UTC+2, James Horsley wrote:
>
> Hey Thomas, 
>
> Totally understand that modularization and mavenization are top priorities 
> but does that mean my Map support patch need to wait until after GWT 2.6?
>

I'm afraid it'll have to; or put differently I can't guarantee it'll be in 
2.6, and I wouldn't want to delay 2.6 for that patch (sorry). Time will 
tell.

-- 
-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups 
"Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Add explicit assertNonNull() statements to JSONTest for clea...

2013-04-17 Thread Matthew Dempsky

Matthew Dempsky has posted comments on this change.

Change subject: Add explicit assertNonNull() statements to JSONTest for  
cleaner test failures.

..


Patch Set 1: Verified-1

testing

--
To view, visit https://gwt-review.googlesource.com/1962
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I283419f3665cec632a438b4a68cc946c09e4f0ac
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Matthew Dempsky 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-HasComments: No

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Re: Fixing AbsolutePanel to set positioning of 'right' instead of 'left' for RTL languages. Without ... (issue1900803)

2013-04-17 Thread goktug

Thanks Andrew & John!

Yes, agreed. Having RTL-aware methods makes sense:

  setWidgetPosition  => sets left for backward compatibility
  setWidgetLeftPosition  => sets left
  setWidgetRightPosition => sets right
  setWidgetLineStartPosition => sets left if LTR, right if RTL
  setWidgetLineEndPosition   => sets right if LTR, left if RTL

What do you think?

On 2013/04/17 19:30:03, Andrew Bachmann wrote:

DockLayoutPanel separates line_start from west, and it seems like it

would be

appropriate to separate line_start from left in this situation.  This

way would

be backwards compatible.



To fix the problem in the description, it would be necessary to add a

new

RTL-aware add method, similar to DockLayoutPanel add* methods.



http://gwt-code-reviews.appspot.com/1900803/

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Re: Fixing AbsolutePanel to set positioning of 'right' instead of 'left' for RTL languages. Without ... (issue1900803)

2013-04-17 Thread andrewbachmann

DockLayoutPanel separates line_start from west, and it seems like it
would be appropriate to separate line_start from left in this situation.
 This way would be backwards compatible.

To fix the problem in the description, it would be necessary to add a
new RTL-aware add method, similar to DockLayoutPanel add* methods.

http://gwt-code-reviews.appspot.com/1900803/

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Avoid creating anonymous inner classes with wildcard type pa...

2013-04-17 Thread Roberto Lublinerman

Roberto Lublinerman has abandoned this change.

Change subject: Avoid creating anonymous inner classes with wildcard type  
parameters.

..


Abandoned

Submitted, thanks!

--
To view, visit https://gwt-review.googlesource.com/2470
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ifbcd6ecec455512a7da5eb473c6bf2e9f402f0ea
Gerrit-PatchSet: 7
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Roberto Lublinerman 
Gerrit-Reviewer: Thomas Broyer 

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Re: Fixing AbsolutePanel to set positioning of 'right' instead of 'left' for RTL languages. Without ... (issue1900803)

2013-04-17 Thread jat

On 2013/04/17 17:21:49, goktug wrote:

On 2013/04/17 05:14:32, yaminik wrote:



Reviewers needed.



I don't have much experience with RTL issues. At least this change

will very

likely break any previous code that was not assuming the different

behavior for

RTL in AbsolutePanel.



I would love to hear what you guys think.


You should get Aharon inside Google to look at it -- he wrote much of
the Bidi support in GWT.

http://gwt-code-reviews.appspot.com/1900803/

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Re: Fixing AbsolutePanel to set positioning of 'right' instead of 'left' for RTL languages. Without ... (issue1900803)

2013-04-17 Thread goktug

On 2013/04/17 05:14:32, yaminik wrote:

Reviewers needed.

I don't have much experience with RTL issues. At least this change will
very likely break any previous code that was not assuming the different
behavior for RTL in AbsolutePanel.

I would love to hear what you guys think.

http://gwt-code-reviews.appspot.com/1900803/

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Avoid creating anonymous inner classes with wildcard type pa...

2013-04-17 Thread Roberto Lublinerman

Roberto Lublinerman has uploaded a new patch set (#7).

Change subject: Avoid creating anonymous inner classes with wildcard type  
parameters.

..

Avoid creating anonymous inner classes with wildcard type parameters.

Under Java 7 wildcards can not be type parameters of superclasses in the  
extends clause
nor superinterfaces in the implementing clause. Anonymous inner classes can  
not have wildcards

in their type parameters.

Change-Id: Ifbcd6ecec455512a7da5eb473c6bf2e9f402f0ea
Review-Link: https://gwt-review.googlesource.com/#/c/2470/
---
M user/src/com/google/gwt/uibinder/rebind/HandlerEvaluator.java
M user/test/com/google/gwt/uibinder/UiBinderSuite.java
A user/test/com/google/gwt/uibinder/test/client/UiHandlerTest.java
M user/test/com/google/gwt/uibinder/test/client/WidgetBasedUi.java
M user/test/com/google/gwt/uibinder/test/client/WidgetBasedUi.ui.xml
A  
user/test/com/google/gwt/uibinder/test/client/WildcardValueChangeWidget.java

6 files changed, 184 insertions(+), 8 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/2470
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifbcd6ecec455512a7da5eb473c6bf2e9f402f0ea
Gerrit-PatchSet: 7
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Roberto Lublinerman 
Gerrit-Reviewer: Thomas Broyer 

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Fix non deterministic behaviour in TypeTightener.

2013-04-17 Thread Roberto Lublinerman

Roberto Lublinerman has abandoned this change.

Change subject: Fix non deterministic behaviour in TypeTightener.
..


Abandoned

Submitted, thanks!

--
To view, visit https://gwt-review.googlesource.com/2530
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I51f551dbf2d5362f710d4e1321f7b7bb35445608
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Ray Cromwell 
Gerrit-Reviewer: Roberto Lublinerman 
Gerrit-Reviewer: Thomas Broyer 

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




Re: [gwt-contrib] Re: RequestFactory Feature Request: @Immutable EntityProxy, reduced payload size, Map support.

2013-04-17 Thread James Horsley
Hey Thomas,

Totally understand that modularization and mavenization are top priorities
but does that mean my Map support patch need to wait until after GWT 2.6? I
know things have been in a transitional period but I submitted the patch
almost a year ago now and would love to get the support in; let me know if
there's anything I can do to help get the patch in a better position to go
out.

Hopefully not coming across too negatively as things seem to be picking up
pace in a great way for GWT in the last few months, just would love to get
Map support integrated.

Cheers,
James


On 16 April 2013 23:56, Thomas Broyer  wrote:

>
> On Tuesday, April 16, 2013 7:43:12 PM UTC+2, Stefan Ollinger wrote:
>>
>> Hi,
>>
>> when editing large object graphs on the client-side, there are currently
>> two problems regarding performance:
>>
>> 1) Entity proxies could not be modified when firing a RequestContext. A
>> diff will be done nevertheless, which costs CPU time. There could be an
>> annotation which marks entity proxies as immutable on the client-side and
>> forces RF to always send the EntityProxyId.
>>
>> 2) All reachable value proxies on the edited data will be sent, even if
>> the owner entity proxies did not change. This increases the payload size
>> and could be avoided by sending only those values proxies which are
>> reachable through actually edited entity proxies (or request arguments).
>> There is already a todo in https://code.google.com/p/**
>> google-web-toolkit/source/**browse/trunk/user/src/com/**
>> google/web/bindery/**requestfactory/shared/impl/**
>> AbstractRequestContext.java#**1211
>>
>> Are you aware of those problems, and are they relevant enough to be taken
>> into account in one of the next releases?
>>
>> Also is there a plan to add support for Maps (https://codereview.appspot.
>> **com/6132056/ .)?
>>
>
> Hi Stefan. I'm the one "responsible" for RF, and my priorities for now are
> on modularization and mavenization.
> Once that's done I'll be back to working on RF. That'll likely be after
> GWT 2.6 lands though.
> Apart from bug fixes and other enhancements (the TODO you're talking
> about), there are a bunch of things I'd like to add/change (e.g. more
> code-gen to use reflection less)
> The @Immutable annotation you're proposing is probably not needed; we
> could base our decision on whether there are setters or only getters.
>
> --
> --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
> ---
> You received this message because you are subscribed to the Google Groups
> "Google Web Toolkit Contributors" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
>

-- 
-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups 
"Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Add callbacks to Super Dev Mode to find out when a compile s...

2013-04-17 Thread James Nelson

James Nelson has posted comments on this change.

Change subject: Add callbacks to Super Dev Mode to find out when a compile  
starts and finishes, and an alternate main() that can be called after  
parsing options.

..


Patch Set 1: Code-Review+1

(1 comment)


File dev/codeserver/java/com/google/gwt/dev/codeserver/CompileDir.java
Line 32: public class CompileDir {
YES!

I will finally be able to delete my CompileDirAccessor :-)


--
To view, visit https://gwt-review.googlesource.com/2540
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2a27a07d2c8219d496613b1c1c88380c6dc3d032
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Brian Slesinsky 
Gerrit-Reviewer: James Nelson 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-HasComments: Yes

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.