[gwt-contrib] Change in gwt[master]: Check for castableTypeMap twice to work around iOS 6 JIT issue
Leif Åstrand has uploaded a new change for review.
https://gwt-review.googlesource.com/2800
Change subject: Check for castableTypeMap twice to work around iOS 6 JIT
issue
..
Check for castableTypeMap twice to work around iOS 6 JIT issue
Fixes https://code.google.com/p/google-web-toolkit/issues/detail?id=8098
Change-Id: I87fd663c2b0dcc8c2d859a4701cd61373c0fcaf7
---
M
dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Cast.java
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
a/dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Cast.java
b/dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Cast.java
index 286bb3e..4f587e0 100644
---
a/dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Cast.java
+++
b/dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Cast.java
@@ -26,7 +26,7 @@
final class Cast {
static native boolean canCast(Object src, int dstId) /*-{
-return s...@java.lang.Object::castableTypeMap
!!s...@java.lang.Object::castableTypeMap[dstId];
+return (s...@java.lang.Object::castableTypeMap |
| s...@java.lang.Object::castableTypeMap)
!!s...@java.lang.Object::castableTypeMap[dstId];
}-*/;
/**
@@ -34,7 +34,7 @@
* context.
*/
static native boolean canCastUnsafe(Object src, int dstId) /*-{
-return s...@java.lang.Object::castableTypeMap
s...@java.lang.Object::castableTypeMap[dstId];
+return (s...@java.lang.Object::castableTypeMap ||
s...@java.lang.Object::castableTypeMap)
s...@java.lang.Object::castableTypeMap[dstId];
}-*/;
static native String charToString(char x) /*-{
--
To view, visit https://gwt-review.googlesource.com/2800
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I87fd663c2b0dcc8c2d859a4701cd61373c0fcaf7
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Leif Åstrand l...@vaadin.com
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Check for castableTypeMap twice to work around iOS 6 JIT issue
Leif Åstrand has uploaded a new patch set (#2). Change subject: Check for castableTypeMap twice to work around iOS 6 JIT issue .. Check for castableTypeMap twice to work around iOS 6 JIT issue Fixes https://code.google.com/p/google-web-toolkit/issues/detail?id=8098 Change-Id: I87fd663c2b0dcc8c2d859a4701cd61373c0fcaf7 --- M dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Cast.java 1 file changed, 8 insertions(+), 2 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2800 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I87fd663c2b0dcc8c2d859a4701cd61373c0fcaf7 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Leif Åstrand l...@vaadin.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: ValueListBox should implement HasEnabled (6112) (issue1832803)
I would be more than happy to but I can't seem to get gwt-dev, gwt-servlet, gwt-user,... under master to work when I check them out in eclipse. Eclipse tells me the source folders do not exist when they do. I'm not familiar with GIT so I'm at a loss. On Thursday, May 16, 2013 3:35:21 PM UTC-4, Matthew Dempsky wrote: Thanks for the patch! But do you mind reuploading it to https://gwt-review.googlesource.com/gwt so we can review and merge it there? http://gwt-code-reviews.appspot.com/1832803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Re: ValueListBox should implement HasEnabled (6112) (issue1832803)
On Fri, May 17, 2013 at 6:11 AM, Patrick Tucker tucker...@gmail.com wrote: I would be more than happy to but I can't seem to get gwt-dev, gwt-servlet, gwt-user,... under master to work when I check them out in eclipse. Eclipse tells me the source folders do not exist when they do. I'm not familiar with GIT so I'm at a loss. Did you setup Eclipse correctly, as documented in eclipse/README.txt? -- John A. Tamplin -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.
Matthew Dempsky has posted comments on this change. Change subject: Removes api-checker reference JARs from the source tree. .. Patch Set 3: (1 comment) Commit Message Line 11: Bug: issue 8031 Did you mean to remove this in patch set 4? -- To view, visit https://gwt-review.googlesource.com/2500 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Re: ValueListBox should implement HasEnabled (6112) (issue1832803)
I'm not sure where to find the file that you are referring to, it is not in my eclipse install folder? I'm using a 64 bit version of Juno, have been since it was released. I have had no issues with the other 12 or so projects that are loaded. I was playing with the settings and tried removing one of the source folders so that I could add it back and got an error saying the file system is read only. Any idea why it would do that? When I cloned the repository, I entered the username and password that was provided by the HTTP Password site. Thanks, Pat On Friday, May 17, 2013 11:43:20 AM UTC-4, John A. Tamplin wrote: On Fri, May 17, 2013 at 6:11 AM, Patrick Tucker tuck...@gmail.comjavascript: wrote: I would be more than happy to but I can't seem to get gwt-dev, gwt-servlet, gwt-user,... under master to work when I check them out in eclipse. Eclipse tells me the source folders do not exist when they do. I'm not familiar with GIT so I'm at a loss. Did you setup Eclipse correctly, as documented in eclipse/README.txt? -- John A. Tamplin -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Re: ValueListBox should implement HasEnabled (6112) (issue1832803)
On Fri, May 17, 2013 at 9:45 AM, Patrick Tucker tucker...@gmail.com wrote: I'm not sure where to find the file that you are referring to, it is not in my eclipse install folder? John was referring to the eclipse directory in the GWT source code tree: https://gwt.googlesource.com/gwt/+/master/eclipse/README.txt I was playing with the settings and tried removing one of the source folders so that I could add it back and got an error saying the file system is read only. Any idea why it would do that? Not sure, that sounds odd to me. Just out of curiosity, what OS are you using? When you prepared the patch from Rietveld, did you checkout the code from Subversion or use the 2.5.1 SDK release zip file? If you were already using Subversion, I would expect using Git shouldn't be any different to setup in Eclipse since the source tree should be the same. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Re: ValueListBox should implement HasEnabled (6112) (issue1832803)
Windows 7 Pro On Friday, May 17, 2013 12:51:47 PM UTC-4, Matthew Dempsky wrote: On Fri, May 17, 2013 at 9:45 AM, Patrick Tucker tuck...@gmail.comjavascript: wrote: I'm not sure where to find the file that you are referring to, it is not in my eclipse install folder? John was referring to the eclipse directory in the GWT source code tree: https://gwt.googlesource.com/gwt/+/master/eclipse/README.txt I was playing with the settings and tried removing one of the source folders so that I could add it back and got an error saying the file system is read only. Any idea why it would do that? Not sure, that sounds odd to me. Just out of curiosity, what OS are you using? When you prepared the patch from Rietveld, did you checkout the code from Subversion or use the 2.5.1 SDK release zip file? If you were already using Subversion, I would expect using Git shouldn't be any different to setup in Eclipse since the source tree should be the same. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds part of Java 7 new language features.
Roberto Lublinerman has posted comments on this change. Change subject: Adds part of Java 7 new language features. .. Patch Set 8: Ping. -- To view, visit https://gwt-review.googlesource.com/2650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Gerrit-PatchSet: 8 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@gmail.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds the remaining (and more complex) Java 7 new language fe...
Roberto Lublinerman has posted comments on this change. Change subject: Adds the remaining (and more complex) Java 7 new language features. .. Patch Set 6: Ping. -- To view, visit https://gwt-review.googlesource.com/2681 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: If973b8c847d1202aca794221f32ae4b33b616f9c Gerrit-PatchSet: 6 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds part of Java 7 new language features.
Matthew Dempsky has posted comments on this change. Change subject: Adds part of Java 7 new language features. .. Patch Set 8: I assume you're pinging for John and/or Ray? -- To view, visit https://gwt-review.googlesource.com/2650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Gerrit-PatchSet: 8 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@gmail.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds part of Java 7 new language features.
Brian Slesinsky has posted comments on this change.
Change subject: Adds part of Java 7 new language features.
..
Patch Set 8: Code-Review+1
(7 comments)
Looks fine to me. I have a few nits, but they don't need to be fixed.
File
dev/core/src/com/google/gwt/dev/javac/testing/impl/Java7MockResources.java
Line 22: public static final MockJavaResource INTEGERLITERALS = new
MockJavaResource(
Nit: INTEGER_LITERALS to match the use of underscores elsewhere in this
file.
More nits: also, some of the constants match the class being created
(INTEGER_LITERALS matches IntegerLiterals) but others don't. Some classes
end with Test and others don't. It would be a bit cleaner to make them
match.
Line 26: StringBuilder code = new StringBuilder();
This sort of code could be made slightly more concise with a helper method:
/**
* Concatenate lines of text, adding a newline to the end of each string.
*/
static String concat(String... lines);
But it's fine as-is.
File dev/core/src/com/google/gwt/dev/util/arg/OptionSource.java
Line 26: enum SourceLevel {
Maybe SourceLevel should be a top-level enum? It would make imports shorter
by default.
Line 27: _6(1.6, 6),
perhaps JAVA6 and JAVA7 instead of underscore?
Line 39: * Returns a string value representation for the source level.
The javadoc here seems to be boilerplate. Better to give an example of what
will be returned, and perhaps say when to use 1.6 and when to use 6?
File dev/core/test/com/google/gwt/dev/CompilerTest.java
Line 60: assertEquals(OptionSource.SourceLevel._7,
options.getSourceLevel());
Perhaps import SourceLevel directly.
File
user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java7Test.java
Line 27: * IMPORTANT: For each test here there must exists the
corresponding method in the non super sourced
must exist
--
To view, visit https://gwt-review.googlesource.com/2650
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70
Gerrit-PatchSet: 8
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: John Stalcup stal...@google.com
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer: Roberto Lublinerman rlu...@gmail.com
Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Moving mailing lists to @gwtproject.org?
So I just setup groups.gwtproject.org so that we can create mailing lists under @gwtproject.org if desirable. Also, since google-web-toolkit-contributors is incredibly long and no longer reflective of the projects name, it seems like a good time to fix that too. I was thinking: gwt-disc...@gwtproject.org (formerly google-web-tool...@googlegroups.com ) gwt-cont...@gwtproject.org (formerly google-web-toolkit-contributors@googlegroups.com) gwt-steer...@gwtproject.org (formerly gwt-steer...@googlegroups.com) but I'm open to other suggestions too. I'll look into whether it's possible to migrate the existing groups cleanly, but I might have to just create new groups, import the existing members, and disable posts to the old groups. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes GWTTestCase.supportsAsync.
Goktug Gokdogan has uploaded a new change for review.
https://gwt-review.googlesource.com/2781
Change subject: Removes GWTTestCase.supportsAsync.
..
Removes GWTTestCase.supportsAsync.
GWTTestCase.supportsAsync was just another artifact of Benchmark infra that
we recently got rid of.
Change-Id: Ie35e94f8ada80d9e4ae0945199831db6d01cc4a4
---
M tools/api-checker/config/gwt25_26userApi.conf
M user/src/com/google/gwt/junit/client/GWTTestCase.java
M
user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/GWTTestCase.java
3 files changed, 21 insertions(+), 42 deletions(-)
diff --git a/tools/api-checker/config/gwt25_26userApi.conf
b/tools/api-checker/config/gwt25_26userApi.conf
index c2e5f4f..6c2261a 100644
--- a/tools/api-checker/config/gwt25_26userApi.conf
+++ b/tools/api-checker/config/gwt25_26userApi.conf
@@ -150,6 +150,7 @@
# Removed deprecated benchmark infra
com.google.gwt.benchmarks.client MISSING
+com.google.gwt.junit.client.GWTTestCase::supportsAsync() MISSING
# Split BaseListenerWrapper
com.google.gwt.user.client.BaseListenerWrapper::getSource(Lcom/google/gwt/event/shared/GwtEvent;)
MISSING
diff --git a/user/src/com/google/gwt/junit/client/GWTTestCase.java
b/user/src/com/google/gwt/junit/client/GWTTestCase.java
index 4f88df7..b4deab1 100644
--- a/user/src/com/google/gwt/junit/client/GWTTestCase.java
+++ b/user/src/com/google/gwt/junit/client/GWTTestCase.java
@@ -435,14 +435,6 @@
}
/**
- * Returns true if this test case supports asynchronous mode. By
default, this
- * is set to true.
- */
- protected boolean supportsAsync() {
-return true;
- }
-
- /**
* This method has been made final to prevent you from accidentally
running
* client code outside of the GWT environment. Please override
* {@link #gwtTearDown()} instead.
diff --git
a/user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/GWTTestCase.java
b/user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/GWTTestCase.java
index 56464a5..9fdaa9f 100644
---
a/user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/GWTTestCase.java
+++
b/user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/GWTTestCase.java
@@ -156,43 +156,33 @@
}
protected final void delayTestFinish(int timeoutMillis) {
-if (supportsAsync()) {
- if (timer != null) {
-// Cancel the pending timer
-timer.cancel();
- }
-
- // Set a new timer for the specified new timeout
- timer = new KillTimer(timeoutMillis);
-} else {
- throw new UnsupportedOperationException(
- This test case does not support asynchronous mode.);
+if (timer != null) {
+ // Cancel the pending timer
+ timer.cancel();
}
+
+// Set a new timer for the specified new timeout
+timer = new KillTimer(timeoutMillis);
}
protected final void finishTest() {
-if (supportsAsync()) {
- if (testIsFinished) {
-// This test is totally done already, just ignore the call.
-return;
- }
+if (testIsFinished) {
+ // This test is totally done already, just ignore the call.
+ return;
+}
- if (timer == null) {
-throw new IllegalStateException(
-This test is not in asynchronous mode; call delayTestFinish()
first);
- }
+if (timer == null) {
+ throw new IllegalStateException(
+ This test is not in asynchronous mode; call delayTestFinish()
first);
+}
- if (mainTestHasRun) {
-// This is a correct, successful async finish.
-reportResultsAndRunNextMethod(null);
- } else {
-// The user tried to finish the test before the main body returned!
-// Just let the test continue running normally.
-resetAsyncState();
- }
+if (mainTestHasRun) {
+ // This is a correct, successful async finish.
+ reportResultsAndRunNextMethod(null);
} else {
- throw new UnsupportedOperationException(
- This test case does not support asynchronous mode.);
+ // The user tried to finish the test before the main body returned!
+ // Just let the test continue running normally.
+ resetAsyncState();
}
}
@@ -235,10 +225,6 @@
synchronousException = ex;
}
}
- }
-
- protected boolean supportsAsync() {
-return true;
}
private void assertTestState() {
--
To view, visit https://gwt-review.googlesource.com/2781
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie35e94f8ada80d9e4ae0945199831db6d01cc4a4
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan gok...@google.com
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups
[gwt-contrib] Change in gwt[master]: Removes GWTTestCase.supportsAsync.
Matthew Dempsky has posted comments on this change. Change subject: Removes GWTTestCase.supportsAsync. .. Patch Set 1: Code-Review+2 -- To view, visit https://gwt-review.googlesource.com/2781 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie35e94f8ada80d9e4ae0945199831db6d01cc4a4 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds the remaining (and more complex) Java 7 new language fe...
Hello Matthew Dempsky, Matthew Dempsky, Leeroy Jenkins, Goktug Gokdogan, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2681 to look at the new patch set (#7). Change subject: Adds the remaining (and more complex) Java 7 new language features. .. Adds the remaining (and more complex) Java 7 new language features. Adds the remaining Java 7 new language features: namely, multiexception catch and try-with-resources. Fixes issue 7999, issue 6960. Change-Id: If973b8c847d1202aca794221f32ae4b33b616f9c --- M dev/core/src/com/google/gwt/dev/jjs/ast/JClassType.java M dev/core/src/com/google/gwt/dev/jjs/ast/JMethod.java M dev/core/src/com/google/gwt/dev/jjs/ast/JMethodCall.java M dev/core/src/com/google/gwt/dev/jjs/ast/JTryStatement.java M dev/core/src/com/google/gwt/dev/jjs/impl/CatchBlockNormalizer.java M dev/core/src/com/google/gwt/dev/jjs/impl/DeadCodeElimination.java M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java M dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java M dev/core/src/com/google/gwt/dev/jjs/impl/ToStringGenerationVisitor.java M dev/core/src/com/google/gwt/dev/jjs/impl/TypeTightener.java M dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java M dev/core/src/com/google/gwt/dev/jjs/impl/gflow/cfg/CfgBuilder.java M dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Exceptions.java M dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java M dev/core/test/com/google/gwt/dev/jjs/impl/Java7AstTest.java M user/src/com/google/gwt/core/shared/SerializableThrowable.java A user/super/com/google/gwt/emul/java/lang/AutoCloseable.java M user/super/com/google/gwt/emul/java/lang/Throwable.java M user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java7Test.java M user/test/com/google/gwt/dev/jjs/test/Java7Test.java M user/test/com/google/gwt/emultest/java/lang/ThrowableTest.java 21 files changed, 760 insertions(+), 89 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2681 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: If973b8c847d1202aca794221f32ae4b33b616f9c Gerrit-PatchSet: 7 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds part of Java 7 new language features.
Hello Matthew Dempsky, Matthew Dempsky, Leeroy Jenkins, Brian Slesinsky, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2650 to look at the new patch set (#9). Change subject: Adds part of Java 7 new language features. .. Adds part of Java 7 new language features. Adds the Java 7 new language features: namely, the diamond operator, new numerical literal formats, and switch/case on string literals. Adds a new flag -source to select source level compatibility (java 6 or java 7); -source defaults to java 6. Fixes issue 6633. Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Review-Link: https://gwt-review.googlesource.com/#/c/2650/ --- M dev/codeserver/java/com/google/gwt/dev/codeserver/CodeServer.java M dev/codeserver/java/com/google/gwt/dev/codeserver/CompilerOptionsImpl.java M dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java M dev/codeserver/java/com/google/gwt/dev/codeserver/Recompiler.java M dev/codeserver/java/com/google/gwt/dev/codeserver/UnmodifiableCompilerOptions.java M dev/core/src/com/google/gwt/dev/CompileModule.java M dev/core/src/com/google/gwt/dev/CompileTaskOptions.java M dev/core/src/com/google/gwt/dev/CompileTaskOptionsImpl.java M dev/core/src/com/google/gwt/dev/Compiler.java M dev/core/src/com/google/gwt/dev/DevMode.java M dev/core/src/com/google/gwt/dev/DevModeBase.java M dev/core/src/com/google/gwt/dev/Precompile.java M dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java M dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java M dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java M dev/core/src/com/google/gwt/dev/javac/testing/GeneratorContextBuilder.java A dev/core/src/com/google/gwt/dev/javac/testing/impl/Java7MockResources.java M dev/core/src/com/google/gwt/dev/javac/testing/impl/JavaResourceBase.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptions.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptionsImpl.java A dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerSource.java A dev/core/src/com/google/gwt/dev/util/arg/OptionSource.java A dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java M dev/core/test/com/google/gwt/dev/CompilerTest.java M dev/core/test/com/google/gwt/dev/javac/CompilationStateTestBase.java M dev/core/test/com/google/gwt/dev/javac/JavaCompilationSuite.java M dev/core/test/com/google/gwt/dev/javac/JdtBehaviorTest.java A dev/core/test/com/google/gwt/dev/javac/JdtJava7Test.java M dev/core/test/com/google/gwt/dev/jjs/impl/CodeSplitter2Test.java M dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java A dev/core/test/com/google/gwt/dev/jjs/impl/Java7AstTest.java M user/src/com/google/gwt/junit/JUnitShell.java A user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java7Test.java M user/test/com/google/gwt/dev/jjs/CompilerSuite.java A user/test/com/google/gwt/dev/jjs/Java7Test.gwt.xml A user/test/com/google/gwt/dev/jjs/test/Java7Test.java 36 files changed, 1,150 insertions(+), 430 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Gerrit-PatchSet: 9 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@gmail.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds part of Java 7 new language features.
Roberto Lublinerman has posted comments on this change.
Change subject: Adds part of Java 7 new language features.
..
Patch Set 8:
(7 comments)
@Ray, can you have a look at this patch and its successor and if ok +2 them.
File
dev/core/src/com/google/gwt/dev/javac/testing/impl/Java7MockResources.java
Line 22: public static final MockJavaResource INTEGERLITERALS = new
MockJavaResource(
Done
Line 26: StringBuilder code = new StringBuilder();
I followed JavaResouceBase.java. But I agree, will fix here.
File dev/core/src/com/google/gwt/dev/util/arg/OptionSource.java
Line 26: enum SourceLevel {
Done
Line 27: _6(1.6, 6),
Done
Line 39: * Returns a string value representation for the source level.
Added an explanation in the class doc. Done
File dev/core/test/com/google/gwt/dev/CompilerTest.java
Line 60: assertEquals(OptionSource.SourceLevel._7,
options.getSourceLevel());
Done. Made SourceLevel a top level enum.
File
user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java7Test.java
Line 27: * IMPORTANT: For each test here there must exists the
corresponding method in the non super sourced
Done
--
To view, visit https://gwt-review.googlesource.com/2650
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70
Gerrit-PatchSet: 8
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: John Stalcup stal...@google.com
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer: Roberto Lublinerman rlu...@gmail.com
Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds part of Java 7 new language features.
Hello Matthew Dempsky, Matthew Dempsky, Leeroy Jenkins, Brian Slesinsky, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2650 to look at the new patch set (#10). Change subject: Adds part of Java 7 new language features. .. Adds part of Java 7 new language features. Adds the Java 7 new language features: namely, the diamond operator, new numerical literal formats, and switch/case on string literals. Adds a new flag -source to select source level compatibility (java 6 or java 7); -source defaults to java 6. Fixes issue 6633. Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Review-Link: https://gwt-review.googlesource.com/#/c/2650/ --- M dev/codeserver/java/com/google/gwt/dev/codeserver/CodeServer.java M dev/codeserver/java/com/google/gwt/dev/codeserver/CompilerOptionsImpl.java M dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java M dev/codeserver/java/com/google/gwt/dev/codeserver/Recompiler.java M dev/codeserver/java/com/google/gwt/dev/codeserver/UnmodifiableCompilerOptions.java M dev/core/src/com/google/gwt/dev/CompileModule.java M dev/core/src/com/google/gwt/dev/CompileTaskOptions.java M dev/core/src/com/google/gwt/dev/CompileTaskOptionsImpl.java M dev/core/src/com/google/gwt/dev/Compiler.java M dev/core/src/com/google/gwt/dev/DevMode.java M dev/core/src/com/google/gwt/dev/DevModeBase.java M dev/core/src/com/google/gwt/dev/Precompile.java M dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java M dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java M dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java M dev/core/src/com/google/gwt/dev/javac/testing/GeneratorContextBuilder.java A dev/core/src/com/google/gwt/dev/javac/testing/impl/Java7MockResources.java M dev/core/src/com/google/gwt/dev/javac/testing/impl/JavaResourceBase.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptions.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptionsImpl.java A dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerSource.java A dev/core/src/com/google/gwt/dev/util/arg/OptionSource.java A dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java M dev/core/test/com/google/gwt/dev/CompilerTest.java M dev/core/test/com/google/gwt/dev/javac/CompilationStateTestBase.java M dev/core/test/com/google/gwt/dev/javac/JavaCompilationSuite.java M dev/core/test/com/google/gwt/dev/javac/JdtBehaviorTest.java A dev/core/test/com/google/gwt/dev/javac/JdtJava7Test.java M dev/core/test/com/google/gwt/dev/jjs/impl/CodeSplitter2Test.java M dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java A dev/core/test/com/google/gwt/dev/jjs/impl/Java7AstTest.java M user/src/com/google/gwt/junit/JUnitShell.java A user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java7Test.java M user/test/com/google/gwt/dev/jjs/CompilerSuite.java A user/test/com/google/gwt/dev/jjs/Java7Test.gwt.xml A user/test/com/google/gwt/dev/jjs/test/Java7Test.java 36 files changed, 1,151 insertions(+), 430 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Gerrit-PatchSet: 10 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@gmail.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds the remaining (and more complex) Java 7 new language fe...
Hello Matthew Dempsky, Matthew Dempsky, Leeroy Jenkins, Goktug Gokdogan, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2681 to look at the new patch set (#8). Change subject: Adds the remaining (and more complex) Java 7 new language features. .. Adds the remaining (and more complex) Java 7 new language features. Adds the remaining Java 7 new language features: namely, multiexception catch and try-with-resources. Fixes issue 7999, issue 6960. Change-Id: If973b8c847d1202aca794221f32ae4b33b616f9c --- M dev/core/src/com/google/gwt/dev/jjs/ast/JClassType.java M dev/core/src/com/google/gwt/dev/jjs/ast/JMethod.java M dev/core/src/com/google/gwt/dev/jjs/ast/JMethodCall.java M dev/core/src/com/google/gwt/dev/jjs/ast/JTryStatement.java M dev/core/src/com/google/gwt/dev/jjs/impl/CatchBlockNormalizer.java M dev/core/src/com/google/gwt/dev/jjs/impl/DeadCodeElimination.java M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java M dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java M dev/core/src/com/google/gwt/dev/jjs/impl/ToStringGenerationVisitor.java M dev/core/src/com/google/gwt/dev/jjs/impl/TypeTightener.java M dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java M dev/core/src/com/google/gwt/dev/jjs/impl/gflow/cfg/CfgBuilder.java M dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Exceptions.java M dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java M dev/core/test/com/google/gwt/dev/jjs/impl/Java7AstTest.java M user/src/com/google/gwt/core/shared/SerializableThrowable.java A user/super/com/google/gwt/emul/java/lang/AutoCloseable.java M user/super/com/google/gwt/emul/java/lang/Throwable.java M user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java7Test.java M user/test/com/google/gwt/dev/jjs/test/Java7Test.java M user/test/com/google/gwt/emultest/java/lang/ThrowableTest.java 21 files changed, 760 insertions(+), 89 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2681 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: If973b8c847d1202aca794221f32ae4b33b616f9c Gerrit-PatchSet: 8 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds part of Java 7 new language features.
Brian Slesinsky has posted comments on this change. Change subject: Adds part of Java 7 new language features. .. Patch Set 10: Code-Review+1 -- To view, visit https://gwt-review.googlesource.com/2650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Gerrit-PatchSet: 10 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@gmail.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes JavaScriptException dependency from c.g.gwt.core.sha...
Goktug Gokdogan has uploaded a new change for review.
https://gwt-review.googlesource.com/2840
Change subject: Removes JavaScriptException dependency from
c.g.gwt.core.shared.
..
Removes JavaScriptException dependency from c.g.gwt.core.shared.
Note that, this change also makes isClassMetadataEnabled public in the
emulated version
of the java/lang/Class so that the logic for resolving types for the no
metadata case
can be compiled out.
Change-Id: Ib610bb27cefb3d405e2126417008f4134743e723
---
M tools/api-checker/config/gwt25_26userApi.conf
M user/src/com/google/gwt/core/shared/SerializableThrowable.java
A user/src/com/google/gwt/core/shared/impl/ThrowableTypeResolver.java
A
user/super/com/google/gwt/core/translatable/com/google/gwt/core/shared/impl/ThrowableTypeResolver.java
M user/super/com/google/gwt/emul/java/lang/Class.java
M user/test/com/google/gwt/junit/client/GWTTestCaseTest.java
6 files changed, 111 insertions(+), 45 deletions(-)
diff --git a/tools/api-checker/config/gwt25_26userApi.conf
b/tools/api-checker/config/gwt25_26userApi.conf
index c2e5f4f..d146973 100644
--- a/tools/api-checker/config/gwt25_26userApi.conf
+++ b/tools/api-checker/config/gwt25_26userApi.conf
@@ -96,6 +96,7 @@
:user/src/com/google/web/bindery/autobean/shared/ValueCodexHelper.java\
:user/src/com/google/web/bindery/autobean/**/impl/**\
:user/src/com/google/gwt/core/client/impl/WeakMapping.java\
+:user/src/com/google/gwt/core/shared/impl/**\
:user/src/com/google/gwt/i18n/**/impl/cldr/**\
:user/src/com/google/gwt/junit/*.java\
:user/src/com/google/gwt/junit/client/GWTTestCase.java\
@@ -129,6 +130,7 @@
##
#excluded packages colon separated list
excludedPackages com.google.gwt.core.client.impl\
+:com.google.gwt.core.shared.impl\
:com.google.gwt.editor.client.impl\
:com.google.gwt.junit.client.impl\
:com.google.gwt.benchmarks.client.impl\
diff --git a/user/src/com/google/gwt/core/shared/SerializableThrowable.java
b/user/src/com/google/gwt/core/shared/SerializableThrowable.java
index a44fb04..82ccaae 100644
--- a/user/src/com/google/gwt/core/shared/SerializableThrowable.java
+++ b/user/src/com/google/gwt/core/shared/SerializableThrowable.java
@@ -15,7 +15,8 @@
*/
package com.google.gwt.core.shared;
-import com.google.gwt.core.client.JavaScriptException;
+import com.google.gwt.core.shared.impl.ThrowableTypeResolver;
+
/**
* A serializable copy of a {@link Throwable}, including its causes and
stack trace. It overrides
@@ -64,6 +65,7 @@
@Override
public Throwable fillInStackTrace() {
// This is a no-op for optimization as we don't need stack traces to
be auto-filled.
+// TODO(goktug): Java 7 let's you disable this by constructor flag
return this;
}
@@ -121,48 +123,7 @@
SerializableThrowable throwable = new SerializableThrowable(null,
t.getMessage());
throwable.setStackTrace(t.getStackTrace());
throwable.initCause(t.getCause());
-if (isClassMetadataAvailable()) {
- throwable.setDesignatedType(t.getClass().getName(), true);
-} else {
- resolveDesignatedType(throwable, t);
-}
+ThrowableTypeResolver.resolveDesignatedType(throwable, t);
return throwable;
- }
-
- // TODO(goktug): Replace when availability of class metadata can be
checked in compile-time so
- // that #resolveDesignatedType will be compiled out.
- private static boolean isClassMetadataAvailable() {
-return !GWT.isScript()
-||
SerializableThrowable.class.getName().endsWith(.SerializableThrowable);
- }
-
- /**
- * Resolves best effort class name by checking against some common
exception types.
- */
- private static void resolveDesignatedType(SerializableThrowable t,
Throwable designatedType) {
-String resolvedName;
-Class? resolvedType;
-try {
- throw designatedType;
-} catch (NullPointerException e) {
- resolvedName = java.lang.NullPointerException;
- resolvedType = NullPointerException.class;
-} catch (JavaScriptException e) {
- resolvedName = com.google.gwt.core.client.JavaScriptException;
- resolvedType = JavaScriptException.class;
-} catch (RuntimeException e) {
- resolvedName = java.lang.RuntimeException;
- resolvedType = RuntimeException.class;
-} catch (Exception e) {
- resolvedName = java.lang.Exception;
- resolvedType = Exception.class;
-} catch (Error e) {
- resolvedName = java.lang.Error;
- resolvedType = Error.class;
-} catch (Throwable e) {
- resolvedName = java.lang.Throwable;
- resolvedType = Throwable.class;
-}
-t.setDesignatedType(resolvedName, resolvedType ==
designatedType.getClass());
}
}
diff --git
a/user/src/com/google/gwt/core/shared/impl/ThrowableTypeResolver.java
b/user/src/com/google/gwt/core/shared/impl/ThrowableTypeResolver.java
new file mode 100644
index
[gwt-contrib] Change in gwt[master]: Removes JavaScriptException dependency from c.g.gwt.core.sha...
John A. Tamplin has posted comments on this change. Change subject: Removes JavaScriptException dependency from c.g.gwt.core.shared. .. Patch Set 1: Code-Review+1 -- To view, visit https://gwt-review.googlesource.com/2840 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib610bb27cefb3d405e2126417008f4134743e723 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
