On Sunday, June 15, 2014 3:07:17 AM UTC+2, Jens wrote: > > The gwt.javac macro in common.ant.xml excludes **/super/** by default, but >> the call point in compile.tests in user/build.xml overrides the excludes="" >> and removed the **/super/** exclusion. I think that was a bug (by >> oversight). >> > > Hmm I don't see anything that tells gwt.javac to exclude **/super/** by > default. But maybe it is a good idea to add it. The compile task explicitly > excludes **/super/** in user/build.xml and the compile.tests task does not > exclude it because there was no need to do so until now. >
Whoops! Totally misread my "git grep" results! ;-) > However I am wondering if the super source files in #7865 are better >> placed into user/test-super ? I guess thats why test-super exists (?) >> > >> There's no strict rule. com.google.gwt.regexp.super is in user/src, not >> user/test for instance. >> I think the super/ root was originally more about IDEs than a real will >> to segregate those files. >> > > I would prefer to have one strategy instead of two. But I guess that will > happen anyways sooner or later with gwt modularization. > I remember making that same remark when c.g.g.regexp was added that "broke the rule", but that ship has sailed years ago. I must say I wouldn't be opposed to having everything in src/ and test/ and removing super/ and test-super/ altogether (for user/ we have test_i18n_bar and test_i18n_dollar, that was added a while back [1,2], I wonder if we couldn't refactor the tests with a single "source root") [1] https://code.google.com/p/google-web-toolkit/source/detail?r=3855 [2] https://gwt.googlesource.com/gwt/+/253054 -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/119df8cc-9a43-4262-9b5d-898358a9b1e6%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
