Re: [gwt-contrib] Future of Renderable and PotentialElement?

2014-07-06 Thread 'Goktug Gokdogan' via GWT Contributors 
On Fri, Jul 4, 2014 at 1:58 PM, Thomas Broyer  wrote:

> Hi Googlers,
>
> AFAIK, PotentialElement and Renderable were an experiment contributed by
> the team at Orkut. Now that Orkut is closing its doors, what will happen of
> that feature?
>

Even Orkut closing the doors, it doesn't mean their code is going away
anytime soon :)


>  Is the experiment successful and should it be promoted? Or is it a
> failure and we should remove it to simplify the codebase? Or are there
> other teams using it and we should keep it in experimental state for a
> little while before taking a decision?
>


I can see that they have built a bunch widgets in Orkut and those widgets
are used in plenty of places but I don't have any other data points and
don't know the value-add of the feature.

On the other hand it doesn't look like a big maintenance burden or has a
big potential for simplifying the codebase - at least at the first sight.


>  --
> You received this message because you are subscribed to the Google Groups
> "GWT Contributors" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/google-web-toolkit-contributors/a0612860-b1bd-4a4f-aa91-0036fbc5049f%40googlegroups.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAN%3DyUA0j-a60RKrN%2B6%3Dr%2Bx8i73q3cq8U2mX%3DcF_i9c2yWtcXYg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: [gwt-contrib] Future of Renderable and PotentialElement?

2014-07-06 Thread Stephen Haberman 

> Even Orkut closing the doors, it doesn't mean their code is going away
> anytime soon :)

You're killing me, Goktug. The backwards compatibility knife had
already pierced my heart, and this just shimmied it around a bit. :-)

I had to refresh on memory on PotentialElement, but it looks virtual
DOM-ish; making fake elements that are really pure JS objects, and then
later converting them into real DOM objects only as-needed. I believe
it sped up the first page load of Orkut by ...15%? or so.

I also vaguely recall that, AFAIU, the pipe dream was to have the
entire initial DOM render be one huge .innerHTML=, since IE
really liked that. But making strings that big hurts the GC such that
(AFAIK) it's a wash in modern browsers to just making DOM elements
directly anyway.

Speaking of PotentialElement, looking at commits from around that time
frame, there is also a change from Ray Ryan that turned
useLazyWidgetBuilders = true, with a commit message of "in prep for
deleting the old code".

Looks like that deleting never happened...can we do that now?

As with PotentialElement, I don't think useLazyWidgetBuilders had any
external design docs, discussion, etc., so I don't really know the
whole story on it. Or even little bits, other than I enjoy deleting old
code and will volunteer to do that if we can.

- Stephen

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit-contributors/20140706220525.6ccc4472%40sh9.
For more options, visit https://groups.google.com/d/optout.

Re: [gwt-contrib] Future of Renderable and PotentialElement?

2014-07-06 Thread 'Goktug Gokdogan' via GWT Contributors 
On Sun, Jul 6, 2014 at 8:05 PM, Stephen Haberman  wrote:

>
> > Even Orkut closing the doors, it doesn't mean their code is going away
> > anytime soon :)
>
> You're killing me, Goktug. The backwards compatibility knife had
> already pierced my heart, and this just shimmied it around a bit. :-)
>
>
The point was more about Orkut announcement doesn't change anything and
cannot effect the decision from our perspective; as long as the system is
running we need to take care of it.



> I had to refresh on memory on PotentialElement, but it looks virtual
> DOM-ish; making fake elements that are really pure JS objects, and then
> later converting them into real DOM objects only as-needed. I believe
> it sped up the first page load of Orkut by ...15%? or so.
>
> I also vaguely recall that, AFAIU, the pipe dream was to have the
> entire initial DOM render be one huge .innerHTML=, since IE
> really liked that. But making strings that big hurts the GC such that
> (AFAIK) it's a wash in modern browsers to just making DOM elements
> directly anyway.
>
> Speaking of PotentialElement, looking at commits from around that time
> frame, there is also a change from Ray Ryan that turned
> useLazyWidgetBuilders = true, with a commit message of "in prep for
> deleting the old code".
>
> Looks like that deleting never happened...can we do that now?
>
> As with PotentialElement, I don't think useLazyWidgetBuilders had any
> external design docs, discussion, etc., so I don't really know the
> whole story on it. Or even little bits, other than I enjoy deleting old
> code and will volunteer to do that if we can.
>
> - Stephen
>
> --
> You received this message because you are subscribed to the Google Groups
> "GWT Contributors" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/google-web-toolkit-contributors/20140706220525.6ccc4472%40sh9
> .
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAN%3DyUA2itF_dBO%3D8GpRmRgs0%3D2NfeBY1r%3Dhr2may347Hb9BQHg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.