Re: [gwt-contrib] Re: Question about contributing with java.util.concurrent emulation

[Thomas Broyer]

+1

I think it's better to refactor code than have partially emulated (breaking 
contracts) classes.

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit-contributors/c5e7e695-e98b-432c-9072-b505aac11841%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [gwt-contrib] Re: Question about contributing with java.util.concurrent emulation

['Goktug Gokdogan' via GWT Contributors]

I created the patch that's moving plenty of Guava's super source to our
emulation, will send it soon.

However, I'm not planning to (and strongly against) moving CountDownLatch
since I think it will do more harm than good.

On Fri, Jul 14, 2017 at 1:28 AM, Jens  wrote:

> AFAICT we want to merge Guava's emulation of JRE classes into GWT itself.
> I think it also includes CountDownLatch.
>
> Maybe you want to check if you have emulated something in addition to
> Guava: https://github.com/google/guava/tree/master/
> guava-gwt/src-super/java
>
> -- J.
>
> --
> You received this message because you are subscribed to the Google Groups
> "GWT Contributors" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/
> msgid/google-web-toolkit-contributors/c61703ff-15d2-
> 4ee8-9952-7650e1c3425d%40googlegroups.com
> 
> .
>
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAN%3DyUA0W-sG_VfC7nVfV0w5d%3DXbr7SPsBpyK-guv3XnOre%2Bd_Q%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

[gwt-contrib] Re: Question about contributing with java.util.concurrent emulation

[Ignacio Baca Moreno-Torres]

Definitively I have duplicated some of its super-sources, initially 
rxjava-gwt dependends on guava bc it super-sourced some pretty common 
utilities like TimeUnit or Executor, etc. but until I get forced to 
implement various other classes I just prefer to copy-paste and remove the 
guava dependency. But yep, I take note and I will be careful to not add any 
already guava super-sourced class.

Anyways, merging guava first will be a good idea!

On Friday, July 14, 2017 at 10:28:39 AM UTC+2, Jens wrote:
>
> AFAICT we want to merge Guava's emulation of JRE classes into GWT itself. 
> I think it also includes CountDownLatch.
>
> Maybe you want to check if you have emulated something in addition to 
> Guava: 
> https://github.com/google/guava/tree/master/guava-gwt/src-super/java
>
> -- J.
>

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit-contributors/e4478077-1b74-4a3d-a413-ba3a04156181%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[gwt-contrib] Re: Question about contributing with java.util.concurrent emulation

[Jens]

AFAICT we want to merge Guava's emulation of JRE classes into GWT itself. I 
think it also includes CountDownLatch.

Maybe you want to check if you have emulated something in addition to 
Guava: https://github.com/google/guava/tree/master/guava-gwt/src-super/java

-- J.

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit-contributors/c61703ff-15d2-4ee8-9952-7650e1c3425d%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.