[gwt-contrib] Re: Elemental2 - What's the big secret?
Elemental 2 is a completely new project that is being developed internally by Google, but their intention is to publish it as open source once the maturity of the code matches their internal threshold. On Thursday, June 16, 2016 at 10:28:39 AM UTC+3, Alex White wrote: > > Just wondering where the source code is and why it has not been published > before a major release for an allegedly open source project. Is the big > secret that it won't be published? > > > -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/f5ec5e86-ffbc-41ca-b007-d337b4bf5caf%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[gwt-contrib] Re: GWT SNAPSHOT is not able to run my tests today
The bundled HtmlUnit dependency was updated to a newer version a while ago. The new version has emulation for FF 38 instead of FF17. You can add < htmlunit>FF38 to the maven plugin configuration to explicitly use the new supported version. On Friday, March 11, 2016 at 11:35:52 AM UTC+2, Debasish Padhy wrote: > > Hi, > > I am trying to build a simple project today with GWT maven mojo plugin > generated code. > > My tests are unable to run with this error message > > [INFO] [ERROR] RunStyleHtmlUnit: Unknown browser name FF17, expected > browser name: one of [FF38, Chrome, Edge, IE8, IE11] > > cheers, > Gautam > > > -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/a3c80c85-a123-435c-b5e4-2bf0843af4c7%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [gwt-contrib] elemental.Json broken with 2.8-SNAPSHOT
Web mode fails, devmode passes, which is maybe the reason this wasn't picked up by any test? On Monday, 7 September 2015 10:41:48 UTC+3, Ray Cromwell wrote: > > Ok I'll take a look, it's probably my unboxing patch. Is this devmode or > web? > > On Monday, September 7, 2015, Leif Åstrand <leg...@gmail.com > > wrote: > >> The latest 2.8-SNAPSHOT seems quite broken at least with elemental.Json. >> >> This fails in compiled mode, while hosted passes: assertEquals(JsonType. >> BOOLEAN, Json.create(true).getType()); >> >> This worked on Friday, but is broken today after downloading a new >> snapshot. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "GWT Contributors" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/google-web-toolkit-contributors/629fb668-ea69-43aa-88b8-54b5801412a2%40googlegroups.com >> >> <https://groups.google.com/d/msgid/google-web-toolkit-contributors/629fb668-ea69-43aa-88b8-54b5801412a2%40googlegroups.com?utm_medium=email_source=footer> >> . >> For more options, visit https://groups.google.com/d/optout. >> > -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/da32803b-dcb9-43d7-8a3c-052fef780e64%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[gwt-contrib] elemental.Json broken with 2.8-SNAPSHOT
The latest 2.8-SNAPSHOT seems quite broken at least with elemental.Json. This fails in compiled mode, while hosted passes: assertEquals(JsonType. BOOLEAN, Json.create(true).getType()); This worked on Friday, but is broken today after downloading a new snapshot. -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/629fb668-ea69-43aa-88b8-54b5801412a2%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [gwt-contrib] Re: GWT 2.7 release plan
Lots of Elemental patches have been merged in the last few days, but we do still have a short list that would be nice to get included. https://gwt-review.googlesource.com/#/c/9098/ https://gwt-review.googlesource.com/#/c/9099/ https://gwt-review.googlesource.com/#/c/9095/ The code appears to be in good shape, so it only remains for someone with appropriate authority to decide whether the changes are wanted. On Thursday, 9 October 2014 16:25:37 UTC+3, Daniel Kurka wrote: We are making steady progress towards GWT 2.7. At this point we are not accepting any new patches, but we still have a list of issues that we would like to include in the upcoming release. This is no guarantee that all of them are going to make it but we are trying our best. Also we are holding off committing any risky patches to master until we have cut the GWT 2.7 release branch. I'll ping back GWT contributors once we have done that. Please do not commit any patches that do not need to go in. - Issue 8762 https://code.google.com/p/google-web-toolkit/issues/detail?id=8762: Migration to android.json from org.json not being complete (Current patch). Deploy a com.google.gwt.org.json version based of android that the GWT SDK can depend on and update the pom of the SDK to use it. Include a warning in the release notes about small the very small incompatibilities between the two. - Issue 8613 https://code.google.com/p/google-web-toolkit/issues/detail?id=8613: Bug fix for ValuePicker - Issue 8619 https://code.google.com/p/google-web-toolkit/issues/detail?id=8619: Super dev mode can fail to start on windows if previous dirs are still locked. SDM will skip deletion of dirs on windows if it fails and emit a warning. (skybrian) - Issue 8716 https://code.google.com/p/google-web-toolkit/issues/detail?id=8716: Package names can collide with class names on case insensitive file system. John will come up with a fix for GWT 2.7 if it is not to hard to do (stalcup). - Issue 8938 https://code.google.com/p/google-web-toolkit/issues/detail?id=8938: GWT RPC base url is not set correctly for all cases in SDM recompiles. dankurka will update the implementation to include a full computeScriptBase implementation. - GWT RPC policy files should be written to -launcherDir so that the normal server can use them easily (skybrian) - verify sample apps are actually compiling in SDM (since it is now default) (dankurka) - remove generation of SDM targets in samples since it is now default (skybrian) - John found two small issues in incremental. These need to be fixed for GWT 2.7 (stalcup rluble) - Exception links in the chrome dev tools are not clickable (goktug) - Issue 4236 https://code.google.com/p/google-web-toolkit/issues/detail?id=4236: NavigatableMap: We would like to include this in GWT 2.7, but it needs more testing. Ask Andrei to copy all apache testcases and make them work, then we include it in GWT 2.7 (goktug) - Removing IE6 references in the code base (niloc) -Daniel -- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/b8d11950-f32a-466a-b748-036622710c70%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...
Leif Åstrand has posted comments on this change. Change subject: Use JSON.parse() instead of eval() to deserialize rpc callback payload .. Patch Set 11: The existing test suite seems to have quite good coverage, but it does not help when it only tests the default protocol version, i.e. 7. All the problems I mentioned were discovered by changing the default protocol version to 8 and running the RPCSuite. Vaadin has fixes for those problems in https://github.com/vaadin/gwt/commit/9c8f102265c032efc575ed3c070334bf57645aa3 and https://github.com/vaadin/gwt/commit/d3914682163347a9eacee8d3b23e55e62b2a97ea. John A is currently on vacation and I won't have time to submit a new version here either because I'm leaving today. -- To view, visit https://gwt-review.googlesource.com/2900 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6062180397f5fabed1dd5f08140c2bd43a19fa9f Gerrit-PatchSet: 11 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Artur Signell ar...@vaadin.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Colin Alworth niloc...@gmail.com Gerrit-Reviewer: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Leif Åstrand l...@vaadin.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...
Leif Åstrand has posted comments on this change. Change subject: Use JSON.parse() instead of eval() to deserialize rpc callback payload .. Patch Set 11: Code-Review-1 This patch does not work as it stands for a couple of reasons: Special numbers (e.g. NaN) values are sent as strings, but they are in the string table which means that the receiver just gets an index to the table without knowing whether that is the actual value or just a string table index. The sent value is not valid JSON in a couple of situations. This does at least include escaping unicode values using \x (JSON only supports \u) and sending long values as base64 strings enclosed using ' (JSON only supports ) A readVersion method has been added to the super sourced version of ClientSerializationStreamReader but it is missing from the original version. -- To view, visit https://gwt-review.googlesource.com/2900 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6062180397f5fabed1dd5f08140c2bd43a19fa9f Gerrit-PatchSet: 11 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Artur Signell ar...@vaadin.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Colin Alworth niloc...@gmail.com Gerrit-Reviewer: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Leif Åstrand l...@vaadin.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: working on issue 8063, ie10 permutation and ms pointer events
Leif Åstrand has posted comments on this change. Change subject: working on issue 8063, ie10 permutation and ms pointer events .. Patch Set 5: (3 comments) Commit Message Line 7: working on issue 8063, ie10 permutation and ms pointer events Commit message could be updated if the work is indeed about to be done. File user/src/com/google/gwt/typedarrays/TypedArrays.gwt.xml Line 24: !-- IE10+ will support typed arrays, but not before then -- Could create a separate for this so that it isn't (completely) forgotten and update the comment so that it doesn't conflict with the actual definition below. File user/super/com/google/gwt/emul/EmulationWithUserAgent.gwt.xml Line 31: !-- Not actually tested whether this is still needed -- Could maybe test and update accordingly or then just remove this comment and instead create a separate for this so that it isn't (completely) forgotten. -- To view, visit https://gwt-review.googlesource.com/2421 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba0cec6e33ffd3fefa69c3c760868beb00d42076 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matti Tahvonen ma...@vaadin.com Gerrit-Reviewer: Artur Signell ar...@vaadin.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Leif Åstrand l...@vaadin.com Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-Reviewer: Matti Tahvonen ma...@vaadin.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: working on issue 8063, ie10 permutation and ms pointer events
Leif Åstrand has posted comments on this change. Change subject: working on issue 8063, ie10 permutation and ms pointer events .. Patch Set 5: (1 comment) File user/src/com/google/gwt/typedarrays/TypedArrays.gwt.xml Line 24: !-- IE10+ will support typed arrays, but not before then -- separate issue -- To view, visit https://gwt-review.googlesource.com/2421 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba0cec6e33ffd3fefa69c3c760868beb00d42076 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matti Tahvonen ma...@vaadin.com Gerrit-Reviewer: Artur Signell ar...@vaadin.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Leif Åstrand l...@vaadin.com Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-Reviewer: Matti Tahvonen ma...@vaadin.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Check for castableTypeMap twice to work around iOS 6 JIT issue
Leif Åstrand has uploaded a new change for review.
https://gwt-review.googlesource.com/2800
Change subject: Check for castableTypeMap twice to work around iOS 6 JIT
issue
..
Check for castableTypeMap twice to work around iOS 6 JIT issue
Fixes https://code.google.com/p/google-web-toolkit/issues/detail?id=8098
Change-Id: I87fd663c2b0dcc8c2d859a4701cd61373c0fcaf7
---
M
dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Cast.java
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
a/dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Cast.java
b/dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Cast.java
index 286bb3e..4f587e0 100644
---
a/dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Cast.java
+++
b/dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Cast.java
@@ -26,7 +26,7 @@
final class Cast {
static native boolean canCast(Object src, int dstId) /*-{
-return s...@java.lang.Object::castableTypeMap
!!s...@java.lang.Object::castableTypeMap[dstId];
+return (s...@java.lang.Object::castableTypeMap |
| s...@java.lang.Object::castableTypeMap)
!!s...@java.lang.Object::castableTypeMap[dstId];
}-*/;
/**
@@ -34,7 +34,7 @@
* context.
*/
static native boolean canCastUnsafe(Object src, int dstId) /*-{
-return s...@java.lang.Object::castableTypeMap
s...@java.lang.Object::castableTypeMap[dstId];
+return (s...@java.lang.Object::castableTypeMap ||
s...@java.lang.Object::castableTypeMap)
s...@java.lang.Object::castableTypeMap[dstId];
}-*/;
static native String charToString(char x) /*-{
--
To view, visit https://gwt-review.googlesource.com/2800
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I87fd663c2b0dcc8c2d859a4701cd61373c0fcaf7
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Leif Åstrand l...@vaadin.com
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Check for castableTypeMap twice to work around iOS 6 JIT issue
Leif Åstrand has uploaded a new patch set (#2). Change subject: Check for castableTypeMap twice to work around iOS 6 JIT issue .. Check for castableTypeMap twice to work around iOS 6 JIT issue Fixes https://code.google.com/p/google-web-toolkit/issues/detail?id=8098 Change-Id: I87fd663c2b0dcc8c2d859a4701cd61373c0fcaf7 --- M dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Cast.java 1 file changed, 8 insertions(+), 2 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2800 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I87fd663c2b0dcc8c2d859a4701cd61373c0fcaf7 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Leif Åstrand l...@vaadin.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Verify that Timer has not been canceled before firing
Leif Åstrand has posted comments on this change. Change subject: Verify that Timer has not been canceled before firing .. Patch Set 4: What is the status of this? Is something still needed from me to get this submitted? -- To view, visit https://gwt-review.googlesource.com/2511 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ac16598bef878ed756f2fe0dc696166f2a3d504 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Leif Åstrand l...@vaadin.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leif Åstrand l...@vaadin.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Verify that Timer has not been canceled before firing
Leif Åstrand has uploaded a new patch set (#3). Change subject: Verify that Timer has not been canceled before firing .. Verify that Timer has not been canceled before firing * cancelTimeout is not always effective with older versions of IE * Add cancelCounter that is updated when canceling and verified when firing * Fixes Issue 8101 Change-Id: I0ac16598bef878ed756f2fe0dc696166f2a3d504 --- M user/src/com/google/gwt/user/client/Timer.java A user/test/com/google/gwt/user/client/TimerCancelTest.java 2 files changed, 137 insertions(+), 7 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2511 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0ac16598bef878ed756f2fe0dc696166f2a3d504 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Leif Åstrand l...@vaadin.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Leif Åstrand l...@vaadin.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Re: future of jvm dev mode
I think sticking to ESR releases of Firefox could be a good approach for keeping up with the release schedules. Even though it's not 100% trivial to set up a system where you run the release channel and ESR at the same time, it is still quite manageable and you only need to do it once. I do also believe that we are approaching the moment where it would be possible to do JVM dev mode without a plugin in the browser. My experiment at https://github.com/Legioth/devmodejs shows that there are only two essential features missing from Firefox: Weak references (http://wiki.ecmascript.org/doku.php?id=strawman:weak_references) to enable garbage collection in the JVM and some way of doing synchronous websocket communication (or some other synchronous communication method that does not require a new HTTP request for each round trip). -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Verify that Timer has not been canceled before firing
Leif Åstrand has uploaded a new patch set (#4). Change subject: Verify that Timer has not been canceled before firing .. Verify that Timer has not been canceled before firing * cancelTimeout is not always effective with older versions of IE * Add cancelCounter that is updated when canceling and verified when firing * Fixes Issue 8101 Change-Id: I0ac16598bef878ed756f2fe0dc696166f2a3d504 --- M user/src/com/google/gwt/user/client/Timer.java M user/test/com/google/gwt/user/MiscSuite.java A user/test/com/google/gwt/user/client/TimerCancelTest.java 3 files changed, 143 insertions(+), 7 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2511 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0ac16598bef878ed756f2fe0dc696166f2a3d504 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Leif Åstrand l...@vaadin.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leif Åstrand l...@vaadin.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Verify that Timer has not been canceled before firing
Leif Åstrand has abandoned this change. Change subject: Verify that Timer has not been canceled before firing .. Abandoned Submission to google-web-toolkit-contributors failed because my account was not a member of that group. Abandoning this and submitting the ticket again now that I have joined the group to make sure everything gets properly registered. -- To view, visit https://gwt-review.googlesource.com/2510 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I68fbe0896dc9d494bbdb86fd2220d4b8a3710420 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Leif Åstrand l...@vaadin.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Verify that Timer has not been canceled before firing
Leif Åstrand has uploaded a new patch set (#2). Change subject: Verify that Timer has not been canceled before firing .. Verify that Timer has not been canceled before firing * cancelTimeout is not always effective with older versions of IE * Add cancelCounter that is updated when canceling and verified when firing * Fixes Issue 8101 Change-Id: I0ac16598bef878ed756f2fe0dc696166f2a3d504 --- M user/src/com/google/gwt/user/client/Timer.java A user/test/com/google/gwt/user/client/TimerCancelTest.java 2 files changed, 117 insertions(+), 7 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2511 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0ac16598bef878ed756f2fe0dc696166f2a3d504 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Leif Åstrand l...@vaadin.com Gerrit-Reviewer: Daniel Kurka danku...@google.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Verify that Timer has not been canceled before firing
Leif Åstrand has posted comments on this change. Change subject: Verify that Timer has not been canceled before firing .. Patch Set 2: Whitespace nits resolved. Where can I find instructions for how to configure Eclipse to not automatically add that whitespace back when formatting the code using the formatter settings included with the project? -- To view, visit https://gwt-review.googlesource.com/2511 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ac16598bef878ed756f2fe0dc696166f2a3d504 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Leif Åstrand l...@vaadin.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Leif Åstrand l...@vaadin.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Verify that Timer has not been canceled before firing
Leif Åstrand has posted comments on this change. Change subject: Verify that Timer has not been canceled before firing .. Patch Set 3: But the problem is not so much about whether those spaces are there or not, but more about including only the relevant changes in the patch (i.e. git add -p vs. git add). Does not help when the extra spaces are in lines added by the patch. -- To view, visit https://gwt-review.googlesource.com/2511 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ac16598bef878ed756f2fe0dc696166f2a3d504 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Leif Åstrand l...@vaadin.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Leif Åstrand l...@vaadin.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: GWT and WebKit issues
I have also stumbled upon another similar issue (i.e. broken in Safari on iOS6 but working in Chrome on the same system) where number comparison breaks down after about 6000 iterations following a specific pattern: http://code.google.com/p/google-web-toolkit/issues/detail?id=7844 As I observed in the already mentioned http://dev.vaadin.com/ticket/10753, adding something like if (false) return new Object(); or .split(); made that problem go away. I have not tested these workarounds together with the 2000 0 or a++ problems, but it could be worth a try for a generic hack that should have a quite insignificant impact on performance. It seems that just rewriting a++ would not be enough considering the other types of problems identified (2000 0 and random ClassCastException). -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
