Revision: 8941
Author: gwt.mirror...@gmail.com
Date: Tue Oct 5 14:33:18 2010
Log: Fix Eclipse / Checkstyle / Javadoc warnings
Review at http://gwt-code-reviews.appspot.com/954801
Review by: j...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8941
Modified:
/trunk/dev/core/src/com/google/gwt/core/ext/linker/SymbolData.java
/trunk/dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java
/trunk/dev/core/src/com/google/gwt/core/linker/CrossSiteIframeLinker.java
/trunk/dev/core/src/com/google/gwt/dev/Precompile.java
/trunk/dev/core/src/com/google/gwt/dev/jdt/AbstractCompiler.java
/trunk/dev/core/src/com/google/gwt/dev/jdt/TypeRefVisitor.java
/trunk/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java
/trunk/dev/core/src/com/google/gwt/dev/jjs/impl/OptimizerStats.java
/trunk/dev/core/src/com/google/gwt/dev/json/JsonObject.java
/trunk/dev/core/src/com/google/gwt/dev/json/JsonValue.java
/trunk/dev/core/src/com/google/gwt/dev/resource/impl/ZipFileResource.java
/trunk/dev/core/src/com/google/gwt/dev/shell/ModuleSpace.java
/trunk/dev/core/src/com/google/gwt/dev/util/editdistance/CharIndex.java
/trunk/dev/core/src/com/google/gwt/dev/util/editdistance/GeneralEditDistances.java
/trunk/dev/core/src/com/google/gwt/dev/util/editdistance/ModifiedBerghelRoachEditDistance.java
/trunk/dev/core/src/com/google/gwt/dev/util/editdistance/MyersBitParallelEditDistance.java
/trunk/dev/core/src/com/google/gwt/dev/util/editdistance/PatternBitmap.java
/trunk/samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/PersonEditorWorkflow.java
/trunk/samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/MentorSelector.java
/trunk/samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/SummaryWidget.java
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseDetails.java
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesMobileShell.java
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileExpenseEntry.java
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileReportEntry.java
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/Employee.java
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/Expense.java
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/Report.java
/trunk/user/src/com/google/gwt/animation/client/Animation.java
/trunk/user/src/com/google/gwt/app/place/AbstractProxyListView.java
/trunk/user/src/com/google/gwt/app/place/Activity.java
/trunk/user/src/com/google/gwt/app/place/CreateAndEditProxy.java
/trunk/user/src/com/google/gwt/app/place/EntityProxyKeyProvider.java
/trunk/user/src/com/google/gwt/app/place/FindAndEditProxy.java
/trunk/user/src/com/google/gwt/app/place/PlaceChangeEvent.java
/trunk/user/src/com/google/gwt/app/place/PlaceChangeRequestEvent.java
/trunk/user/src/com/google/gwt/app/place/Prefix.java
/trunk/user/src/com/google/gwt/app/place/ProxyPlaceToListPlace.java
/trunk/user/src/com/google/gwt/app/place/WithTokenizers.java
/trunk/user/src/com/google/gwt/cell/client/ImageLoadingCell.java
/trunk/user/src/com/google/gwt/editor/client/AutoBean.java
/trunk/user/src/com/google/gwt/editor/client/AutoBeanVisitor.java
/trunk/user/src/com/google/gwt/editor/client/EditorError.java
/trunk/user/src/com/google/gwt/editor/client/impl/AbstractAutoBean.java
/trunk/user/src/com/google/gwt/editor/client/testing/MockEditorChain.java
/trunk/user/src/com/google/gwt/editor/client/ui/ValueBoxEditorDecorator.java
/trunk/user/src/com/google/gwt/editor/rebind/model/EditorData.java
/trunk/user/src/com/google/gwt/event/logical/shared/AttachEvent.java
/trunk/user/src/com/google/gwt/event/shared/DefaultHandlerRegistration.java
/trunk/user/src/com/google/gwt/event/shared/HandlerManager.java
/trunk/user/src/com/google/gwt/i18n/client/CurrencyList.java
/trunk/user/src/com/google/gwt/i18n/client/DateTimeFormatRenderer.java
/trunk/user/src/com/google/gwt/i18n/client/Messages.java
/trunk/user/src/com/google/gwt/i18n/client/impl/CurrencyDataImpl.java
/trunk/user/src/com/google/gwt/layout/client/Layout.java
/trunk/user/src/com/google/gwt/layout/client/LayoutImplIE8.java
/trunk/user/src/com/google/gwt/logging/client/HtmlLogFormatter.java
/trunk/user/src/com/google/gwt/logging/impl/FormatterImpl.java
/trunk/user/src/com/google/gwt/logging/server/JsonLogRecordServerUtil.java
/trunk/user/src/com/google/gwt/logging/server/RemoteLoggingServiceUtil.java
/trunk/user/src/com/google/gwt/requestfactory/client/DefaultRequestTransport.java
/trunk/user/src/com/google/gwt/requestfactory/client/LoginWidget.java
/trunk/user/src/com/google/gwt/requestfactory/client/RequestFactoryEditorDriver.java
/trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractRequestFactory.java
/trunk/user/src/com/google/gwt/requestfactory/client/impl/FindRequest.java
/trunk/user/src/com/google/gwt/requestfactory/client/impl/SimpleEntityProxyId.java
/trunk/user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java
/trunk/user/src/com/google/gwt/requestfactory/server/Logging.java
/trunk/user/src/com/google/gwt/requestfactory/server/SampleDataPopulator.java
/trunk/user/src/com/google/gwt/requestfactory/shared/EntityProxy.java
/trunk/user/src/com/google/gwt/requestfactory/shared/RequestContext.java
/trunk/user/src/com/google/gwt/requestfactory/shared/RequestFactory.java
/trunk/user/src/com/google/gwt/resources/css/ast/CssSprite.java
/trunk/user/src/com/google/gwt/resources/css/ast/CssVisitor.java
/trunk/user/src/com/google/gwt/safehtml/client/SafeHtmlTemplates.java
/trunk/user/src/com/google/gwt/safehtml/shared/SimpleHtmlSanitizer.java
/trunk/user/src/com/google/gwt/text/shared/SimpleSafeHtmlRenderer.java
/trunk/user/src/com/google/gwt/uibinder/attributeparsers/FieldReferenceConverter.java
/trunk/user/src/com/google/gwt/uibinder/client/UiChild.java
/trunk/user/src/com/google/gwt/uibinder/client/UiHandler.java
/trunk/user/src/com/google/gwt/uibinder/elementparsers/AttributeMessageParser.java
/trunk/user/src/com/google/gwt/uibinder/elementparsers/ImageParser.java
/trunk/user/src/com/google/gwt/uibinder/elementparsers/UiChildParser.java
/trunk/user/src/com/google/gwt/user/cellview/client/RowStyles.java
/trunk/user/src/com/google/gwt/user/client/History.java
/trunk/user/src/com/google/gwt/user/client/ResponseTextHandler.java
/trunk/user/src/com/google/gwt/user/client/Window.java
/trunk/user/src/com/google/gwt/user/client/rpc/core/java/util/logging/Level_CustomFieldSerializer.java
/trunk/user/src/com/google/gwt/user/client/rpc/impl/RemoteServiceProxy.java
/trunk/user/src/com/google/gwt/user/client/ui/CustomButton.java
/trunk/user/src/com/google/gwt/user/client/ui/HTML.java
/trunk/user/src/com/google/gwt/user/client/ui/InlineHTML.java
/trunk/user/src/com/google/gwt/user/client/ui/InlineLabel.java
/trunk/user/src/com/google/gwt/user/client/ui/Label.java
/trunk/user/src/com/google/gwt/user/client/ui/PopupPanel.java
/trunk/user/src/com/google/gwt/user/client/ui/StackLayoutPanel.java
/trunk/user/src/com/google/gwt/user/client/ui/SuggestOracle.java
/trunk/user/src/com/google/gwt/user/client/ui/TabBar.java
/trunk/user/src/com/google/gwt/user/client/ui/TabLayoutPanel.java
/trunk/user/src/com/google/gwt/user/client/ui/TabPanel.java
/trunk/user/src/com/google/gwt/user/client/ui/ValueListBox.java
/trunk/user/src/com/google/gwt/user/client/ui/Widget.java
/trunk/user/src/com/google/gwt/user/server/rpc/RPCServletUtils.java
/trunk/user/src/com/google/gwt/validation/client/GwtValidation.java
/trunk/user/src/com/google/gwt/validation/client/constraints/AbstractDecimalMaxValidator.java
/trunk/user/src/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfBoolean.java
/trunk/user/src/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfByte.java
/trunk/user/src/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfChar.java
/trunk/user/src/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfDouble.java
/trunk/user/src/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfFloat.java
/trunk/user/src/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfInt.java
/trunk/user/src/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfLong.java
/trunk/user/src/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfShort.java
/trunk/user/src/com/google/gwt/xhr/client/ReadyStateChangeHandler.java
/trunk/user/src/com/google/gwt/xhr/client/XMLHttpRequest.java
/trunk/user/test/com/google/gwt/core/ext/test/CrossSiteIframeLinkerTest.java
/trunk/user/test/com/google/gwt/dev/jjs/test/EnumsWithNameObfuscationTest.java
/trunk/user/test/com/google/gwt/resources/client/DataResourceDoNotEmbedTest.java
/trunk/user/test/com/google/gwt/uibinder/test/client/HandlerDemo.java
/trunk/user/test/com/google/gwt/user/client/ui/HTMLPanelTest.java
/trunk/user/test/com/google/gwt/user/server/rpc/RPCServletUtilsTest.java
=======================================
--- /trunk/dev/core/src/com/google/gwt/core/ext/linker/SymbolData.java Mon
Aug 30 04:31:11 2010
+++ /trunk/dev/core/src/com/google/gwt/core/ext/linker/SymbolData.java Tue
Oct 5 14:33:18 2010
@@ -81,7 +81,7 @@
}
/**
- * Returns a JSON map of castableTypes
+ * Returns a JSON map of castableTypes.
*/
CastableTypeMap getCastableTypeMap();
=======================================
--- /trunk/dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java
Thu Sep 9 08:24:17 2010
+++ /trunk/dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java
Tue Oct 5 14:33:18 2010
@@ -494,7 +494,7 @@
}
/**
- * @Deprecated This method will always return 0 because a TypeOracle
never
+ * @deprecated This method will always return 0 because a TypeOracle
never
* gets reloaded anymore. Callers should not rely on this
value to
* manage static state.
*/
=======================================
---
/trunk/dev/core/src/com/google/gwt/core/linker/CrossSiteIframeLinker.java
Wed Sep 29 08:04:55 2010
+++
/trunk/dev/core/src/com/google/gwt/core/linker/CrossSiteIframeLinker.java
Tue Oct 5 14:33:18 2010
@@ -66,7 +66,7 @@
protected byte[] generatePrimaryFragment(TreeLogger logger,
LinkerContext context, CompilationResult result, String[] js) {
TextOutput script = new DefaultTextOutput(context.isOutputCompact());
- script.print(getModulePrefix(context, result.getStrongName(),
js.length > 1));
+ script.print(getModulePrefix(context, result.getStrongName()));
script.print(js[0]);
script.print(getModuleSuffix(logger, context));
StringBuffer out = new StringBuffer();
@@ -194,8 +194,7 @@
return "com/google/gwt/core/linker/CrossSiteIframeTemplate.js";
}
- private String getModulePrefix(LinkerContext context, String strongName,
- boolean supportRunAsync) {
+ private String getModulePrefix(LinkerContext context, String strongName)
{
TextOutput out = new DefaultTextOutput(context.isOutputCompact());
out.print("var __gwtModuleFunction = $wnd." +
context.getModuleFunctionName() + ";");
out.newlineOpt();
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/Precompile.java Wed Sep 29
08:04:55 2010
+++ /trunk/dev/core/src/com/google/gwt/dev/Precompile.java Tue Oct 5
14:33:18 2010
@@ -388,6 +388,7 @@
setDaemon(true);
}
+ @Override
public void run() {
SpeedTracerLogger.Event createGraphicsEvent =
SpeedTracerLogger.start(
CompilerEventType.GRAPHICS_INIT, "java.awt.headless",
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/jdt/AbstractCompiler.java Wed
Sep 15 10:32:35 2010
+++ /trunk/dev/core/src/com/google/gwt/dev/jdt/AbstractCompiler.java Tue
Oct 5 11:03:13 2010
@@ -638,22 +638,28 @@
}
}
- @SuppressWarnings("unused")
- // overrider may use unused parameter
+ /**
+ * @param logger a {...@link TreeLogger}
+ * @param cud a {...@link CompilationUnitDeclaration}
+ */
protected String[] doFindAdditionalTypesUsingArtificialRescues(
TreeLogger logger, CompilationUnitDeclaration cud) {
return Empty.STRINGS;
}
- @SuppressWarnings("unused")
- // overrider may use unused parameter
+ /**
+ * @param logger a {...@link TreeLogger}
+ * @param cud a {...@link CompilationUnitDeclaration}
+ */
protected String[] doFindAdditionalTypesUsingJsni(TreeLogger logger,
CompilationUnitDeclaration cud) {
return Empty.STRINGS;
}
- @SuppressWarnings("unused")
- // overrider may use unused parameter
+ /**
+ * @param logger a {...@link TreeLogger}
+ * @param cud a {...@link CompilationUnitDeclaration}
+ */
protected String[] doFindAdditionalTypesUsingRebinds(TreeLogger logger,
CompilationUnitDeclaration cud) {
return Empty.STRINGS;
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/jdt/TypeRefVisitor.java Fri Jul
30 07:51:15 2010
+++ /trunk/dev/core/src/com/google/gwt/dev/jdt/TypeRefVisitor.java Tue Oct
5 11:03:13 2010
@@ -153,7 +153,11 @@
return true;
}
- @SuppressWarnings("unused")
+ /**
+ * @param referencedType
+ * @param unitOfReferrer
+ * @param expression
+ */
protected void onBinaryTypeRef(BinaryTypeBinding referencedType,
CompilationUnitDeclaration unitOfReferrer, Expression expression) {
}
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java
Tue Aug 31 17:13:43 2010
+++ /trunk/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java
Tue Oct 5 11:03:13 2010
@@ -248,6 +248,7 @@
this.childClass = childClass;
}
+ @Override
public boolean equals(Object obj) {
if (obj instanceof MethodKey) {
MethodKey otherKey = (MethodKey) obj;
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/jjs/impl/OptimizerStats.java Thu
Sep 9 00:20:17 2010
+++ /trunk/dev/core/src/com/google/gwt/dev/jjs/impl/OptimizerStats.java Tue
Oct 5 11:03:13 2010
@@ -88,7 +88,7 @@
}
/**
- * Return a human readable string representing the values of all
statistics
+ * Return a human-readable string representing the values of all
statistics.
*/
public String prettyPrint() {
StringBuilder builder = new StringBuilder();
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/json/JsonObject.java Thu Jul 22
13:05:55 2010
+++ /trunk/dev/core/src/com/google/gwt/dev/json/JsonObject.java Tue Oct 5
11:03:13 2010
@@ -75,7 +75,7 @@
int c = tokenizer.nextNonWhitespace();
if (c != '{') {
throw new JsonException("Payload does not begin with '{'. Got " + c
+ "("
- + Character.valueOf((char)c) + ")");
+ + Character.valueOf((char) c) + ")");
}
while (true) {
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/json/JsonValue.java Mon Jul 19
11:45:38 2010
+++ /trunk/dev/core/src/com/google/gwt/dev/json/JsonValue.java Tue Oct 5
11:03:13 2010
@@ -25,7 +25,7 @@
/**
* JSON placeholder for null.
*/
- final JsonValue NULL = new JsonValue() {
+ JsonValue NULL = new JsonValue() {
public JsonArray asArray() {
return null;
=======================================
---
/trunk/dev/core/src/com/google/gwt/dev/resource/impl/ZipFileResource.java
Thu Sep 23 06:33:21 2010
+++
/trunk/dev/core/src/com/google/gwt/dev/resource/impl/ZipFileResource.java
Tue Oct 5 11:03:13 2010
@@ -49,7 +49,9 @@
@Override
public String getLocation() {
+ // CHECKSTYLE_OFF
return "jar:" + classPathEntry.getLocation() + "!/" + path;
+ // CHECKSTYLE_ON
}
@Override
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/shell/ModuleSpace.java Thu Sep
16 10:52:13 2010
+++ /trunk/dev/core/src/com/google/gwt/dev/shell/ModuleSpace.java Tue Oct
5 11:03:13 2010
@@ -361,7 +361,6 @@
// Try to initialize EntryPoint, else throw up glass panel
try {
Class<?> clazz = loadClassFromSourceName(entryPointTypeName);
- onModuleLoad = null;
try {
onModuleLoad = clazz.getMethod("onModuleLoad");
if (!Modifier.isStatic(onModuleLoad.getModifiers())) {
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/util/editdistance/CharIndex.java
Tue Sep 28 15:31:23 2010
+++ /trunk/dev/core/src/com/google/gwt/dev/util/editdistance/CharIndex.java
Tue Oct 5 11:03:13 2010
@@ -47,13 +47,13 @@
*/
public static class FullHash extends CharIndex {
/**
- * Mutable holder for a character
+ * Mutable holder for a character.
*/
static class Char {
char c;
@Override
public boolean equals(Object x) {
- return (x != null) && (((Char)x).c == this.c);
+ return (x != null) && (((Char) x).c == this.c);
}
@Override
public int hashCode() {
@@ -68,12 +68,12 @@
static final int NULL_ELEMENT = 0;
protected int lastUsed = NULL_ELEMENT;
/**
- * Mapping from pattern characters to their integer index values
+ * Mapping from pattern characters to their integer index values.
*/
final java.util.HashMap<Char,Integer> map;
/**
- * Constructs a full hash-based mapping
+ * Constructs a full hash-based mapping.
*/
FullHash(CharSequence s) {
/* Choose a hash size larger at least twice the string length */
@@ -148,21 +148,20 @@
*/
public static class Masked extends CharIndex {
/**
- * Hash table size
+ * Hash table size.
*/
static final int SIZE = 0x100;
/**
- * Mask used for hashing
+ * Mask used for hashing.
*/
static final int MASK = (SIZE - 1);
/**
- * Where we may invalid characters: beyond the hash table
+ * Where we may invalid characters: beyond the hash table.
*/
static final int NULL_ELEMENT = SIZE;
-
/**
* Generates an instance of this implementation if possible.
* @param s pattern string
@@ -177,7 +176,7 @@
char [] contains = new char[SIZE];
/* Ensure that for all x, hash(contains[x]) != x initially. */
- contains[0] = (char)1;
+ contains[0] = (char) 1;
/* Hash characters, recording values seen, rejecting collisions */
for (int i = 0; i < s.length(); i++) {
@@ -200,7 +199,7 @@
final char[] contains;
/**
- * Constructor based on hash table built by generate()
+ * Constructor based on hash table built by generate().
*/
private Masked(char [] contains) {
this.contains = contains;
@@ -215,7 +214,9 @@
@Override
public int[] map(CharSequence s, int[] mapped) {
int len = s.length();
- if (mapped.length < len) mapped = new int[len];
+ if (mapped.length < len) {
+ mapped = new int[len];
+ }
for (int i = 0; i < len; i++) {
char c = s.charAt(i);
int index = c & MASK;
@@ -238,21 +239,20 @@
*/
public static class Straight extends CharIndex {
/**
- * The largest character we will map (directly)
+ * The largest character we will map (directly).
*/
static final int MAX = 0x80;
/**
- * A mask used to find characters that fall outside
+ * A mask used to find characters that fall outside.
*/
static final int MASK = ~(MAX - 1);
/**
- * A map result we never generate for valid characters
+ * A map result we never generate for valid characters.
*/
static final int NULL_ELEMENT = MAX;
-
/**
* Generates an instance of this implementation if possible.
* @param s pattern string
@@ -271,7 +271,7 @@
}
/**
- * Simple private constructor, no state required
+ * Simple private constructor, no state required.
*/
private Straight() { }
@@ -283,7 +283,9 @@
@Override
public int[] map(CharSequence s, int[] mapped) {
int len = s.length();
- if (mapped.length < len) mapped = new int[len];
+ if (mapped.length < len) {
+ mapped = new int[len];
+ }
for (int i = 0; i < len; i++) {
char c = s.charAt(i);
mapped[i] = ((c & MASK) == 0) ? c : NULL_ELEMENT;
=======================================
---
/trunk/dev/core/src/com/google/gwt/dev/util/editdistance/GeneralEditDistances.java
Tue Sep 28 15:31:23 2010
+++
/trunk/dev/core/src/com/google/gwt/dev/util/editdistance/GeneralEditDistances.java
Tue Oct 5 11:03:13 2010
@@ -58,22 +58,22 @@
*/
private static class Levenshtein implements GeneralEditDistance {
/**
- * Long+bounded implementation class: distance-only Berghel-Roach
+ * Long+bounded implementation class: distance-only Berghel-Roach.
*/
private ModifiedBerghelRoachEditDistance berghel;
/**
- * Short/unbounded implementation class: Myers bit-parallel
+ * Short/unbounded implementation class: Myers bit-parallel.
*/
private MyersBitParallelEditDistance myers;
/**
- * Saved pattern, for specialized comparisons
+ * Saved pattern, for specialized comparisons.
*/
private final CharSequence pattern;
/**
- * Length of saved pattern
+ * Length of saved pattern.
*/
private final int patternLength;
=======================================
---
/trunk/dev/core/src/com/google/gwt/dev/util/editdistance/ModifiedBerghelRoachEditDistance.java
Tue Sep 28 15:31:23 2010
+++
/trunk/dev/core/src/com/google/gwt/dev/util/editdistance/ModifiedBerghelRoachEditDistance.java
Tue Oct 5 11:03:13 2010
@@ -209,7 +209,7 @@
private int[] lastRight = EMPTY_INT_ARRAY;
/**
- * The "pattern" string against which others are compared
+ * The "pattern" string against which others are compared.
*/
private final char[] pattern;
@@ -319,7 +319,6 @@
lastRight[offDiagonal],
immediateRight);
}
-
/*
* Lower-numbered diagonals
=======================================
---
/trunk/dev/core/src/com/google/gwt/dev/util/editdistance/MyersBitParallelEditDistance.java
Tue Sep 28 15:31:23 2010
+++
/trunk/dev/core/src/com/google/gwt/dev/util/editdistance/MyersBitParallelEditDistance.java
Tue Oct 5 11:03:13 2010
@@ -15,7 +15,6 @@
*/
package com.google.gwt.dev.util.editdistance;
-
/**
* Computes Levenshtein string-edit distance using the
* algorithm of Eugene Myers (see "A fast bit-vector algorithm for
@@ -136,7 +135,7 @@
*/
/**
- * A trivial implementation for the zero-length string
+ * A trivial implementation for the zero-length string.
*/
static class Empty extends MyersBitParallelEditDistance {
Empty(CharSequence s) {
@@ -166,12 +165,12 @@
int count;
/**
- * Where the last-row bit lives -- only in the last array slot, though
+ * Where the last-row bit lives -- only in the last array slot, though.
*/
final int lastBitPosition;
/**
- * Bitmaps for pattern string: [pattern_index][column_index]
+ * Bitmaps for pattern string: [pattern_index][column_index].
*/
final int[][] positions;
@@ -180,17 +179,17 @@
int[] verticalPositivesReusable;
/**
- * A mask with those bits set
+ * A mask with those bits set.
*/
final int wordMask = (-1 >>> 1);
/**
- * How many bits we use per word
+ * How many bits we use per word.
*/
final int wordSize = Integer.SIZE - 1;
/**
- * Constructs a multi-word engine
+ * Constructs a multi-word engine.
*/
Multi(CharSequence s) {
super(s);
@@ -223,7 +222,9 @@
/* We can only miss the distance-- below this many times: */
int maxMisses = k + len - m;
- if (maxMisses < 0) maxMisses = Integer.MAX_VALUE;
+ if (maxMisses < 0) {
+ maxMisses = Integer.MAX_VALUE;
+ }
outer:
for (int j = 0; j < len; j++) {
@@ -311,7 +312,7 @@
/* Precompute bitmaps for this pattern */
map = PatternBitmap.map(s, idx, new int/*WORD*/[idx.size()]);
/* Compute the bit that represents a change in the last row */
- lastBitPosition = (((int/*WORD*/)1) << (m - 1));
+ lastBitPosition = (((int/*WORD*/) 1) << (m - 1));
}
@Override
@@ -319,8 +320,9 @@
int len = s.length();
/* Quick check based on length */
- if (((len - m) > k) || ((m - len) > k))
+ if (((len - m) > k) || ((m - len) > k)) {
return k + 1;
+ }
/* Map characters to their integer positions in the bitmap array */
indices = idx.map(s, indices);
@@ -332,7 +334,9 @@
/* We can only miss the "distance--" below this many times: */
int maxMisses = k + len - m;
- if (maxMisses < 0) maxMisses = Integer.MAX_VALUE;
+ if (maxMisses < 0) {
+ maxMisses = Integer.MAX_VALUE;
+ }
for (int j = 0; j < len; j++) {
/* Where is diagonal zero: matches, or prior VN; plus recursion */
@@ -376,13 +380,12 @@
final long/*WORD*/ lastBitPosition;
final long/*WORD*/[] map;
- @SuppressWarnings("cast")
TYPElong/*WORD*/(CharSequence s) {
super(s);
/* Precompute bitmaps for this pattern */
map = PatternBitmap.map(s, idx, new long/*WORD*/[idx.size()]);
/* Compute the bit that represents a change in the last row */
- lastBitPosition = (((long/*WORD*/)1) << (m - 1));
+ lastBitPosition = (((long/*WORD*/) 1) << (m - 1));
}
@Override
@@ -390,8 +393,9 @@
int len = s.length();
/* Quick check based on length */
- if (((len - m) > k) || ((m - len) > k))
+ if (((len - m) > k) || ((m - len) > k)) {
return k + 1;
+ }
/* Map characters to their integer positions in the bitmap array */
indices = idx.map(s, indices);
@@ -403,7 +407,9 @@
/* We can only miss the "distance--" below this many times: */
int maxMisses = k + len - m;
- if (maxMisses < 0) maxMisses = Integer.MAX_VALUE;
+ if (maxMisses < 0) {
+ maxMisses = Integer.MAX_VALUE;
+ }
for (int j = 0; j < len; j++) {
/* Where is diagonal zero: matches, or prior VN; plus recursion */
@@ -453,7 +459,7 @@
}
/**
- * Tests a computation manually
+ * Tests a computation manually.
*/
public static void main(String[] args) {
MyersBitParallelEditDistance b = getInstance(args[0]);
@@ -462,22 +468,22 @@
}
/**
- * Index mapping for pattern string
+ * Index mapping for pattern string.
*/
final CharIndex idx;
/**
- * Reusable array of indices for target strings
+ * Reusable array of indices for target strings.
*/
int[] indices = new int[0];
/**
- * Length of pattern
+ * Length of pattern.
*/
final int m;
/**
- * Constructs a distance calculator for a given string
+ * Constructs a distance calculator for a given string.
*/
protected MyersBitParallelEditDistance(CharSequence s) {
m = s.length();
@@ -486,7 +492,7 @@
public GeneralEditDistance duplicate() {
try {
- return (MyersBitParallelEditDistance)clone();
+ return (MyersBitParallelEditDistance) clone();
} catch (CloneNotSupportedException x) { /*IMPOSSIBLE */
throw new IllegalStateException("Cloneable object would not clone");
}
@@ -494,7 +500,7 @@
/**
* Computes distance from the pattern to a given string, bounded by
- * a limiting distance
@see(GeneralEditDistance.getDistance(CharSequence,int))
+ * a limiting distance
@see(GeneralEditDistance.getDistance(CharSequence,int)).
*/
public abstract int getDistance(CharSequence s, int k);
@@ -503,13 +509,13 @@
Object obj = super.clone();
/* Re-initialize any non-thread-safe parts */
- ((MyersBitParallelEditDistance)obj).perThreadInit();
+ ((MyersBitParallelEditDistance) obj).perThreadInit();
return obj;
}
/**
- * Initializes items that cannot be shared among threads
+ * Initializes items that cannot be shared among threads.
*/
protected void perThreadInit() {
indices = new int[0];
=======================================
---
/trunk/dev/core/src/com/google/gwt/dev/util/editdistance/PatternBitmap.java
Tue Sep 28 15:31:23 2010
+++
/trunk/dev/core/src/com/google/gwt/dev/util/editdistance/PatternBitmap.java
Tue Oct 5 11:03:13 2010
@@ -15,7 +15,6 @@
*/
package com.google.gwt.dev.util.editdistance;
-
/**
* A bitmap array generator for the positions that a given character
* appears within a pattern. The array of bitmaps is indexed by a
=======================================
---
/trunk/samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/PersonEditorWorkflow.java
Sun Oct 3 11:35:25 2010
+++
/trunk/samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/PersonEditorWorkflow.java
Tue Oct 5 11:03:13 2010
@@ -100,12 +100,12 @@
}
@UiHandler("cancel")
- void onCancel(ClickEvent e) {
+ void onCancel(@SuppressWarnings("unused") ClickEvent event) {
dialog.hide();
}
@UiHandler("save")
- void onSave(ClickEvent e) {
+ void onSave(@SuppressWarnings("unused") ClickEvent event) {
// MOVE TO ACTIVITY END
RequestContext context = editorDriver.flush();
if (editorDriver.hasErrors()) {
@@ -127,7 +127,7 @@
}
@UiHandler("favorite")
- void onValueChanged(ValueChangeEvent<Boolean> event) {
+ void onValueChanged(@SuppressWarnings("unused")
ValueChangeEvent<Boolean> event) {
manager.setFavorite(person, favorite.getValue());
}
=======================================
---
/trunk/samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/MentorSelector.java
Sun Oct 3 11:35:25 2010
+++
/trunk/samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/MentorSelector.java
Tue Oct 5 11:03:13 2010
@@ -74,7 +74,7 @@
}
@UiHandler("choose")
- void onChoose(ClickEvent event) {
+ void onChoose(@SuppressWarnings("unused") ClickEvent event) {
setEnabled(false);
factory.schoolCalendarRequest().getRandomPerson().to(
new Receiver<PersonProxy>() {
@@ -87,7 +87,7 @@
}
@UiHandler("clear")
- void onClear(ClickEvent event) {
+ void onClear(@SuppressWarnings("unused") ClickEvent event) {
setValue(null);
}
=======================================
---
/trunk/samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/SummaryWidget.java
Sun Oct 3 11:35:25 2010
+++
/trunk/samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/SummaryWidget.java
Tue Oct 5 11:03:13 2010
@@ -162,8 +162,8 @@
fetch(0);
}
- @UiHandler("create")
- void onCreate(ClickEvent event) {
+ @UiHandler("create")
+ void onCreate(@SuppressWarnings("unused") ClickEvent event) {
PersonRequest context = requestFactory.personRequest();
AddressProxy address = context.create(AddressProxy.class);
PersonProxy person = context.edit(context.create(PersonProxy.class));
=======================================
---
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseDetails.java
Fri Oct 1 18:15:55 2010
+++
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseDetails.java
Tue Oct 5 11:03:13 2010
@@ -43,7 +43,6 @@
import com.google.gwt.requestfactory.shared.EntityProxyChange;
import com.google.gwt.requestfactory.shared.EntityProxyId;
import com.google.gwt.requestfactory.shared.Receiver;
-import com.google.gwt.requestfactory.shared.Request;
import com.google.gwt.resources.client.ImageResource;
import com.google.gwt.safehtml.client.SafeHtmlTemplates;
import com.google.gwt.safehtml.shared.SafeHtml;
=======================================
---
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesMobileShell.java
Fri Sep 10 17:56:09 2010
+++
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesMobileShell.java
Tue Oct 5 11:03:13 2010
@@ -76,26 +76,22 @@
}
@UiHandler("addButton")
- @SuppressWarnings("unused")
- void onAdd(ClickEvent evt) {
+ void onAdd(@SuppressWarnings("unused") ClickEvent evt) {
topPage().onAdd();
}
@UiHandler("backButton")
- @SuppressWarnings("unused")
- void onBack(ClickEvent evt) {
+ void onBack(@SuppressWarnings("unused") ClickEvent evt) {
popPage();
}
@UiHandler("customButton")
- @SuppressWarnings("unused")
- void onCustom(ClickEvent evt) {
+ void onCustom(@SuppressWarnings("unused") ClickEvent evt) {
topPage().onCustom();
}
@UiHandler("refreshButton")
- @SuppressWarnings("unused")
- void onRefresh(ClickEvent evt) {
+ void onRefresh(@SuppressWarnings("unused") ClickEvent evt) {
topPage().onRefresh(true);
}
=======================================
---
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileExpenseEntry.java
Fri Oct 1 18:15:55 2010
+++
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileExpenseEntry.java
Tue Oct 5 11:03:13 2010
@@ -52,6 +52,7 @@
private ExpenseProxy expense;
private final ExpensesRequestFactory requestFactory;
+ @SuppressWarnings("unused")
private final Listener listener;
private ExpenseRequest request;
=======================================
---
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileReportEntry.java
Fri Oct 1 18:15:55 2010
+++
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileReportEntry.java
Tue Oct 5 11:03:13 2010
@@ -57,6 +57,7 @@
private ReportProxy report;
private final ExpensesRequestFactory requestFactory;
+ @SuppressWarnings("unused")
private final Listener listener;
private ReportRequest request;
=======================================
---
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/Employee.java
Thu Sep 16 10:06:06 2010
+++
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/Employee.java
Tue Oct 5 11:03:13 2010
@@ -141,6 +141,7 @@
private Integer version;
@Transient
+ @SuppressWarnings("unused")
private Employee supervisor;
public String getDepartment() {
=======================================
---
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/Expense.java
Thu Sep 16 10:06:06 2010
+++
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/Expense.java
Tue Oct 5 11:03:13 2010
@@ -110,6 +110,7 @@
private String reasonDenied;
@Transient
+ @SuppressWarnings("unused")
private Report report;
// @JoinColumn
=======================================
---
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/Report.java
Fri Aug 20 12:02:03 2010
+++
/trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/Report.java
Tue Oct 5 11:03:13 2010
@@ -338,9 +338,11 @@
}
@Transient
+ @SuppressWarnings("unused")
private Employee approvedSupervisor;
@Transient
+ @SuppressWarnings("unused")
private Employee reporter;
// @JoinColumn
=======================================
--- /trunk/user/src/com/google/gwt/animation/client/Animation.java Wed Oct
28 09:10:53 2009
+++ /trunk/user/src/com/google/gwt/animation/client/Animation.java Tue Oct
5 11:03:13 2010
@@ -138,7 +138,7 @@
// Add to the list of animations
// We use a static list of animations and a single timer, and create
them
- // only if we are the only active animation. This is safe since JS is
+ // only if we are the only active animation. This is safe since JS is
// single-threaded.
if (animations == null) {
animations = new ArrayList<Animation>();
=======================================
--- /trunk/user/src/com/google/gwt/app/place/AbstractProxyListView.java Sun
Oct 3 19:15:33 2010
+++ /trunk/user/src/com/google/gwt/app/place/AbstractProxyListView.java Tue
Oct 5 11:03:13 2010
@@ -61,6 +61,7 @@
});
}
+ @Override
protected void initWidget(Widget widget) {
throw new UnsupportedOperationException(
"AbstractRecordListView must be initialized via "
=======================================
--- /trunk/user/src/com/google/gwt/app/place/Activity.java Mon Sep 13
10:28:49 2010
+++ /trunk/user/src/com/google/gwt/app/place/Activity.java Tue Oct 5
11:03:13 2010
@@ -53,7 +53,7 @@
* Called when the Activity should ready its widget for the user. When
the
* widget is ready (typically after an RPC response has been received),
* receiver should present it by calling
- * {...@link AcceptsOneWidget#setWidget()} on the given panel
+ * {...@link AcceptsOneWidget#setWidget} on the given panel
* <p>
* Any handlers attached to the provided event bus will be de-registered
when
* the activity is stopped, so activities will rarely need to hold on to
the
=======================================
--- /trunk/user/src/com/google/gwt/app/place/CreateAndEditProxy.java Mon
Oct 4 10:12:28 2010
+++ /trunk/user/src/com/google/gwt/app/place/CreateAndEditProxy.java Tue
Oct 5 11:03:13 2010
@@ -21,7 +21,8 @@
import com.google.gwt.user.client.ui.AcceptsOneWidget;
/**
- * Extends {...@link AbstractProxyEditActivity} to first create an instance
to edit
+ * Extends {...@link AbstractProxyEditActivity} to first create an instance to
+ * edit.
*
* @param <P> the type of proxy to create and edit
*/
=======================================
--- /trunk/user/src/com/google/gwt/app/place/EntityProxyKeyProvider.java
Sat Sep 18 09:13:37 2010
+++ /trunk/user/src/com/google/gwt/app/place/EntityProxyKeyProvider.java
Tue Oct 5 11:03:13 2010
@@ -19,7 +19,7 @@
import com.google.gwt.view.client.ProvidesKey;
/**
- * A {...@link Record}-aware key provider.
+ * An {...@link EntityProxy}-aware key provider.
*
* @param <P> the proxy type
*/
=======================================
--- /trunk/user/src/com/google/gwt/app/place/FindAndEditProxy.java Sun Oct
3 19:15:33 2010
+++ /trunk/user/src/com/google/gwt/app/place/FindAndEditProxy.java Tue Oct
5 11:03:13 2010
@@ -23,7 +23,8 @@
import com.google.gwt.user.client.ui.AcceptsOneWidget;
/**
- * Extends {...@link AbstractProxyEditActivity} to work from a {...@link
EntityProxyId}
+ * Extends {...@link AbstractProxyEditActivity} to work from a
+ * {...@link EntityProxyId}.
*
* @param <P> the type of proxy to find and edit
*/
=======================================
--- /trunk/user/src/com/google/gwt/app/place/PlaceChangeEvent.java Mon Aug
16 20:22:31 2010
+++ /trunk/user/src/com/google/gwt/app/place/PlaceChangeEvent.java Tue Oct
5 11:03:13 2010
@@ -30,8 +30,6 @@
/**
* Implemented by handlers of PlaceChangeEvent.
- *
- * @param <P> the type of the new Place
*/
public interface Handler extends EventHandler {
void onPlaceChange(PlaceChangeEvent event);
=======================================
--- /trunk/user/src/com/google/gwt/app/place/PlaceChangeRequestEvent.java
Fri Sep 17 09:11:27 2010
+++ /trunk/user/src/com/google/gwt/app/place/PlaceChangeRequestEvent.java
Tue Oct 5 11:03:13 2010
@@ -33,8 +33,6 @@
/**
* Implemented by handlers of PlaceChangeRequestEvent.
- *
- * @param <P> the type of the requested Place
*/
public interface Handler extends EventHandler {
void onPlaceChangeRequest(PlaceChangeRequestEvent event);
=======================================
--- /trunk/user/src/com/google/gwt/app/place/Prefix.java Sat Sep 18
17:22:16 2010
+++ /trunk/user/src/com/google/gwt/app/place/Prefix.java Tue Oct 5
11:03:13 2010
@@ -24,7 +24,7 @@
* Indicates the prefix to use when the token written by
* {...@link PlaceTokenizer#getToken(Place)} is written to
* {...@link com.google.gwt.user.client.History#newItem}.
- * {...@link com.google.gwt.app.rebind.PlaceHistoryMapperGenerator} looks
+ * {...@code com.google.gwt.app.rebind.PlaceHistoryMapperGenerator} looks
* for this annotation on the factory methods that return a tokenizer, and
on
* the tokenizer types themselves.
*/
=======================================
--- /trunk/user/src/com/google/gwt/app/place/ProxyPlaceToListPlace.java Sun
Oct 3 19:15:33 2010
+++ /trunk/user/src/com/google/gwt/app/place/ProxyPlaceToListPlace.java Tue
Oct 5 11:03:13 2010
@@ -16,13 +16,13 @@
package com.google.gwt.app.place;
/**
- * Converts a {...@link #ProxyPlace} to a {...@link ProxyListPlace}.
+ * Converts a {...@link ProxyPlace} to a {...@link ProxyListPlace}.
*/
public class ProxyPlaceToListPlace implements
FilteredActivityMapper.Filter {
/**
- * Required by {...@link FilteredActivityMapper.Filter}, calls
- * {...@link #proxyListPlaceFor()}.
+ * Required by {...@link
com.google.gwt.app.place.FilteredActivityMapper.Filter}, calls
+ * {...@link #proxyListPlaceFor}.
*/
public Place filter(Place place) {
return proxyListPlaceFor(place);
=======================================
--- /trunk/user/src/com/google/gwt/app/place/WithTokenizers.java Sat Sep 18
17:22:16 2010
+++ /trunk/user/src/com/google/gwt/app/place/WithTokenizers.java Tue Oct 5
11:03:13 2010
@@ -23,7 +23,7 @@
/**
* Indicates {...@link PlaceTokenizer} types used by an implementation of
* {...@link PlaceHistoryMapper} generated by
- * {...@link com.google.gwt.app.rebind.PlaceHistoryMapperGenerator}.
+ * {...@code com.google.gwt.app.rebind.PlaceHistoryMapperGenerator}.
*/
@Target({ElementType.TYPE})
@Retention(RetentionPolicy.RUNTIME)
=======================================
--- /trunk/user/src/com/google/gwt/cell/client/ImageLoadingCell.java Thu
Sep 2 08:33:16 2010
+++ /trunk/user/src/com/google/gwt/cell/client/ImageLoadingCell.java Tue
Oct 5 11:03:13 2010
@@ -45,7 +45,7 @@
* Get the renderer used to render an error message when the image
does not
* load. By default, the broken image is rendered.
*
- * @return the {...@link Renderer} used when the image doesn't load
+ * @return the {...@link SafeHtmlRenderer} used when the image doesn't
load
*/
SafeHtmlRenderer<String> getErrorRenderer();
@@ -54,7 +54,7 @@
* <code>img</code> element, which triggers the <code>load</code> or
<code>
* error</code> event that this cell handles.
*
- * @return the {...@link Renderer} used to render the image
+ * @return the {...@link SafeHtmlRenderer} used to render the image
*/
SafeHtmlRenderer<String> getImageRenderer();
@@ -62,7 +62,7 @@
* Get the renderer used to render a loading message. By default, an
* animated loading icon is rendered.
*
- * @return the {...@link Renderer} used to render the loading html
+ * @return the {...@link SafeHtmlRenderer} used to render the loading html
*/
SafeHtmlRenderer<String> getLoadingRenderer();
}
@@ -81,7 +81,7 @@
private static Template template;
/**
- * The default {...@link Renderers}.
+ * The default {...@link SafeHtmlRenderer SafeHtmlRenderers}.
*/
public static class DefaultRenderers implements Renderers {
@@ -149,7 +149,7 @@
/**
* Construct an {...@link ImageResourceCell} using the specified
- * {...@link Renderers}.
+ * {...@link SafeHtmlRenderer SafeHtmlRenderers}.
*
*/
public ImageLoadingCell(Renderers renderers) {
=======================================
--- /trunk/user/src/com/google/gwt/editor/client/AutoBean.java Fri Oct 1
18:15:55 2010
+++ /trunk/user/src/com/google/gwt/editor/client/AutoBean.java Tue Oct 5
11:03:13 2010
@@ -51,7 +51,8 @@
<Q> Q getTag(String tagName);
/**
- * Returns <code>true</code> if {...@link #freeze()} has been called.
+ * Returns the value most recently passed to {...@link #setFrozen}, or false
+ * if it has never been called.
*/
boolean isFrozen();
=======================================
--- /trunk/user/src/com/google/gwt/editor/client/AutoBeanVisitor.java Fri
Oct 1 18:15:55 2010
+++ /trunk/user/src/com/google/gwt/editor/client/AutoBeanVisitor.java Tue
Oct 5 11:03:13 2010
@@ -48,17 +48,43 @@
void set(Object value);
}
+ /**
+ * TODO: document.
+ *
+ * @param bean
+ * @param ctx a Context
+ */
public void endVisit(AutoBean<?> bean, Context ctx) {
}
+ /**
+ * TODO: document.
+ *
+ * @param propertyName
+ * @param value
+ * @param ctx a PropertyContext
+ */
public void endVisitReferenceProperty(String propertyName, AutoBean<?>
value,
PropertyContext ctx) {
}
+ /**
+ * TODO: document.
+ *
+ * @param propertyName
+ * @param value
+ * @param ctx a PropertyContext
+ */
public void endVisitValueProperty(String propertyName, Object value,
PropertyContext ctx) {
}
+ /**
+ * TODO: document.
+ *
+ * @param bean
+ * @param ctx a Context
+ */
public boolean visit(AutoBean<?> bean, Context ctx) {
return true;
}
@@ -66,12 +92,23 @@
/**
* Called every time, but {...@link #visit(AutoBean, Context)} will be
called for
* the value only the first time it is encountered.
+ *
+ * @param propertyName
+ * @param value
+ * @param ctx a PropertyContext
*/
public boolean visitReferenceProperty(String propertyName, AutoBean<?>
value,
PropertyContext ctx) {
return true;
}
+ /**
+ * TODO: document.
+ *
+ * @param propertyName
+ * @param value
+ * @param ctx a PropertyContext
+ */
public boolean visitValueProperty(String propertyName, Object value,
PropertyContext ctx) {
return true;
=======================================
--- /trunk/user/src/com/google/gwt/editor/client/EditorError.java Mon Sep
13 09:30:34 2010
+++ /trunk/user/src/com/google/gwt/editor/client/EditorError.java Tue Oct
5 11:03:13 2010
@@ -18,7 +18,7 @@
/**
* Allows invalid Editor state to be propagated through an Editor
hierarchy.
* Instances of EditorError are typically created as a side effect of
calling
- * {...@link EditorDelegate#recordError()}.
+ * {...@link EditorDelegate#recordError}.
*
* @see com.google.gwt.editor.client.testing.MockEditorError
*/
@@ -47,7 +47,7 @@
String getPath();
/**
- * Returns the object passed into {...@link EditorDelegate#recordError()}.
+ * Returns the object passed into {...@link EditorDelegate#recordError}.
*/
Object getUserData();
=======================================
--- /trunk/user/src/com/google/gwt/editor/client/impl/AbstractAutoBean.java
Fri Oct 1 18:15:55 2010
+++ /trunk/user/src/com/google/gwt/editor/client/impl/AbstractAutoBean.java
Tue Oct 5 11:03:13 2010
@@ -163,6 +163,10 @@
/**
* No-op. Used as a debugger hook point for generated code.
+ *
+ * @param method the method name
+ * @param returned the returned object
+ * @param parameters the parameter list
*/
protected void call(String method, Object returned, Object...
parameters) {
}
@@ -185,6 +189,9 @@
/**
* No-op. Used as a debugger hook point for generated code.
+ *
+ * @param method the method name
+ * @param toReturn the value to return
*/
protected <V> V get(String method, V toReturn) {
return toReturn;
@@ -205,6 +212,9 @@
/**
* No-op. Used as a debugger hook point for generated code.
+ *
+ * @param method the method name
+ * @param value the Object value to be set
*/
protected void set(String method, Object value) {
}
=======================================
---
/trunk/user/src/com/google/gwt/editor/client/testing/MockEditorChain.java
Thu Sep 9 11:46:06 2010
+++
/trunk/user/src/com/google/gwt/editor/client/testing/MockEditorChain.java
Tue Oct 5 11:03:13 2010
@@ -21,7 +21,9 @@
import java.util.Map;
/**
- * A Mock implementation of {...@link CompositeEditor.EditorChain}.
+ * A Mock implementation of
+ * {...@link com.google.gwt.editor.client.CompositeEditor.EditorChain
+ * CompositeEditor.EditorChain}.
*
* @param <C> the type being edited
*/
=======================================
---
/trunk/user/src/com/google/gwt/editor/client/ui/ValueBoxEditorDecorator.java
Wed Sep 15 02:26:39 2010
+++
/trunk/user/src/com/google/gwt/editor/client/ui/ValueBoxEditorDecorator.java
Tue Oct 5 11:03:13 2010
@@ -103,7 +103,7 @@
/**
* The default implementation will display, but not consume, received
errors
* whose {...@link EditorError#getEditor() getEditor()} method returns the
Editor
- * passed into {...@link #setEditor()}.
+ * passed into {...@link #setEditor}.
*/
public void showErrors(List<EditorError> errors) {
StringBuilder sb = new StringBuilder();
=======================================
--- /trunk/user/src/com/google/gwt/editor/rebind/model/EditorData.java Fri
Oct 1 18:15:55 2010
+++ /trunk/user/src/com/google/gwt/editor/rebind/model/EditorData.java Tue
Oct 5 11:03:13 2010
@@ -25,7 +25,6 @@
import com.google.gwt.editor.client.LeafValueEditor;
import com.google.gwt.editor.client.ValueAwareEditor;
-
/**
* Describes how an Editor is related to bean properties. This type
contains
* answers to questions asked by the generator code.
=======================================
--- /trunk/user/src/com/google/gwt/event/logical/shared/AttachEvent.java
Fri Oct 1 09:39:58 2010
+++ /trunk/user/src/com/google/gwt/event/logical/shared/AttachEvent.java
Tue Oct 5 11:03:13 2010
@@ -69,11 +69,10 @@
/**
* Construct a new {...@link AttachEvent}.
*
- * @param width the new width
- * @param height the new height
+ * @param attached true if the source has been attached
*/
- protected AttachEvent(boolean loaded) {
- this.attached = loaded;
+ protected AttachEvent(boolean attached) {
+ this.attached = attached;
}
@Override
=======================================
---
/trunk/user/src/com/google/gwt/event/shared/DefaultHandlerRegistration.java
Fri Sep 10 17:56:09 2010
+++
/trunk/user/src/com/google/gwt/event/shared/DefaultHandlerRegistration.java
Tue Oct 5 11:03:13 2010
@@ -25,7 +25,6 @@
@Deprecated
public class DefaultHandlerRegistration implements HandlerRegistration {
- @SuppressWarnings("deprecation")
private final HandlerManager manager;
private final EventHandler handler;
private final Type<?> type;
@@ -40,7 +39,7 @@
* @param handler the handler
*/
protected <H extends EventHandler> DefaultHandlerRegistration(
- @SuppressWarnings("deprecation") HandlerManager manager, Type<H>
type,
+ HandlerManager manager, Type<H> type,
H handler) {
this.manager = manager;
this.handler = handler;
@@ -50,7 +49,7 @@
/**
* Removes the given handler from its manager.
*/
- @SuppressWarnings({"unchecked", "deprecation"})
+ @SuppressWarnings({"unchecked"})
// This is safe because when the elements were passed in they conformed
to
// Type<H>,H.
public void removeHandler() {
=======================================
--- /trunk/user/src/com/google/gwt/event/shared/HandlerManager.java Mon Sep
13 16:10:55 2010
+++ /trunk/user/src/com/google/gwt/event/shared/HandlerManager.java Tue
Oct 5 11:03:13 2010
@@ -50,7 +50,6 @@
* @param source the event source
* @param fireInReverseOrder true to fire handlers in reverse order
*/
- @SuppressWarnings("deprecation")
public HandlerManager(Object source, boolean fireInReverseOrder) {
eventBus = new SimpleEventBus(fireInReverseOrder);
this.source = source;
@@ -115,7 +114,6 @@
* @param type the handler's event type
* @return the given handler
*/
- @SuppressWarnings("deprecation")
public <H extends EventHandler> H getHandler(GwtEvent.Type<H> type, int
index) {
return eventBus.getHandler(type, index);
}
@@ -126,7 +124,6 @@
* @param type the event type
* @return the number of registered handlers
*/
- @SuppressWarnings("deprecation")
public int getHandlerCount(Type<?> type) {
return eventBus.getHandlerCount(type);
}
@@ -137,7 +134,6 @@
* @param e the event type
* @return whether the given event type is handled
*/
- @SuppressWarnings("deprecation")
public boolean isEventHandled(Type<?> e) {
return eventBus.isEventHandled(e);
}
=======================================
--- /trunk/user/src/com/google/gwt/i18n/client/CurrencyList.java Fri Aug 27
07:09:23 2010
+++ /trunk/user/src/com/google/gwt/i18n/client/CurrencyList.java Tue Oct 5
11:03:13 2010
@@ -106,7 +106,7 @@
/**
* Map of currency codes to localized currency names. This is kept
separate
- * from {...@link #dataMap} above so that the names can be completely
removed by
+ * from {...@link #dataMapJava} above so that the names can be completely
removed by
* the compiler if they are not used.
*/
protected HashMap<String, String> namesMapJava;
=======================================
***Additional files exist in this changeset.***
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
