Author: amitman...@google.com
Date: Fri Feb 6 11:47:58 2009
New Revision: 4658
Modified:
releases/1.6/dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java
releases/1.6/user/build.xml
Log:
Update to the test target for emma hosted mode. Plus, added check to not
generate class mappings
if the unit is generated.
Patch by: amitmanjhi
Review by: jat (desk review)
Modified:
releases/1.6/dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java
==============================================================================
---
releases/1.6/dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java
(original)
+++
releases/1.6/dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java
Fri Feb 6 11:47:58 2009
@@ -386,10 +386,10 @@
/**
* Checks if the class names is generated. Accepts any classes whose
names
- * match .+$\d.* (handling named classes within anonymous classes and
- * multiple named classes of the same name in a class, but in different
- * methods). Checks if the class or any of its enclosing classes are
anonymous
- * or synthetic.
+ * match .+$\d.* (handling named classes within anonymous classes and
multiple
+ * named classes of the same name in a class, but in different methods).
+ * Checks if the class or any of its enclosing classes are anonymous or
+ * synthetic.
* <p>
* If new compilers have different conventions for anonymous and
synthetic
* classes, this code needs to be updated.
@@ -680,9 +680,9 @@
*/
List<JsniMethod> jsniMethods = (unit == null) ? null
: unit.getJsniMethods();
- if (unit != null && !unit.isSuperSource() &&
unit.hasAnonymousClasses()
- && jsniMethods != null && jsniMethods.size() > 0
- && !unit.createdClassMapping()) {
+ if (unit != null && !unit.isSuperSource() && !unit.isGenerated()
+ && unit.hasAnonymousClasses() && jsniMethods != null
+ && jsniMethods.size() > 0 && !unit.createdClassMapping()) {
if (!unit.constructAnonymousClassMappings(logger)) {
logger.log(TreeLogger.ERROR,
"Our heuristic for mapping anonymous classes between
compilers "
Modified: releases/1.6/user/build.xml
==============================================================================
--- releases/1.6/user/build.xml (original)
+++ releases/1.6/user/build.xml Fri Feb 6 11:47:58 2009
@@ -2,6 +2,7 @@
<property name="gwt.root" location=".." />
<property name="project.tail" value="user" />
<property name="test.args" value="" />
+ <property name="gwt.junit.emmatestcase.includes"
value="**/*Suite.class,com/google/gwt/dev/jjs/test/*Test.class"/>
<import file="${gwt.root}/common.ant.xml" />
<!--
@@ -14,7 +15,7 @@
includes="**/EmmaClassLoadingTest.class" />
<fileset id="default.hosted.emma.tests" dir="${javac.junit.out}"
- excludes="**/CoverageTest.class" includes="**/*Test.class" />
+ excludes="**/CoverageTest.class,**/CompilerSuite.class"
includes="${gwt.junit.emmatestcase.includes}" />
<!-- everything succeeds except CoverageTest.java. It fails due to a
javac bug in sun/OpenJDK's Java. See the file contents for details -->
<!--
--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---
