Reviewers: amitmanjhi, Description: A warning is printed when a really old plugin connects to the code server. This adds a HelpInfo link, which points at the UsingOOPHM web page for now, giving users information about getting a later plugin.
In the future, this will be changed to a better location. Please review this at http://gwt-code-reviews.appspot.com/78819 Affected files: dev/oophm/src/com/google/gwt/dev/shell/BrowserChannelServer.java Index: dev/oophm/src/com/google/gwt/dev/shell/BrowserChannelServer.java =================================================================== --- dev/oophm/src/com/google/gwt/dev/shell/BrowserChannelServer.java (revision 6372) +++ dev/oophm/src/com/google/gwt/dev/shell/BrowserChannelServer.java (working copy) @@ -16,12 +16,15 @@ package com.google.gwt.dev.shell; import com.google.gwt.core.ext.TreeLogger; +import com.google.gwt.core.ext.TreeLogger.HelpInfo; import com.google.gwt.dev.shell.JsValue.DispatchObject; import java.io.IOException; import java.io.InputStream; import java.io.OutputStream; +import java.net.MalformedURLException; import java.net.Socket; +import java.net.URL; import java.util.HashMap; import java.util.Map; import java.util.Set; @@ -233,8 +236,27 @@ moduleName = oldLoadModule.getModuleName(); userAgent = oldLoadModule.getUserAgent(); protocolVersion = 1; + HelpInfo helpInfo = new HelpInfo() { + @Override + public String getAnchorText() { + return "UsingOOPHM wiki page"; + } + + @Override + public URL getURL() { + try { + // TODO(jat): better landing page for more info + return new URL( + "http://code.google.com/p/google-web-toolkit/wiki/UsingOOPHM"); + } catch (MalformedURLException e) { + // can't happen + return null; + } + } + }; logger.log(TreeLogger.WARN, "Connection from old browser plugin -- " - + "please upgrade to a later version for full functionality"); + + "please upgrade to a later version for full functionality", null, + helpInfo); break; case CHECK_VERSIONS: String connectError = null; --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---