[gwt-contrib] Avoid an infinite loop in toString() for collections that directly include themselves (issue962801)

[rice]

Reviewers: jat,

Description:
Avoid an infinite loop in toString() for collections that directly
include themselves

Please review this at http://gwt-code-reviews.appspot.com/962801/show

Affected files:
  M user/super/com/google/gwt/emul/java/util/AbstractCollection.java


Index: user/super/com/google/gwt/emul/java/util/AbstractCollection.java
===================================================================
--- user/super/com/google/gwt/emul/java/util/AbstractCollection.java	 
(revision 8903)
+++ user/super/com/google/gwt/emul/java/util/AbstractCollection.java	 
(working copy)
@@ -142,7 +142,8 @@
       } else {
         comma = ", ";
       }
-      sb.append(String.valueOf(iter.next()));
+      E value = iter.next();
+      sb.append(value == this ? "(this Collection)" :  
String.valueOf(value));
     }
     sb.append("]");
     return sb.toString();


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors