[gwt-contrib] Change in gwt[master]: Added missing JUnit tests to JUnitSuite.

2013-04-30 Thread Roberto Lublinerman

Roberto Lublinerman has abandoned this change.

Change subject: Added missing JUnit tests to JUnitSuite.
..


Abandoned

Submitted, thanks!

--
To view, visit https://gwt-review.googlesource.com/2620
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I18b51bdfbe9141535a8e0f47306ea73791aec4b4
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Added missing JUnit tests to JUnitSuite.

2013-04-29 Thread Roberto Lublinerman

Roberto Lublinerman has uploaded a new change for review.

  https://gwt-review.googlesource.com/2620


Change subject: Added missing JUnit tests to JUnitSuite.
..

Added missing JUnit tests to JUnitSuite.

Change-Id: I18b51bdfbe9141535a8e0f47306ea73791aec4b4
---
M user/test/com/google/gwt/junit/JUnitSuite.java
1 file changed, 7 insertions(+), 1 deletion(-)



diff --git a/user/test/com/google/gwt/junit/JUnitSuite.java  
b/user/test/com/google/gwt/junit/JUnitSuite.java

index 8b556b7..05f9879 100644
--- a/user/test/com/google/gwt/junit/JUnitSuite.java
+++ b/user/test/com/google/gwt/junit/JUnitSuite.java
@@ -45,9 +45,14 @@
 suite.addTestSuite(BatchingStrategyTest.class);
 suite.addTestSuite(CompileStrategyTest.class);

+// TODO(rluble): Make Selenium tests work or deprecate. They are  
missing the Selenium

+// dependency.
+
+// suite.addTestSuite(RunStyleSeleniumTest.class);
+
+suite.addTestSuite(FakeCssMakerTest.class);
 suite.addTestSuite(FakeMessagesMakerTest.class);
 suite.addTestSuite(GWTMockUtilitiesTest.class);
-suite.addTestSuite(JUnitMessageQueueTest.class);
 suite.addTestSuite(GWTTestCaseNoClientTest.class);

 // Intended only to be run manually. See class comments
@@ -60,6 +65,7 @@
 suite.addTestSuite(PropertyDefiningStrategyTest.class);
 suite.addTestSuite(PropertyDefiningGWTTest.class);

+suite.addTestSuite(JUnitMessageQueueTest.class);
 suite.addTestSuite(JUnitShellTest.class);

 return suite;

--
To view, visit https://gwt-review.googlesource.com/2620
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I18b51bdfbe9141535a8e0f47306ea73791aec4b4
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman rlu...@google.com

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Added missing JUnit tests to JUnitSuite.

2013-04-29 Thread Matthew Dempsky

Matthew Dempsky has posted comments on this change.

Change subject: Added missing JUnit tests to JUnitSuite.
..


Patch Set 1: Verified+1

Hoorays, this change passed the build and style presubmit. :D  More details  
at http://gwt-ci.dempsky.org:8080/job/gwt.presubmit/41


--
To view, visit https://gwt-review.googlesource.com/2620
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18b51bdfbe9141535a8e0f47306ea73791aec4b4
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: No

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Added missing JUnit tests to JUnitSuite.

2013-04-29 Thread Goktug Gokdogan

Goktug Gokdogan has posted comments on this change.

Change subject: Added missing JUnit tests to JUnitSuite.
..


Patch Set 1: Code-Review+1

Thanks!

--
To view, visit https://gwt-review.googlesource.com/2620
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18b51bdfbe9141535a8e0f47306ea73791aec4b4
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: No

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.