[gwt-contrib] Change in gwt[master]: Adds part of Java 7 new language features.
Roberto Lublinerman has posted comments on this change. Change subject: Adds part of Java 7 new language features. .. Patch Set 10: (1 comment) Thanks. File dev/core/src/com/google/gwt/dev/javac/testing/GeneratorContextBuilder.java Line 109: OptionSource.DEFAULT_SOURCE_LEVEL); Isn't this only used for testing purposes? There is no obvious way to thread the flag. In any case we will be pushing the default to Java7 in a not too distant time in the future. -- To view, visit https://gwt-review.googlesource.com/2650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Gerrit-PatchSet: 10 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: John Stalcup Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Ray Cromwell Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds part of Java 7 new language features.
Ray Cromwell has posted comments on this change. Change subject: Adds part of Java 7 new language features. .. Patch Set 10: Code-Review+2 (1 comment) File dev/core/src/com/google/gwt/dev/javac/testing/GeneratorContextBuilder.java Line 109: OptionSource.DEFAULT_SOURCE_LEVEL); Why is generated code compiled a different source level? -- To view, visit https://gwt-review.googlesource.com/2650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Gerrit-PatchSet: 10 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: John Stalcup Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Ray Cromwell Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds part of Java 7 new language features.
Brian Slesinsky has posted comments on this change. Change subject: Adds part of Java 7 new language features. .. Patch Set 10: Code-Review+1 -- To view, visit https://gwt-review.googlesource.com/2650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Gerrit-PatchSet: 10 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: John Stalcup Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Ray Cromwell Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds part of Java 7 new language features.
Hello Matthew Dempsky, Matthew Dempsky, Leeroy Jenkins, Brian Slesinsky, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2650 to look at the new patch set (#10). Change subject: Adds part of Java 7 new language features. .. Adds part of Java 7 new language features. Adds the Java 7 new language features: namely, the diamond operator, new numerical literal formats, and switch/case on string literals. Adds a new flag -source to select source level compatibility (java 6 or java 7); -source defaults to java 6. Fixes issue 6633. Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Review-Link: https://gwt-review.googlesource.com/#/c/2650/ --- M dev/codeserver/java/com/google/gwt/dev/codeserver/CodeServer.java M dev/codeserver/java/com/google/gwt/dev/codeserver/CompilerOptionsImpl.java M dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java M dev/codeserver/java/com/google/gwt/dev/codeserver/Recompiler.java M dev/codeserver/java/com/google/gwt/dev/codeserver/UnmodifiableCompilerOptions.java M dev/core/src/com/google/gwt/dev/CompileModule.java M dev/core/src/com/google/gwt/dev/CompileTaskOptions.java M dev/core/src/com/google/gwt/dev/CompileTaskOptionsImpl.java M dev/core/src/com/google/gwt/dev/Compiler.java M dev/core/src/com/google/gwt/dev/DevMode.java M dev/core/src/com/google/gwt/dev/DevModeBase.java M dev/core/src/com/google/gwt/dev/Precompile.java M dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java M dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java M dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java M dev/core/src/com/google/gwt/dev/javac/testing/GeneratorContextBuilder.java A dev/core/src/com/google/gwt/dev/javac/testing/impl/Java7MockResources.java M dev/core/src/com/google/gwt/dev/javac/testing/impl/JavaResourceBase.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptions.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptionsImpl.java A dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerSource.java A dev/core/src/com/google/gwt/dev/util/arg/OptionSource.java A dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java M dev/core/test/com/google/gwt/dev/CompilerTest.java M dev/core/test/com/google/gwt/dev/javac/CompilationStateTestBase.java M dev/core/test/com/google/gwt/dev/javac/JavaCompilationSuite.java M dev/core/test/com/google/gwt/dev/javac/JdtBehaviorTest.java A dev/core/test/com/google/gwt/dev/javac/JdtJava7Test.java M dev/core/test/com/google/gwt/dev/jjs/impl/CodeSplitter2Test.java M dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java A dev/core/test/com/google/gwt/dev/jjs/impl/Java7AstTest.java M user/src/com/google/gwt/junit/JUnitShell.java A user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java7Test.java M user/test/com/google/gwt/dev/jjs/CompilerSuite.java A user/test/com/google/gwt/dev/jjs/Java7Test.gwt.xml A user/test/com/google/gwt/dev/jjs/test/Java7Test.java 36 files changed, 1,151 insertions(+), 430 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Gerrit-PatchSet: 10 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: John Stalcup Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Ray Cromwell Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Thomas Broyer -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds part of Java 7 new language features.
Roberto Lublinerman has posted comments on this change.
Change subject: Adds part of Java 7 new language features.
..
Patch Set 8:
(7 comments)
@Ray, can you have a look at this patch and its successor and if ok +2 them.
File
dev/core/src/com/google/gwt/dev/javac/testing/impl/Java7MockResources.java
Line 22: public static final MockJavaResource INTEGERLITERALS = new
MockJavaResource(
Done
Line 26: StringBuilder code = new StringBuilder();
I followed JavaResouceBase.java. But I agree, will fix here.
File dev/core/src/com/google/gwt/dev/util/arg/OptionSource.java
Line 26: enum SourceLevel {
Done
Line 27: _6("1.6", "6"),
Done
Line 39: * Returns a string value representation for the source level.
Added an explanation in the class doc. Done
File dev/core/test/com/google/gwt/dev/CompilerTest.java
Line 60: assertEquals(OptionSource.SourceLevel._7,
options.getSourceLevel());
Done. Made SourceLevel a top level enum.
File
user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java7Test.java
Line 27: * IMPORTANT: For each test here there must exists the
corresponding method in the non super sourced
Done
--
To view, visit https://gwt-review.googlesource.com/2650
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70
Gerrit-PatchSet: 8
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman
Gerrit-Reviewer: Brian Slesinsky
Gerrit-Reviewer: John Stalcup
Gerrit-Reviewer: Leeroy Jenkins
Gerrit-Reviewer: Matthew Dempsky
Gerrit-Reviewer: Matthew Dempsky
Gerrit-Reviewer: Ray Cromwell
Gerrit-Reviewer: Roberto Lublinerman
Gerrit-Reviewer: Roberto Lublinerman
Gerrit-Reviewer: Thomas Broyer
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds part of Java 7 new language features.
Hello Matthew Dempsky, Matthew Dempsky, Leeroy Jenkins, Brian Slesinsky, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2650 to look at the new patch set (#9). Change subject: Adds part of Java 7 new language features. .. Adds part of Java 7 new language features. Adds the Java 7 new language features: namely, the diamond operator, new numerical literal formats, and switch/case on string literals. Adds a new flag -source to select source level compatibility (java 6 or java 7); -source defaults to java 6. Fixes issue 6633. Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Review-Link: https://gwt-review.googlesource.com/#/c/2650/ --- M dev/codeserver/java/com/google/gwt/dev/codeserver/CodeServer.java M dev/codeserver/java/com/google/gwt/dev/codeserver/CompilerOptionsImpl.java M dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java M dev/codeserver/java/com/google/gwt/dev/codeserver/Recompiler.java M dev/codeserver/java/com/google/gwt/dev/codeserver/UnmodifiableCompilerOptions.java M dev/core/src/com/google/gwt/dev/CompileModule.java M dev/core/src/com/google/gwt/dev/CompileTaskOptions.java M dev/core/src/com/google/gwt/dev/CompileTaskOptionsImpl.java M dev/core/src/com/google/gwt/dev/Compiler.java M dev/core/src/com/google/gwt/dev/DevMode.java M dev/core/src/com/google/gwt/dev/DevModeBase.java M dev/core/src/com/google/gwt/dev/Precompile.java M dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java M dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java M dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java M dev/core/src/com/google/gwt/dev/javac/testing/GeneratorContextBuilder.java A dev/core/src/com/google/gwt/dev/javac/testing/impl/Java7MockResources.java M dev/core/src/com/google/gwt/dev/javac/testing/impl/JavaResourceBase.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptions.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptionsImpl.java A dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerSource.java A dev/core/src/com/google/gwt/dev/util/arg/OptionSource.java A dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java M dev/core/test/com/google/gwt/dev/CompilerTest.java M dev/core/test/com/google/gwt/dev/javac/CompilationStateTestBase.java M dev/core/test/com/google/gwt/dev/javac/JavaCompilationSuite.java M dev/core/test/com/google/gwt/dev/javac/JdtBehaviorTest.java A dev/core/test/com/google/gwt/dev/javac/JdtJava7Test.java M dev/core/test/com/google/gwt/dev/jjs/impl/CodeSplitter2Test.java M dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java A dev/core/test/com/google/gwt/dev/jjs/impl/Java7AstTest.java M user/src/com/google/gwt/junit/JUnitShell.java A user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java7Test.java M user/test/com/google/gwt/dev/jjs/CompilerSuite.java A user/test/com/google/gwt/dev/jjs/Java7Test.gwt.xml A user/test/com/google/gwt/dev/jjs/test/Java7Test.java 36 files changed, 1,150 insertions(+), 430 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Gerrit-PatchSet: 9 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: John Stalcup Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Ray Cromwell Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Thomas Broyer -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds part of Java 7 new language features.
Brian Slesinsky has posted comments on this change.
Change subject: Adds part of Java 7 new language features.
..
Patch Set 8: Code-Review+1
(7 comments)
Looks fine to me. I have a few nits, but they don't need to be fixed.
File
dev/core/src/com/google/gwt/dev/javac/testing/impl/Java7MockResources.java
Line 22: public static final MockJavaResource INTEGERLITERALS = new
MockJavaResource(
Nit: INTEGER_LITERALS to match the use of underscores elsewhere in this
file.
More nits: also, some of the constants match the class being created
(INTEGER_LITERALS matches IntegerLiterals) but others don't. Some classes
end with "Test" and others don't. It would be a bit cleaner to make them
match.
Line 26: StringBuilder code = new StringBuilder();
This sort of code could be made slightly more concise with a helper method:
/**
* Concatenate lines of text, adding a newline to the end of each string.
*/
static String concat(String... lines);
But it's fine as-is.
File dev/core/src/com/google/gwt/dev/util/arg/OptionSource.java
Line 26: enum SourceLevel {
Maybe SourceLevel should be a top-level enum? It would make imports shorter
by default.
Line 27: _6("1.6", "6"),
perhaps JAVA6 and JAVA7 instead of underscore?
Line 39: * Returns a string value representation for the source level.
The javadoc here seems to be boilerplate. Better to give an example of what
will be returned, and perhaps say when to use "1.6" and when to use "6"?
File dev/core/test/com/google/gwt/dev/CompilerTest.java
Line 60: assertEquals(OptionSource.SourceLevel._7,
options.getSourceLevel());
Perhaps import SourceLevel directly.
File
user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java7Test.java
Line 27: * IMPORTANT: For each test here there must exists the
corresponding method in the non super sourced
"must exist"
--
To view, visit https://gwt-review.googlesource.com/2650
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70
Gerrit-PatchSet: 8
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman
Gerrit-Reviewer: Brian Slesinsky
Gerrit-Reviewer: John Stalcup
Gerrit-Reviewer: Leeroy Jenkins
Gerrit-Reviewer: Matthew Dempsky
Gerrit-Reviewer: Matthew Dempsky
Gerrit-Reviewer: Ray Cromwell
Gerrit-Reviewer: Roberto Lublinerman
Gerrit-Reviewer: Roberto Lublinerman
Gerrit-Reviewer: Thomas Broyer
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds part of Java 7 new language features.
Matthew Dempsky has posted comments on this change. Change subject: Adds part of Java 7 new language features. .. Patch Set 8: I assume you're pinging for John and/or Ray? -- To view, visit https://gwt-review.googlesource.com/2650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Gerrit-PatchSet: 8 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: John Stalcup Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Ray Cromwell Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds part of Java 7 new language features.
Roberto Lublinerman has posted comments on this change. Change subject: Adds part of Java 7 new language features. .. Patch Set 8: Ping. -- To view, visit https://gwt-review.googlesource.com/2650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Gerrit-PatchSet: 8 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: John Stalcup Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Ray Cromwell Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds part of Java 7 new language features.
Hello Matthew Dempsky, Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2650 to look at the new patch set (#8). Change subject: Adds part of Java 7 new language features. .. Adds part of Java 7 new language features. Adds the Java 7 new language features: namely, the diamond operator, new numerical literal formats, and switch/case on string literals. Adds a new flag -source to select source level compatibility (java 6 or java 7); -source defaults to java 6. Fixes issue 6633. Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Review-Link: https://gwt-review.googlesource.com/#/c/2650/ --- M dev/codeserver/java/com/google/gwt/dev/codeserver/CodeServer.java M dev/codeserver/java/com/google/gwt/dev/codeserver/CompilerOptionsImpl.java M dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java M dev/codeserver/java/com/google/gwt/dev/codeserver/Recompiler.java M dev/codeserver/java/com/google/gwt/dev/codeserver/UnmodifiableCompilerOptions.java M dev/core/src/com/google/gwt/dev/CompileModule.java M dev/core/src/com/google/gwt/dev/CompileTaskOptions.java M dev/core/src/com/google/gwt/dev/CompileTaskOptionsImpl.java M dev/core/src/com/google/gwt/dev/Compiler.java M dev/core/src/com/google/gwt/dev/DevMode.java M dev/core/src/com/google/gwt/dev/DevModeBase.java M dev/core/src/com/google/gwt/dev/Precompile.java M dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java M dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java M dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java M dev/core/src/com/google/gwt/dev/javac/testing/GeneratorContextBuilder.java A dev/core/src/com/google/gwt/dev/javac/testing/impl/Java7MockResources.java M dev/core/src/com/google/gwt/dev/javac/testing/impl/JavaResourceBase.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptions.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptionsImpl.java A dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerSource.java A dev/core/src/com/google/gwt/dev/util/arg/OptionSource.java M dev/core/test/com/google/gwt/dev/CompilerTest.java M dev/core/test/com/google/gwt/dev/javac/CompilationStateTestBase.java M dev/core/test/com/google/gwt/dev/javac/JavaCompilationSuite.java M dev/core/test/com/google/gwt/dev/javac/JdtBehaviorTest.java A dev/core/test/com/google/gwt/dev/javac/JdtJava7Test.java M dev/core/test/com/google/gwt/dev/jjs/impl/CodeSplitter2Test.java M dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java A dev/core/test/com/google/gwt/dev/jjs/impl/Java7AstTest.java M user/src/com/google/gwt/junit/JUnitShell.java A user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java7Test.java M user/test/com/google/gwt/dev/jjs/CompilerSuite.java A user/test/com/google/gwt/dev/jjs/Java7Test.gwt.xml A user/test/com/google/gwt/dev/jjs/test/Java7Test.java 35 files changed, 1,002 insertions(+), 116 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Gerrit-PatchSet: 8 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: John Stalcup Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Ray Cromwell Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Thomas Broyer -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds part of Java 7 new language features.
Matthew Dempsky has posted comments on this change. Change subject: Adds part of Java 7 new language features. .. Patch Set 5: Verified+1 Hoorays, this change passed the build and style presubmit. :D More details at http://gwt-ci.dempsky.org:8080/job/gwt.presubmit/45 -- To view, visit https://gwt-review.googlesource.com/2650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: John Stalcup Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Ray Cromwell Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds part of Java 7 new language features.
Roberto Lublinerman has uploaded a new patch set (#5). Change subject: Adds part of Java 7 new language features. .. Adds part of Java 7 new language features. Adds the Java 7 new language features: namely, the diamond operator, new numerical literal formats, and switch/case on string literals. Adds a new flag -source to select source level compatibility (java 6 or java 7); -source defaults to java 6. Fixes issue 6633. Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Review-Link: https://gwt-review.googlesource.com/#/c/2650/ --- M dev/codeserver/java/com/google/gwt/dev/codeserver/CodeServer.java M dev/codeserver/java/com/google/gwt/dev/codeserver/CompilerOptionsImpl.java M dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java M dev/codeserver/java/com/google/gwt/dev/codeserver/Recompiler.java M dev/codeserver/java/com/google/gwt/dev/codeserver/UnmodifiableCompilerOptions.java M dev/core/src/com/google/gwt/dev/CompileModule.java M dev/core/src/com/google/gwt/dev/CompileTaskOptions.java M dev/core/src/com/google/gwt/dev/CompileTaskOptionsImpl.java M dev/core/src/com/google/gwt/dev/Compiler.java M dev/core/src/com/google/gwt/dev/DevMode.java M dev/core/src/com/google/gwt/dev/DevModeBase.java M dev/core/src/com/google/gwt/dev/Precompile.java M dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java M dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java M dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java M dev/core/src/com/google/gwt/dev/javac/testing/GeneratorContextBuilder.java M dev/core/src/com/google/gwt/dev/javac/testing/impl/JavaResourceBase.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptions.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptionsImpl.java A dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerSource.java A dev/core/src/com/google/gwt/dev/util/arg/OptionSource.java M dev/core/test/com/google/gwt/dev/CompilerTest.java M dev/core/test/com/google/gwt/dev/javac/CompilationStateTestBase.java M dev/core/test/com/google/gwt/dev/javac/JavaCompilationSuite.java M dev/core/test/com/google/gwt/dev/javac/JdtBehaviorTest.java A dev/core/test/com/google/gwt/dev/javac/JdtJava7Test.java M dev/core/test/com/google/gwt/dev/jjs/impl/CodeSplitter2Test.java M dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java A dev/core/test/com/google/gwt/dev/jjs/impl/Java7AstTest.java M user/src/com/google/gwt/junit/JUnitShell.java A user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java7Test.java M user/test/com/google/gwt/dev/jjs/CompilerSuite.java A user/test/com/google/gwt/dev/jjs/Java7Test.gwt.xml A user/test/com/google/gwt/dev/jjs/test/Java7Test.java 34 files changed, 944 insertions(+), 45 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: John Stalcup Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Ray Cromwell Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Thomas Broyer -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds part of Java 7 new language features.
Roberto Lublinerman has uploaded a new patch set (#4). Change subject: Adds part of Java 7 new language features. .. Adds part of Java 7 new language features. Adds the Java 7 new language features: namely, the diamond operator, new numerical literal formats, and switch/case on string literals. Adds a new flag -source to select source level compatibility (java 6 or java 7); -source defaults to java 6. Fixes issue 6633. Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Review-Link: https://gwt-review.googlesource.com/#/c/2650/ --- M dev/codeserver/java/com/google/gwt/dev/codeserver/CodeServer.java M dev/codeserver/java/com/google/gwt/dev/codeserver/CompilerOptionsImpl.java M dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java M dev/codeserver/java/com/google/gwt/dev/codeserver/Recompiler.java M dev/codeserver/java/com/google/gwt/dev/codeserver/UnmodifiableCompilerOptions.java M dev/core/src/com/google/gwt/dev/CompileModule.java M dev/core/src/com/google/gwt/dev/CompileTaskOptions.java M dev/core/src/com/google/gwt/dev/CompileTaskOptionsImpl.java M dev/core/src/com/google/gwt/dev/Compiler.java M dev/core/src/com/google/gwt/dev/DevMode.java M dev/core/src/com/google/gwt/dev/DevModeBase.java M dev/core/src/com/google/gwt/dev/Precompile.java M dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java M dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java M dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java M dev/core/src/com/google/gwt/dev/javac/testing/GeneratorContextBuilder.java M dev/core/src/com/google/gwt/dev/javac/testing/impl/JavaResourceBase.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptions.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptionsImpl.java A dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerSource.java A dev/core/src/com/google/gwt/dev/util/arg/OptionSource.java M dev/core/test/com/google/gwt/dev/CompilerTest.java M dev/core/test/com/google/gwt/dev/javac/CompilationStateTestBase.java M dev/core/test/com/google/gwt/dev/javac/JavaCompilationSuite.java M dev/core/test/com/google/gwt/dev/javac/JdtBehaviorTest.java A dev/core/test/com/google/gwt/dev/javac/JdtJava7Test.java M dev/core/test/com/google/gwt/dev/jjs/impl/CodeSplitter2Test.java M dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java A dev/core/test/com/google/gwt/dev/jjs/impl/Java7AstTest.java M user/src/com/google/gwt/junit/JUnitShell.java A user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java7Test.java M user/test/com/google/gwt/dev/jjs/CompilerSuite.java A user/test/com/google/gwt/dev/jjs/Java7Test.gwt.xml A user/test/com/google/gwt/dev/jjs/test/Java7Test.java 34 files changed, 944 insertions(+), 45 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: John Stalcup Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Ray Cromwell Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Thomas Broyer -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
