[gwt-contrib] Change in gwt[master]: FileUpload failed to initialize internal state

2013-05-29 Thread Daniel Kurka 

Daniel Kurka has submitted this change and it was merged.

Change subject: FileUpload failed to initialize internal state
..


FileUpload failed to initialize internal state

fixes issue 5055

Change-Id: I74ccb2617bb301aeaf0845e5c43f724d6247b3ca
Review-Link: https://gwt-review.googlesource.com/#/c/2981/
---
M user/src/com/google/gwt/user/client/ui/FileUpload.java
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Leeroy Jenkins: Verified
  Thomas Broyer: Looks good to me, approved



diff --git a/user/src/com/google/gwt/user/client/ui/FileUpload.java  
b/user/src/com/google/gwt/user/client/ui/FileUpload.java

index dd14e84..48f2292 100644
--- a/user/src/com/google/gwt/user/client/ui/FileUpload.java
+++ b/user/src/com/google/gwt/user/client/ui/FileUpload.java
@@ -130,10 +130,8 @@
* Constructs a new file upload widget.
*/
   public FileUpload() {
-setElement(Document.get().createFileInputElement());
+this(Document.get().createFileInputElement());
 setStyleName("gwt-FileUpload");
-impl = GWT.create(FileUploadImpl.class);
-impl.init(this);
   }

   /**
@@ -146,6 +144,8 @@
   protected FileUpload(Element element) {
 assert InputElement.as(element).getType().equalsIgnoreCase("file");
 setElement(element);
+impl = GWT.create(FileUploadImpl.class);
+impl.init(this);
   }

   public HandlerRegistration addChangeHandler(ChangeHandler handler) {

--
To view, visit https://gwt-review.googlesource.com/2981
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I74ccb2617bb301aeaf0845e5c43f724d6247b3ca
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: FileUpload failed to initialize internal state

2013-05-29 Thread Thomas Broyer 

Thomas Broyer has posted comments on this change.

Change subject: FileUpload failed to initialize internal state
..


Patch Set 3: Code-Review+2

--
To view, visit https://gwt-review.googlesource.com/2981
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74ccb2617bb301aeaf0845e5c43f724d6247b3ca
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: FileUpload failed to initialize internal state

2013-05-29 Thread Thomas Broyer 

Hello John A. Tamplin, Leeroy Jenkins,

I'd like you to reexamine a rebased change.  Please visit

https://gwt-review.googlesource.com/2981

to look at the new rebased patch set (#3).

Change subject: FileUpload failed to initialize internal state
..

FileUpload failed to initialize internal state

fixes issue 5055

Change-Id: I74ccb2617bb301aeaf0845e5c43f724d6247b3ca
Review-Link: https://gwt-review.googlesource.com/#/c/2981/
---
M user/src/com/google/gwt/user/client/ui/FileUpload.java
1 file changed, 3 insertions(+), 3 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/2981
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I74ccb2617bb301aeaf0845e5c43f724d6247b3ca
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: FileUpload failed to initialize internal state

2013-05-27 Thread Thomas Broyer 

Thomas Broyer has posted comments on this change.

Change subject: FileUpload failed to initialize internal state
..


Patch Set 2: Code-Review+2

--
To view, visit https://gwt-review.googlesource.com/2981
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74ccb2617bb301aeaf0845e5c43f724d6247b3ca
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: FileUpload failed to initialize internal state

2013-05-27 Thread Daniel Kurka 

Hello John A. Tamplin, Thomas Broyer,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/2981

to look at the new patch set (#2).

Change subject: FileUpload failed to initialize internal state
..

FileUpload failed to initialize internal state

fixes issue 5055

Change-Id: I74ccb2617bb301aeaf0845e5c43f724d6247b3ca
Review-Link: https://gwt-review.googlesource.com/#/c/2981/
---
M user/src/com/google/gwt/user/client/ui/FileUpload.java
1 file changed, 3 insertions(+), 3 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/2981
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I74ccb2617bb301aeaf0845e5c43f724d6247b3ca
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: FileUpload failed to initialize internal state

2013-05-27 Thread Thomas Broyer 

Thomas Broyer has posted comments on this change.

Change subject: FileUpload failed to initialize internal state
..


Patch Set 1: Code-Review-1

(1 comment)


File user/src/com/google/gwt/user/client/ui/FileUpload.java
Line 146: setStyleName("gwt-FileUpload");
FormUpload.wrap shouldn't change the styles (even less overwrite it): move  
that line back to the other ctor.



--
To view, visit https://gwt-review.googlesource.com/2981
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74ccb2617bb301aeaf0845e5c43f724d6247b3ca
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: FileUpload failed to initialize internal state

2013-05-27 Thread Daniel Kurka 

Daniel Kurka has uploaded a new change for review.

  https://gwt-review.googlesource.com/2981


Change subject: FileUpload failed to initialize internal state
..

FileUpload failed to initialize internal state

fixes issue 5055

Change-Id: I74ccb2617bb301aeaf0845e5c43f724d6247b3ca
---
M user/src/com/google/gwt/user/client/ui/FileUpload.java
1 file changed, 4 insertions(+), 4 deletions(-)



diff --git a/user/src/com/google/gwt/user/client/ui/FileUpload.java  
b/user/src/com/google/gwt/user/client/ui/FileUpload.java

index dd14e84..978f299 100644
--- a/user/src/com/google/gwt/user/client/ui/FileUpload.java
+++ b/user/src/com/google/gwt/user/client/ui/FileUpload.java
@@ -130,10 +130,7 @@
* Constructs a new file upload widget.
*/
   public FileUpload() {
-setElement(Document.get().createFileInputElement());
-setStyleName("gwt-FileUpload");
-impl = GWT.create(FileUploadImpl.class);
-impl.init(this);
+this(Document.get().createFileInputElement());
   }

   /**
@@ -146,6 +143,9 @@
   protected FileUpload(Element element) {
 assert InputElement.as(element).getType().equalsIgnoreCase("file");
 setElement(element);
+setStyleName("gwt-FileUpload");
+impl = GWT.create(FileUploadImpl.class);
+impl.init(this);
   }

   public HandlerRegistration addChangeHandler(ChangeHandler handler) {

--
To view, visit https://gwt-review.googlesource.com/2981
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I74ccb2617bb301aeaf0845e5c43f724d6247b3ca
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: FileUpload failed to initialize internal state

2013-05-27 Thread John A. Tamplin 

John A. Tamplin has posted comments on this change.

Change subject: FileUpload failed to initialize internal state
..


Patch Set 1: Code-Review+2

--
To view, visit https://gwt-review.googlesource.com/2981
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74ccb2617bb301aeaf0845e5c43f724d6247b3ca
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.