[gwt-contrib] Change in gwt[master]: Fix ValuePicker.setValue(T) to no longer fire events.
Thomas Broyer has submitted this change and it was merged.
Change subject: Fix ValuePicker.setValue(T) to no longer fire events.
..
Fix ValuePicker.setValue(T) to no longer fire events.
Bug: issue 7330
Change-Id: I20042df6fa0770e4505b1acae8dc28aa77ab7e3a
---
M user/src/com/google/gwt/user/client/ui/ValuePicker.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Leeroy Jenkins: Verified
Jens Nehlmeier: Looks good to me, but someone else must approve
Goktug Gokdogan: Looks good to me, approved
diff --git a/user/src/com/google/gwt/user/client/ui/ValuePicker.java
b/user/src/com/google/gwt/user/client/ui/ValuePicker.java
index 45ced21..5914791 100644
--- a/user/src/com/google/gwt/user/client/ui/ValuePicker.java
+++ b/user/src/com/google/gwt/user/client/ui/ValuePicker.java
@@ -64,7 +64,7 @@
cellList.setSelectionModel(smodel);
smodel.addSelectionChangeHandler(new SelectionChangeEvent.Handler() {
public void onSelectionChange(SelectionChangeEvent event) {
-setValue(smodel.getSelectedObject());
+setValue(smodel.getSelectedObject(), true);
}
});
}
@@ -112,7 +112,7 @@
}
public void setValue(T value) {
-setValue(value, true);
+setValue(value, false);
}
public void setValue(T value, boolean fireEvents) {
--
To view, visit https://gwt-review.googlesource.com/2980
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I20042df6fa0770e4505b1acae8dc28aa77ab7e3a
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Thomas Broyer t.bro...@gmail.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Jens Nehlmeier jens.nehlme...@gmail.com
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fix ValuePicker.setValue(T) to no longer fire events.
Goktug Gokdogan has posted comments on this change. Change subject: Fix ValuePicker.setValue(T) to no longer fire events. .. Patch Set 2: Code-Review+2 Unfortunately, this is a breaking change. Marked the issue accordingly. -- To view, visit https://gwt-review.googlesource.com/2980 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20042df6fa0770e4505b1acae8dc28aa77ab7e3a Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Jens Nehlmeier jens.nehlme...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fix ValuePicker.setValue(T) to no longer fire events.
Thomas Broyer has uploaded a new change for review.
https://gwt-review.googlesource.com/2980
Change subject: Fix ValuePicker.setValue(T) to no longer fire events.
..
Fix ValuePicker.setValue(T) to no longer fire events.
Change-Id: I20042df6fa0770e4505b1acae8dc28aa77ab7e3a
---
M user/src/com/google/gwt/user/client/ui/ValuePicker.java
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/user/src/com/google/gwt/user/client/ui/ValuePicker.java
b/user/src/com/google/gwt/user/client/ui/ValuePicker.java
index 45ced21..5914791 100644
--- a/user/src/com/google/gwt/user/client/ui/ValuePicker.java
+++ b/user/src/com/google/gwt/user/client/ui/ValuePicker.java
@@ -64,7 +64,7 @@
cellList.setSelectionModel(smodel);
smodel.addSelectionChangeHandler(new SelectionChangeEvent.Handler() {
public void onSelectionChange(SelectionChangeEvent event) {
-setValue(smodel.getSelectedObject());
+setValue(smodel.getSelectedObject(), true);
}
});
}
@@ -112,7 +112,7 @@
}
public void setValue(T value) {
-setValue(value, true);
+setValue(value, false);
}
public void setValue(T value, boolean fireEvents) {
--
To view, visit https://gwt-review.googlesource.com/2980
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I20042df6fa0770e4505b1acae8dc28aa77ab7e3a
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Thomas Broyer t.bro...@gmail.com
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fix ValuePicker.setValue(T) to no longer fire events.
Thomas Broyer has uploaded a new patch set (#2). Change subject: Fix ValuePicker.setValue(T) to no longer fire events. .. Fix ValuePicker.setValue(T) to no longer fire events. Bug: issue 7330 Change-Id: I20042df6fa0770e4505b1acae8dc28aa77ab7e3a --- M user/src/com/google/gwt/user/client/ui/ValuePicker.java 1 file changed, 2 insertions(+), 2 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2980 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I20042df6fa0770e4505b1acae8dc28aa77ab7e3a Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fix ValuePicker.setValue(T) to no longer fire events.
Jens Nehlmeier has posted comments on this change. Change subject: Fix ValuePicker.setValue(T) to no longer fire events. .. Patch Set 2: Code-Review+1 Looks good. The only minor nip-pick would be that calling setValue() with true inside the SingleSelectionModel handler probably doesn't do anything as it seems like that the SingleSelectionModel selection and the ValuePicker's value are always in sync = setValue() would always return early. But technically, calling setValue() with true from the the SingleSelectionModel handler isn't wrong. -- To view, visit https://gwt-review.googlesource.com/2980 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20042df6fa0770e4505b1acae8dc28aa77ab7e3a Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Jens Nehlmeier jens.nehlme...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fix ValuePicker.setValue(T) to no longer fire events.
Thomas Broyer has posted comments on this change. Change subject: Fix ValuePicker.setValue(T) to no longer fire events. .. Patch Set 2: AFAICT, no, they won't be in sync, as it's the purpose of the SelectionChangeHandler to update the current value (this.value) with the one being selected (using the mouse or keyboard) in the CellList. This is specifically where we want to fire a ValueChangeEvent. -- To view, visit https://gwt-review.googlesource.com/2980 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20042df6fa0770e4505b1acae8dc28aa77ab7e3a Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Jens Nehlmeier jens.nehlme...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fix ValuePicker.setValue(T) to no longer fire events.
Jens Nehlmeier has posted comments on this change. Change subject: Fix ValuePicker.setValue(T) to no longer fire events. .. Patch Set 2: Oh right, makes totally sense. -- To view, visit https://gwt-review.googlesource.com/2980 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20042df6fa0770e4505b1acae8dc28aa77ab7e3a Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Jens Nehlmeier jens.nehlme...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
