[gwt-contrib] Change in gwt[master]: Fixes internal compiler error caused by a null logger parsin...
Roberto Lublinerman has abandoned this change. Change subject: Fixes internal compiler error caused by a null logger parsing jsni code that was generated by a generator at test time. .. Abandoned Submitted, thanks! -- To view, visit https://gwt-review.googlesource.com/1830 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I034918d940c3318bc82ed9cb615c6f64b89fb027 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: Ray Cromwell Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Thomas Broyer -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fixes internal compiler error caused by a null logger parsin...
Goktug Gokdogan has posted comments on this change. Change subject: Fixes internal compiler error caused by a null logger parsing jsni code that was generated by a generator at test time. .. Patch Set 2: It looks like this part of the flow is not covered at all with unit tests. Is it possible to add some test cases so that we will know if it gets broken again? -- To view, visit https://gwt-review.googlesource.com/1830 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I034918d940c3318bc82ed9cb615c6f64b89fb027 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: Ray Cromwell Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fixes internal compiler error caused by a null logger parsin...
Ray Cromwell has posted comments on this change. Change subject: Fixes internal compiler error caused by a null logger parsing jsni code that was generated by a generator at test time. .. Patch Set 2: Code-Review+1 -- To view, visit https://gwt-review.googlesource.com/1830 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I034918d940c3318bc82ed9cb615c6f64b89fb027 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: Ray Cromwell Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fixes internal compiler error caused by a null logger parsin...
Brian Slesinsky has posted comments on this change. Change subject: Fixes internal compiler error caused by a null logger parsing jsni code that was generated by a generator at test time. .. Patch Set 2: Code-Review+1 -- To view, visit https://gwt-review.googlesource.com/1830 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I034918d940c3318bc82ed9cb615c6f64b89fb027 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fixes internal compiler error caused by a null logger parsin...
Roberto Lublinerman has posted comments on this change. Change subject: Fixes internal compiler error caused by a null logger parsing jsni code that was generated by a generator at test time. .. Patch Set 1: (1 comment) File dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java Line 528: public void addRootTypes(TreeLogger logger, Collection sourceTypeNames) Done -- To view, visit https://gwt-review.googlesource.com/1830 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I034918d940c3318bc82ed9cb615c6f64b89fb027 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fixes internal compiler error caused by a null logger parsin...
Roberto Lublinerman has uploaded a new patch set (#2). Change subject: Fixes internal compiler error caused by a null logger parsing jsni code that was generated by a generator at test time. .. Fixes internal compiler error caused by a null logger parsing jsni code that was generated by a generator at test time. Change-Id: I034918d940c3318bc82ed9cb615c6f64b89fb027 Review-Link: https://gwt-review.googlesource.com/#/c/1830/ --- M dev/core/src/com/google/gwt/dev/jjs/AstConstructor.java M dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java M dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java 3 files changed, 9 insertions(+), 11 deletions(-) -- To view, visit https://gwt-review.googlesource.com/1830 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I034918d940c3318bc82ed9cb615c6f64b89fb027 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: Thomas Broyer -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fixes internal compiler error caused by a null logger parsin...
Brian Slesinsky has posted comments on this change. Change subject: Fixes internal compiler error caused by a null logger parsing jsni code that was generated by a generator at test time. .. Patch Set 1: (1 comment) File dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java Line 528: public void addRootTypes(TreeLogger logger, Collection sourceTypeNames) It seems like it would be cleaner to pass the logger to the constructor and make it a final field. (It is only constructed in two places and it will be the same logger.) -- To view, visit https://gwt-review.googlesource.com/1830 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I034918d940c3318bc82ed9cb615c6f64b89fb027 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fixes internal compiler error caused by a null logger parsin...
Roberto Lublinerman has uploaded a new change for review.
https://gwt-review.googlesource.com/1830
Change subject: Fixes internal compiler error caused by a null logger
parsing jsni code that was generated by a generator at test time.
..
Fixes internal compiler error caused by a null logger parsing jsni code
that was generated by a generator at test time.
Change-Id: I034918d940c3318bc82ed9cb615c6f64b89fb027
---
M dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
M dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git
a/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
b/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
index 042e145..36102d2 100644
--- a/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
+++ b/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
@@ -618,7 +618,7 @@
try {
// (2) Assemble the Java AST.
UnifyAst unifyAst = new UnifyAst(jprogram, jsProgram, options, rpo);
- unifyAst.addRootTypes(allRootTypes);
+ unifyAst.addRootTypes(logger, allRootTypes);
// TODO: move this into UnifyAst?
findEntryPoints(logger, rpo, declEntryPts, jprogram);
unifyAst.exec(logger);
diff --git a/dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java
b/dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java
index a7aa3a9..ed7e38a 100644
--- a/dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java
+++ b/dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java
@@ -525,7 +525,9 @@
this.classFileMapBySource =
rpo.getCompilationState().getClassFileMapBySource();
}
- public void addRootTypes(Collection sourceTypeNames) throws
UnableToCompleteException {
+ public void addRootTypes(TreeLogger logger, Collection
sourceTypeNames)
+ throws UnableToCompleteException {
+this.logger = logger;
for (String sourceTypeName : sourceTypeNames) {
searchForTypeBySource(sourceTypeName);
}
--
To view, visit https://gwt-review.googlesource.com/1830
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I034918d940c3318bc82ed9cb615c6f64b89fb027
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
