[gwt-contrib] Change in gwt[master]: Issue 7713 - Float/Double parsing of NaN/Infinity
Matthew Dempsky has abandoned this change. Change subject: Issue 7713 - Float/Double parsing of NaN/Infinity .. Abandoned Submitted, thanks! -- To view, visit https://gwt-review.googlesource.com/1670 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ibc14d48df05e2029d4bcc780c77883f07b7f07f4 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John A. Tamplin Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Daniel Kurka Gerrit-Reviewer: John A. Tamplin Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Thomas Broyer -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: Issue 7713 - Float/Double parsing of NaN/Infinity
Thomas Broyer has posted comments on this change. Change subject: Issue 7713 - Float/Double parsing of NaN/Infinity .. Patch Set 3: (1 comment) File user/super/com/google/gwt/emul/java/lang/Number.java Line 348 Most likely an oversight. https://code.google.com/p/google-web-toolkit/source/detail?r=7344 changes an 'e' to [eE] and the commit message talks about now accepting both 'e' and 'E' for the exponent, but that was already the case with /i, which was retained. I guess rice and fabbott just didn't see the flag back then (as well as everyone who later updated the regexp, including me) -- To view, visit https://gwt-review.googlesource.com/1670 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc14d48df05e2029d4bcc780c77883f07b7f07f4 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John A. Tamplin Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: John A. Tamplin Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: Issue 7713 - Float/Double parsing of NaN/Infinity
Matthew Dempsky has posted comments on this change. Change subject: Issue 7713 - Float/Double parsing of NaN/Infinity .. Patch Set 3: (1 comment) File user/super/com/google/gwt/emul/java/lang/Number.java Line 348 More precisely, I understand why it needs to be case-sensitive now, but the old regex looks like it was already explicitly case-insensitive by using [eE] and [dDfF]. Just wondering if there was some reason for still using /i then. -- To view, visit https://gwt-review.googlesource.com/1670 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc14d48df05e2029d4bcc780c77883f07b7f07f4 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John A. Tamplin Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: Issue 7713 - Float/Double parsing of NaN/Infinity
Matthew Dempsky has posted comments on this change. Change subject: Issue 7713 - Float/Double parsing of NaN/Infinity .. Patch Set 3: Code-Review+1 (1 comment) File user/super/com/google/gwt/emul/java/lang/Number.java Line 348 Any idea why this used to be case-insensitive? -- To view, visit https://gwt-review.googlesource.com/1670 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc14d48df05e2029d4bcc780c77883f07b7f07f4 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John A. Tamplin Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
