[gwt-contrib] Change in gwt[master]: Redoing existing svn patch https://codereview.appspot.com/61...
James Horsley has uploaded a new change for review. https://gwt-review.googlesource.com/3210 Change subject: Redoing existing svn patch https://codereview.appspot.com/6132056/ on new git repo to work with gerrit. .. Redoing existing svn patch https://codereview.appspot.com/6132056/ on new git repo to work with gerrit. This patch adds Map support to RequestFactory (see https://code.google.com/p/google-web-toolkit/issues/detail?id=5524) There's a lot of existing discussion on the patch at https://codereview.appspot.com/6132056/. From looking back over that discussion the main user facing design decision to call out which isn't just what someone might expect from Map support is that referencing child complex types in keys and values is done using .with(someMap.keys.property, someMap.values.property ) Change-Id: I89d87d39e38b8f1df045494cbe655a44849a650b --- M user/src/com/google/web/bindery/requestfactory/apt/ClientToDomainMapper.java M user/src/com/google/web/bindery/requestfactory/apt/TransportableTypeVisitor.java M user/src/com/google/web/bindery/requestfactory/server/Resolver.java A user/src/com/google/web/bindery/requestfactory/server/Resolver.java.orig M user/src/com/google/web/bindery/requestfactory/server/ResolverServiceLayer.java A user/src/com/google/web/bindery/requestfactory/server/ResolverServiceLayer.java.orig M user/src/com/google/web/bindery/requestfactory/server/SimpleRequestProcessor.java A user/src/com/google/web/bindery/requestfactory/server/SimpleRequestProcessor.java.orig M user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java A user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java.orig A user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java.rej M user/src/com/google/web/bindery/requestfactory/shared/impl/EntityCodex.java M user/src/com/google/web/bindery/requestfactory/shared/impl/ProxySerializerImpl.java M user/test/com/google/web/bindery/requestfactory/gwt/client/FindServiceTest.java M user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java A user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java.orig A user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java.rej A user/test/com/google/web/bindery/requestfactory/server/MapKey.java A user/test/com/google/web/bindery/requestfactory/server/MapValue.java M user/test/com/google/web/bindery/requestfactory/server/SimpleFoo.java A user/test/com/google/web/bindery/requestfactory/server/SimpleFoo.java.orig M user/test/com/google/web/bindery/requestfactory/shared/BaseFooProxy.java A user/test/com/google/web/bindery/requestfactory/shared/MapKeyProxy.java A user/test/com/google/web/bindery/requestfactory/shared/MapKeyRequest.java A user/test/com/google/web/bindery/requestfactory/shared/MapValueProxy.java A user/test/com/google/web/bindery/requestfactory/shared/MapValueRequest.java M user/test/com/google/web/bindery/requestfactory/shared/SimpleBarProxy.java M user/test/com/google/web/bindery/requestfactory/shared/SimpleRequestFactory.java 28 files changed, 7,973 insertions(+), 46 deletions(-) -- To view, visit https://gwt-review.googlesource.com/3210 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I89d87d39e38b8f1df045494cbe655a44849a650b Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: James Horsley james.hors...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Redoing existing svn patch https://codereview.appspot.com/61...
Manuel Carrasco Moñino has posted comments on this change. Change subject: Redoing existing svn patch https://codereview.appspot.com/6132056/ on new git repo to work with gerrit. .. Patch Set 1: James could you submit a new patch set without files *.rej and *.orig -- To view, visit https://gwt-review.googlesource.com/3210 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89d87d39e38b8f1df045494cbe655a44849a650b Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: James Horsley james.hors...@gmail.com Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Redoing existing svn patch https://codereview.appspot.com/61...
James Horsley has posted comments on this change. Change subject: Redoing existing svn patch https://codereview.appspot.com/6132056/ on new git repo to work with gerrit. .. Patch Set 1: Ick sorry. Will submit a new patch. Should just discard this one or update it? -- To view, visit https://gwt-review.googlesource.com/3210 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89d87d39e38b8f1df045494cbe655a44849a650b Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: James Horsley james.hors...@gmail.com Gerrit-Reviewer: James Horsley james.hors...@gmail.com Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Redoing existing svn patch https://codereview.appspot.com/61...
James Horsley has abandoned this change. Change subject: Redoing existing svn patch https://codereview.appspot.com/6132056/ on new git repo to work with gerrit. .. Abandoned Contains unintended .orig and .rej files. Resubmitted with https://gwt-review.googlesource.com/#/c/3186/ -- To view, visit https://gwt-review.googlesource.com/3210 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I89d87d39e38b8f1df045494cbe655a44849a650b Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: James Horsley james.hors...@gmail.com Gerrit-Reviewer: James Horsley james.hors...@gmail.com Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Redoing existing svn patch https://codereview.appspot.com/61...
Manuel Carrasco Moñino has posted comments on this change. Change subject: Redoing existing svn patch https://codereview.appspot.com/6132056/ on new git repo to work with gerrit. .. Patch Set 1: Actually you could have submitted a new patch set to this issue instead of abandoning it and opening a new one. git commit --amend -a git push origin HEAD:refs/for/master But it's ok a new one as well. -- To view, visit https://gwt-review.googlesource.com/3210 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89d87d39e38b8f1df045494cbe655a44849a650b Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: James Horsley james.hors...@gmail.com Gerrit-Reviewer: James Horsley james.hors...@gmail.com Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Redoing existing svn patch https://codereview.appspot.com/61...
James Horsley has posted comments on this change. Change subject: Redoing existing svn patch https://codereview.appspot.com/6132056/ on new git repo to work with gerrit. .. Patch Set 1: Will remember for next time. Thanks! -- To view, visit https://gwt-review.googlesource.com/3210 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89d87d39e38b8f1df045494cbe655a44849a650b Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: James Horsley james.hors...@gmail.com Gerrit-Reviewer: James Horsley james.hors...@gmail.com Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
