[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.
Thomas Broyer has submitted this change and it was merged.
Change subject: Removes api-checker reference JARs from the source tree.
..
Removes api-checker reference JARs from the source tree.
Now expects them in GWT_TOOLS.
Bug: issue 8031
Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879
---
M build.xml
D tools/api-checker/reference/README
D tools/api-checker/reference/createApiCheckerReferenceJars.sh
D tools/api-checker/reference/gwt-dev-modified.jar
D tools/api-checker/reference/gwt-user-modified.jar
5 files changed, 3 insertions(+), 46 deletions(-)
Approvals:
Matthew Dempsky: Looks good to me, approved
Leeroy Jenkins: Verified
diff --git a/build.xml b/build.xml
index c783631..0726332 100755
--- a/build.xml
+++ b/build.xml
@@ -32,6 +32,8 @@
property name=gwt.apicheck.config
location=tools/api-checker/config/gwt25_26userApi.conf/
+ property name=gwt.apicheck.referencelibs
+
value=${gwt.tools}/api-checker-reference/2.5.1/gwt-dev-modified.jar:${gwt.tools}/api-checker-reference/2.5.1/gwt-user-modified.jar/
target name=buildonly
description=[action] Minimal one-platform devel build, without
distro packaging
@@ -206,7 +208,7 @@
pathelement location=${gwt.tools.lib}/apache/ant-1.6.5.jar /
/classpath
arg value=-refJar/
- arg
path=${gwt.root}/tools/api-checker/reference/gwt-dev-modified.jar:${gwt.root}/tools/api-checker/reference/gwt-user-modified.jar/
+ arg path=${gwt.apicheck.referencelibs}/
arg value=-configFile/
arg file=${gwt.apicheck.config}/
arg value=-logLevel/
diff --git a/tools/api-checker/reference/README
b/tools/api-checker/reference/README
deleted file mode 100644
index ebf6477..000
--- a/tools/api-checker/reference/README
+++ /dev/null
@@ -1,10 +0,0 @@
-gwt-dev.jar and gwt-user.jar were extracted from
http://google-web-toolkit.googlecode.com/files/gwt-2.5.1-rc1.zip
-
-Steps:
-1. Unzip the GWT zip file
-2. Copy gwt-dev.jar and gwt-user.jar into this directory
-3. Delete gwt-dev-modified.jar and gwt-user-modified.jar from this
directory
-4. run ./createApiCheckerReferenceJars.sh
- - Ignore the benign error about finding com/google/web. The directory
only exists in gwt-user.
-5. Delete gwt-dev.jar and gwt-user.jar from this directory
-6. Commit the new gwt-dev-modified.jar and gwt-user-modified.jar
diff --git a/tools/api-checker/reference/createApiCheckerReferenceJars.sh
b/tools/api-checker/reference/createApiCheckerReferenceJars.sh
deleted file mode 100755
index eb38787..000
--- a/tools/api-checker/reference/createApiCheckerReferenceJars.sh
+++ /dev/null
@@ -1,35 +0,0 @@
-#!/bin/bash
-
-showhelp() {
- echo 2 usage: ./createModifiedJars.sh
- echo 2 (1) checks for the existence of gwt-dev.jar and gwt-user.jar
- echo 2 (2) creates gwt-dev-modified.jar and gwt-user-modified.jar (to
be used by api-checker) by only including .java files in com/google/gwt
- exit 1
-}
-
-for file in gwt-dev.jar gwt-user.jar
-do
- if [ ! -f $file ]
- then
-echo [$file] not found - Aborting
-showhelp
- fi
-done
-
-# unpack files in a temporary dir, create a new jar file with only .java
files in com/google/gwt
-for file in gwt-dev.jar gwt-user.jar
-do
- TEMP_DIR=tmp
- rm -rf ${TEMP_DIR}
- mkdir ${TEMP_DIR}
- cd ${TEMP_DIR}
- jar -xf ../${file}
- MODIFIED_FILE=gwt-user-modified.jar
- if [ $file != gwt-user.jar ]
- then
-MODIFIED_FILE=gwt-dev-modified.jar
- fi
- jar -cf ../${MODIFIED_FILE} `find com/google/gwt -name *.java` `find
com/google/web -name *.java`
- cd ..
- rm -rf ${TEMP_DIR}
-done
diff --git a/tools/api-checker/reference/gwt-dev-modified.jar
b/tools/api-checker/reference/gwt-dev-modified.jar
deleted file mode 100644
index 18ab2bb..000
--- a/tools/api-checker/reference/gwt-dev-modified.jar
+++ /dev/null
Binary files differ
diff --git a/tools/api-checker/reference/gwt-user-modified.jar
b/tools/api-checker/reference/gwt-user-modified.jar
deleted file mode 100644
index 5a4a5c8..000
--- a/tools/api-checker/reference/gwt-user-modified.jar
+++ /dev/null
Binary files differ
--
To view, visit https://gwt-review.googlesource.com/2500
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Thomas Broyer t.bro...@gmail.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed
[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.
Thomas Broyer has posted comments on this change. Change subject: Removes api-checker reference JARs from the source tree. .. Patch Set 5: Matthew: can I go ahead and merge? Any blocker on Google's side? -- To view, visit https://gwt-review.googlesource.com/2500 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.
Hello Matthew Dempsky, Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2500 to look at the new patch set (#5). Change subject: Removes api-checker reference JARs from the source tree. .. Removes api-checker reference JARs from the source tree. Now expects them in GWT_TOOLS. Bug: issue 8031 Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879 --- M build.xml D tools/api-checker/reference/README D tools/api-checker/reference/createApiCheckerReferenceJars.sh D tools/api-checker/reference/gwt-dev-modified.jar D tools/api-checker/reference/gwt-user-modified.jar 5 files changed, 3 insertions(+), 46 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2500 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.
Matthew Dempsky has posted comments on this change. Change subject: Removes api-checker reference JARs from the source tree. .. Patch Set 5: Code-Review+2 -- To view, visit https://gwt-review.googlesource.com/2500 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.
Matthew Dempsky has posted comments on this change. Change subject: Removes api-checker reference JARs from the source tree. .. Patch Set 3: (1 comment) Commit Message Line 11: Bug: issue 8031 Did you mean to remove this in patch set 4? -- To view, visit https://gwt-review.googlesource.com/2500 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.
Matthew Dempsky has posted comments on this change.
Change subject: Removes api-checker reference JARs from the source tree.
..
Patch Set 3:
(1 comment)
File build.xml
Line 36:
value=${gwt.tools}/api-checker-reference/2.5.1/gwt-dev.jar:${gwt.tools}/api-checker-reference/2.5.1/gwt-user.jar/
Oh, I added the jars to GWT_TOOLS as gwt-{dev,user}-modified.jar like they
were already. I'd like to keep the modified label for now just so it's
clearer that the files aren't the pristine release jar files.
--
To view, visit https://gwt-review.googlesource.com/2500
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Thomas Broyer t.bro...@gmail.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.
Hello Matthew Dempsky, Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2500 to look at the new patch set (#4). Change subject: Removes api-checker reference JARs from the source tree. .. Removes api-checker reference JARs from the source tree. Now expects them in GWT_TOOLS. Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879 --- M build.xml D tools/api-checker/reference/README D tools/api-checker/reference/createApiCheckerReferenceJars.sh D tools/api-checker/reference/gwt-dev-modified.jar D tools/api-checker/reference/gwt-user-modified.jar 5 files changed, 3 insertions(+), 46 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2500 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.
Thomas Broyer has posted comments on this change.
Change subject: Removes api-checker reference JARs from the source tree.
..
Patch Set 3:
(1 comment)
File build.xml
Line 36:
value=${gwt.tools}/api-checker-reference/2.5.1/gwt-dev.jar:${gwt.tools}/api-checker-reference/2.5.1/gwt-user.jar/
Done
--
To view, visit https://gwt-review.googlesource.com/2500
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Thomas Broyer t.bro...@gmail.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.
Brian Slesinsky has posted comments on this change. Change subject: Removes api-checker reference JARs from the source tree. .. Patch Set 2: I'm okay with moving things with GWT_TOOLS especially if it means we can recreate the git repo earlier. We can figure out what to do about GWT_TOOLS later. -- To view, visit https://gwt-review.googlesource.com/2500 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.
Hello Matthew Dempsky, I'd like you to reexamine a rebased change. Please visit https://gwt-review.googlesource.com/2500 to look at the new rebased patch set (#2). Change subject: Removes api-checker reference JARs from the source tree. .. Removes api-checker reference JARs from the source tree. Now expects them in GWT_TOOLS. Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879 --- M build.xml D tools/api-checker/reference/README D tools/api-checker/reference/createApiCheckerReferenceJars.sh D tools/api-checker/reference/gwt-dev-modified.jar D tools/api-checker/reference/gwt-user-modified.jar 5 files changed, 3 insertions(+), 46 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2500 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.
Matthew Dempsky has posted comments on this change. Change subject: Removes api-checker reference JARs from the source tree. .. Patch Set 2: Oh duh, we'll need to add the .jars to GWT_TOOLS first for the presubmit to actually work. :) Did we make any decision on whether this is the approach we want to take? It seems like a good idea to me. -- To view, visit https://gwt-review.googlesource.com/2500 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.
Matthew Dempsky has posted comments on this change. Change subject: Removes api-checker reference JARs from the source tree. .. Patch Set 1: Verified-1 Oops, this change failed presubmit. :( More details at -- To view, visit https://gwt-review.googlesource.com/2500 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.
Brian Slesinsky has posted comments on this change. Change subject: Removes api-checker reference JARs from the source tree. .. Patch Set 1: It seems like we should have a separate repo in Gerrit for GWT dependencies, with cruft removed; it only needs to work back to a stable release, and before that you can use svn tools. Does Maven have a mode for loading deps from a local cache? We could use whatever directory structure Maven supports. -- To view, visit https://gwt-review.googlesource.com/2500 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.
Thomas Broyer has posted comments on this change. Change subject: Removes api-checker reference JARs from the source tree. .. Patch Set 1: A lot of people will tell you that putting binaries in a VCS is a Bad Thing™, and 99% of the time they'll be right. That wouldn't be an issue for GWT_TOOLS if we keep the append only rule, otherwise it means that cloning the repo also clones all previous versions of the binaries, that many of us will never use. For once, this is something SVN does well: an easy way to synchronize a snapshot of a directory tree. Maven doesn't play well with dependencies that aren't in a Maven repo (other build tools allow this, not Maven), but it's rather easy to deploy our dependencies in a Maven repo. And for people that don't want Maven to connect to the Internet, you can setup a mirror and have everyone use it in their settings.xml (this is recommended in all organizations anyway). Generally, the mirror downloads from the Internet but you can configure it so that it only hosts artifacts, or possibly allow it to connect from time to time (e.g. when you bootstrap a new build, or you know you'll need new dependencies or new versions of them). That said, if (as?) Google keeps its own non-Maven build, there's no reasons to change the way you deal with 3rd-party libs; the main change is that because it'll be easier for us (using Maven) to add new dependencies or update them, we'll have to try not doing it too often and you'll have to keep an eye on changes on any pom.xml file. You can use then the maven-dependency-plugin to update your GWT_TOOLS with dependencies from Maven (and go through your internal process for updating it): http://maven.apache.org/plugins/maven-dependency-plugin/copy-dependencies-mojo.html It was Ray who first proposed moving to Maven last year, so maybe he already thought about this (and if not, well, you know who to blame ;-) ) -- To view, visit https://gwt-review.googlesource.com/2500 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.
Thomas Broyer has uploaded a new change for review.
https://gwt-review.googlesource.com/2500
Change subject: Removes api-checker reference JARs from the source tree.
..
Removes api-checker reference JARs from the source tree.
Now expects them in GWT_TOOLS.
Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879
---
M build.xml
D tools/api-checker/reference/README
D tools/api-checker/reference/createApiCheckerReferenceJars.sh
D tools/api-checker/reference/gwt-dev-modified.jar
D tools/api-checker/reference/gwt-user-modified.jar
5 files changed, 3 insertions(+), 46 deletions(-)
diff --git a/build.xml b/build.xml
index c783631..6312554 100755
--- a/build.xml
+++ b/build.xml
@@ -32,6 +32,8 @@
property name=gwt.apicheck.config
location=tools/api-checker/config/gwt25_26userApi.conf/
+ property name=gwt.apicheck.referencelibs
+
value=${gwt.tools}/api-checker-reference/2.5.1/gwt-dev.jar:${gwt.tools}/api-checker-reference/2.5.1/gwt-user.jar/
target name=buildonly
description=[action] Minimal one-platform devel build, without
distro packaging
@@ -206,7 +208,7 @@
pathelement location=${gwt.tools.lib}/apache/ant-1.6.5.jar /
/classpath
arg value=-refJar/
- arg
path=${gwt.root}/tools/api-checker/reference/gwt-dev-modified.jar:${gwt.root}/tools/api-checker/reference/gwt-user-modified.jar/
+ arg path=${gwt.apicheck.referencelibs}/
arg value=-configFile/
arg file=${gwt.apicheck.config}/
arg value=-logLevel/
diff --git a/tools/api-checker/reference/README
b/tools/api-checker/reference/README
deleted file mode 100644
index ebf6477..000
--- a/tools/api-checker/reference/README
+++ /dev/null
@@ -1,10 +0,0 @@
-gwt-dev.jar and gwt-user.jar were extracted from
http://google-web-toolkit.googlecode.com/files/gwt-2.5.1-rc1.zip
-
-Steps:
-1. Unzip the GWT zip file
-2. Copy gwt-dev.jar and gwt-user.jar into this directory
-3. Delete gwt-dev-modified.jar and gwt-user-modified.jar from this
directory
-4. run ./createApiCheckerReferenceJars.sh
- - Ignore the benign error about finding com/google/web. The directory
only exists in gwt-user.
-5. Delete gwt-dev.jar and gwt-user.jar from this directory
-6. Commit the new gwt-dev-modified.jar and gwt-user-modified.jar
diff --git a/tools/api-checker/reference/createApiCheckerReferenceJars.sh
b/tools/api-checker/reference/createApiCheckerReferenceJars.sh
deleted file mode 100755
index eb38787..000
--- a/tools/api-checker/reference/createApiCheckerReferenceJars.sh
+++ /dev/null
@@ -1,35 +0,0 @@
-#!/bin/bash
-
-showhelp() {
- echo 2 usage: ./createModifiedJars.sh
- echo 2 (1) checks for the existence of gwt-dev.jar and gwt-user.jar
- echo 2 (2) creates gwt-dev-modified.jar and gwt-user-modified.jar (to
be used by api-checker) by only including .java files in com/google/gwt
- exit 1
-}
-
-for file in gwt-dev.jar gwt-user.jar
-do
- if [ ! -f $file ]
- then
-echo [$file] not found - Aborting
-showhelp
- fi
-done
-
-# unpack files in a temporary dir, create a new jar file with only .java
files in com/google/gwt
-for file in gwt-dev.jar gwt-user.jar
-do
- TEMP_DIR=tmp
- rm -rf ${TEMP_DIR}
- mkdir ${TEMP_DIR}
- cd ${TEMP_DIR}
- jar -xf ../${file}
- MODIFIED_FILE=gwt-user-modified.jar
- if [ $file != gwt-user.jar ]
- then
-MODIFIED_FILE=gwt-dev-modified.jar
- fi
- jar -cf ../${MODIFIED_FILE} `find com/google/gwt -name *.java` `find
com/google/web -name *.java`
- cd ..
- rm -rf ${TEMP_DIR}
-done
diff --git a/tools/api-checker/reference/gwt-dev-modified.jar
b/tools/api-checker/reference/gwt-dev-modified.jar
deleted file mode 100644
index 18ab2bb..000
--- a/tools/api-checker/reference/gwt-dev-modified.jar
+++ /dev/null
Binary files differ
diff --git a/tools/api-checker/reference/gwt-user-modified.jar
b/tools/api-checker/reference/gwt-user-modified.jar
deleted file mode 100644
index 5a4a5c8..000
--- a/tools/api-checker/reference/gwt-user-modified.jar
+++ /dev/null
Binary files differ
--
To view, visit https://gwt-review.googlesource.com/2500
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Thomas Broyer t.bro...@gmail.com
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.
Thomas Broyer has posted comments on this change. Change subject: Removes api-checker reference JARs from the source tree. .. Patch Set 1: Tested it by downloading the 2.5.1 JARs from Central, saving them in GWT_TOOLS/api-checker-reference/2.5.1 as gwt-dev.jar and gwt-user.jar respectively, and running ant apicheck. -- To view, visit https://gwt-review.googlesource.com/2500 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.
Matthew Dempsky has posted comments on this change. Change subject: Removes api-checker reference JARs from the source tree. .. Patch Set 1: Seems okay to me in principle. I take it we'll move gwt-dev.jar and gwt-user.jar into GWT_TOOLS too? Or can we set things up to expect them to be fetched directly from the download page? -- To view, visit https://gwt-review.googlesource.com/2500 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.
Thomas Broyer has posted comments on this change. Change subject: Removes api-checker reference JARs from the source tree. .. Patch Set 1: When I proposed downloading them from Central or Google Code, Goktug (IIRC) told me Google's policy rules out such external dependencies. That's why I'm proposing hosting reference versions in GWT_TOOLS (those could be the modified JARs, with the script and README that this change removes, or the original ones). Also, given that the rule for GWT_TOOLS is append only, this change suppose that all the reference JARs will be stored in sibling directories by version, but I'd be fine just moving tools/api-checker/reference to GWT_TOOLS as-is. -- To view, visit https://gwt-review.googlesource.com/2500 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.
John A. Tamplin has posted comments on this change. Change subject: Removes api-checker reference JARs from the source tree. .. Patch Set 1: Yes, and many places don't allow build systems unfettered access to the internet, such as at Square. So moving them to some external system greatly complicates getting builds working, as you have to arrange to fetch them manually and update an internal mirror, and then manually point at that mirror instead. -- To view, visit https://gwt-review.googlesource.com/2500 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.
Matthew Dempsky has posted comments on this change. Change subject: Removes api-checker reference JARs from the source tree. .. Patch Set 1: Alright, let's go with storing them in GWT_TOOLS for now then. I think once we move to Maven though, it'll be worth reconsidering whether we can fetch the artifacts from Central instead. (At that point, Google, Square, and others will need to have a solution for Maven dependencies anyway.) -- To view, visit https://gwt-review.googlesource.com/2500 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
