[gwt-contrib] Change in gwt[master]: Removes deprecated methods from JUnitShell.

2013-03-01 Thread Goktug Gokdogan

Goktug Gokdogan has posted comments on this change.

Change subject: Removes deprecated methods from JUnitShell.
..


Patch Set 1:

Submitted. Thanks!

--
To view, visit https://gwt-review.googlesource.com/2030
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e3fc2b0773d3b9814e1800c2ddfaa21213adeab
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-HasComments: No

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Removes deprecated methods from JUnitShell.

2013-03-01 Thread Goktug Gokdogan

Goktug Gokdogan has abandoned this change.

Change subject: Removes deprecated methods from JUnitShell.
..


Abandoned

Submitted. Thanks!

--
To view, visit https://gwt-review.googlesource.com/2030
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I0e3fc2b0773d3b9814e1800c2ddfaa21213adeab
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Removes deprecated methods from JUnitShell.

2013-02-27 Thread Goktug Gokdogan

Goktug Gokdogan has uploaded a new change for review.

  https://gwt-review.googlesource.com/2030


Change subject: Removes deprecated methods from JUnitShell.
..

Removes deprecated methods from JUnitShell.

Change-Id: I0e3fc2b0773d3b9814e1800c2ddfaa21213adeab
---
M user/src/com/google/gwt/junit/JUnitShell.java
1 file changed, 1 insertion(+), 39 deletions(-)



diff --git a/user/src/com/google/gwt/junit/JUnitShell.java  
b/user/src/com/google/gwt/junit/JUnitShell.java

index 1911031..8cff47a 100644
--- a/user/src/com/google/gwt/junit/JUnitShell.java
+++ b/user/src/com/google/gwt/junit/JUnitShell.java
@@ -29,9 +29,9 @@
 import com.google.gwt.dev.cfg.ModuleDef;
 import com.google.gwt.dev.cfg.Properties;
 import com.google.gwt.dev.cfg.Property;
+import com.google.gwt.dev.javac.CompilationProblemReporter;
 import com.google.gwt.dev.javac.CompilationState;
 import com.google.gwt.dev.javac.CompilationUnit;
-import com.google.gwt.dev.javac.CompilationProblemReporter;
 import com.google.gwt.dev.shell.CheckForUpdates;
 import com.google.gwt.dev.shell.jetty.JettyLauncher;
 import com.google.gwt.dev.util.arg.ArgHandlerDeployDir;
@@ -653,35 +653,6 @@
   }

   /**
-   * Entry point for {@link com.google.gwt.junit.client.GWTTestCase}. Gets  
or

-   * creates the singleton {@link JUnitShell} and invokes its
-   * {@link #runTestImpl(GWTTestCase, TestResult)}.
-   *
-   * @deprecated use {@link #runTest(GWTTestCase, TestResult)} instead
-   */
-  @Deprecated
-  public static void runTest(String moduleName, TestCase testCase,
-  TestResult testResult) throws UnableToCompleteException {
-runTest(moduleName, testCase, testResult,
-((GWTTestCase) testCase).getStrategy());
-  }
-
-  /**
-   * @deprecated use {@link #runTest(GWTTestCase, TestResult)} instead
-   */
-  @Deprecated
-  public static void runTest(String moduleName, TestCase testCase,
-  TestResult testResult, Strategy strategy)
-  throws UnableToCompleteException {
-GWTTestCase gwtTestCase = (GWTTestCase) testCase;
-assert moduleName != null : moduleName cannot be null;
-assert strategy != null : strategy cannot be null;
-assert moduleName.equals(gwtTestCase.getModuleName()) : moduleName  
does not match GWTTestCase#getModuleName();
-assert strategy.equals(gwtTestCase.getStrategy()) : strategy does not  
match GWTTestCase#getStrategy();

-runTest(gwtTestCase, testResult);
-  }
-
-  /**
* Retrieves the JUnitShell. This should only be invoked during  
TestRunner

* execution of JUnit tests.
*/
@@ -1141,15 +1112,6 @@
 } else {
   compileForWebMode(module, userAgents);
 }
-  }
-
-  /**
-   * @deprecated TODO(fabbott) delete me
-   */
-  @Deprecated
-  @SuppressWarnings(unused)
-  void setNumClients(int numClients) {
-throw new UnsupportedOperationException(This method should be  
deleted.);

   }

   void setStandardsMode(boolean standardsMode) {

--
To view, visit https://gwt-review.googlesource.com/2030
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0e3fc2b0773d3b9814e1800c2ddfaa21213adeab
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan gok...@google.com

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Removes deprecated methods from JUnitShell.

2013-02-27 Thread Matthew Dempsky

Matthew Dempsky has posted comments on this change.

Change subject: Removes deprecated methods from JUnitShell.
..


Patch Set 1: Code-Review+1

--
To view, visit https://gwt-review.googlesource.com/2030
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e3fc2b0773d3b9814e1800c2ddfaa21213adeab
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-HasComments: No

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.