[gwt-contrib] Change in gwt[master]: Upgrade JDT to 3.8.3.
Roberto Lublinerman has abandoned this change. Change subject: Upgrade JDT to 3.8.3. .. Abandoned Submitted, thanks! -- To view, visit https://gwt-review.googlesource.com/2361 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: If7d533adcb953de614ea071cfd7e57560b664ce0 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Ray Cromwell Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Thomas Broyer -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Upgrade JDT to 3.8.3.
Matthew Dempsky has posted comments on this change. Change subject: Upgrade JDT to 3.8.3. .. Patch Set 3: Verified-1 Boo, this patch set FAILED the build and/or checkstyle tests. :( Build details: http://gwt-ci.dempsky.org:8080/job/gwt.checkstyle/15/ -- To view, visit https://gwt-review.googlesource.com/2361 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7d533adcb953de614ea071cfd7e57560b664ce0 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Ray Cromwell Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Upgrade JDT to 3.8.3.
Matthew Dempsky has posted comments on this change. Change subject: Upgrade JDT to 3.8.3. .. Patch Set 3: (Should be safe to ignore that verification failure; it's probably just because JDT 3.8 isn't in svn/tools yet.) -- To view, visit https://gwt-review.googlesource.com/2361 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7d533adcb953de614ea071cfd7e57560b664ce0 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Ray Cromwell Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Upgrade JDT to 3.8.3.
Brian Slesinsky has posted comments on this change. Change subject: Upgrade JDT to 3.8.3. .. Patch Set 3: Code-Review+1 -- To view, visit https://gwt-review.googlesource.com/2361 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7d533adcb953de614ea071cfd7e57560b664ce0 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Ray Cromwell Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Upgrade JDT to 3.8.3.
Roberto Lublinerman has posted comments on this change. Change subject: Upgrade JDT to 3.8.3. .. Patch Set 3: For the moment we set the JDT to accept java 6, so I expect that users will get a compiler error if they use Java 7 features. -- To view, visit https://gwt-review.googlesource.com/2361 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7d533adcb953de614ea071cfd7e57560b664ce0 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Ray Cromwell Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Upgrade JDT to 3.8.3.
Matthew Dempsky has posted comments on this change. Change subject: Upgrade JDT to 3.8.3. .. Patch Set 3: What happens if people try to use those new Java 7 features at the moment? Will they get a compiler error before we implement them, or will we silently generate incorrect code? -- To view, visit https://gwt-review.googlesource.com/2361 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7d533adcb953de614ea071cfd7e57560b664ce0 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Ray Cromwell Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Upgrade JDT to 3.8.3.
Roberto Lublinerman has posted comments on this change. Change subject: Upgrade JDT to 3.8.3. .. Patch Set 3: The custom SourceTypeBindings does not seem to provide any significant benefits in terms of memory usage; hence the customization has been removed. WRT to Java 7 features: - new literals (binary and underscore) and switch on string values work with no modification - multi exceptions requires a small patch (that I will submit after this one). - try-with-resource is probably best handled by a "source code transform" in GwtAstBuilder. -- To view, visit https://gwt-review.googlesource.com/2361 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7d533adcb953de614ea071cfd7e57560b664ce0 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Ray Cromwell Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Upgrade JDT to 3.8.3.
Matthew Dempsky has posted comments on this change. Change subject: Upgrade JDT to 3.8.3. .. Patch Set 3: Code-Review+1 -- To view, visit https://gwt-review.googlesource.com/2361 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7d533adcb953de614ea071cfd7e57560b664ce0 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Ray Cromwell Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Upgrade JDT to 3.8.3.
Roberto Lublinerman has uploaded a new patch set (#3). Change subject: Upgrade JDT to 3.8.3. .. Upgrade JDT to 3.8.3. Change-Id: If7d533adcb953de614ea071cfd7e57560b664ce0 Review-Link: https://gwt-review.googlesource.com/#/c/2361/ --- M dev/build.xml M dev/core/src/com/google/gwt/dev/javac/JavaSourceParser.java M dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java M dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java D dev/core/src/org/eclipse/jdt/internal/compiler/lookup/SourceTypeBinding.java M dev/core/test/com/google/gwt/dev/javac/BinaryTypeReferenceRestrictionsCheckerTest.java M dev/core/test/com/google/gwt/dev/javac/JdtBehaviorTest.java M eclipse/dev/.classpath M eclipse/dev/compiler/.classpath M user/super/com/google/gwt/emul/java/lang/Enum.java 10 files changed, 36 insertions(+), 1,694 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2361 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: If7d533adcb953de614ea071cfd7e57560b664ce0 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Ray Cromwell Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Thomas Broyer -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
