[gwt-contrib] Change in gwt[master]: fixing mismatch in Double.isInfinite between dev / production
Daniel Kurka has uploaded a new change for review.
https://gwt-review.googlesource.com/2240
Change subject: fixing mismatch in Double.isInfinite between dev /
production
..
fixing mismatch in Double.isInfinite between dev / production
fixes ISSUE 8073
Change-Id: I792a2f2f17e7b4688e5b5d99410f74f34144
---
M user/super/com/google/gwt/emul/java/lang/Double.java
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/user/super/com/google/gwt/emul/java/lang/Double.java
b/user/super/com/google/gwt/emul/java/lang/Double.java
index 5144653..e32f9d2 100644
--- a/user/super/com/google/gwt/emul/java/lang/Double.java
+++ b/user/super/com/google/gwt/emul/java/lang/Double.java
@@ -192,7 +192,7 @@
}
public static native boolean isInfinite(double x) /*-{
-return !isFinite(x);
+return !isFinite(x) && !isNaN(x);
}-*/;
public static native boolean isNaN(double x) /*-{
--
To view, visit https://gwt-review.googlesource.com/2240
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I792a2f2f17e7b4688e5b5d99410f74f34144
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: fixing mismatch in Double.isInfinite between dev / production
Thomas Broyer has posted comments on this change. Change subject: fixing mismatch in Double.isInfinite between dev / production .. Patch Set 1: Could you add a test to com.google.gwt.emultest.java.lang.DoubleTest#testDoubleConstants? We also have the same issue in Float.isInfinite(). -- To view, visit https://gwt-review.googlesource.com/2240 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I792a2f2f17e7b4688e5b5d99410f74f34144 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: fixing mismatch in Double.isInfinite between dev / production
Daniel Kurka has abandoned this change. Change subject: fixing mismatch in Double.isInfinite between dev / production .. Abandoned error -- To view, visit https://gwt-review.googlesource.com/2240 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I792a2f2f17e7b4688e5b5d99410f74f34144 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka Gerrit-Reviewer: Thomas Broyer -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: fixing mismatch in Double.isInfinite between dev / production
Daniel Kurka has posted comments on this change. Change subject: fixing mismatch in Double.isInfinite between dev / production .. Patch Set 1: I was getting an IllegalArgumentException which I was unable to fix while trying to update this commit. Added a new review: https://gwt-review.googlesource.com/2250 -- To view, visit https://gwt-review.googlesource.com/2240 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I792a2f2f17e7b4688e5b5d99410f74f34144 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka Gerrit-Reviewer: Daniel Kurka Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
