[gwt-contrib] Change in gwt[master]: makes GWT boolean flags togglable
John Stalcup has posted comments on this change. Change subject: makes GWT boolean flags togglable .. Patch Set 1: yeah i was hesitant to change public class names since it would introduce the danger of breaking some external code i'll defer that change to a later CL -- To view, visit https://gwt-review.googlesource.com/2682 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5eee53b0b50fde31f3e750ad85c3e089a52fcbab Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Stalcup Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: John Stalcup Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Roberto Lublinerman Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: makes GWT boolean flags togglable
Roberto Lublinerman has posted comments on this change.
Change subject: makes GWT boolean flags togglable
..
Patch Set 1: Code-Review+2
(1 comment)
File dev/core/src/com/google/gwt/dev/DevModeBase.java
Line 292: protected static class ArgHandlerNoServerFlag extends
ArgHandlerFlag {
Maybe rename this one ArgHandlerStartServerFlag, but as Matthew said does
not have to be on this patch.
--
To view, visit https://gwt-review.googlesource.com/2682
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eee53b0b50fde31f3e750ad85c3e089a52fcbab
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: John Stalcup
Gerrit-Reviewer: Brian Slesinsky
Gerrit-Reviewer: Leeroy Jenkins
Gerrit-Reviewer: Matthew Dempsky
Gerrit-Reviewer: Roberto Lublinerman
Gerrit-Reviewer: Roberto Lublinerman
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: makes GWT boolean flags togglable
Matthew Dempsky has posted comments on this change. Change subject: makes GWT boolean flags togglable .. Patch Set 1: Some of the flag classes (e.g., ArgHandlerNoServerFlag) no longer match the tag name. Should those class names be updated? (Doesn't have to be in this patch.) -- To view, visit https://gwt-review.googlesource.com/2682 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5eee53b0b50fde31f3e750ad85c3e089a52fcbab Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Stalcup Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Roberto Lublinerman Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
