[gwt-contrib] Change in gwt[master]: working on issue 8063, ie10 permutation and ms pointer events
Leif Åstrand has posted comments on this change. Change subject: working on issue 8063, ie10 permutation and ms pointer events .. Patch Set 5: (1 comment) File user/src/com/google/gwt/typedarrays/TypedArrays.gwt.xml Line 24: "separate issue" -- To view, visit https://gwt-review.googlesource.com/2421 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba0cec6e33ffd3fefa69c3c760868beb00d42076 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matti Tahvonen Gerrit-Reviewer: Artur Signell Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Leif Åstrand Gerrit-Reviewer: Manuel Carrasco Moñino Gerrit-Reviewer: Matti Tahvonen Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: working on issue 8063, ie10 permutation and ms pointer events
Leif Åstrand has posted comments on this change. Change subject: working on issue 8063, ie10 permutation and ms pointer events .. Patch Set 5: (3 comments) Commit Message Line 7: working on issue 8063, ie10 permutation and ms pointer events Commit message could be updated if the work is indeed about to be done. File user/src/com/google/gwt/typedarrays/TypedArrays.gwt.xml Line 24: Could create a separate for this so that it isn't (completely) forgotten and update the comment so that it doesn't conflict with the actual definition below. File user/super/com/google/gwt/emul/EmulationWithUserAgent.gwt.xml Line 31: Could maybe test and update accordingly or then just remove this comment and instead create a separate for this so that it isn't (completely) forgotten. -- To view, visit https://gwt-review.googlesource.com/2421 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba0cec6e33ffd3fefa69c3c760868beb00d42076 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matti Tahvonen Gerrit-Reviewer: Artur Signell Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Leif Åstrand Gerrit-Reviewer: Manuel Carrasco Moñino Gerrit-Reviewer: Matti Tahvonen Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: working on issue 8063, ie10 permutation and ms pointer events
Thomas Broyer has posted comments on this change. Change subject: working on issue 8063, ie10 permutation and ms pointer events .. Patch Set 5: Gerrit has minimal formatting support (only paragraphs, preformatted text and lists): https://gerrit.googlesource.com/gerrit/+/master/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/safehtml/client/SafeHtml.java -- To view, visit https://gwt-review.googlesource.com/2421 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba0cec6e33ffd3fefa69c3c760868beb00d42076 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matti Tahvonen Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Manuel Carrasco Moñino Gerrit-Reviewer: Matti Tahvonen Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: working on issue 8063, ie10 permutation and ms pointer events
Manuel Carrasco Moñino has posted comments on this change. Change subject: working on issue 8063, ie10 permutation and ms pointer events .. Patch Set 4: Matti the patch looks good to me, but I dont understand why you continue having the block '' in the HTTP.gwt.xml. IMO it does nothing and it is confusing to leave it there. Or maybe I'm missing something. -- To view, visit https://gwt-review.googlesource.com/2421 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba0cec6e33ffd3fefa69c3c760868beb00d42076 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matti Tahvonen Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Manuel Carrasco Moñino Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: working on issue 8063, ie10 permutation and ms pointer events
Manuel Carrasco Moñino has posted comments on this change.
Change subject: working on issue 8063, ie10 permutation and ms pointer
events
..
Patch Set 3:
(10 comments)
File user/src/com/google/gwt/event/dom/client/MsPointerCancelEvent.java
Line 21: * Represents a native pointer cancel event.
MsPointer
File user/src/com/google/gwt/event/dom/client/MsPointerDownEvent.java
Line 20: /**
It seems this file has the same javadoc of MouseDownEvent.java, I think you
should change those comments to say that this events are MS specific
File user/src/com/google/gwt/event/dom/client/MsPointerDownHandler.java
Line 21: * Handler interface for {@link MousePointerEvent} events.
change it by MsPointerDownEvent
Line 27:*
change them
File user/src/com/google/gwt/event/dom/client/MsPointerEvent.java
Line 19: * Abstract class representing pointer events.
add MS
File user/src/com/google/gwt/event/dom/client/MsPointerMoveEvent.java
Line 21: * Represents a native pointer down event.
the same that I say in my other comments related with javadoc
File user/src/com/google/gwt/event/dom/client/MsPointerUpEvent.java
Line 21: * Represents a native pointer down event.
revise javadoc
File user/src/com/google/gwt/http/HTTP.gwt.xml
Line 20:
Maybe good time to change tabs by two spaces like we use in all gwt.xml ?
Line 32:
is this '' block necessary? I think the '' one is enough.
File user/src/com/google/gwt/user/client/impl/DOMImplIE10.java
Line 8: * http://www.apache.org/licenses/LICENSE-2.0
It is better to remove all these spaces at the end of lines: #3, #7, #9,
#39, #78, #84
--
To view, visit https://gwt-review.googlesource.com/2421
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba0cec6e33ffd3fefa69c3c760868beb00d42076
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Matti Tahvonen
Gerrit-Reviewer: Leeroy Jenkins
Gerrit-Reviewer: Manuel Carrasco Moñino
Gerrit-Reviewer: Thomas Broyer
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: working on issue 8063, ie10 permutation and ms pointer events
Manuel Carrasco Moñino has posted comments on this change. Change subject: working on issue 8063, ie10 permutation and ms pointer events .. Patch Set 2: Code-Review+1 (4 comments) File user/src/com/google/gwt/dom/DOM.gwt.xml Line 37: Use two spaces here File user/src/com/google/gwt/event/dom/client/MsPointerCancelEvent.java Line 9: * There are final spaces here, and in many other lines of other classes in the patch. File user/src/com/google/gwt/http/HTTP.gwt.xml Line 30: This block shouldn't be necessary. Is there any reason to add this? File user/src/com/google/gwt/user/DOM.gwt.xml Line 35: class="com.google.gwt.user.client.impl.DOMImpl"/> It should be indented with two spaces -- To view, visit https://gwt-review.googlesource.com/2421 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba0cec6e33ffd3fefa69c3c760868beb00d42076 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matti Tahvonen Gerrit-Reviewer: Manuel Carrasco Moñino Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
