Re: [gwt-contrib] Gerrit presubmit changes
Fantastic. On Sun, Oct 20, 2013 at 9:28 PM, Stephen Haberman step...@exigencecorp.comwrote: Wow, that sounds awesome, Matthew. Great work. I'm looking forward to hopefully *not* triggering this great feedback. :-) - Stephen -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Gerrit presubmit changes
I've made a few changes to the presubmit process this weekend that I wanted to share: 1. There's now an initial fast style check step that should give style feedback much faster (on average within about a minute). If this fails, then the usual build/full-style check is skipped. 2. Style warnings are now presented inline as normal Gerrit review comments so you don't need to dig through the build log to figure out what went wrong. E.g., see https://gwt-review.googlesource.com/#/c/5035/ for an example review. 3. In addition to the usual style 'errors' that the full style check warns about, the fast style check will include 'info' and 'warning' messages, but only if they came from a source line modified by the change (as identified by git blame). 4. The fast style check now also includes some basic warnings for commit messages that don't follow Git commit message best practiceshttp://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html. Currently it checks that the subject line is =50 chars, the second line is blank, and all other lines are =72 chars. 5. I've configured an issue tracker template for reporting issues with the presubmitter: https://code.google.com/p/google-web-toolkit/issues/entry?template=Presubmit%20issue If you notice anything wrong or that could be improved, please feel free to submit an issue. Thanks -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Gerrit presubmit changes
Wow, that sounds awesome, Matthew. Great work. I'm looking forward to hopefully *not* triggering this great feedback. :-) - Stephen -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
