[gwt-contrib] Re: Add javadocs for ExternalTextResource.getText, fixes #7035 (issue1605803)

2012-06-07 Thread rchandia 

LGTM. Reposted at http://gwt-code-reviews.appspot.com/1733804/

http://gwt-code-reviews.appspot.com/1605803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add javadocs for ExternalTextResource.getText, fixes #7035 (issue1605803)

2012-06-07 Thread rchandia 

Submitted as r11027

http://gwt-code-reviews.appspot.com/1605803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add javadocs for ExternalTextResource.getText, fixes #7035 (issue1605803)

2012-06-06 Thread stephen . haberman 



Yes, please. The license in particular should stay as it was before.


Done.

http://gwt-code-reviews.appspot.com/1605803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add javadocs for ExternalTextResource.getText, fixes #7035 (issue1605803)

2012-06-05 Thread rchandia 


http://gwt-code-reviews.appspot.com/1605803/diff/1/user/src/com/google/gwt/resources/client/ExternalTextResource.java
File user/src/com/google/gwt/resources/client/ExternalTextResource.java
(right):

http://gwt-code-reviews.appspot.com/1605803/diff/1/user/src/com/google/gwt/resources/client/ExternalTextResource.java#newcode23
user/src/com/google/gwt/resources/client/ExternalTextResource.java:23: *
initialization.
On 2011/12/01 03:00:25, stephenh wrote:

I didn't change the license/javadocs, but just formatted the file with

the

Eclipse formatter settings. I can undo that if needed.


Yes, please. The license in particular should stay as it was before.

http://gwt-code-reviews.appspot.com/1605803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add javadocs for ExternalTextResource.getText, fixes #7035 (issue1605803)

2011-11-30 Thread stephen . haberman 


http://gwt-code-reviews.appspot.com/1605803/diff/1/user/src/com/google/gwt/resources/client/ExternalTextResource.java
File user/src/com/google/gwt/resources/client/ExternalTextResource.java
(right):

http://gwt-code-reviews.appspot.com/1605803/diff/1/user/src/com/google/gwt/resources/client/ExternalTextResource.java#newcode23
user/src/com/google/gwt/resources/client/ExternalTextResource.java:23: *
initialization.
I didn't change the license/javadocs, but just formatted the file with
the Eclipse formatter settings. I can undo that if needed.

http://gwt-code-reviews.appspot.com/1605803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors