[gwt-contrib] Re: Adds the -XdisableGflow flag. (issue260801)

2010-03-23 Thread spoon 

Bob, can you review this little patch?

It adds a flag -XdisableGflow that does exactly what it sounds like.
This would provide a safety valve in case there are any problems that
arise from the new gflow optimizer.

In a month or so we could reevaluate whether we need to keep the flag or
not.

http://gwt-code-reviews.appspot.com/260801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

To unsubscribe from this group, send email to 
google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this email with 
the words REMOVE ME as the subject.

[gwt-contrib] Re: Adds the -XdisableGflow flag. (issue260801)

2010-03-23 Thread scottb 

Just a thought.. but instead of a new flag, what if we redefined
aggressive optimizations to mean just GFlow, since all the other
optimizations have a lot of miles on them now.  What do you think?

http://gwt-code-reviews.appspot.com/260801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

To unsubscribe from this group, send email to 
google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this email with 
the words REMOVE ME as the subject.

[gwt-contrib] Re: Adds the -XdisableGflow flag. (issue260801)

2010-03-23 Thread Lex Spoon 
On Tue, Mar 23, 2010 at 2:24 PM, sco...@google.com wrote:

 Just a thought.. but instead of a new flag, what if we redefined
 aggressive optimizations to mean just GFlow, since all the other
 optimizations have a lot of miles on them now.  What do you think?


I like the idea of updating the aggressive optimization flag, and started to
suggest that instead.  However, it would still probably include more than
gflow.  Potential examples would be function clustering, function deduping,
and same parameter value substitution.  So we'd likely end up wanting a
separate flag, anyway.

-Lex

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

To unsubscribe from this group, send email to 
google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this 
email with the words REMOVE ME as the subject.