[gwt-contrib] Re: CSS Media types are comma separated. (issue1861804)

2012-10-30 Thread mdempsky 


http://gwt-code-reviews.appspot.com/1861804/diff/1/user/src/com/google/gwt/resources/css/CssGenerationVisitor.java
File user/src/com/google/gwt/resources/css/CssGenerationVisitor.java
(right):

http://gwt-code-reviews.appspot.com/1861804/diff/1/user/src/com/google/gwt/resources/css/CssGenerationVisitor.java#newcode192
user/src/com/google/gwt/resources/css/CssGenerationVisitor.java:192:
spaceOpt();
I think the first space is mandatory, no?  Otherwise won't compact
output get something like @mediafoo,bar instead of @media foo,bar?

http://gwt-code-reviews.appspot.com/1861804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: CSS Media types are comma separated. (issue1861804)

2012-10-30 Thread rchandia 

http://gwt-code-reviews.appspot.com/1861804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: CSS Media types are comma separated. (issue1861804)

2012-10-30 Thread rchandia 


http://gwt-code-reviews.appspot.com/1861804/diff/1/user/src/com/google/gwt/resources/css/CssGenerationVisitor.java
File user/src/com/google/gwt/resources/css/CssGenerationVisitor.java
(right):

http://gwt-code-reviews.appspot.com/1861804/diff/1/user/src/com/google/gwt/resources/css/CssGenerationVisitor.java#newcode192
user/src/com/google/gwt/resources/css/CssGenerationVisitor.java:192:
spaceOpt();
On 2012/10/30 18:35:18, mdempsky wrote:

I think the first space is mandatory, no?  Otherwise won't compact

output get

something like @mediafoo,bar instead of @media foo,bar?


Done.

http://gwt-code-reviews.appspot.com/1861804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: CSS Media types are comma separated. (issue1861804)

2012-10-30 Thread mdempsky 

LGTM

http://gwt-code-reviews.appspot.com/1861804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors