[gwt-contrib] Re: Checkstyle fixes (issue1565806)
LGTM. With a Nit.
http://gwt-code-reviews.appspot.com/1565806/diff/8001/user/test/com/google/gwt/editor/client/DirtyEditorTest.java
File user/test/com/google/gwt/editor/client/DirtyEditorTest.java
(right):
http://gwt-code-reviews.appspot.com/1565806/diff/8001/user/test/com/google/gwt/editor/client/DirtyEditorTest.java#newcode182
user/test/com/google/gwt/editor/client/DirtyEditorTest.java:182:
OptionalFieldEditor.of(ListEditor.Person, PersonEditor of(new
EditorSourcePersonEditor() {
Line length.
http://gwt-code-reviews.appspot.com/1565806/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Checkstyle fixes (issue1565806)
Line length. Oh no! That was completely fine before adding those generics. :-) I was putzing around with ant trying to get it to fail the compile so didn't have Eclipse to flag the error. Resubmitting. http://gwt-code-reviews.appspot.com/1565806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Checkstyle fixes (issue1565806)
I was putzing around with ant trying to get it to fail the compile so didn't have Eclipse to flag the error. Huh, I thought I had Eclipse configured to show checkstyle errors like that--but I don't see it. I see other errors like methods not in alphabetical order. Resubmitting. I hope the new formatting is okay--I just let the Eclipse formatter handle it. http://gwt-code-reviews.appspot.com/1565806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Checkstyle fixes (issue1565806)
LGTM On 2012/06/08 18:27:29, stephenh wrote: I was putzing around with ant trying to get it to fail the compile so didn't have Eclipse to flag the error. Huh, I thought I had Eclipse configured to show checkstyle errors like that--but I don't see it. I see other errors like methods not in alphabetical order. Resubmitting. I hope the new formatting is okay--I just let the Eclipse formatter handle it. http://gwt-code-reviews.appspot.com/1565806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Checkstyle fixes (issue1565806)
Submitted as r11034 http://gwt-code-reviews.appspot.com/1565806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Checkstyle fixes (issue1565806)
http://gwt-code-reviews.appspot.com/1565806/diff/4001/user/test/com/google/gwt/editor/client/DirtyEditorTest.java
File user/test/com/google/gwt/editor/client/DirtyEditorTest.java
(right):
http://gwt-code-reviews.appspot.com/1565806/diff/4001/user/test/com/google/gwt/editor/client/DirtyEditorTest.java#newcode182
user/test/com/google/gwt/editor/client/DirtyEditorTest.java:182:
OptionalFieldEditor.of(ListEditor.of(new EditorSourcePersonEditor() {
Breaks compilation.
Should be ...(ListEditor.Person, PersonEditor of(...
http://gwt-code-reviews.appspot.com/1565806/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Checkstyle fixes (issue1565806)
Should be ...(ListEditor.Person, PersonEditor of(... I must be doing something wrong? This compiles in both Eclipse and ant clean dist-dev for me. I'm using a JDK 1.6 compiler. I will still change it, but should I make any changes to my local environment to catch stuff like this going forward? http://gwt-code-reviews.appspot.com/1565806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Checkstyle fixes (issue1565806)
Oh, sorry, it breaks test compilation (that is, 'cd user; ant test.htmlunit', for example), that is. On Thu, Jun 7, 2012 at 12:04 PM, stephen.haber...@gmail.com wrote: Should be ...(ListEditor.Person, PersonEditor of(... I must be doing something wrong? This compiles in both Eclipse and ant clean dist-dev for me. I'm using a JDK 1.6 compiler. I will still change it, but should I make any changes to my local environment to catch stuff like this going forward? http://gwt-code-reviews.**appspot.com/1565806/http://gwt-code-reviews.appspot.com/1565806/ -- Rodrigo Chandia | Software Engineer | rchan...@google.com | 678 7431725 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Checkstyle fixes (issue1565806)
Oh, sorry, it breaks test compilation (that is, 'cd user; ant test.htmlunit', for example), that is. That works for me too. :-) http://gwt-code-reviews.appspot.com/1565806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Checkstyle fixes (issue1565806)
I guess it is a difference between OpenJDK and Oracle JDK. On Thu, Jun 7, 2012 at 12:33 PM, stephen.haber...@gmail.com wrote: Oh, sorry, it breaks test compilation (that is, 'cd user; ant test.htmlunit', for example), that is. That works for me too. :-) http://gwt-code-reviews.**appspot.com/1565806/http://gwt-code-reviews.appspot.com/1565806/ -- Rodrigo Chandia | Software Engineer | rchan...@google.com | 678 7431725 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Checkstyle fixes (issue1565806)
Reviewers: rjrjr, rdayal, rchandia,
Message:
Please keep the license header as it was before.
Done.
Please review this at http://gwt-code-reviews.appspot.com/1565806/
Affected files:
M
dev/core/src/com/google/gwt/core/ext/linker/impl/StandardPublicResource.java
M dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java
M user/src/com/google/gwt/geolocation/client/Position.java
M user/src/com/google/gwt/i18n/shared/AlternateMessageSelector.java
M
user/src/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamReader.java
M user/src/com/google/gwt/validation/client/BaseMessageInterpolator.java
M
user/src/com/google/web/bindery/event/shared/testing/CountingEventBus.java
M user/test/com/google/gwt/dev/jjs/test/singlejso/TypeHierarchyTest.java
M user/test/com/google/gwt/editor/client/DirtyEditorTest.java
M user/test/com/google/gwt/emultest/java/util/TreeMapTest.java
M user/test/com/google/gwt/user/server/rpc/RPCTypeCheckTest.java
Index:
dev/core/src/com/google/gwt/core/ext/linker/impl/StandardPublicResource.java
diff --git
a/dev/core/src/com/google/gwt/core/ext/linker/impl/StandardPublicResource.java
b/dev/core/src/com/google/gwt/core/ext/linker/impl/StandardPublicResource.java
index
5df3c26269f08649a4de37e9c05aa538b7a78be9..9111d097fb25758db53d3e72f2c00d70abe66554
100644
---
a/dev/core/src/com/google/gwt/core/ext/linker/impl/StandardPublicResource.java
+++
b/dev/core/src/com/google/gwt/core/ext/linker/impl/StandardPublicResource.java
@@ -84,7 +84,7 @@ public class StandardPublicResource extends
PublicResource {
try {
return resource.openContents();
} catch (IOException ex) {
- logger.log (TreeLogger.ERROR, Problem reading resource: +
resource.getLocation(), ex);
+ logger.log(TreeLogger.ERROR, Problem reading resource: +
resource.getLocation(), ex);
throw new UnableToCompleteException();
}
}
Index: dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java
diff --git a/dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java
b/dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java
index
36cb77753045ea98ff722d71bc63bee732a0756d..c3fe75cd64217800ffaf4012adb7019bc21d6438
100644
--- a/dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java
+++ b/dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java
@@ -179,8 +179,7 @@ public class BindingProperty extends Property {
LinkedListString childList = fallbackValues.get(from);
LinkedHashSetString children = new LinkedHashSetString();
children.addAll(childList);
-while (children != null children.size() 0)
-{
+while (children != null children.size() 0) {
alternates.add(children);
LinkedHashSetString newChildren = new LinkedHashSetString();
for (String child : children) {
Index: user/src/com/google/gwt/geolocation/client/Position.java
diff --git a/user/src/com/google/gwt/geolocation/client/Position.java
b/user/src/com/google/gwt/geolocation/client/Position.java
index
88c51294b4c6f71ed5e731f2e1483e85c0ea6884..477d3b3fbb54a4f1a7127095e3c755e577a12da2
100644
--- a/user/src/com/google/gwt/geolocation/client/Position.java
+++ b/user/src/com/google/gwt/geolocation/client/Position.java
@@ -28,12 +28,12 @@ public interface Position {
/**
* Returns information about the coordinates reported by the browser.
*/
- public Coordinates getCoordinates();
+ Coordinates getCoordinates();
/**
* Returns the time this position was reported by the browser.
*/
- public double getTimestamp();
+ double getTimestamp();
/**
* Represents position reported by the browser.
@@ -44,7 +44,7 @@ public interface Position {
/**
* Returns the estimated accuracy reported by the browser, in meters.
*/
-public double getAccuracy();
+double getAccuracy();
/**
* Returns the altitude reported by the browser, in meters, above the
a
@@ -52,37 +52,37 @@ public interface Position {
* ellipsoid/a, or codenull/code if the browser did not report an
* altitude.
*/
-public Double getAltitude();
+Double getAltitude();
/**
* Returns the estimated accuracy of the altitude reported by the
browser,
* in meters, or codenull/code if the browser did not report an
* accuracy.
*/
-public Double getAltitudeAccuracy();
+Double getAltitudeAccuracy();
/**
* Returns the heading, in degrees from due north, reported by the
browser,
* based on previous calls to get the user's position, or
codenull/code
* if the browser did not report a heading.
*/
-public Double getHeading();
+Double getHeading();
/**
* Returns the decimal latitude reported by the browser.
*/
-public double getLatitude();
+double getLatitude();
/**
* Returns the decimal longitude reported by the browser.
*/
-public double
