Because newer versions of Ant (1.7?) allow it, and our build system only
officially supports 1.7+.

On Thu, Dec 11, 2008 at 11:57 AM, John LaBanca <[EMAIL PROTECTED]> wrote:

> I didn't see it in the 1.6 branch.  The line in question references soyc,
> which is only in trunk as far as I know:
> <tarfileset file="${gwt.build.lib}/gwt-soyc-vis.jar"
> prefix="${project.distname}" />
>
> This line was recently committed.  It just uses tarfileset instead of
> zipfileset, which causes build errors.  I'm not sure why this hasn't
> affected anyone else yet.
>
> Thanks,
> John LaBanca
> [EMAIL PROTECTED]
>
>
> On Thu, Dec 11, 2008 at 11:53 AM, Scott Blum <[EMAIL PROTECTED]> wrote:
>
>> Wait, this sounds like something already committed.  Was it something
>> committed to trunk that should have been 1.6, or vice versa?
>>
>>
>> On Thu, Dec 11, 2008 at 11:42 AM, John LaBanca <[EMAIL PROTECTED]>wrote:
>>
>>> Freeland -
>>>
>>> Please do a code review on this patch that fixes the windows distro build
>>> file.
>>>
>>> Description:
>>> =========
>>> <zip> does not support the <tarfileset>, at least on my machine.  This
>>> looks like a typo,
>>>
>>> Fix:
>>> ===
>>> Changed <tarfileset> to <zipfileset>, which is consistent with the rest
>>> of the file.
>>>
>>> Testing:
>>> ======
>>> Building using "ant" now works.
>>>
>>>
>>> Thanks,
>>> John LaBanca
>>> [EMAIL PROTECTED]
>>>
>>>
>>>
>>
>>
>>
>
> >
>

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to