[gwt-contrib] Re: Don't allow DataflowOptimizer to perform constant transformation on expressions with side-effects. (issue1467801)

2011-06-21 Thread jbrosenberg 


http://gwt-code-reviews.appspot.com/1467801/diff/1/dev/core/test/com/google/gwt/dev/jjs/impl/gflow/DataflowOptimizerTest.java
File
dev/core/test/com/google/gwt/dev/jjs/impl/gflow/DataflowOptimizerTest.java
(right):

http://gwt-code-reviews.appspot.com/1467801/diff/1/dev/core/test/com/google/gwt/dev/jjs/impl/gflow/DataflowOptimizerTest.java#newcode333
dev/core/test/com/google/gwt/dev/jjs/impl/gflow/DataflowOptimizerTest.java:333:
addSnippetClassDecl("static volatile boolean TRUE = true;");
removed (was leftover from refactoring)

http://gwt-code-reviews.appspot.com/1467801/diff/1/dev/core/test/com/google/gwt/dev/jjs/impl/gflow/DataflowOptimizerTest.java#newcode349
dev/core/test/com/google/gwt/dev/jjs/impl/gflow/DataflowOptimizerTest.java:349:
// TODO: Allow the second line below to be transformed to just:
"EntryPoint.x = n;"
well, the multi-expression (EntryPoint.x = n, true) will always return
true, so the || EntryPoint.fail() will never be reachable.

http://gwt-code-reviews.appspot.com/1467801/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Don't allow DataflowOptimizer to perform constant transformation on expressions with side-effects. (issue1467801)

2011-06-21 Thread jbrosenberg 

http://gwt-code-reviews.appspot.com/1467801/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Don't allow DataflowOptimizer to perform constant transformation on expressions with side-effects. (issue1467801)

2011-06-21 Thread zundel 

LGTM, just some comments.


http://gwt-code-reviews.appspot.com/1467801/diff/1/dev/core/test/com/google/gwt/dev/jjs/impl/gflow/DataflowOptimizerTest.java
File
dev/core/test/com/google/gwt/dev/jjs/impl/gflow/DataflowOptimizerTest.java
(right):

http://gwt-code-reviews.appspot.com/1467801/diff/1/dev/core/test/com/google/gwt/dev/jjs/impl/gflow/DataflowOptimizerTest.java#newcode333
dev/core/test/com/google/gwt/dev/jjs/impl/gflow/DataflowOptimizerTest.java:333:
addSnippetClassDecl("static volatile boolean TRUE = true;");
I'm not clear on the purpose of TRUE.

http://gwt-code-reviews.appspot.com/1467801/diff/1/dev/core/test/com/google/gwt/dev/jjs/impl/gflow/DataflowOptimizerTest.java#newcode349
dev/core/test/com/google/gwt/dev/jjs/impl/gflow/DataflowOptimizerTest.java:349:
// TODO: Allow the second line below to be transformed to just:
"EntryPoint.x = n;"
you mean, because the method always returns true?

http://gwt-code-reviews.appspot.com/1467801/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors