[gwt-contrib] Re: Drop the bikeshed jar from the GWT distribution. (issue665801)

[Amit Manjhi]

Yes, the eclipse plugin code should be modified appropriately and the jar
does not need to published by maven. That is why I put you and Jason on the
reviewers list :). Can you guys take care of these issues? Thanks!

On Fri, Jun 25, 2010 at 10:58 AM,  wrote:

> LGTM - I'm guessing that the appropriate classes have now been merged
> into gwt-user proper?
>
> Side note: The plugin code can now be modified so that it doesn't have
> special handling for the bikeshed jar (i.e. putting it at the top of the
> container).
>
>
> http://gwt-code-reviews.appspot.com/665801/show
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Drop the bikeshed jar from the GWT distribution. (issue665801)

[rdayal]

LGTM - I'm guessing that the appropriate classes have now been merged
into gwt-user proper?

Side note: The plugin code can now be modified so that it doesn't have
special handling for the bikeshed jar (i.e. putting it at the top of the
container).

http://gwt-code-reviews.appspot.com/665801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Drop the bikeshed jar from the GWT distribution. (issue665801)

[Freeland Abbott]

At least for now, yeah, that covers me.  If we start putting stuff back in,
we can restore it to dist (if we want to) then.


On Fri, Jun 25, 2010 at 11:08 AM, Amit Manjhi  wrote:

> There is still a "dist-bikeshed" target that will produce the bikeshed jar.
> I did not touch it. Does that cover the use case you have in mind?
>
> This CL just ensures that the "dist" target not produce the bikeshed jar or
> include the bikeshed jar in the distribution.
>
>
> On Fri, Jun 25, 2010 at 8:01 AM,  wrote:
>
>> I have mixed feelings... if bikeshed is null now, do we think we
>> will/won't need such a workspace in the future?  I thought something
>> like that was being considered as the incubator replacement model, for
>> example.
>>
>> I suppose we can turn it back on at will, but it seems to me that having
>> build.xml always build the perhaps-empty bikeshed.  I'm less sure about
>> distro-source, though... it's explicitly for in-progress work, so I'm
>> not sure it's part of a release even if not empty!
>>
>>
>>
>> On 2010/06/25 14:23:11, amitmanjhi wrote:
>>
>>> Yes, it is no longer needed. We can drop it from the maven report for
>>>
>> the
>>
>>> next milestone.
>>>
>>
>>  On Jun 25, 2010 6:37 AM,  wrote:
>>> > Does this mean gwt-bikeshed.jar is no longer needed? Do we need it
>>>
>> at
>>
>>> > all in the Maven repo for the next milestone?
>>> >
>>> > http://gwt-code-reviews.appspot.com/665801/show
>>>
>>
>>
>>
>>
>> http://gwt-code-reviews.appspot.com/665801/show
>>
>
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Drop the bikeshed jar from the GWT distribution. (issue665801)

[Amit Manjhi]

There is still a "dist-bikeshed" target that will produce the bikeshed jar.
I did not touch it. Does that cover the use case you have in mind?

This CL just ensures that the "dist" target not produce the bikeshed jar or
include the bikeshed jar in the distribution.

On Fri, Jun 25, 2010 at 8:01 AM,  wrote:

> I have mixed feelings... if bikeshed is null now, do we think we
> will/won't need such a workspace in the future?  I thought something
> like that was being considered as the incubator replacement model, for
> example.
>
> I suppose we can turn it back on at will, but it seems to me that having
> build.xml always build the perhaps-empty bikeshed.  I'm less sure about
> distro-source, though... it's explicitly for in-progress work, so I'm
> not sure it's part of a release even if not empty!
>
>
>
> On 2010/06/25 14:23:11, amitmanjhi wrote:
>
>> Yes, it is no longer needed. We can drop it from the maven report for
>>
> the
>
>> next milestone.
>>
>
>  On Jun 25, 2010 6:37 AM,  wrote:
>> > Does this mean gwt-bikeshed.jar is no longer needed? Do we need it
>>
> at
>
>> > all in the Maven repo for the next milestone?
>> >
>> > http://gwt-code-reviews.appspot.com/665801/show
>>
>
>
>
>
> http://gwt-code-reviews.appspot.com/665801/show
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Drop the bikeshed jar from the GWT distribution. (issue665801)

[fabbott]

I have mixed feelings... if bikeshed is null now, do we think we
will/won't need such a workspace in the future?  I thought something
like that was being considered as the incubator replacement model, for
example.

I suppose we can turn it back on at will, but it seems to me that having
build.xml always build the perhaps-empty bikeshed.  I'm less sure about
distro-source, though... it's explicitly for in-progress work, so I'm
not sure it's part of a release even if not empty!


On 2010/06/25 14:23:11, amitmanjhi wrote:

Yes, it is no longer needed. We can drop it from the maven report for

the

next milestone.



On Jun 25, 2010 6:37 AM,  wrote:
> Does this mean gwt-bikeshed.jar is no longer needed? Do we need it

at

> all in the Maven repo for the next milestone?
>
> http://gwt-code-reviews.appspot.com/665801/show





http://gwt-code-reviews.appspot.com/665801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Drop the bikeshed jar from the GWT distribution. (issue665801)

[Amit Manjhi]

Yes, it is no longer needed. We can drop it from the maven report for the
next milestone.

On Jun 25, 2010 6:37 AM,  wrote:
> Does this mean gwt-bikeshed.jar is no longer needed? Do we need it at
> all in the Maven repo for the next milestone?
>
> http://gwt-code-reviews.appspot.com/665801/show

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Drop the bikeshed jar from the GWT distribution. (issue665801)

[jasonparekh]

Does this mean gwt-bikeshed.jar is no longer needed?  Do we need it at
all in the Maven repo for the next milestone?

http://gwt-code-reviews.appspot.com/665801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Drop the bikeshed jar from the GWT distribution. (issue665801)

[amitmanjhi]

http://gwt-code-reviews.appspot.com/665801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors